diff mbox series

[meta-arago,scarthgap/master] packagegroups: opencl and vulkan utilities

Message ID 20250226201334.3807093-1-rs@ti.com
State Superseded
Delegated to: Ryan Eatmon
Headers show
Series [meta-arago,scarthgap/master] packagegroups: opencl and vulkan utilities | expand

Commit Message

Randolph Sapp Feb. 26, 2025, 8:13 p.m. UTC
From: Randolph Sapp <rs@ti.com>

Add package groups for OpenCL and Vulkan related utilities.
Conditionally install them in tisdk-default-image if we enable the
required distro features.

Currently these package groups consist of clinfo and vulkaninfo
respectively. These are useful tools for checking device extension
compatibility and ICD loader functionality.

Signed-off-by: Randolph Sapp <rs@ti.com>
---
 .../recipes-core/images/tisdk-default-image.bb      |  2 ++
 .../packagegroups/packagegroup-arago-opencl.bb      | 13 +++++++++++++
 .../packagegroups/packagegroup-arago-vulkan.bb      | 13 +++++++++++++
 3 files changed, 28 insertions(+)
 create mode 100644 meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-opencl.bb
 create mode 100644 meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-vulkan.bb

Comments

Denys Dmytriyenko Feb. 26, 2025, 8:43 p.m. UTC | #1
On Wed, Feb 26, 2025 at 02:13:34PM -0600, rs@ti.com wrote:
> From: Randolph Sapp <rs@ti.com>
> 
> Add package groups for OpenCL and Vulkan related utilities.
> Conditionally install them in tisdk-default-image if we enable the
> required distro features.
> 
> Currently these package groups consist of clinfo and vulkaninfo
> respectively. These are useful tools for checking device extension
> compatibility and ICD loader functionality.
> 
> Signed-off-by: Randolph Sapp <rs@ti.com>
> ---
>  .../recipes-core/images/tisdk-default-image.bb      |  2 ++
>  .../packagegroups/packagegroup-arago-opencl.bb      | 13 +++++++++++++
>  .../packagegroups/packagegroup-arago-vulkan.bb      | 13 +++++++++++++
>  3 files changed, 28 insertions(+)
>  create mode 100644 meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-opencl.bb
>  create mode 100644 meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-vulkan.bb
> 
> diff --git a/meta-arago-distro/recipes-core/images/tisdk-default-image.bb b/meta-arago-distro/recipes-core/images/tisdk-default-image.bb
> index aace490b..bc067857 100644
> --- a/meta-arago-distro/recipes-core/images/tisdk-default-image.bb
> +++ b/meta-arago-distro/recipes-core/images/tisdk-default-image.bb
> @@ -17,6 +17,8 @@ IMAGE_INSTALL += "\
>      ti-test-extras \
>      ${@bb.utils.contains('DISTRO_FEATURES','opengl','packagegroup-arago-tisdk-graphics','',d)} \
>      ${@bb.utils.contains('DISTRO_FEATURES','opengl','packagegroup-arago-tisdk-gtk','',d)} \
> +    ${@bb.utils.contains('DISTRO_FEATURES','opencl','packagegroup-arago-opencl','',d)} \
> +    ${@bb.utils.contains('DISTRO_FEATURES','vulkan','packagegroup-arago-vulkan','',d)} \
>      packagegroup-arago-tisdk-connectivity \
>      packagegroup-arago-tisdk-crypto \
>      packagegroup-arago-tisdk-multimedia \
> diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-opencl.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-opencl.bb
> new file mode 100644
> index 00000000..49b6efc8
> --- /dev/null
> +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-opencl.bb
> @@ -0,0 +1,13 @@
> +DESCRIPTION = "Group containing various useful 0penCL packages"

SUMMARY is required these days.


> +LICENSE = "MIT"
> +PR = "r0"

No explicit PR is needed these days.


> +PACKAGE_ARCH = "${MACHINE_ARCH}"
> +
> +inherit packagegroup features_check
> +
> +REQUIRED_DISTRO_FEATURES = "opencl"
> +
> +RDEPENDS:${PN} = "\
> +    clinfo \
> +"
> diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-vulkan.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-vulkan.bb
> new file mode 100644
> index 00000000..36ee4b7b
> --- /dev/null
> +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-vulkan.bb
> @@ -0,0 +1,13 @@
> +DESCRIPTION = "Group containing various useful Vulkan packages"
> +LICENSE = "MIT"
> +PR = "r0"

Same 2 comments as above.


> +PACKAGE_ARCH = "${MACHINE_ARCH}"
> +
> +inherit packagegroup features_check
> +
> +REQUIRED_DISTRO_FEATURES = "vulkan"
> +
> +RDEPENDS:${PN} = "\
> +    vulkan-tools \
> +"
> -- 
> 2.48.1
Randolph Sapp Feb. 26, 2025, 9:20 p.m. UTC | #2
On Wed Feb 26, 2025 at 2:43 PM CST, Denys Dmytriyenko wrote:
> On Wed, Feb 26, 2025 at 02:13:34PM -0600, rs@ti.com wrote:
>> From: Randolph Sapp <rs@ti.com>
>> 
>> Add package groups for OpenCL and Vulkan related utilities.
>> Conditionally install them in tisdk-default-image if we enable the
>> required distro features.
>> 
>> Currently these package groups consist of clinfo and vulkaninfo
>> respectively. These are useful tools for checking device extension
>> compatibility and ICD loader functionality.
>> 
>> Signed-off-by: Randolph Sapp <rs@ti.com>
>> ---
>>  .../recipes-core/images/tisdk-default-image.bb      |  2 ++
>>  .../packagegroups/packagegroup-arago-opencl.bb      | 13 +++++++++++++
>>  .../packagegroups/packagegroup-arago-vulkan.bb      | 13 +++++++++++++
>>  3 files changed, 28 insertions(+)
>>  create mode 100644 meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-opencl.bb
>>  create mode 100644 meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-vulkan.bb
>> 
>> diff --git a/meta-arago-distro/recipes-core/images/tisdk-default-image.bb b/meta-arago-distro/recipes-core/images/tisdk-default-image.bb
>> index aace490b..bc067857 100644
>> --- a/meta-arago-distro/recipes-core/images/tisdk-default-image.bb
>> +++ b/meta-arago-distro/recipes-core/images/tisdk-default-image.bb
>> @@ -17,6 +17,8 @@ IMAGE_INSTALL += "\
>>      ti-test-extras \
>>      ${@bb.utils.contains('DISTRO_FEATURES','opengl','packagegroup-arago-tisdk-graphics','',d)} \
>>      ${@bb.utils.contains('DISTRO_FEATURES','opengl','packagegroup-arago-tisdk-gtk','',d)} \
>> +    ${@bb.utils.contains('DISTRO_FEATURES','opencl','packagegroup-arago-opencl','',d)} \
>> +    ${@bb.utils.contains('DISTRO_FEATURES','vulkan','packagegroup-arago-vulkan','',d)} \
>>      packagegroup-arago-tisdk-connectivity \
>>      packagegroup-arago-tisdk-crypto \
>>      packagegroup-arago-tisdk-multimedia \
>> diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-opencl.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-opencl.bb
>> new file mode 100644
>> index 00000000..49b6efc8
>> --- /dev/null
>> +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-opencl.bb
>> @@ -0,0 +1,13 @@
>> +DESCRIPTION = "Group containing various useful 0penCL packages"
>
> SUMMARY is required these days.
>
>
>> +LICENSE = "MIT"

Verifying against oe-core I see that LICENSE is no longer being populated as
well. Do you want me to drop that or not?

>> +PR = "r0"
>
> No explicit PR is needed these days.
>
>
>> +PACKAGE_ARCH = "${MACHINE_ARCH}"
>> +
>> +inherit packagegroup features_check
>> +
>> +REQUIRED_DISTRO_FEATURES = "opencl"
>> +
>> +RDEPENDS:${PN} = "\
>> +    clinfo \
>> +"
>> diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-vulkan.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-vulkan.bb
>> new file mode 100644
>> index 00000000..36ee4b7b
>> --- /dev/null
>> +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-vulkan.bb
>> @@ -0,0 +1,13 @@
>> +DESCRIPTION = "Group containing various useful Vulkan packages"
>> +LICENSE = "MIT"
>> +PR = "r0"
>
> Same 2 comments as above.
>
>
>> +PACKAGE_ARCH = "${MACHINE_ARCH}"
>> +
>> +inherit packagegroup features_check
>> +
>> +REQUIRED_DISTRO_FEATURES = "vulkan"
>> +
>> +RDEPENDS:${PN} = "\
>> +    vulkan-tools \
>> +"
>> -- 
>> 2.48.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#15922): https://lists.yoctoproject.org/g/meta-arago/message/15922
> Mute This Topic: https://lists.yoctoproject.org/mt/111403398/7094281
> Group Owner: meta-arago+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-arago/unsub [rs@ti.com]
> -=-=-=-=-=-=-=-=-=-=-=-
Denys Dmytriyenko Feb. 27, 2025, 4:13 p.m. UTC | #3
On Wed, Feb 26, 2025 at 03:20:48PM -0600, Randolph Sapp wrote:
> On Wed Feb 26, 2025 at 2:43 PM CST, Denys Dmytriyenko wrote:
> > On Wed, Feb 26, 2025 at 02:13:34PM -0600, rs@ti.com wrote:
> >> From: Randolph Sapp <rs@ti.com>
> >> 
> >> Add package groups for OpenCL and Vulkan related utilities.
> >> Conditionally install them in tisdk-default-image if we enable the
> >> required distro features.
> >> 
> >> Currently these package groups consist of clinfo and vulkaninfo
> >> respectively. These are useful tools for checking device extension
> >> compatibility and ICD loader functionality.
> >> 
> >> Signed-off-by: Randolph Sapp <rs@ti.com>
> >> ---
> >>  .../recipes-core/images/tisdk-default-image.bb      |  2 ++
> >>  .../packagegroups/packagegroup-arago-opencl.bb      | 13 +++++++++++++
> >>  .../packagegroups/packagegroup-arago-vulkan.bb      | 13 +++++++++++++
> >>  3 files changed, 28 insertions(+)
> >>  create mode 100644 meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-opencl.bb
> >>  create mode 100644 meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-vulkan.bb
> >> 
> >> diff --git a/meta-arago-distro/recipes-core/images/tisdk-default-image.bb b/meta-arago-distro/recipes-core/images/tisdk-default-image.bb
> >> index aace490b..bc067857 100644
> >> --- a/meta-arago-distro/recipes-core/images/tisdk-default-image.bb
> >> +++ b/meta-arago-distro/recipes-core/images/tisdk-default-image.bb
> >> @@ -17,6 +17,8 @@ IMAGE_INSTALL += "\
> >>      ti-test-extras \
> >>      ${@bb.utils.contains('DISTRO_FEATURES','opengl','packagegroup-arago-tisdk-graphics','',d)} \
> >>      ${@bb.utils.contains('DISTRO_FEATURES','opengl','packagegroup-arago-tisdk-gtk','',d)} \
> >> +    ${@bb.utils.contains('DISTRO_FEATURES','opencl','packagegroup-arago-opencl','',d)} \
> >> +    ${@bb.utils.contains('DISTRO_FEATURES','vulkan','packagegroup-arago-vulkan','',d)} \
> >>      packagegroup-arago-tisdk-connectivity \
> >>      packagegroup-arago-tisdk-crypto \
> >>      packagegroup-arago-tisdk-multimedia \
> >> diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-opencl.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-opencl.bb
> >> new file mode 100644
> >> index 00000000..49b6efc8
> >> --- /dev/null
> >> +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-opencl.bb
> >> @@ -0,0 +1,13 @@
> >> +DESCRIPTION = "Group containing various useful 0penCL packages"
> >
> > SUMMARY is required these days.
> >
> >
> >> +LICENSE = "MIT"
> 
> Verifying against oe-core I see that LICENSE is no longer being populated as
> well. Do you want me to drop that or not?

packagegroup.bbclass already weakly sets LICENSE to MIT, so unless you set a 
different license, you don't need it.


> >> +PR = "r0"
> >
> > No explicit PR is needed these days.
> >
> >
> >> +PACKAGE_ARCH = "${MACHINE_ARCH}"

Also, I was wondering why you set these packagroups as machine-specific.


> >> +inherit packagegroup features_check
> >> +
> >> +REQUIRED_DISTRO_FEATURES = "opencl"
> >> +
> >> +RDEPENDS:${PN} = "\
> >> +    clinfo \
> >> +"
> >> diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-vulkan.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-vulkan.bb
> >> new file mode 100644
> >> index 00000000..36ee4b7b
> >> --- /dev/null
> >> +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-vulkan.bb
> >> @@ -0,0 +1,13 @@
> >> +DESCRIPTION = "Group containing various useful Vulkan packages"
> >> +LICENSE = "MIT"
> >> +PR = "r0"
> >
> > Same 2 comments as above.
> >
> >
> >> +PACKAGE_ARCH = "${MACHINE_ARCH}"
> >> +
> >> +inherit packagegroup features_check
> >> +
> >> +REQUIRED_DISTRO_FEATURES = "vulkan"
> >> +
> >> +RDEPENDS:${PN} = "\
> >> +    vulkan-tools \
> >> +"
> >> -- 
> >> 2.48.1
diff mbox series

Patch

diff --git a/meta-arago-distro/recipes-core/images/tisdk-default-image.bb b/meta-arago-distro/recipes-core/images/tisdk-default-image.bb
index aace490b..bc067857 100644
--- a/meta-arago-distro/recipes-core/images/tisdk-default-image.bb
+++ b/meta-arago-distro/recipes-core/images/tisdk-default-image.bb
@@ -17,6 +17,8 @@  IMAGE_INSTALL += "\
     ti-test-extras \
     ${@bb.utils.contains('DISTRO_FEATURES','opengl','packagegroup-arago-tisdk-graphics','',d)} \
     ${@bb.utils.contains('DISTRO_FEATURES','opengl','packagegroup-arago-tisdk-gtk','',d)} \
+    ${@bb.utils.contains('DISTRO_FEATURES','opencl','packagegroup-arago-opencl','',d)} \
+    ${@bb.utils.contains('DISTRO_FEATURES','vulkan','packagegroup-arago-vulkan','',d)} \
     packagegroup-arago-tisdk-connectivity \
     packagegroup-arago-tisdk-crypto \
     packagegroup-arago-tisdk-multimedia \
diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-opencl.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-opencl.bb
new file mode 100644
index 00000000..49b6efc8
--- /dev/null
+++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-opencl.bb
@@ -0,0 +1,13 @@ 
+DESCRIPTION = "Group containing various useful 0penCL packages"
+LICENSE = "MIT"
+PR = "r0"
+
+PACKAGE_ARCH = "${MACHINE_ARCH}"
+
+inherit packagegroup features_check
+
+REQUIRED_DISTRO_FEATURES = "opencl"
+
+RDEPENDS:${PN} = "\
+    clinfo \
+"
diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-vulkan.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-vulkan.bb
new file mode 100644
index 00000000..36ee4b7b
--- /dev/null
+++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-vulkan.bb
@@ -0,0 +1,13 @@ 
+DESCRIPTION = "Group containing various useful Vulkan packages"
+LICENSE = "MIT"
+PR = "r0"
+
+PACKAGE_ARCH = "${MACHINE_ARCH}"
+
+inherit packagegroup features_check
+
+REQUIRED_DISTRO_FEATURES = "vulkan"
+
+RDEPENDS:${PN} = "\
+    vulkan-tools \
+"