| Message ID | 20241217210206.47052-1-afd@ti.com |
|---|---|
| State | New |
| Headers | show |
| Series | [meta-arago,scarthgap/master,1/3] ti-demos: Add pdm-anomaly-detection for all platforms | expand |
On Tue, Dec 17, 2024 at 03:02:04PM -0600, Andrew Davis via lists.yoctoproject.org wrote: > There is nothing in this demo that makes it specific to any board. > Enable this for all devices. Why fix up ti-demos.bb here and completely remove it in the next patch of the series? > Signed-off-by: Andrew Davis <afd@ti.com> > --- > .../recipes-core/packagegroups/ti-demos.bb | 10 +--------- > 1 file changed, 1 insertion(+), 9 deletions(-) > > diff --git a/meta-arago-distro/recipes-core/packagegroups/ti-demos.bb b/meta-arago-distro/recipes-core/packagegroups/ti-demos.bb > index 7bccb4de..91e469e7 100644 > --- a/meta-arago-distro/recipes-core/packagegroups/ti-demos.bb > +++ b/meta-arago-distro/recipes-core/packagegroups/ti-demos.bb > @@ -1,17 +1,9 @@ > SUMMARY = "TI World packagegroup" > LICENSE = "MIT" > > -PACKAGE_ARCH = "${MACHINE_ARCH}" > - > inherit packagegroup > > -PDM_ANOMALY_PKG = "${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 'pdm-anomaly-detection', '', d)}" > - > -PDM_ANOMALY = "" > -PDM_ANOMALY:ti33x = "${PDM_ANOMALY_PKG}" > -PDM_ANOMALY:ti43x = "${PDM_ANOMALY_PKG}" > -PDM_ANOMALY:omap-a15 = "${PDM_ANOMALY_PKG}" > -PDM_ANOMALY:am65xx = "${PDM_ANOMALY_PKG}" > +PDM_ANOMALY = "${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 'pdm-anomaly-detection', '', d)}" > > RDEPENDS:${PN} = "\ > ${PDM_ANOMALY} \ > -- > 2.39.2
On 12/18/24 3:42 PM, Denys Dmytriyenko wrote: > On Tue, Dec 17, 2024 at 03:02:04PM -0600, Andrew Davis via lists.yoctoproject.org wrote: >> There is nothing in this demo that makes it specific to any board. >> Enable this for all devices. > > Why fix up ti-demos.bb here and completely remove it in the next patch of the > series? > Felt better to do this in two steps, especially when each step could break something different :) > >> Signed-off-by: Andrew Davis <afd@ti.com> >> --- >> .../recipes-core/packagegroups/ti-demos.bb | 10 +--------- >> 1 file changed, 1 insertion(+), 9 deletions(-) >> >> diff --git a/meta-arago-distro/recipes-core/packagegroups/ti-demos.bb b/meta-arago-distro/recipes-core/packagegroups/ti-demos.bb >> index 7bccb4de..91e469e7 100644 >> --- a/meta-arago-distro/recipes-core/packagegroups/ti-demos.bb >> +++ b/meta-arago-distro/recipes-core/packagegroups/ti-demos.bb >> @@ -1,17 +1,9 @@ >> SUMMARY = "TI World packagegroup" >> LICENSE = "MIT" >> >> -PACKAGE_ARCH = "${MACHINE_ARCH}" >> - >> inherit packagegroup >> >> -PDM_ANOMALY_PKG = "${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 'pdm-anomaly-detection', '', d)}" >> - >> -PDM_ANOMALY = "" >> -PDM_ANOMALY:ti33x = "${PDM_ANOMALY_PKG}" >> -PDM_ANOMALY:ti43x = "${PDM_ANOMALY_PKG}" >> -PDM_ANOMALY:omap-a15 = "${PDM_ANOMALY_PKG}" >> -PDM_ANOMALY:am65xx = "${PDM_ANOMALY_PKG}" >> +PDM_ANOMALY = "${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 'pdm-anomaly-detection', '', d)}" >> >> RDEPENDS:${PN} = "\ >> ${PDM_ANOMALY} \ >> -- >> 2.39.2
diff --git a/meta-arago-distro/recipes-core/packagegroups/ti-demos.bb b/meta-arago-distro/recipes-core/packagegroups/ti-demos.bb index 7bccb4de..91e469e7 100644 --- a/meta-arago-distro/recipes-core/packagegroups/ti-demos.bb +++ b/meta-arago-distro/recipes-core/packagegroups/ti-demos.bb @@ -1,17 +1,9 @@ SUMMARY = "TI World packagegroup" LICENSE = "MIT" -PACKAGE_ARCH = "${MACHINE_ARCH}" - inherit packagegroup -PDM_ANOMALY_PKG = "${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 'pdm-anomaly-detection', '', d)}" - -PDM_ANOMALY = "" -PDM_ANOMALY:ti33x = "${PDM_ANOMALY_PKG}" -PDM_ANOMALY:ti43x = "${PDM_ANOMALY_PKG}" -PDM_ANOMALY:omap-a15 = "${PDM_ANOMALY_PKG}" -PDM_ANOMALY:am65xx = "${PDM_ANOMALY_PKG}" +PDM_ANOMALY = "${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 'pdm-anomaly-detection', '', d)}" RDEPENDS:${PN} = "\ ${PDM_ANOMALY} \
There is nothing in this demo that makes it specific to any board. Enable this for all devices. Signed-off-by: Andrew Davis <afd@ti.com> --- .../recipes-core/packagegroups/ti-demos.bb | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-)