| Message ID | 20241217210137.46974-2-afd@ti.com |
|---|---|
| State | New |
| Headers | show |
| Series | [meta-arago,scarthgap/master,1/2] packagegroup-arago-gst: Disable vpe and ducati gstreamer plugins | expand |
On 12/17/24 3:01 PM, Andrew Davis wrote: > Currently MACHINE_FEATURES are disabled based on branding, but the > branding is not what determines if these are functional, the BSP version > does. While we do select the BSP version here, what is supported or not > by a given version is a property of the BSP layer. Disabling missing > MACHINE_FEATURES for each version should be handled there. > > Signed-off-by: Andrew Davis <afd@ti.com> > --- > meta-arago-distro/conf/distro/include/branding-core.inc | 5 ----- > meta-arago-distro/conf/distro/include/branding-ltsprep.inc | 4 ---- > 2 files changed, 9 deletions(-) > > diff --git a/meta-arago-distro/conf/distro/include/branding-core.inc b/meta-arago-distro/conf/distro/include/branding-core.inc > index 48fe36e1..3eed685a 100644 > --- a/meta-arago-distro/conf/distro/include/branding-core.inc > +++ b/meta-arago-distro/conf/distro/include/branding-core.inc > @@ -7,8 +7,3 @@ > > # Raise priority for sample IPC FW images > ALTERNATIVE_PRIORITY:pn-ti-ipc-rtos = "15" > - > -# GC320 support requires out-of-tree drivers not available in until LTS prep is > -# complete. Disable for now. > -# Remove gc320 - the driver fails to build with gcc12 > -MACHINE_FEATURES:remove = "gc320" > diff --git a/meta-arago-distro/conf/distro/include/branding-ltsprep.inc b/meta-arago-distro/conf/distro/include/branding-ltsprep.inc > index 415eee8d..21e33662 100644 > --- a/meta-arago-distro/conf/distro/include/branding-ltsprep.inc > +++ b/meta-arago-distro/conf/distro/include/branding-ltsprep.inc > @@ -1,5 +1 @@ > TI_PREFERRED_BSP = "ti-6_12" > - > -# GC320 support requires out-of-tree drivers not available in until LTS prep is > -# complete. Disable for now. > -MACHINE_FEATURES:remove = "gc320" This has a equal opposite patch[0] over in meta-ti disabling these in the BSP layer. That will need to go in first to prevent GC320 support from being enabled in the meantime (gc320 doesn't build that would cause failures). [0] https://lists.yoctoproject.org/g/meta-ti/message/18126 Andrew
diff --git a/meta-arago-distro/conf/distro/include/branding-core.inc b/meta-arago-distro/conf/distro/include/branding-core.inc index 48fe36e1..3eed685a 100644 --- a/meta-arago-distro/conf/distro/include/branding-core.inc +++ b/meta-arago-distro/conf/distro/include/branding-core.inc @@ -7,8 +7,3 @@ # Raise priority for sample IPC FW images ALTERNATIVE_PRIORITY:pn-ti-ipc-rtos = "15" - -# GC320 support requires out-of-tree drivers not available in until LTS prep is -# complete. Disable for now. -# Remove gc320 - the driver fails to build with gcc12 -MACHINE_FEATURES:remove = "gc320" diff --git a/meta-arago-distro/conf/distro/include/branding-ltsprep.inc b/meta-arago-distro/conf/distro/include/branding-ltsprep.inc index 415eee8d..21e33662 100644 --- a/meta-arago-distro/conf/distro/include/branding-ltsprep.inc +++ b/meta-arago-distro/conf/distro/include/branding-ltsprep.inc @@ -1,5 +1 @@ TI_PREFERRED_BSP = "ti-6_12" - -# GC320 support requires out-of-tree drivers not available in until LTS prep is -# complete. Disable for now. -MACHINE_FEATURES:remove = "gc320"
Currently MACHINE_FEATURES are disabled based on branding, but the branding is not what determines if these are functional, the BSP version does. While we do select the BSP version here, what is supported or not by a given version is a property of the BSP layer. Disabling missing MACHINE_FEATURES for each version should be handled there. Signed-off-by: Andrew Davis <afd@ti.com> --- meta-arago-distro/conf/distro/include/branding-core.inc | 5 ----- meta-arago-distro/conf/distro/include/branding-ltsprep.inc | 4 ---- 2 files changed, 9 deletions(-)