| Message ID | 20241205201212.1114249-1-jm@ti.com |
|---|---|
| State | Accepted |
| Delegated to: | Ryan Eatmon |
| Headers | show |
| Series | [meta-arago,master/kirkstone] ti-test: Add rng-tools | expand |
rng-tools were removed back in 2023: https://git.yoctoproject.org/meta-arago/commit/?id=dc19fed1b898cf5abdf50fa04dda7b1d9afd22ca and added back last September to master and scarthgap: https://git.yoctoproject.org/meta-arago/commit/?id=662a5119446e7d47094a68efe8b775b3dda2b4e8 I see you are trying to backport that to kirkstone, even though the subject states master... Anyway, based on Randolph's comments for the removal, rngd was deprecated and is no longer needed - should testcases be adjusted for the removal of rng-tools? On Thu, Dec 05, 2024 at 02:12:12PM -0600, Mendez, Judith via lists.yoctoproject.org wrote: > Add rng-tools to the ti-test tool list. > > RNG testcases are failing since they require > rngtest, so add rng-tools to ti-test only. > > Signed-off-by: Judith Mendez <jm@ti.com> > --- > This patch has been previously sent and merged to scarthgap > branch, but is also required for kirkstone > --- > meta-arago-test/recipes-core/packagegroups/ti-test.bb | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/meta-arago-test/recipes-core/packagegroups/ti-test.bb b/meta-arago-test/recipes-core/packagegroups/ti-test.bb > index a80b943b..85398eaf 100644 > --- a/meta-arago-test/recipes-core/packagegroups/ti-test.bb > +++ b/meta-arago-test/recipes-core/packagegroups/ti-test.bb > @@ -44,6 +44,7 @@ TI_TEST_BASE = "\ > powertop \ > procps \ > pulseaudio-misc \ > + rng-tools \ > rt-tests \ > rwmem \ > smcroute \ > -- > 2.46.0
On Thu Dec 5, 2024 at 2:39 PM CST, Denys Dmytriyenko wrote: > rng-tools were removed back in 2023: > https://git.yoctoproject.org/meta-arago/commit/?id=dc19fed1b898cf5abdf50fa04dda7b1d9afd22ca > > and added back last September to master and scarthgap: > https://git.yoctoproject.org/meta-arago/commit/?id=662a5119446e7d47094a68efe8b775b3dda2b4e8 > > I see you are trying to backport that to kirkstone, even though the subject > states master... Yeah, noticed the tags were a bit off. > Anyway, based on Randolph's comments for the removal, rngd was deprecated > and is no longer needed - should testcases be adjusted for the removal of > rng-tools? I did have a conversation with Judith about this. While I still believe the rng-tools service is deprecated and does nothing more than hinder general usage, the package itself actually has some useful tools for testing hardware RNG devices. I wasn't able to find any similar tools to replace them in my brief search. > On Thu, Dec 05, 2024 at 02:12:12PM -0600, Mendez, Judith via lists.yoctoproject.org wrote: > > Add rng-tools to the ti-test tool list. > > > > RNG testcases are failing since they require > > rngtest, so add rng-tools to ti-test only. > > > > Signed-off-by: Judith Mendez <jm@ti.com> > > --- > > This patch has been previously sent and merged to scarthgap > > branch, but is also required for kirkstone > > --- > > meta-arago-test/recipes-core/packagegroups/ti-test.bb | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/meta-arago-test/recipes-core/packagegroups/ti-test.bb b/meta-arago-test/recipes-core/packagegroups/ti-test.bb > > index a80b943b..85398eaf 100644 > > --- a/meta-arago-test/recipes-core/packagegroups/ti-test.bb > > +++ b/meta-arago-test/recipes-core/packagegroups/ti-test.bb > > @@ -44,6 +44,7 @@ TI_TEST_BASE = "\ > > powertop \ > > procps \ > > pulseaudio-misc \ > > + rng-tools \ > > rt-tests \ > > rwmem \ > > smcroute \ > > -- > > 2.46.0
On 12/5/2024 3:09 PM, Randolph Sapp wrote: > On Thu Dec 5, 2024 at 2:39 PM CST, Denys Dmytriyenko wrote: >> rng-tools were removed back in 2023: >> https://git.yoctoproject.org/meta-arago/commit/?id=dc19fed1b898cf5abdf50fa04dda7b1d9afd22ca >> >> and added back last September to master and scarthgap: >> https://git.yoctoproject.org/meta-arago/commit/?id=662a5119446e7d47094a68efe8b775b3dda2b4e8 >> >> I see you are trying to backport that to kirkstone, even though the subject >> states master... > > Yeah, noticed the tags were a bit off. > >> Anyway, based on Randolph's comments for the removal, rngd was deprecated >> and is no longer needed - should testcases be adjusted for the removal of >> rng-tools? > > I did have a conversation with Judith about this. While I still believe the > rng-tools service is deprecated and does nothing more than hinder general usage, > the package itself actually has some useful tools for testing hardware RNG > devices. I wasn't able to find any similar tools to replace them in my brief > search. Do we need to add something to a bbappend to disable the service while still getting the tools? I haven't looked at the recipe, I'm just asking a general question. >> On Thu, Dec 05, 2024 at 02:12:12PM -0600, Mendez, Judith via lists.yoctoproject.org wrote: >>> Add rng-tools to the ti-test tool list. >>> >>> RNG testcases are failing since they require >>> rngtest, so add rng-tools to ti-test only. >>> >>> Signed-off-by: Judith Mendez <jm@ti.com> >>> --- >>> This patch has been previously sent and merged to scarthgap >>> branch, but is also required for kirkstone >>> --- >>> meta-arago-test/recipes-core/packagegroups/ti-test.bb | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/meta-arago-test/recipes-core/packagegroups/ti-test.bb b/meta-arago-test/recipes-core/packagegroups/ti-test.bb >>> index a80b943b..85398eaf 100644 >>> --- a/meta-arago-test/recipes-core/packagegroups/ti-test.bb >>> +++ b/meta-arago-test/recipes-core/packagegroups/ti-test.bb >>> @@ -44,6 +44,7 @@ TI_TEST_BASE = "\ >>> powertop \ >>> procps \ >>> pulseaudio-misc \ >>> + rng-tools \ >>> rt-tests \ >>> rwmem \ >>> smcroute \ >>> -- >>> 2.46.0 >
On Fri Dec 6, 2024 at 8:37 AM CST, Ryan Eatmon wrote: > > > On 12/5/2024 3:09 PM, Randolph Sapp wrote: > > On Thu Dec 5, 2024 at 2:39 PM CST, Denys Dmytriyenko wrote: > >> rng-tools were removed back in 2023: > >> https://git.yoctoproject.org/meta-arago/commit/?id=dc19fed1b898cf5abdf50fa04dda7b1d9afd22ca > >> > >> and added back last September to master and scarthgap: > >> https://git.yoctoproject.org/meta-arago/commit/?id=662a5119446e7d47094a68efe8b775b3dda2b4e8 > >> > >> I see you are trying to backport that to kirkstone, even though the subject > >> states master... > > > > Yeah, noticed the tags were a bit off. > > > >> Anyway, based on Randolph's comments for the removal, rngd was deprecated > >> and is no longer needed - should testcases be adjusted for the removal of > >> rng-tools? > > > > I did have a conversation with Judith about this. While I still believe the > > rng-tools service is deprecated and does nothing more than hinder general usage, > > the package itself actually has some useful tools for testing hardware RNG > > devices. I wasn't able to find any similar tools to replace them in my brief > > search. > > Do we need to add something to a bbappend to disable the service while > still getting the tools? I haven't looked at the recipe, I'm just > asking a general question. Nah, previously we were going out of our way to enable it. If I remember corectly it's disabled by default. > >> On Thu, Dec 05, 2024 at 02:12:12PM -0600, Mendez, Judith via lists.yoctoproject.org wrote: > >>> Add rng-tools to the ti-test tool list. > >>> > >>> RNG testcases are failing since they require > >>> rngtest, so add rng-tools to ti-test only. > >>> > >>> Signed-off-by: Judith Mendez <jm@ti.com> > >>> --- > >>> This patch has been previously sent and merged to scarthgap > >>> branch, but is also required for kirkstone > >>> --- > >>> meta-arago-test/recipes-core/packagegroups/ti-test.bb | 1 + > >>> 1 file changed, 1 insertion(+) > >>> > >>> diff --git a/meta-arago-test/recipes-core/packagegroups/ti-test.bb b/meta-arago-test/recipes-core/packagegroups/ti-test.bb > >>> index a80b943b..85398eaf 100644 > >>> --- a/meta-arago-test/recipes-core/packagegroups/ti-test.bb > >>> +++ b/meta-arago-test/recipes-core/packagegroups/ti-test.bb > >>> @@ -44,6 +44,7 @@ TI_TEST_BASE = "\ > >>> powertop \ > >>> procps \ > >>> pulseaudio-misc \ > >>> + rng-tools \ > >>> rt-tests \ > >>> rwmem \ > >>> smcroute \ > >>> -- > >>> 2.46.0 > >
Hi Randolph, Denys, On 12/5/24 3:09 PM, Randolph Sapp wrote: > On Thu Dec 5, 2024 at 2:39 PM CST, Denys Dmytriyenko wrote: >> rng-tools were removed back in 2023: >> https://git.yoctoproject.org/meta-arago/commit/?id=dc19fed1b898cf5abdf50fa04dda7b1d9afd22ca >> >> and added back last September to master and scarthgap: >> https://git.yoctoproject.org/meta-arago/commit/?id=662a5119446e7d47094a68efe8b775b3dda2b4e8 >> >> I see you are trying to backport that to kirkstone, even though the subject >> states master... > > Yeah, noticed the tags were a bit off. Sorry about that, this patch is supposed to be for kirkstone only. > >> Anyway, based on Randolph's comments for the removal, rngd was deprecated >> and is no longer needed - should testcases be adjusted for the removal of >> rng-tools? > > I did have a conversation with Judith about this. While I still believe the > rng-tools service is deprecated and does nothing more than hinder general usage, > the package itself actually has some useful tools for testing hardware RNG > devices. I wasn't able to find any similar tools to replace them in my brief > search. Right, and since we added for scarthgap, could we also do the same for kirkstone branch? ~ Judith > >> On Thu, Dec 05, 2024 at 02:12:12PM -0600, Mendez, Judith via lists.yoctoproject.org wrote: >>> Add rng-tools to the ti-test tool list. >>> >>> RNG testcases are failing since they require >>> rngtest, so add rng-tools to ti-test only. >>> >>> Signed-off-by: Judith Mendez <jm@ti.com> >>> --- >>> This patch has been previously sent and merged to scarthgap >>> branch, but is also required for kirkstone >>> --- >>> meta-arago-test/recipes-core/packagegroups/ti-test.bb | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/meta-arago-test/recipes-core/packagegroups/ti-test.bb b/meta-arago-test/recipes-core/packagegroups/ti-test.bb >>> index a80b943b..85398eaf 100644 >>> --- a/meta-arago-test/recipes-core/packagegroups/ti-test.bb >>> +++ b/meta-arago-test/recipes-core/packagegroups/ti-test.bb >>> @@ -44,6 +44,7 @@ TI_TEST_BASE = "\ >>> powertop \ >>> procps \ >>> pulseaudio-misc \ >>> + rng-tools \ >>> rt-tests \ >>> rwmem \ >>> smcroute \ >>> -- >>> 2.46.0 >
diff --git a/meta-arago-test/recipes-core/packagegroups/ti-test.bb b/meta-arago-test/recipes-core/packagegroups/ti-test.bb index a80b943b..85398eaf 100644 --- a/meta-arago-test/recipes-core/packagegroups/ti-test.bb +++ b/meta-arago-test/recipes-core/packagegroups/ti-test.bb @@ -44,6 +44,7 @@ TI_TEST_BASE = "\ powertop \ procps \ pulseaudio-misc \ + rng-tools \ rt-tests \ rwmem \ smcroute \
Add rng-tools to the ti-test tool list. RNG testcases are failing since they require rngtest, so add rng-tools to ti-test only. Signed-off-by: Judith Mendez <jm@ti.com> --- This patch has been previously sent and merged to scarthgap branch, but is also required for kirkstone --- meta-arago-test/recipes-core/packagegroups/ti-test.bb | 1 + 1 file changed, 1 insertion(+)