diff mbox series

[meta-rockchip] SOQuartz: add

Message ID 3608313a-2d69-435d-807f-3dceb6326ca8@trifork.com
State New
Headers show
Series [meta-rockchip] SOQuartz: add | expand

Commit Message

Paul M. Bendixen Nov. 15, 2024, 2:51 p.m. UTC
The SOQuartz is a RK3566 based compute module and parts of Quartz64 series
The Model-A base board is one possible board that supports it

Website:
     https://pine64.org/devices/soquartz/
Wiki:
     https://wiki.pine64.org/wiki/SOQuartz

Specs:
- Rockchip RK3566 Quad-core ARM Cortex-A55@1.8GHz
- Mali-G52 2EE Bifrost GPU@800MHz
- Raspberry Pi 4 CM form factor
- RAM Memory Variants: 2GB, 4GB, 8GB LPDDR4.
- optional eMMC from 8GB to 128GB
- optional 128Mb SPI Flash
- 10/100/1000Mbps Ethernet
- WiFi 802.11 b/g/n/ac with Bluetooth 5.0

Exposed preripherals:
- 1x HDMI
- 2x DSI
- 1x eDP
- 1x LVDS
- 1x CSI 4-line
- 1x Ethernet
- 1x USB 2.0 OTG
- 1x SD
- 1x PCIe 1-line
- 28x GPIO

Model-A baseboard:
- 1x microSD - bootable
- 1x HDMI Port
- 2x USB A 2.0 Host
- 1x USB C 2.0 Host
- 1x 5 pin USB expansion
- 1x Ethernet w. PoE
- 1x 40 pole Pi2 compatible GPIO
- 1x MiPi-CSI 2 lanes
- 1x MiPi-CSI 4 lanes
- 1x MiPi-DSI 2 lanes
- 1x MiPi-DSI 4 lanes
- 1x PCIe open ended

Signed-off-by: Paul M. B. Bendixen <pbe@trifork.com>
---
  README                                      |  1 +
  conf/machine/include/soquartz.inc           | 15 +++++++++++++++
  conf/machine/soquartz-model-a.conf          | 12 ++++++++++++
  recipes-kernel/linux/linux-yocto_%.bbappend |  1 +
  4 files changed, 29 insertions(+)
  create mode 100644 conf/machine/include/soquartz.inc
  create mode 100644 conf/machine/soquartz-model-a.conf

  SRC_URI:append:nanopi-r4s = " file://nanopi-r4s.scc"
-- 
2.43.0

Comments

Quentin Schulz Nov. 15, 2024, 2:59 p.m. UTC | #1
Hi Paul,

Please version your patches when sending (usually -v N with N being the 
proper version number should be enough), a vN will then appear next to 
[PATCH in the mail subject. That is necessary for maintainers and 
reviewers to not have to figure out which one mail is the latest and 
greatest patch you've sent and they should review or merge.

I can also recommend using b4 which does a lot of things automatically 
for you :)

See comment inline.

On 11/15/24 3:51 PM, Paul M. Bendixen via lists.yoctoproject.org wrote:
> [You don't often get email from pbe=trifork.com@lists.yoctoproject.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
> 
> The SOQuartz is a RK3566 based compute module and parts of Quartz64 series
> The Model-A base board is one possible board that supports it
> 
> Website:
>       https://pine64.org/devices/soquartz/
> Wiki:
>       https://wiki.pine64.org/wiki/SOQuartz
> 
> Specs:
> - Rockchip RK3566 Quad-core ARM Cortex-A55@1.8GHz
> - Mali-G52 2EE Bifrost GPU@800MHz
> - Raspberry Pi 4 CM form factor
> - RAM Memory Variants: 2GB, 4GB, 8GB LPDDR4.
> - optional eMMC from 8GB to 128GB
> - optional 128Mb SPI Flash
> - 10/100/1000Mbps Ethernet
> - WiFi 802.11 b/g/n/ac with Bluetooth 5.0
> 
> Exposed preripherals:
> - 1x HDMI
> - 2x DSI
> - 1x eDP
> - 1x LVDS
> - 1x CSI 4-line
> - 1x Ethernet
> - 1x USB 2.0 OTG
> - 1x SD
> - 1x PCIe 1-line
> - 28x GPIO
> 
> Model-A baseboard:
> - 1x microSD - bootable
> - 1x HDMI Port
> - 2x USB A 2.0 Host
> - 1x USB C 2.0 Host
> - 1x 5 pin USB expansion
> - 1x Ethernet w. PoE
> - 1x 40 pole Pi2 compatible GPIO
> - 1x MiPi-CSI 2 lanes
> - 1x MiPi-CSI 4 lanes
> - 1x MiPi-DSI 2 lanes
> - 1x MiPi-DSI 4 lanes
> - 1x PCIe open ended
> 
> Signed-off-by: Paul M. B. Bendixen <pbe@trifork.com>
> ---
>    README                                      |  1 +
>    conf/machine/include/soquartz.inc           | 15 +++++++++++++++
>    conf/machine/soquartz-model-a.conf          | 12 ++++++++++++
>    recipes-kernel/linux/linux-yocto_%.bbappend |  1 +
>    4 files changed, 29 insertions(+)
>    create mode 100644 conf/machine/include/soquartz.inc
>    create mode 100644 conf/machine/soquartz-model-a.conf
> 
> diff --git a/README b/README
> index 09f8691..85ab2ec 100644
> --- a/README
> +++ b/README
> @@ -45,6 +45,7 @@ Status of supported boards:
>                rock-pi-e
>                rock-pi-s
>                rock64
> +            soquartz (on model A base board)
> 
>        builds:
>            32-bit:
> diff --git a/conf/machine/include/soquartz.inc
> b/conf/machine/include/soquartz.inc
> new file mode 100644
> index 0000000..6714efc
> --- /dev/null
> +++ b/conf/machine/include/soquartz.inc
> @@ -0,0 +1,15 @@
> +#Copyright (C) Trifork A/S 2024
> +# Released under the MIT license (see COPYING.MIT for the terms)
> +
> +# Common override for basing a SOQuartz design on
> +# https://wiki.pine64.org/wiki/SOQuartz
> +
> +MACHINEOVERRIDES =. "soquartz:"
> +
> +require conf/machine/include/rk3566.inc
> +
> +# A machine using this baseboard could use these options or overload them

I think it is actually required to set those variables in a machine 
configuration file since nothing else defines a default? And since those 
are now commented out (as they should).

So I'm just nitpicking on the phrasing here. I wouldn't necessarily send 
a new version just for that, but maybe Trevor will have a different 
opinion (or fix it when merging).

Looks good to me otherwise!

Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>

Thanks!
Quentin
Paul M. Bendixen Nov. 18, 2024, 8:04 a.m. UTC | #2
On 15.11.2024 15.59, Quentin Schulz via lists.yoctoproject.org wrote:
> Hi Paul,
>
> Please version your patches when sending (usually -v N with N being 
> the proper version number should be enough), a vN will then appear 
> next to [PATCH in the mail subject. That is necessary for maintainers 
> and reviewers to not have to figure out which one mail is the latest 
> and greatest patch you've sent and they should review or merge.
>
Ok, makes sense, couldn't find that anywhere but will change for next time.

> I can also recommend using b4 which does a lot of things automatically 
> for you :)
Thanks for the tip, I'll check it out.
>
> See comment inline.
>
> On 11/15/24 3:51 PM, Paul M. Bendixen via lists.yoctoproject.org wrote:
>> [You don't often get email from 
>> pbe=trifork.com@lists.yoctoproject.org. Learn why this is important 
>> at https://aka.ms/LearnAboutSenderIdentification ]
>>
>> The SOQuartz is a RK3566 based compute module and parts of Quartz64 
>> series
>> The Model-A base board is one possible board that supports it
>>
>> Website:
>>       https://pine64.org/devices/soquartz/
>> Wiki:
>>       https://wiki.pine64.org/wiki/SOQuartz
>>
>> Specs:
>> - Rockchip RK3566 Quad-core ARM Cortex-A55@1.8GHz
>> - Mali-G52 2EE Bifrost GPU@800MHz
>> - Raspberry Pi 4 CM form factor
>> - RAM Memory Variants: 2GB, 4GB, 8GB LPDDR4.
>> - optional eMMC from 8GB to 128GB
>> - optional 128Mb SPI Flash
>> - 10/100/1000Mbps Ethernet
>> - WiFi 802.11 b/g/n/ac with Bluetooth 5.0
>>
>> Exposed preripherals:
>> - 1x HDMI
>> - 2x DSI
>> - 1x eDP
>> - 1x LVDS
>> - 1x CSI 4-line
>> - 1x Ethernet
>> - 1x USB 2.0 OTG
>> - 1x SD
>> - 1x PCIe 1-line
>> - 28x GPIO
>>
>> Model-A baseboard:
>> - 1x microSD - bootable
>> - 1x HDMI Port
>> - 2x USB A 2.0 Host
>> - 1x USB C 2.0 Host
>> - 1x 5 pin USB expansion
>> - 1x Ethernet w. PoE
>> - 1x 40 pole Pi2 compatible GPIO
>> - 1x MiPi-CSI 2 lanes
>> - 1x MiPi-CSI 4 lanes
>> - 1x MiPi-DSI 2 lanes
>> - 1x MiPi-DSI 4 lanes
>> - 1x PCIe open ended
>>
>> Signed-off-by: Paul M. B. Bendixen <pbe@trifork.com>
>> ---
>>    README                                      |  1 +
>>    conf/machine/include/soquartz.inc           | 15 +++++++++++++++
>>    conf/machine/soquartz-model-a.conf          | 12 ++++++++++++
>>    recipes-kernel/linux/linux-yocto_%.bbappend |  1 +
>>    4 files changed, 29 insertions(+)
>>    create mode 100644 conf/machine/include/soquartz.inc
>>    create mode 100644 conf/machine/soquartz-model-a.conf
>>
>> diff --git a/README b/README
>> index 09f8691..85ab2ec 100644
>> --- a/README
>> +++ b/README
>> @@ -45,6 +45,7 @@ Status of supported boards:
>>                rock-pi-e
>>                rock-pi-s
>>                rock64
>> +            soquartz (on model A base board)
>>
>>        builds:
>>            32-bit:
>> diff --git a/conf/machine/include/soquartz.inc
>> b/conf/machine/include/soquartz.inc
>> new file mode 100644
>> index 0000000..6714efc
>> --- /dev/null
>> +++ b/conf/machine/include/soquartz.inc
>> @@ -0,0 +1,15 @@
>> +#Copyright (C) Trifork A/S 2024
>> +# Released under the MIT license (see COPYING.MIT for the terms)
>> +
>> +# Common override for basing a SOQuartz design on
>> +# https://wiki.pine64.org/wiki/SOQuartz
>> +
>> +MACHINEOVERRIDES =. "soquartz:"
>> +
>> +require conf/machine/include/rk3566.inc
>> +
>> +# A machine using this baseboard could use these options or overload 
>> them
>
> I think it is actually required to set those variables in a machine 
> configuration file since nothing else defines a default? And since 
> those are now commented out (as they should).
>
> So I'm just nitpicking on the phrasing here. I wouldn't necessarily 
> send a new version just for that, but maybe Trevor will have a 
> different opinion (or fix it when merging).
>
English is not my first language, but I was trying to convey that if 
starting a new board, these could be used as a starting point.
Could you suggest wording that would convey that more clearly? (maybe I 
just did)

> Looks good to me otherwise!
>
> Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>
>
> Thanks!
> Quentin
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#810): 
> https://lists.yoctoproject.org/g/yocto-patches/message/810
> Mute This Topic: https://lists.yoctoproject.org/mt/109551419/9116071
> Group Owner: yocto-patches+owner@lists.yoctoproject.org
> Unsubscribe: 
> https://lists.yoctoproject.org/g/yocto-patches/leave/13741902/9116071/1253603286/xyzzy 
> [pbe@trifork.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>
Quentin Schulz Nov. 18, 2024, 9:36 a.m. UTC | #3
Hi Paul,

On 11/18/24 9:04 AM, Paul M. Bendixen via lists.yoctoproject.org wrote:
> [You don't often get email from pbe=trifork.com@lists.yoctoproject.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
> 
> On 15.11.2024 15.59, Quentin Schulz via lists.yoctoproject.org wrote:
>> Hi Paul,
>>
>> Please version your patches when sending (usually -v N with N being
>> the proper version number should be enough), a vN will then appear
>> next to [PATCH in the mail subject. That is necessary for maintainers
>> and reviewers to not have to figure out which one mail is the latest
>> and greatest patch you've sent and they should review or merge.
>>
> Ok, makes sense, couldn't find that anywhere but will change for next time.
> 
>> I can also recommend using b4 which does a lot of things automatically
>> for you :)
> Thanks for the tip, I'll check it out.
>>
>> See comment inline.
>>
>> On 11/15/24 3:51 PM, Paul M. Bendixen via lists.yoctoproject.org wrote:
>>> [You don't often get email from
>>> pbe=trifork.com@lists.yoctoproject.org. Learn why this is important
>>> at https://aka.ms/LearnAboutSenderIdentification ]
>>>
>>> The SOQuartz is a RK3566 based compute module and parts of Quartz64
>>> series
>>> The Model-A base board is one possible board that supports it
>>>
>>> Website:
>>>        https://pine64.org/devices/soquartz/
>>> Wiki:
>>>        https://wiki.pine64.org/wiki/SOQuartz
>>>
>>> Specs:
>>> - Rockchip RK3566 Quad-core ARM Cortex-A55@1.8GHz
>>> - Mali-G52 2EE Bifrost GPU@800MHz
>>> - Raspberry Pi 4 CM form factor
>>> - RAM Memory Variants: 2GB, 4GB, 8GB LPDDR4.
>>> - optional eMMC from 8GB to 128GB
>>> - optional 128Mb SPI Flash
>>> - 10/100/1000Mbps Ethernet
>>> - WiFi 802.11 b/g/n/ac with Bluetooth 5.0
>>>
>>> Exposed preripherals:
>>> - 1x HDMI
>>> - 2x DSI
>>> - 1x eDP
>>> - 1x LVDS
>>> - 1x CSI 4-line
>>> - 1x Ethernet
>>> - 1x USB 2.0 OTG
>>> - 1x SD
>>> - 1x PCIe 1-line
>>> - 28x GPIO
>>>
>>> Model-A baseboard:
>>> - 1x microSD - bootable
>>> - 1x HDMI Port
>>> - 2x USB A 2.0 Host
>>> - 1x USB C 2.0 Host
>>> - 1x 5 pin USB expansion
>>> - 1x Ethernet w. PoE
>>> - 1x 40 pole Pi2 compatible GPIO
>>> - 1x MiPi-CSI 2 lanes
>>> - 1x MiPi-CSI 4 lanes
>>> - 1x MiPi-DSI 2 lanes
>>> - 1x MiPi-DSI 4 lanes
>>> - 1x PCIe open ended
>>>
>>> Signed-off-by: Paul M. B. Bendixen <pbe@trifork.com>
>>> ---
>>>     README                                      |  1 +
>>>     conf/machine/include/soquartz.inc           | 15 +++++++++++++++
>>>     conf/machine/soquartz-model-a.conf          | 12 ++++++++++++
>>>     recipes-kernel/linux/linux-yocto_%.bbappend |  1 +
>>>     4 files changed, 29 insertions(+)
>>>     create mode 100644 conf/machine/include/soquartz.inc
>>>     create mode 100644 conf/machine/soquartz-model-a.conf
>>>
>>> diff --git a/README b/README
>>> index 09f8691..85ab2ec 100644
>>> --- a/README
>>> +++ b/README
>>> @@ -45,6 +45,7 @@ Status of supported boards:
>>>                 rock-pi-e
>>>                 rock-pi-s
>>>                 rock64
>>> +            soquartz (on model A base board)
>>>
>>>         builds:
>>>             32-bit:
>>> diff --git a/conf/machine/include/soquartz.inc
>>> b/conf/machine/include/soquartz.inc
>>> new file mode 100644
>>> index 0000000..6714efc
>>> --- /dev/null
>>> +++ b/conf/machine/include/soquartz.inc
>>> @@ -0,0 +1,15 @@
>>> +#Copyright (C) Trifork A/S 2024
>>> +# Released under the MIT license (see COPYING.MIT for the terms)
>>> +
>>> +# Common override for basing a SOQuartz design on
>>> +# https://wiki.pine64.org/wiki/SOQuartz
>>> +
>>> +MACHINEOVERRIDES =. "soquartz:"
>>> +
>>> +require conf/machine/include/rk3566.inc
>>> +
>>> +# A machine using this baseboard could use these options or overload
>>> them
>>
>> I think it is actually required to set those variables in a machine
>> configuration file since nothing else defines a default? And since
>> those are now commented out (as they should).
>>
>> So I'm just nitpicking on the phrasing here. I wouldn't necessarily
>> send a new version just for that, but maybe Trevor will have a
>> different opinion (or fix it when merging).
>>
> English is not my first language, but I was trying to convey that if

Me neither :)

> starting a new board, these could be used as a starting point.
> Could you suggest wording that would convey that more clearly? (maybe I
> just did)
> 

To **me**, *could* means the ability to do something, or something that 
is possible to happen. Not required, just recommended, maybe will 
happen, maybe not.

*should* has multiple meanings, mostly depending on the context I guess. 
It indicates a "more" recommended way than could.

Basically I see it in this order of "necessity"

might, may, could, should, shall/must

shall/must is a pretty rare occurrence - and more "legalese" speak to me 
- but is technically the right verb to use to convey that one REALLY 
does need to do that thing we're talking about.

Here what I'm disputing is that it is absolutely required for a machine 
including soquartz.inc to provide those two variables otherwise it 
simply won't work (haven't checked but I believe that's the case). So 
"suggesting" to do it with "could" is a bit misleading. "must" probably 
would be better here.

https://learn-english-today.com/lessons/lesson_contents/verbs/modals.html 
or https://english.lingolia.com/en/grammar/verbs/modal-verbs I guess 
that could help?

Anyway, the fact that the variables are here and with the small comment, 
people would probably get what they are supposed to do with it, 
especially with the model-a machine config as an example :)

Cheers,
Quentin
Trevor Woerner Nov. 18, 2024, 6:03 p.m. UTC | #4
Hi Paul,

Thanks for your patch!

Are you using "git send-email ..." to send your patches? The patch itself
appears to be base64 encoded. It looks fine in email readers, but using mutt
to save the patch then try to apply it is running into issues.

I'll see if I can figure out the magic to decode (done) in a way that makes
"git am ..." happy (not working).

Thanks, Quentin and Ross, for your help :-)

Best regards,
	Trevor


On Fri 2024-11-15 @ 02:51:08 PM, Paul M. Bendixen wrote:
> The SOQuartz is a RK3566 based compute module and parts of Quartz64 series
> The Model-A base board is one possible board that supports it
> 
> Website:
>      https://pine64.org/devices/soquartz/
> Wiki:
>      https://wiki.pine64.org/wiki/SOQuartz
> 
> Specs:
> - Rockchip RK3566 Quad-core ARM Cortex-A55@1.8GHz
> - Mali-G52 2EE Bifrost GPU@800MHz
> - Raspberry Pi 4 CM form factor
> - RAM Memory Variants: 2GB, 4GB, 8GB LPDDR4.
> - optional eMMC from 8GB to 128GB
> - optional 128Mb SPI Flash
> - 10/100/1000Mbps Ethernet
> - WiFi 802.11 b/g/n/ac with Bluetooth 5.0
> 
> Exposed preripherals:
> - 1x HDMI
> - 2x DSI
> - 1x eDP
> - 1x LVDS
> - 1x CSI 4-line
> - 1x Ethernet
> - 1x USB 2.0 OTG
> - 1x SD
> - 1x PCIe 1-line
> - 28x GPIO
> 
> Model-A baseboard:
> - 1x microSD - bootable
> - 1x HDMI Port
> - 2x USB A 2.0 Host
> - 1x USB C 2.0 Host
> - 1x 5 pin USB expansion
> - 1x Ethernet w. PoE
> - 1x 40 pole Pi2 compatible GPIO
> - 1x MiPi-CSI 2 lanes
> - 1x MiPi-CSI 4 lanes
> - 1x MiPi-DSI 2 lanes
> - 1x MiPi-DSI 4 lanes
> - 1x PCIe open ended
> 
> Signed-off-by: Paul M. B. Bendixen <pbe@trifork.com>
> ---
>   README                                      |  1 +
>   conf/machine/include/soquartz.inc           | 15 +++++++++++++++
>   conf/machine/soquartz-model-a.conf          | 12 ++++++++++++
>   recipes-kernel/linux/linux-yocto_%.bbappend |  1 +
>   4 files changed, 29 insertions(+)
>   create mode 100644 conf/machine/include/soquartz.inc
>   create mode 100644 conf/machine/soquartz-model-a.conf
> 
> diff --git a/README b/README
> index 09f8691..85ab2ec 100644
> --- a/README
> +++ b/README
> @@ -45,6 +45,7 @@ Status of supported boards:
>               rock-pi-e
>               rock-pi-s
>               rock64
> +            soquartz (on model A base board)
> 
>       builds:
>           32-bit:
> diff --git a/conf/machine/include/soquartz.inc 
> b/conf/machine/include/soquartz.inc
> new file mode 100644
> index 0000000..6714efc
> --- /dev/null
> +++ b/conf/machine/include/soquartz.inc
> @@ -0,0 +1,15 @@
> +#Copyright (C) Trifork A/S 2024
> +# Released under the MIT license (see COPYING.MIT for the terms)
> +
> +# Common override for basing a SOQuartz design on
> +# https://wiki.pine64.org/wiki/SOQuartz
> +
> +MACHINEOVERRIDES =. "soquartz:"
> +
> +require conf/machine/include/rk3566.inc
> +
> +# A machine using this baseboard could use these options or overload them
> +# UBOOT_MACHINE ?= "soquartz-cm4-rk3566_defconfig"
> +# KERNEL_DEVICETREE ?= "rockchip/rk3566-soquartz-cm4.dtb"
> +
> +MACHINE_EXTRA_RRECOMMENDS += "kernel-modules"
> diff --git a/conf/machine/soquartz-model-a.conf 
> b/conf/machine/soquartz-model-a.conf
> new file mode 100644
> index 0000000..b8be4ca
> --- /dev/null
> +++ b/conf/machine/soquartz-model-a.conf
> @@ -0,0 +1,12 @@
> +#Copyright (C) Trifork A/S 2024
> +# Released under the MIT license (see COPYING.MIT for the terms)
> +
> +#@TYPE: Machine
> +#@NAME: SOQuartz on Model A base board
> +#@DESCRIPTION: SOQuartz is a series of Compute Module by Pine64, the 
> Model-A baseboard provides standard connectors for the compute module
> +#https://wiki.pine64.org/wiki/SOQuartz#SOQuartz_Model-A_Baseboard_Features
> +
> +require conf/machine/include/soquartz.inc
> +
> +KERNEL_DEVICETREE = "rockchip/rk3566-soquartz-model-a.dtb"
> +UBOOT_MACHINE = "soquartz-model-a-rk3566_defconfig"
> diff --git a/recipes-kernel/linux/linux-yocto_%.bbappend 
> b/recipes-kernel/linux/linux-yocto_%.bbappend
> index 5528bab..56ec9d7 100644
> --- a/recipes-kernel/linux/linux-yocto_%.bbappend
> +++ b/recipes-kernel/linux/linux-yocto_%.bbappend
> @@ -22,6 +22,7 @@ COMPATIBLE_MACHINE:rock-3a = "rock-3a"
>   COMPATIBLE_MACHINE:rock-4c-plus = "rock-4c-plus"
>   COMPATIBLE_MACHINE:rock-5a = "rock-5a"
>   COMPATIBLE_MACHINE:rock-5b = "rock-5b"
> +COMPATIBLE_MACHINE:soquartz = "soquartz"
> 
>   SRC_URI:append = " 
> file://rockchip-kmeta;type=kmeta;name=rockchip-kmeta;destsuffix=rockchip-kmeta"
>   SRC_URI:append:nanopi-r4s = " file://nanopi-r4s.scc"
> -- 
> 2.43.0
> 
>
Paul M. Bendixen Nov. 19, 2024, 11:46 a.m. UTC | #5
Hi Trevor

On mandag den 18. november 2024 19.03.17 CET you wrote:
> Hi Paul,
> 
> Thanks for your patch!
> 
> Are you using "git send-email ..." to send your patches? The patch itself
> appears to be base64 encoded. It looks fine in email readers, but using mutt
> to save the patch then try to apply it is running into issues.
> 
> I'll see if I can figure out the magic to decode (done) in a way that makes
> "git am ..." happy (not working).
> 
I'm going to try sending using KMail now, does this help? (should I do another version?
> Thanks, Quentin and Ross, for your help :-)
> 
> Best regards,
> 	Trevor
> 
> On Fri 2024-11-15 @ 02:51:08 PM, Paul M. Bendixen wrote:
> > The SOQuartz is a RK3566 based compute module and parts of Quartz64 series
> > The Model-A base board is one possible board that supports it
> > 
> > Website:
> >      https://pine64.org/devices/soquartz/
> > 
> > Wiki:
> >      https://wiki.pine64.org/wiki/SOQuartz
> > 
> > Specs:
> > - Rockchip RK3566 Quad-core ARM Cortex-A55@1.8GHz
> > - Mali-G52 2EE Bifrost GPU@800MHz
> > - Raspberry Pi 4 CM form factor
> > - RAM Memory Variants: 2GB, 4GB, 8GB LPDDR4.
> > - optional eMMC from 8GB to 128GB
> > - optional 128Mb SPI Flash
> > - 10/100/1000Mbps Ethernet
> > - WiFi 802.11 b/g/n/ac with Bluetooth 5.0
> > 
> > Exposed preripherals:
> > - 1x HDMI
> > - 2x DSI
> > - 1x eDP
> > - 1x LVDS
> > - 1x CSI 4-line
> > - 1x Ethernet
> > - 1x USB 2.0 OTG
> > - 1x SD
> > - 1x PCIe 1-line
> > - 28x GPIO
> > 
> > Model-A baseboard:
> > - 1x microSD - bootable
> > - 1x HDMI Port
> > - 2x USB A 2.0 Host
> > - 1x USB C 2.0 Host
> > - 1x 5 pin USB expansion
> > - 1x Ethernet w. PoE
> > - 1x 40 pole Pi2 compatible GPIO
> > - 1x MiPi-CSI 2 lanes
> > - 1x MiPi-CSI 4 lanes
> > - 1x MiPi-DSI 2 lanes
> > - 1x MiPi-DSI 4 lanes
> > - 1x PCIe open ended
> > 
> > Signed-off-by: Paul M. B. Bendixen <pbe@trifork.com>
> > ---
> > 
> >   README                                      |  1 +
> >   conf/machine/include/soquartz.inc           | 15 +++++++++++++++
> >   conf/machine/soquartz-model-a.conf          | 12 ++++++++++++
> >   recipes-kernel/linux/linux-yocto_%.bbappend |  1 +
> >   4 files changed, 29 insertions(+)
> >   create mode 100644 conf/machine/include/soquartz.inc
> >   create mode 100644 conf/machine/soquartz-model-a.conf
> > 
> > diff --git a/README b/README
> > index 09f8691..85ab2ec 100644
> > --- a/README
> > +++ b/README
> > 
> > @@ -45,6 +45,7 @@ Status of supported boards:
> >               rock-pi-e
> >               rock-pi-s
> >               rock64
> > 
> > +            soquartz (on model A base board)
> > 
> >       builds:
> > 
> >           32-bit:
> > diff --git a/conf/machine/include/soquartz.inc
> > b/conf/machine/include/soquartz.inc
> > new file mode 100644
> > index 0000000..6714efc
> > --- /dev/null
> > +++ b/conf/machine/include/soquartz.inc
> > @@ -0,0 +1,15 @@
> > +#Copyright (C) Trifork A/S 2024
> > +# Released under the MIT license (see COPYING.MIT for the terms)
> > +
> > +# Common override for basing a SOQuartz design on
> > +# https://wiki.pine64.org/wiki/SOQuartz
> > +
> > +MACHINEOVERRIDES =. "soquartz:"
> > +
> > +require conf/machine/include/rk3566.inc
> > +
> > +# A machine using this baseboard could use these options or overload them
> > +# UBOOT_MACHINE ?= "soquartz-cm4-rk3566_defconfig"
> > +# KERNEL_DEVICETREE ?= "rockchip/rk3566-soquartz-cm4.dtb"
> > +
> > +MACHINE_EXTRA_RRECOMMENDS += "kernel-modules"
> > diff --git a/conf/machine/soquartz-model-a.conf
> > b/conf/machine/soquartz-model-a.conf
> > new file mode 100644
> > index 0000000..b8be4ca
> > --- /dev/null
> > +++ b/conf/machine/soquartz-model-a.conf
> > @@ -0,0 +1,12 @@
> > +#Copyright (C) Trifork A/S 2024
> > +# Released under the MIT license (see COPYING.MIT for the terms)
> > +
> > +#@TYPE: Machine
> > +#@NAME: SOQuartz on Model A base board
> > +#@DESCRIPTION: SOQuartz is a series of Compute Module by Pine64, the
> > Model-A baseboard provides standard connectors for the compute module
> > +#https://wiki.pine64.org/wiki/SOQuartz#SOQuartz_Model-A_Baseboard_Feature
> > s
> > +
> > +require conf/machine/include/soquartz.inc
> > +
> > +KERNEL_DEVICETREE = "rockchip/rk3566-soquartz-model-a.dtb"
> > +UBOOT_MACHINE = "soquartz-model-a-rk3566_defconfig"
> > diff --git a/recipes-kernel/linux/linux-yocto_%.bbappend
> > b/recipes-kernel/linux/linux-yocto_%.bbappend
> > index 5528bab..56ec9d7 100644
> > --- a/recipes-kernel/linux/linux-yocto_%.bbappend
> > +++ b/recipes-kernel/linux/linux-yocto_%.bbappend
> > @@ -22,6 +22,7 @@ COMPATIBLE_MACHINE:rock-3a = "rock-3a"
> > 
> >   COMPATIBLE_MACHINE:rock-4c-plus = "rock-4c-plus"
> >   COMPATIBLE_MACHINE:rock-5a = "rock-5a"
> >   COMPATIBLE_MACHINE:rock-5b = "rock-5b"
> > 
> > +COMPATIBLE_MACHINE:soquartz = "soquartz"
> > 
> >   SRC_URI:append = "
> > 
> > file://rockchip-kmeta;type=kmeta;name=rockchip-kmeta;destsuffix=rockchip-k
> > meta"> 
> >   SRC_URI:append:nanopi-r4s = " file://nanopi-r4s.scc"

From 1eba8ca5a6c04301603da3367359444a2f3b6743 Mon Sep 17 00:00:00 2001
From: "Paul M. B. Bendixen" <pbe@trifork.com>
Date: Wed, 13 Nov 2024 09:29:46 +0100
Subject: [meta-rockchip] [PATCH] SOQuartz: add

The SOQuartz is a RK3566 based compute module and parts of Quartz64 series
The Model-A base board is one possible board that supports it

Website:
	https://pine64.org/devices/soquartz/
Wiki:
	https://wiki.pine64.org/wiki/SOQuartz

Specs:
- Rockchip RK3566 Quad-core ARM Cortex-A55@1.8GHz
- Mali-G52 2EE Bifrost GPU@800MHz
- Raspberry Pi 4 CM form factor
- RAM Memory Variants: 2GB, 4GB, 8GB LPDDR4.
- optional eMMC from 8GB to 128GB
- optional 128Mb SPI Flash
- 10/100/1000Mbps Ethernet
- WiFi 802.11 b/g/n/ac with Bluetooth 5.0

Exposed preripherals:
- 1x HDMI
- 2x DSI
- 1x eDP
- 1x LVDS
- 1x CSI 4-line
- 1x Ethernet
- 1x USB 2.0 OTG
- 1x SD
- 1x PCIe 1-line
- 28x GPIO

Model-A baseboard:
- 1x microSD - bootable
- 1x HDMI Port
- 2x USB A 2.0 Host
- 1x USB C 2.0 Host
- 1x 5 pin USB expansion
- 1x Ethernet w. PoE
- 1x 40 pole Pi2 compatible GPIO
- 1x MiPi-CSI 2 lanes
- 1x MiPi-CSI 4 lanes
- 1x MiPi-DSI 2 lanes
- 1x MiPi-DSI 4 lanes
- 1x PCIe open ended

Signed-off-by: Paul M. B. Bendixen <pbe@trifork.com>
---
 README                                      |  1 +
 conf/machine/include/soquartz.inc           | 15 +++++++++++++++
 conf/machine/soquartz-model-a.conf          | 12 ++++++++++++
 recipes-kernel/linux/linux-yocto_%.bbappend |  1 +
 4 files changed, 29 insertions(+)
 create mode 100644 conf/machine/include/soquartz.inc
 create mode 100644 conf/machine/soquartz-model-a.conf

diff --git a/README b/README
index 09f8691..85ab2ec 100644
--- a/README
+++ b/README
@@ -45,6 +45,7 @@ Status of supported boards:
 			rock-pi-e
 			rock-pi-s
 			rock64
+			soquartz (on model A base board)
 
 	builds:
 		32-bit:
diff --git a/conf/machine/include/soquartz.inc b/conf/machine/include/soquartz.inc
new file mode 100644
index 0000000..6714efc
--- /dev/null
+++ b/conf/machine/include/soquartz.inc
@@ -0,0 +1,15 @@
+#Copyright (C) Trifork A/S 2024
+# Released under the MIT license (see COPYING.MIT for the terms)
+
+# Common override for basing a SOQuartz design on
+# https://wiki.pine64.org/wiki/SOQuartz
+
+MACHINEOVERRIDES =. "soquartz:"
+
+require conf/machine/include/rk3566.inc
+
+# A machine using this baseboard could use these options or overload them
+# UBOOT_MACHINE ?= "soquartz-cm4-rk3566_defconfig"
+# KERNEL_DEVICETREE ?= "rockchip/rk3566-soquartz-cm4.dtb"
+
+MACHINE_EXTRA_RRECOMMENDS += "kernel-modules"
diff --git a/conf/machine/soquartz-model-a.conf b/conf/machine/soquartz-model-a.conf
new file mode 100644
index 0000000..b8be4ca
--- /dev/null
+++ b/conf/machine/soquartz-model-a.conf
@@ -0,0 +1,12 @@
+#Copyright (C) Trifork A/S 2024
+# Released under the MIT license (see COPYING.MIT for the terms)
+
+#@TYPE: Machine
+#@NAME: SOQuartz on Model A base board
+#@DESCRIPTION: SOQuartz is a series of Compute Module by Pine64, the Model-A baseboard provides standard connectors for the compute module
+#https://wiki.pine64.org/wiki/SOQuartz#SOQuartz_Model-A_Baseboard_Features 
+
+require conf/machine/include/soquartz.inc
+
+KERNEL_DEVICETREE = "rockchip/rk3566-soquartz-model-a.dtb"
+UBOOT_MACHINE = "soquartz-model-a-rk3566_defconfig"
diff --git a/recipes-kernel/linux/linux-yocto_%.bbappend b/recipes-kernel/linux/linux-yocto_%.bbappend
index 5528bab..56ec9d7 100644
--- a/recipes-kernel/linux/linux-yocto_%.bbappend
+++ b/recipes-kernel/linux/linux-yocto_%.bbappend
@@ -22,6 +22,7 @@ COMPATIBLE_MACHINE:rock-3a = "rock-3a"
 COMPATIBLE_MACHINE:rock-4c-plus = "rock-4c-plus"
 COMPATIBLE_MACHINE:rock-5a = "rock-5a"
 COMPATIBLE_MACHINE:rock-5b = "rock-5b"
+COMPATIBLE_MACHINE:soquartz = "soquartz"
 
 SRC_URI:append = " file://rockchip-kmeta;type=kmeta;name=rockchip-kmeta;destsuffix=rockchip-kmeta"
 SRC_URI:append:nanopi-r4s = " file://nanopi-r4s.scc"
diff mbox series

Patch

diff --git a/README b/README
index 09f8691..85ab2ec 100644
--- a/README
+++ b/README
@@ -45,6 +45,7 @@  Status of supported boards:
              rock-pi-e
              rock-pi-s
              rock64
+            soquartz (on model A base board)

      builds:
          32-bit:
diff --git a/conf/machine/include/soquartz.inc 
b/conf/machine/include/soquartz.inc
new file mode 100644
index 0000000..6714efc
--- /dev/null
+++ b/conf/machine/include/soquartz.inc
@@ -0,0 +1,15 @@ 
+#Copyright (C) Trifork A/S 2024
+# Released under the MIT license (see COPYING.MIT for the terms)
+
+# Common override for basing a SOQuartz design on
+# https://wiki.pine64.org/wiki/SOQuartz
+
+MACHINEOVERRIDES =. "soquartz:"
+
+require conf/machine/include/rk3566.inc
+
+# A machine using this baseboard could use these options or overload them
+# UBOOT_MACHINE ?= "soquartz-cm4-rk3566_defconfig"
+# KERNEL_DEVICETREE ?= "rockchip/rk3566-soquartz-cm4.dtb"
+
+MACHINE_EXTRA_RRECOMMENDS += "kernel-modules"
diff --git a/conf/machine/soquartz-model-a.conf 
b/conf/machine/soquartz-model-a.conf
new file mode 100644
index 0000000..b8be4ca
--- /dev/null
+++ b/conf/machine/soquartz-model-a.conf
@@ -0,0 +1,12 @@ 
+#Copyright (C) Trifork A/S 2024
+# Released under the MIT license (see COPYING.MIT for the terms)
+
+#@TYPE: Machine
+#@NAME: SOQuartz on Model A base board
+#@DESCRIPTION: SOQuartz is a series of Compute Module by Pine64, the 
Model-A baseboard provides standard connectors for the compute module
+#https://wiki.pine64.org/wiki/SOQuartz#SOQuartz_Model-A_Baseboard_Features
+
+require conf/machine/include/soquartz.inc
+
+KERNEL_DEVICETREE = "rockchip/rk3566-soquartz-model-a.dtb"
+UBOOT_MACHINE = "soquartz-model-a-rk3566_defconfig"
diff --git a/recipes-kernel/linux/linux-yocto_%.bbappend 
b/recipes-kernel/linux/linux-yocto_%.bbappend
index 5528bab..56ec9d7 100644
--- a/recipes-kernel/linux/linux-yocto_%.bbappend
+++ b/recipes-kernel/linux/linux-yocto_%.bbappend
@@ -22,6 +22,7 @@  COMPATIBLE_MACHINE:rock-3a = "rock-3a"
  COMPATIBLE_MACHINE:rock-4c-plus = "rock-4c-plus"
  COMPATIBLE_MACHINE:rock-5a = "rock-5a"
  COMPATIBLE_MACHINE:rock-5b = "rock-5b"
+COMPATIBLE_MACHINE:soquartz = "soquartz"

  SRC_URI:append = " 
file://rockchip-kmeta;type=kmeta;name=rockchip-kmeta;destsuffix=rockchip-kmeta"