Message ID | 1731403483-21399-1-git-send-email-wangmy@fujitsu.com |
---|---|
State | New |
Headers | show |
Series | [01/47] barebox-tools: upgrade 2024.09.0 -> 2024.10.0 | expand |
On Tue, 12 Nov 2024 at 10:25, wangmy via lists.openembedded.org <wangmy=fujitsu.com@lists.openembedded.org> wrote: > > From: Wang Mingyu <wangmy@fujitsu.com> > > Signed-off-by: Wang Mingyu <wangmy@fujitsu.com> > --- > .../{barebox-tools_2024.09.0.bb => barebox-tools_2024.10.0.bb} | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > rename meta/recipes-bsp/barebox/{barebox-tools_2024.09.0.bb => barebox-tools_2024.10.0.bb} (93%) > > diff --git a/meta/recipes-bsp/barebox/barebox-tools_2024.09.0.bb b/meta/recipes-bsp/barebox/barebox-tools_2024.10.0.bb > similarity index 93% > rename from meta/recipes-bsp/barebox/barebox-tools_2024.09.0.bb > rename to meta/recipes-bsp/barebox/barebox-tools_2024.10.0.bb > index 13a308b3da..386656f7ad 100644 > --- a/meta/recipes-bsp/barebox/barebox-tools_2024.09.0.bb > +++ b/meta/recipes-bsp/barebox/barebox-tools_2024.10.0.bb > @@ -8,7 +8,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=f5125d13e000b9ca1f0d3364286c4192" > DEPENDS = "bison-native flex-native libusb1" > > SRC_URI = "https://barebox.org/download/barebox-${PV}.tar.bz2" > -SRC_URI[sha256sum] = "4d4ea7e232aeba2b3cb9ccf0dbf8cd8e01c65b6c615f64c3bd0c4f24f23a47da" > +SRC_URI[sha256sum] = "955b20bfa7358732d2c0c09ccfd4c1a69087b7e2c610b16dee7442d71a5af88d" Main barebox recipe needs to be updated at the same time. I think we need to put SRC_URI items into a shared .inc file, otherwise people will easily forget about this, and update one recipe but not the other. Alex
Am Dienstag, dem 12.11.2024 um 10:39 +0100 schrieb Alexander Kanavin via lists.openembedded.org: > On Tue, 12 Nov 2024 at 10:25, wangmy via lists.openembedded.org > <wangmy=fujitsu.com@lists.openembedded.org> wrote: > > > > From: Wang Mingyu <wangmy@fujitsu.com> > > > > Signed-off-by: Wang Mingyu <wangmy@fujitsu.com> > > --- > > .../{barebox-tools_2024.09.0.bb => barebox-tools_2024.10.0.bb} | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > rename meta/recipes-bsp/barebox/{barebox-tools_2024.09.0.bb => barebox-tools_2024.10.0.bb} > > (93%) > > > > diff --git a/meta/recipes-bsp/barebox/barebox-tools_2024.09.0.bb b/meta/recipes- > > bsp/barebox/barebox-tools_2024.10.0.bb > > similarity index 93% > > rename from meta/recipes-bsp/barebox/barebox-tools_2024.09.0.bb > > rename to meta/recipes-bsp/barebox/barebox-tools_2024.10.0.bb > > index 13a308b3da..386656f7ad 100644 > > --- a/meta/recipes-bsp/barebox/barebox-tools_2024.09.0.bb > > +++ b/meta/recipes-bsp/barebox/barebox-tools_2024.10.0.bb > > @@ -8,7 +8,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=f5125d13e000b9ca1f0d3364286c4192" > > DEPENDS = "bison-native flex-native libusb1" > > > > SRC_URI = "https://barebox.org/download/barebox-${PV}.tar.bz2" > > -SRC_URI[sha256sum] = "4d4ea7e232aeba2b3cb9ccf0dbf8cd8e01c65b6c615f64c3bd0c4f24f23a47da" > > +SRC_URI[sha256sum] = "955b20bfa7358732d2c0c09ccfd4c1a69087b7e2c610b16dee7442d71a5af88d" > > Main barebox recipe needs to be updated at the same time. Last time I updated this, I assumed my version bump patch was not taken because patchtest complained about a missing description. Thus I took a look at other version bumps and decided it might be desired to have a short note on the main changes or a link to the changelog in the commit message. Is that the case? Are the changes I see in other recipes all generated by hand? Another thing I noticed is that I did not get a mail from the AUH for barebox-tools 2024.10 so far. (But this would update barebox-tools only, maybe for the same reason the maintainer check failed initially (barebox recipe not being a default provider)). > I think we need to put SRC_URI items into a shared .inc file, > otherwise people will easily forget about this, and update one recipe > but not the other. Looks like this currently is the way to ensure this, yes. Can the upgrade helper handle this properly? I wouldn't yet do it now to not interfere with these patches, but If I should step in, just let me know. Thanks and Regards, Enrico > Alex > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#207037): https://lists.openembedded.org/g/openembedded-core/message/207037 > Mute This Topic: https://lists.openembedded.org/mt/109531959/3616721 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [ejo@pengutronix.de] > -=-=-=-=-=-=-=-=-=-=-=- >
On Tue, 12 Nov 2024 at 12:25, Enrico Jörns <ejo@pengutronix.de> wrote: > Last time I updated this, I assumed my version bump patch was not taken because patchtest complained > about a missing description. > Thus I took a look at other version bumps and decided it might be desired to have a short note on > the main changes or a link to the changelog in the commit message. > Is that the case? Are the changes I see in other recipes all generated by hand? The changelog is not required. And missing description is not a hard blocker; it's at the discretion of the submitter to add something. > Another thing I noticed is that I did not get a mail from the AUH for barebox-tools 2024.10 so far. > (But this would update barebox-tools only, maybe for the same reason the maintainer check failed > initially (barebox recipe not being a default provider)). The last AUH run got somehow stuck and was killed on timeout. I'd wait and see what happens in three days time. > > I think we need to put SRC_URI items into a shared .inc file, > > otherwise people will easily forget about this, and update one recipe > > but not the other. > > Looks like this currently is the way to ensure this, yes. Can the upgrade helper handle this > properly? I wouldn't yet do it now to not interfere with these patches, but If I should step in, > just let me know. Yes. AUH detects if recipes share an include file, and if so, updates them in lockstep and makes a single patch. Alex
diff --git a/meta/recipes-bsp/barebox/barebox-tools_2024.09.0.bb b/meta/recipes-bsp/barebox/barebox-tools_2024.10.0.bb similarity index 93% rename from meta/recipes-bsp/barebox/barebox-tools_2024.09.0.bb rename to meta/recipes-bsp/barebox/barebox-tools_2024.10.0.bb index 13a308b3da..386656f7ad 100644 --- a/meta/recipes-bsp/barebox/barebox-tools_2024.09.0.bb +++ b/meta/recipes-bsp/barebox/barebox-tools_2024.10.0.bb @@ -8,7 +8,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=f5125d13e000b9ca1f0d3364286c4192" DEPENDS = "bison-native flex-native libusb1" SRC_URI = "https://barebox.org/download/barebox-${PV}.tar.bz2" -SRC_URI[sha256sum] = "4d4ea7e232aeba2b3cb9ccf0dbf8cd8e01c65b6c615f64c3bd0c4f24f23a47da" +SRC_URI[sha256sum] = "955b20bfa7358732d2c0c09ccfd4c1a69087b7e2c610b16dee7442d71a5af88d" S = "${WORKDIR}/barebox-${PV}" B = "${WORKDIR}/build"