diff mbox series

[meta-arago,master/scarthgap,v3] packagegroup-arago-tisdk-multimedia: Add mpv package

Message ID 20240801181807.13201-1-t-lannynd@ti.com
State Superseded
Delegated to: Ryan Eatmon
Headers show
Series [meta-arago,master/scarthgap,v3] packagegroup-arago-tisdk-multimedia: Add mpv package | expand

Commit Message

Thorsten Lannynd Aug. 1, 2024, 6:18 p.m. UTC
From: Thorsten Lannynd <t-lannynd@ti.com>

Add mpv package to allow for video playback and streaming of online videos

Signed-off-by: Thorsten Lannynd <t-lannynd@ti.com>
---
v3: Add version number to patch

v2: Update commit message

 .../packagegroups/packagegroup-arago-tisdk-multimedia.bb         | 1 +
 1 file changed, 1 insertion(+)

Comments

Ryan Eatmon Aug. 1, 2024, 6:22 p.m. UTC | #1
Thank you.


On 8/1/2024 1:18 PM, Thorsten Lannynd via lists.yoctoproject.org wrote:
> From: Thorsten Lannynd <t-lannynd@ti.com>
> 
> Add mpv package to allow for video playback and streaming of online videos
> 
> Signed-off-by: Thorsten Lannynd <t-lannynd@ti.com>
> ---
> v3: Add version number to patch
> 
> v2: Update commit message
> 
>   .../packagegroups/packagegroup-arago-tisdk-multimedia.bb         | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-multimedia.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-multimedia.bb
> index 6571d484..1ed1b8ab 100644
> --- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-multimedia.bb
> +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-multimedia.bb
> @@ -10,6 +10,7 @@ MULTIMEDIA = " \
>       amsdk-av-files \
>       libcamera \
>       libcamera-gst \
> +    mpv \
>   "
>   
>   MULTIMEDIA:omapl138 = ""
Ryan Eatmon Aug. 1, 2024, 6:30 p.m. UTC | #2
On 8/1/2024 1:18 PM, Thorsten Lannynd via lists.yoctoproject.org wrote:
> From: Thorsten Lannynd <t-lannynd@ti.com>
> 
> Add mpv package to allow for video playback and streaming of online videos
> 
> Signed-off-by: Thorsten Lannynd <t-lannynd@ti.com>
> ---
> v3: Add version number to patch
> 
> v2: Update commit message
> 
>   .../packagegroups/packagegroup-arago-tisdk-multimedia.bb         | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-multimedia.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-multimedia.bb
> index 6571d484..1ed1b8ab 100644
> --- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-multimedia.bb
> +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-multimedia.bb
> @@ -10,6 +10,7 @@ MULTIMEDIA = " \
>       amsdk-av-files \
>       libcamera \
>       libcamera-gst \
> +    mpv \
>   "

This does apply.  Your current patch does not include your recent ffmpeg 
patch which has been in production on scarthgap since Saturday.  Make 
sure you always rebase your patches on top of the latest changes before 
you submit in order to reduce the strain on the maintainers who have to 
figure out how to apply your patch.  Many will not take the time and 
just reject the patch.

I myself will sometimes reject (like this case), and other times I'll 
just fix up the patch while applying depending on the circumstances of 
why the patch does not apply and what mood I'm in that day.


>   MULTIMEDIA:omapl138 = ""
diff mbox series

Patch

diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-multimedia.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-multimedia.bb
index 6571d484..1ed1b8ab 100644
--- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-multimedia.bb
+++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-multimedia.bb
@@ -10,6 +10,7 @@  MULTIMEDIA = " \
     amsdk-av-files \
     libcamera \
     libcamera-gst \
+    mpv \
 "
 
 MULTIMEDIA:omapl138 = ""