| Message ID | 20240801125441.16164-1-ranjitsinh.rathod@kpit.com |
|---|---|
| State | Accepted |
| Delegated to: | Steve Sakoman |
| Headers | show |
| Series | [scarthgap] rust: Add new varaible RUST_ENABLE_EXTRA_TOOLS | expand |
Hi Ranjitsinh, Is this not compatible with master? If so, why? If not, please send the patch for the master branch (just remove the [scarthgap] prefix) first, then we can backport it to still-maintained branches once merged in master. The rule is basically: master first then backport or master not compatible thus only impacted branches. Cheers, Quentin On 8/1/24 2:54 PM, Ranjitsinh Rathod via lists.openembedded.org wrote: > [You don't often get email from ranjitsinh.rathod=kpit.com@lists.openembedded.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] > > There is a need to enable some extra tools from the rust for the build > and so this new variable will help for that > > This varaible then we can use during do_configure task to add overall > values as per json format in build -> tools > > Signed-off-by: Ranjitsinh Rathod <ranjitsinh.rathod@kpit.com> > --- > meta/recipes-devtools/rust/rust_1.75.0.bb | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/meta/recipes-devtools/rust/rust_1.75.0.bb b/meta/recipes-devtools/rust/rust_1.75.0.bb > index 76e1fe2d84..c33f31d261 100644 > --- a/meta/recipes-devtools/rust/rust_1.75.0.bb > +++ b/meta/recipes-devtools/rust/rust_1.75.0.bb > @@ -70,6 +70,10 @@ addtask do_test_compile after do_configure do_rust_gen_targets > do_rust_setup_snapshot[dirs] += "${WORKDIR}/rust-snapshot" > do_rust_setup_snapshot[vardepsexclude] += "UNINATIVE_LOADER" > > +# there is a need to enable some more rust tools for the project > +# We can extend a list of more tools via this variable > +RUST_ENABLE_EXTRA_TOOLS ?= "rust-demangler" > + > python do_configure() { > import json > import configparser > @@ -141,7 +145,7 @@ python do_configure() { > config.add_section("build") > config.set("build", "submodules", e(False)) > config.set("build", "docs", e(False)) > - config.set("build", "tools", ["rust-demangler",]) > + config.set("build", "tools", e(d.getVar("RUST_ENABLE_EXTRA_TOOLS").split())) > > rustc = d.expand("${WORKDIR}/rust-snapshot/bin/rustc") > config.set("build", "rustc", e(rustc)) > -- > 2.25.1 > > This message contains information that may be privileged or confidential and is the property of the KPIT Technologies Ltd. It is intended only for the person to whom it is addressed. If you are not the intended recipient, you are not authorized to read, print, retain copy, disseminate, distribute, or use this message or any part thereof. If you receive this message in error, please notify the sender immediately and delete all copies of this message. KPIT Technologies Ltd. does not accept any liability for virus infected mails. > > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#202730): https://lists.openembedded.org/g/openembedded-core/message/202730 > Mute This Topic: https://lists.openembedded.org/mt/107665271/6293953 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [quentin.schulz@cherry.de] > -=-=-=-=-=-=-=-=-=-=-=- >
Hello Quentin, Yes, the changes is not compatible for master branch because the line in which I'm changing it removed as part of below commit. Link: https://git.yoctoproject.org/poky/commit/?id=3f69d525d813ee071bd20c7577a0653cb0f0a210 This reason I also mentioned in the other thread of meta-lts-mixins - https://lists.yoctoproject.org/g/yocto-patches/topic/107660592#msg503 Thanks, Best Regards, Ranjitsinh Rathod Technical Leader | | KPIT Technologies Ltd. Cellphone: +91-84606 92403
diff --git a/meta/recipes-devtools/rust/rust_1.75.0.bb b/meta/recipes-devtools/rust/rust_1.75.0.bb index 76e1fe2d84..c33f31d261 100644 --- a/meta/recipes-devtools/rust/rust_1.75.0.bb +++ b/meta/recipes-devtools/rust/rust_1.75.0.bb @@ -70,6 +70,10 @@ addtask do_test_compile after do_configure do_rust_gen_targets do_rust_setup_snapshot[dirs] += "${WORKDIR}/rust-snapshot" do_rust_setup_snapshot[vardepsexclude] += "UNINATIVE_LOADER" +# there is a need to enable some more rust tools for the project +# We can extend a list of more tools via this variable +RUST_ENABLE_EXTRA_TOOLS ?= "rust-demangler" + python do_configure() { import json import configparser @@ -141,7 +145,7 @@ python do_configure() { config.add_section("build") config.set("build", "submodules", e(False)) config.set("build", "docs", e(False)) - config.set("build", "tools", ["rust-demangler",]) + config.set("build", "tools", e(d.getVar("RUST_ENABLE_EXTRA_TOOLS").split())) rustc = d.expand("${WORKDIR}/rust-snapshot/bin/rustc") config.set("build", "rustc", e(rustc))
There is a need to enable some extra tools from the rust for the build and so this new variable will help for that This varaible then we can use during do_configure task to add overall values as per json format in build -> tools Signed-off-by: Ranjitsinh Rathod <ranjitsinh.rathod@kpit.com> --- meta/recipes-devtools/rust/rust_1.75.0.bb | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) -- 2.25.1 This message contains information that may be privileged or confidential and is the property of the KPIT Technologies Ltd. It is intended only for the person to whom it is addressed. If you are not the intended recipient, you are not authorized to read, print, retain copy, disseminate, distribute, or use this message or any part thereof. If you receive this message in error, please notify the sender immediately and delete all copies of this message. KPIT Technologies Ltd. does not accept any liability for virus infected mails.