Message ID | 20240722221657.157473-1-t-lannynd@ti.com |
---|---|
State | Superseded |
Delegated to: | Ryan Eatmon |
Headers | show |
Series | [scarthgap] Added ffmpeg package to scarthgap | expand |
Hi, On 23/07/24 03:46, Thorsten Lannynd via lists.yoctoproject.org wrote: > Added ffmpeg package to scarthgap Signed-off-by: Thorsten Lannynd > <t-lannynd@ ti. com> --- > .. . /packagegroups/packagegroup-arago-tisdk-multimedia. bb | 1 + 1 > file changed, 1 insertion(+) diff --git > a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-multimedia. bb > ZjQcmQRYFpfptBannerStart > This message was sent from outside of Texas Instruments. > Do not click links or open attachments unless you recognize the source > of this email and know the content is safe. If you wish to report this > message to IT Security, please forward the message as an attachment to > phishing@list.ti.com > ZjQcmQRYFpfptBannerEnd > Added ffmpeg package to scarthgap Is this patch limited to scarthgap or applicable on master branch as well? The commit message & title might need an update if we need this patch in master. --- Chirag > > Signed-off-by: Thorsten Lannynd <t-lannynd@ti.com> > --- > .../packagegroups/packagegroup-arago-tisdk-multimedia.bb | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-multimedia.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-multimedia.bb > index 6571d484..2085ad09 100644 > --- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-multimedia.bb > +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-multimedia.bb > @@ -8,6 +8,7 @@ inherit packagegroup > > MULTIMEDIA = " \ > amsdk-av-files \ > + ffmpeg \ > libcamera \ > libcamera-gst \ > " > -- > 2.34.1 > > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#15462):https://urldefense.com/v3/__https://lists.yoctoproject.org/g/meta-arago/message/15462__;!!G3vK!QAWo4b7tM51pltf97F-SN4YnlwGwMxcJcUu7V7bZiR4orkpg1Ml-qB_zMVpgGBQFY1cBjmB7ET1BeOr3RrCjljbnYpdZJi3OEGne$ > Mute This Topic:https://urldefense.com/v3/__https://lists.yoctoproject.org/mt/107495232/7030289__;!!G3vK!QAWo4b7tM51pltf97F-SN4YnlwGwMxcJcUu7V7bZiR4orkpg1Ml-qB_zMVpgGBQFY1cBjmB7ET1BeOr3RrCjljbnYpdZJlv_nBPU$ > Group Owner: meta-arago+owner@lists.yoctoproject.org > Unsubscribe:https://urldefense.com/v3/__https://lists.yoctoproject.org/g/meta-arago/unsub__;!!G3vK!QAWo4b7tM51pltf97F-SN4YnlwGwMxcJcUu7V7bZiR4orkpg1Ml-qB_zMVpgGBQFY1cBjmB7ET1BeOr3RrCjljbnYpdZJsuZFm5d$ [c-shilwant@ti.com] > -=-=-=-=-=-=-=-=-=-=-=- > >
The subject is a little odd in the wording. Added is the past tense of the verb. Also, our patches usually include the name of the recipe file so that scanning through the list of commits becomes clearer what area the patch is touching. Finally, including the branch name in the commit message makes it harder to think of the patch being able to apply to other branches. I think a better subject would be: packagegroup-arago-tisdk-multimedia: Add ffmpeg package And as Chirag pointed out, unless a patch is directly targeting issues related to a specific branch, we usually include master as well to make it clear that the patch can/should be applied to both. So: [meta-arago][master/scarthgap][PATCH] ... Please submit a v2. On 7/22/2024 5:16 PM, Thorsten Lannynd via lists.yoctoproject.org wrote: > Added ffmpeg package to scarthgap > > Signed-off-by: Thorsten Lannynd <t-lannynd@ti.com> > --- > .../packagegroups/packagegroup-arago-tisdk-multimedia.bb | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-multimedia.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-multimedia.bb > index 6571d484..2085ad09 100644 > --- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-multimedia.bb > +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-multimedia.bb > @@ -8,6 +8,7 @@ inherit packagegroup > > MULTIMEDIA = " \ > amsdk-av-files \ > + ffmpeg \ > libcamera \ > libcamera-gst \ > "
diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-multimedia.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-multimedia.bb index 6571d484..2085ad09 100644 --- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-multimedia.bb +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-multimedia.bb @@ -8,6 +8,7 @@ inherit packagegroup MULTIMEDIA = " \ amsdk-av-files \ + ffmpeg \ libcamera \ libcamera-gst \ "
Added ffmpeg package to scarthgap Signed-off-by: Thorsten Lannynd <t-lannynd@ti.com> --- .../packagegroups/packagegroup-arago-tisdk-multimedia.bb | 1 + 1 file changed, 1 insertion(+)