diff mbox series

[meta-rockchip] mesa: build panfrost for RK3566 boards

Message ID 20240617200024.389206-1-mbober1@gmail.com
State New
Headers show
Series [meta-rockchip] mesa: build panfrost for RK3566 boards | expand

Commit Message

Marcin Bober June 17, 2024, 8 p.m. UTC
The RK356x SoC family (of which we currently only support RK3568) has a
Bifrost GPU that is supported by open-source Panfrost Linux kernel and
Mesa drivers, therefore let's build mesa with Panfrost support for
RK3566.

Signed-off-by: Marcin Bober <mbober1@gmail.com>
---
 recipes-graphics/mesa/mesa_%.bbappend | 1 +
 1 file changed, 1 insertion(+)

Comments

Quentin Schulz June 18, 2024, 9:48 a.m. UTC | #1
Hi Marcin,

On 6/17/24 10:00 PM, Marcin Bober via lists.yoctoproject.org wrote:
> [You don't often get email from mbober1=gmail.com@lists.yoctoproject.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
> 
> The RK356x SoC family (of which we currently only support RK3568) has a
> Bifrost GPU that is supported by open-source Panfrost Linux kernel and
> Mesa drivers, therefore let's build mesa with Panfrost support for
> RK3566.
> 
> Signed-off-by: Marcin Bober <mbober1@gmail.com>
> ---
>   recipes-graphics/mesa/mesa_%.bbappend | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/recipes-graphics/mesa/mesa_%.bbappend b/recipes-graphics/mesa/mesa_%.bbappend
> index 2d9ec2e..ca1ad70 100644
> --- a/recipes-graphics/mesa/mesa_%.bbappend
> +++ b/recipes-graphics/mesa/mesa_%.bbappend
> @@ -2,4 +2,5 @@ PACKAGECONFIG:append:rk3288 = " kmsro panfrost"
>   PACKAGECONFIG:append:rk3328 = " kmsro lima"
>   PACKAGECONFIG:append:rk3399 = " kmsro panfrost"
>   PACKAGECONFIG:append:rk3568 = " kmsro panfrost"
> +PACKAGECONFIG:append:rk3566 = " kmsro panfrost"

Maybe re-order alphabetically :) ?

Otherwise looking good to me,

Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>

Thanks!
Quentin
Trevor Woerner June 18, 2024, 12:11 p.m. UTC | #2
On Tue 2024-06-18 @ 11:48:26 AM, Quentin Schulz via lists.yoctoproject.org wrote:
> Hi Marcin,
> 
> On 6/17/24 10:00 PM, Marcin Bober via lists.yoctoproject.org wrote:
> > [You don't often get email from mbober1=gmail.com@lists.yoctoproject.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
> > 
> > The RK356x SoC family (of which we currently only support RK3568) has a
> > Bifrost GPU that is supported by open-source Panfrost Linux kernel and
> > Mesa drivers, therefore let's build mesa with Panfrost support for
> > RK3566.
> > 
> > Signed-off-by: Marcin Bober <mbober1@gmail.com>
> > ---
> >   recipes-graphics/mesa/mesa_%.bbappend | 1 +
> >   1 file changed, 1 insertion(+)
> > 
> > diff --git a/recipes-graphics/mesa/mesa_%.bbappend b/recipes-graphics/mesa/mesa_%.bbappend
> > index 2d9ec2e..ca1ad70 100644
> > --- a/recipes-graphics/mesa/mesa_%.bbappend
> > +++ b/recipes-graphics/mesa/mesa_%.bbappend
> > @@ -2,4 +2,5 @@ PACKAGECONFIG:append:rk3288 = " kmsro panfrost"
> >   PACKAGECONFIG:append:rk3328 = " kmsro lima"
> >   PACKAGECONFIG:append:rk3399 = " kmsro panfrost"
> >   PACKAGECONFIG:append:rk3568 = " kmsro panfrost"
> > +PACKAGECONFIG:append:rk3566 = " kmsro panfrost"
> 
> Maybe re-order alphabetically :) ?

I can re-order when I apply.

> Otherwise looking good to me,
> 
> Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>
> 
> Thanks!
> Quentin
> 
> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#336): https://lists.yoctoproject.org/g/yocto-patches/message/336
> Mute This Topic: https://lists.yoctoproject.org/mt/106728240/900817
> Group Owner: yocto-patches+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/yocto-patches/leave/13168745/900817/63955952/xyzzy [twoerner@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
> 
>
Trevor Woerner June 18, 2024, 12:20 p.m. UTC | #3
On Mon 2024-06-17 @ 08:00:24 PM, Marcin Bober via lists.yoctoproject.org wrote:
> The RK356x SoC family (of which we currently only support RK3568) has a
> Bifrost GPU that is supported by open-source Panfrost Linux kernel and
> Mesa drivers, therefore let's build mesa with Panfrost support for
> RK3566.
> 
> Signed-off-by: Marcin Bober <mbober1@gmail.com>
> ---
>  recipes-graphics/mesa/mesa_%.bbappend | 1 +
>  1 file changed, 1 insertion(+)

Applied to meta-rockchip, and sorted numerically, master branch. Thanks!

Thanks for the patch Marcin! The git repository originally rejected your patch
because the Author email address was strange so I had to adjust that as well.
In the patch it is:

	Marcin Bober via lists.yoctoproject.org <mbober1=gmail.com@lists.yoctoproject.org>

So I adjusted it to your actual email address. Perhaps you have a
misconfiguration in the [user] section of your git configuration?
diff mbox series

Patch

diff --git a/recipes-graphics/mesa/mesa_%.bbappend b/recipes-graphics/mesa/mesa_%.bbappend
index 2d9ec2e..ca1ad70 100644
--- a/recipes-graphics/mesa/mesa_%.bbappend
+++ b/recipes-graphics/mesa/mesa_%.bbappend
@@ -2,4 +2,5 @@  PACKAGECONFIG:append:rk3288 = " kmsro panfrost"
 PACKAGECONFIG:append:rk3328 = " kmsro lima"
 PACKAGECONFIG:append:rk3399 = " kmsro panfrost"
 PACKAGECONFIG:append:rk3568 = " kmsro panfrost"
+PACKAGECONFIG:append:rk3566 = " kmsro panfrost"
 PACKAGECONFIG:append:px30 = " kmsro panfrost"