| Message ID | 20240323195304.2909926-2-anibal@limonsoftware.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/2] wic: bootimg-partition allow to set var to get boot files | expand |
This breaks some selftests and meta-virtualization: https://autobuilder.yoctoproject.org/typhoon/#/builders/87/builds/6573/steps/14/logs/stdio https://autobuilder.yoctoproject.org/typhoon/#/builders/128/builds/3005/steps/12/logs/stdio On 23/03/2024 13:53:04-0600, Anibal Limon wrote: > Python not support importing modules with - so change to _. > > Signed-off-by: Anibal Limon <anibal@limonsoftware.com> > --- > .../source/{bootimg-biosplusefi.py => bootimg_biosplusefi.py} | 0 > scripts/lib/wic/plugins/source/{bootimg-efi.py => bootimg_efi.py} | 0 > .../plugins/source/{bootimg-partition.py => bootimg_partition.py} | 0 > .../wic/plugins/source/{bootimg-pcbios.py => bootimg_pcbios.py} | 0 > .../source/{isoimage-isohybrid.py => isoimage_isohybrid.py} | 0 > 5 files changed, 0 insertions(+), 0 deletions(-) > rename scripts/lib/wic/plugins/source/{bootimg-biosplusefi.py => bootimg_biosplusefi.py} (100%) > rename scripts/lib/wic/plugins/source/{bootimg-efi.py => bootimg_efi.py} (100%) > rename scripts/lib/wic/plugins/source/{bootimg-partition.py => bootimg_partition.py} (100%) > rename scripts/lib/wic/plugins/source/{bootimg-pcbios.py => bootimg_pcbios.py} (100%) > rename scripts/lib/wic/plugins/source/{isoimage-isohybrid.py => isoimage_isohybrid.py} (100%) > > diff --git a/scripts/lib/wic/plugins/source/bootimg-biosplusefi.py b/scripts/lib/wic/plugins/source/bootimg_biosplusefi.py > similarity index 100% > rename from scripts/lib/wic/plugins/source/bootimg-biosplusefi.py > rename to scripts/lib/wic/plugins/source/bootimg_biosplusefi.py > diff --git a/scripts/lib/wic/plugins/source/bootimg-efi.py b/scripts/lib/wic/plugins/source/bootimg_efi.py > similarity index 100% > rename from scripts/lib/wic/plugins/source/bootimg-efi.py > rename to scripts/lib/wic/plugins/source/bootimg_efi.py > diff --git a/scripts/lib/wic/plugins/source/bootimg-partition.py b/scripts/lib/wic/plugins/source/bootimg_partition.py > similarity index 100% > rename from scripts/lib/wic/plugins/source/bootimg-partition.py > rename to scripts/lib/wic/plugins/source/bootimg_partition.py > diff --git a/scripts/lib/wic/plugins/source/bootimg-pcbios.py b/scripts/lib/wic/plugins/source/bootimg_pcbios.py > similarity index 100% > rename from scripts/lib/wic/plugins/source/bootimg-pcbios.py > rename to scripts/lib/wic/plugins/source/bootimg_pcbios.py > diff --git a/scripts/lib/wic/plugins/source/isoimage-isohybrid.py b/scripts/lib/wic/plugins/source/isoimage_isohybrid.py > similarity index 100% > rename from scripts/lib/wic/plugins/source/isoimage-isohybrid.py > rename to scripts/lib/wic/plugins/source/isoimage_isohybrid.py > -- > 2.43.0 > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#197471): https://lists.openembedded.org/g/openembedded-core/message/197471 > Mute This Topic: https://lists.openembedded.org/mt/105108998/3617179 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alexandre.belloni@bootlin.com] > -=-=-=-=-=-=-=-=-=-=-=- >
Hi, Thanks for reporting, I will adapt the tests. Regards, Anibal On Mon, Mar 25, 2024, 04:18 Alexandre Belloni <alexandre.belloni@bootlin.com> wrote: > This breaks some selftests and meta-virtualization: > > > https://autobuilder.yoctoproject.org/typhoon/#/builders/87/builds/6573/steps/14/logs/stdio > > > https://autobuilder.yoctoproject.org/typhoon/#/builders/128/builds/3005/steps/12/logs/stdio > > > On 23/03/2024 13:53:04-0600, Anibal Limon wrote: > > Python not support importing modules with - so change to _. > > > > Signed-off-by: Anibal Limon <anibal@limonsoftware.com> > > --- > > .../source/{bootimg-biosplusefi.py => bootimg_biosplusefi.py} | 0 > > scripts/lib/wic/plugins/source/{bootimg-efi.py => bootimg_efi.py} | 0 > > .../plugins/source/{bootimg-partition.py => bootimg_partition.py} | 0 > > .../wic/plugins/source/{bootimg-pcbios.py => bootimg_pcbios.py} | 0 > > .../source/{isoimage-isohybrid.py => isoimage_isohybrid.py} | 0 > > 5 files changed, 0 insertions(+), 0 deletions(-) > > rename scripts/lib/wic/plugins/source/{bootimg-biosplusefi.py => > bootimg_biosplusefi.py} (100%) > > rename scripts/lib/wic/plugins/source/{bootimg-efi.py => > bootimg_efi.py} (100%) > > rename scripts/lib/wic/plugins/source/{bootimg-partition.py => > bootimg_partition.py} (100%) > > rename scripts/lib/wic/plugins/source/{bootimg-pcbios.py => > bootimg_pcbios.py} (100%) > > rename scripts/lib/wic/plugins/source/{isoimage-isohybrid.py => > isoimage_isohybrid.py} (100%) > > > > diff --git a/scripts/lib/wic/plugins/source/bootimg-biosplusefi.py > b/scripts/lib/wic/plugins/source/bootimg_biosplusefi.py > > similarity index 100% > > rename from scripts/lib/wic/plugins/source/bootimg-biosplusefi.py > > rename to scripts/lib/wic/plugins/source/bootimg_biosplusefi.py > > diff --git a/scripts/lib/wic/plugins/source/bootimg-efi.py > b/scripts/lib/wic/plugins/source/bootimg_efi.py > > similarity index 100% > > rename from scripts/lib/wic/plugins/source/bootimg-efi.py > > rename to scripts/lib/wic/plugins/source/bootimg_efi.py > > diff --git a/scripts/lib/wic/plugins/source/bootimg-partition.py > b/scripts/lib/wic/plugins/source/bootimg_partition.py > > similarity index 100% > > rename from scripts/lib/wic/plugins/source/bootimg-partition.py > > rename to scripts/lib/wic/plugins/source/bootimg_partition.py > > diff --git a/scripts/lib/wic/plugins/source/bootimg-pcbios.py > b/scripts/lib/wic/plugins/source/bootimg_pcbios.py > > similarity index 100% > > rename from scripts/lib/wic/plugins/source/bootimg-pcbios.py > > rename to scripts/lib/wic/plugins/source/bootimg_pcbios.py > > diff --git a/scripts/lib/wic/plugins/source/isoimage-isohybrid.py > b/scripts/lib/wic/plugins/source/isoimage_isohybrid.py > > similarity index 100% > > rename from scripts/lib/wic/plugins/source/isoimage-isohybrid.py > > rename to scripts/lib/wic/plugins/source/isoimage_isohybrid.py > > -- > > 2.43.0 > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- > > Links: You receive all messages sent to this group. > > View/Reply Online (#197471): > https://lists.openembedded.org/g/openembedded-core/message/197471 > > Mute This Topic: https://lists.openembedded.org/mt/105108998/3617179 > > Group Owner: openembedded-core+owner@lists.openembedded.org > > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [ > alexandre.belloni@bootlin.com] > > -=-=-=-=-=-=-=-=-=-=-=- > > > > > -- > Alexandre Belloni, co-owner and COO, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com >
Hi, Finally sent a patch to meta-virtualization, to fix the problem when rename the wic source plugins to allow re-use. https://lists.yoctoproject.org/g/meta-virtualization/message/9240 Cheers!, Anibal On Mon, Mar 25, 2024 at 8:39 AM Anibal Limon via lists.openembedded.org <anibal=limonsoftware.com@lists.openembedded.org> wrote: > Hi, > > Thanks for reporting, I will adapt the tests. > > Regards, > Anibal > > On Mon, Mar 25, 2024, 04:18 Alexandre Belloni < > alexandre.belloni@bootlin.com> wrote: > >> This breaks some selftests and meta-virtualization: >> >> >> https://autobuilder.yoctoproject.org/typhoon/#/builders/87/builds/6573/steps/14/logs/stdio >> >> >> https://autobuilder.yoctoproject.org/typhoon/#/builders/128/builds/3005/steps/12/logs/stdio >> >> >> On 23/03/2024 13:53:04-0600, Anibal Limon wrote: >> > Python not support importing modules with - so change to _. >> > >> > Signed-off-by: Anibal Limon <anibal@limonsoftware.com> >> > --- >> > .../source/{bootimg-biosplusefi.py => bootimg_biosplusefi.py} | 0 >> > scripts/lib/wic/plugins/source/{bootimg-efi.py => bootimg_efi.py} | 0 >> > .../plugins/source/{bootimg-partition.py => bootimg_partition.py} | 0 >> > .../wic/plugins/source/{bootimg-pcbios.py => bootimg_pcbios.py} | 0 >> > .../source/{isoimage-isohybrid.py => isoimage_isohybrid.py} | 0 >> > 5 files changed, 0 insertions(+), 0 deletions(-) >> > rename scripts/lib/wic/plugins/source/{bootimg-biosplusefi.py => >> bootimg_biosplusefi.py} (100%) >> > rename scripts/lib/wic/plugins/source/{bootimg-efi.py => >> bootimg_efi.py} (100%) >> > rename scripts/lib/wic/plugins/source/{bootimg-partition.py => >> bootimg_partition.py} (100%) >> > rename scripts/lib/wic/plugins/source/{bootimg-pcbios.py => >> bootimg_pcbios.py} (100%) >> > rename scripts/lib/wic/plugins/source/{isoimage-isohybrid.py => >> isoimage_isohybrid.py} (100%) >> > >> > diff --git a/scripts/lib/wic/plugins/source/bootimg-biosplusefi.py >> b/scripts/lib/wic/plugins/source/bootimg_biosplusefi.py >> > similarity index 100% >> > rename from scripts/lib/wic/plugins/source/bootimg-biosplusefi.py >> > rename to scripts/lib/wic/plugins/source/bootimg_biosplusefi.py >> > diff --git a/scripts/lib/wic/plugins/source/bootimg-efi.py >> b/scripts/lib/wic/plugins/source/bootimg_efi.py >> > similarity index 100% >> > rename from scripts/lib/wic/plugins/source/bootimg-efi.py >> > rename to scripts/lib/wic/plugins/source/bootimg_efi.py >> > diff --git a/scripts/lib/wic/plugins/source/bootimg-partition.py >> b/scripts/lib/wic/plugins/source/bootimg_partition.py >> > similarity index 100% >> > rename from scripts/lib/wic/plugins/source/bootimg-partition.py >> > rename to scripts/lib/wic/plugins/source/bootimg_partition.py >> > diff --git a/scripts/lib/wic/plugins/source/bootimg-pcbios.py >> b/scripts/lib/wic/plugins/source/bootimg_pcbios.py >> > similarity index 100% >> > rename from scripts/lib/wic/plugins/source/bootimg-pcbios.py >> > rename to scripts/lib/wic/plugins/source/bootimg_pcbios.py >> > diff --git a/scripts/lib/wic/plugins/source/isoimage-isohybrid.py >> b/scripts/lib/wic/plugins/source/isoimage_isohybrid.py >> > similarity index 100% >> > rename from scripts/lib/wic/plugins/source/isoimage-isohybrid.py >> > rename to scripts/lib/wic/plugins/source/isoimage_isohybrid.py >> > -- >> > 2.43.0 >> > >> >> > >> > >> > >> >> >> -- >> Alexandre Belloni, co-owner and COO, Bootlin >> Embedded Linux and Kernel engineering >> https://bootlin.com >> > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#197487): > https://lists.openembedded.org/g/openembedded-core/message/197487 > Mute This Topic: https://lists.openembedded.org/mt/105108998/8181911 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [ > anibal@limonsoftware.com] > -=-=-=-=-=-=-=-=-=-=-=- > >
Just a ping. After apply this Bruce will apply the meta-virt one, https://lists.yoctoproject.org/g/meta-virtualization/message/9252 Thanks!, Anibal On Sun, May 4, 2025 at 2:34 PM Anibal Limon via lists.openembedded.org <anibal=limonsoftware.com@lists.openembedded.org> wrote: > Hi, > > Finally sent a patch to meta-virtualization, to fix the problem when > rename the wic source plugins to allow re-use. > > https://lists.yoctoproject.org/g/meta-virtualization/message/9240 > > Cheers!, > Anibal > > On Mon, Mar 25, 2024 at 8:39 AM Anibal Limon via lists.openembedded.org > <anibal=limonsoftware.com@lists.openembedded.org> wrote: > >> Hi, >> >> Thanks for reporting, I will adapt the tests. >> >> Regards, >> Anibal >> >> On Mon, Mar 25, 2024, 04:18 Alexandre Belloni < >> alexandre.belloni@bootlin.com> wrote: >> >>> This breaks some selftests and meta-virtualization: >>> >>> >>> https://autobuilder.yoctoproject.org/typhoon/#/builders/87/builds/6573/steps/14/logs/stdio >>> >>> >>> https://autobuilder.yoctoproject.org/typhoon/#/builders/128/builds/3005/steps/12/logs/stdio >>> >>> >>> On 23/03/2024 13:53:04-0600, Anibal Limon wrote: >>> > Python not support importing modules with - so change to _. >>> > >>> > Signed-off-by: Anibal Limon <anibal@limonsoftware.com> >>> > --- >>> > .../source/{bootimg-biosplusefi.py => bootimg_biosplusefi.py} | 0 >>> > scripts/lib/wic/plugins/source/{bootimg-efi.py => bootimg_efi.py} | 0 >>> > .../plugins/source/{bootimg-partition.py => bootimg_partition.py} | 0 >>> > .../wic/plugins/source/{bootimg-pcbios.py => bootimg_pcbios.py} | 0 >>> > .../source/{isoimage-isohybrid.py => isoimage_isohybrid.py} | 0 >>> > 5 files changed, 0 insertions(+), 0 deletions(-) >>> > rename scripts/lib/wic/plugins/source/{bootimg-biosplusefi.py => >>> bootimg_biosplusefi.py} (100%) >>> > rename scripts/lib/wic/plugins/source/{bootimg-efi.py => >>> bootimg_efi.py} (100%) >>> > rename scripts/lib/wic/plugins/source/{bootimg-partition.py => >>> bootimg_partition.py} (100%) >>> > rename scripts/lib/wic/plugins/source/{bootimg-pcbios.py => >>> bootimg_pcbios.py} (100%) >>> > rename scripts/lib/wic/plugins/source/{isoimage-isohybrid.py => >>> isoimage_isohybrid.py} (100%) >>> > >>> > diff --git a/scripts/lib/wic/plugins/source/bootimg-biosplusefi.py >>> b/scripts/lib/wic/plugins/source/bootimg_biosplusefi.py >>> > similarity index 100% >>> > rename from scripts/lib/wic/plugins/source/bootimg-biosplusefi.py >>> > rename to scripts/lib/wic/plugins/source/bootimg_biosplusefi.py >>> > diff --git a/scripts/lib/wic/plugins/source/bootimg-efi.py >>> b/scripts/lib/wic/plugins/source/bootimg_efi.py >>> > similarity index 100% >>> > rename from scripts/lib/wic/plugins/source/bootimg-efi.py >>> > rename to scripts/lib/wic/plugins/source/bootimg_efi.py >>> > diff --git a/scripts/lib/wic/plugins/source/bootimg-partition.py >>> b/scripts/lib/wic/plugins/source/bootimg_partition.py >>> > similarity index 100% >>> > rename from scripts/lib/wic/plugins/source/bootimg-partition.py >>> > rename to scripts/lib/wic/plugins/source/bootimg_partition.py >>> > diff --git a/scripts/lib/wic/plugins/source/bootimg-pcbios.py >>> b/scripts/lib/wic/plugins/source/bootimg_pcbios.py >>> > similarity index 100% >>> > rename from scripts/lib/wic/plugins/source/bootimg-pcbios.py >>> > rename to scripts/lib/wic/plugins/source/bootimg_pcbios.py >>> > diff --git a/scripts/lib/wic/plugins/source/isoimage-isohybrid.py >>> b/scripts/lib/wic/plugins/source/isoimage_isohybrid.py >>> > similarity index 100% >>> > rename from scripts/lib/wic/plugins/source/isoimage-isohybrid.py >>> > rename to scripts/lib/wic/plugins/source/isoimage_isohybrid.py >>> > -- >>> > 2.43.0 >>> > >>> >>> > >>> > >>> > >>> >>> >>> -- >>> Alexandre Belloni, co-owner and COO, Bootlin >>> Embedded Linux and Kernel engineering >>> https://bootlin.com >>> >> >> >> >> > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#215972): > https://lists.openembedded.org/g/openembedded-core/message/215972 > Mute This Topic: https://lists.openembedded.org/mt/105108998/8181911 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [ > anibal@limonsoftware.com] > -=-=-=-=-=-=-=-=-=-=-=- > >
On Tue, 2025-05-20 at 08:20 -0600, Anibal Limon wrote: > Just a ping. > > After apply this Bruce will apply the meta-virt one, > > https://lists.yoctoproject.org/g/meta-virtualization/message/9252 I put this in for testing and there are multiple references in OE-Core which also need renaming as without that we see a ton of failures. I've gone ahead and put a potential patch in master-next but I'm a bit worried the needed thought/planning for a major change like this hasn't happened. I understand the need to make it, we do need to support existing users somehow though. Cheers, Richard
Hi Richard, Yeah, I understand, let me know any further breakage I can fix. Cheers!, Anibal On Mon, May 26, 2025 at 6:01 AM Richard Purdie < richard.purdie@linuxfoundation.org> wrote: > On Tue, 2025-05-20 at 08:20 -0600, Anibal Limon wrote: > > Just a ping. > > > > After apply this Bruce will apply the meta-virt one, > > > > https://lists.yoctoproject.org/g/meta-virtualization/message/9252 > > I put this in for testing and there are multiple references in OE-Core > which also need renaming as without that we see a ton of failures. I've > gone ahead and put a potential patch in master-next but I'm a bit > worried the needed thought/planning for a major change like this hasn't > happened. > > I understand the need to make it, we do need to support existing users > somehow though. > > Cheers, > > Richard >
Hi Anibal,
On Mon, 2025-05-26 at 10:30 -0600, Anibal Limon wrote:
> Yeah, I understand, let me know any further breakage I can fix.
I have patches for oe-core and meta-yocto to fix the issues there.
meta-virtualization fails, I believe you have fixes for that. meta-arm
and meta-intel also showed issues:
https://autobuilder.yoctoproject.org/valkyrie/#/builders/75/builds/1599
https://autobuilder.yoctoproject.org/valkyrie/#/builders/41/builds/1561
https://autobuilder.yoctoproject.org/valkyrie/#/builders/89/builds/1574
I think the missing pieces to get this merged are:
* A note for the migration guide explaining what changed and how to fix
it
* A tweak to wic to warn about "-" characters in the plugin name. This
might be able to translate "-" to "_" with a warning to allow some kind
of slightly easier migration? At the very least we should give users a
better error with a hint about how to fix it.
Cheers,
Richard
I will fix the failures and add the proper migration doc to the patch. Thanks!, Anibal On Tue, May 27, 2025 at 2:04 AM Richard Purdie < richard.purdie@linuxfoundation.org> wrote: > Hi Anibal, > > On Mon, 2025-05-26 at 10:30 -0600, Anibal Limon wrote: > > Yeah, I understand, let me know any further breakage I can fix. > > I have patches for oe-core and meta-yocto to fix the issues there. > meta-virtualization fails, I believe you have fixes for that. meta-arm > and meta-intel also showed issues: > > https://autobuilder.yoctoproject.org/valkyrie/#/builders/75/builds/1599 > > https://autobuilder.yoctoproject.org/valkyrie/#/builders/41/builds/1561 > https://autobuilder.yoctoproject.org/valkyrie/#/builders/89/builds/1574 > > I think the missing pieces to get this merged are: > > * A note for the migration guide explaining what changed and how to fix > it > > * A tweak to wic to warn about "-" characters in the plugin name. This > might be able to translate "-" to "_" with a warning to allow some kind > of slightly easier migration? At the very least we should give users a > better error with a hint about how to fix it. > > Cheers, > > Richard >
Update, I cannot reproduce meta-intel and meta-arm, I will look at autobuilder full config to see if I found something I missed. On Tue, May 27, 2025 at 9:58 AM Anibal Limon via lists.openembedded.org <anibal=limonsoftware.com@lists.openembedded.org> wrote: > I will fix the failures and add the proper migration doc to the patch. > > Thanks!, > Anibal > > On Tue, May 27, 2025 at 2:04 AM Richard Purdie < > richard.purdie@linuxfoundation.org> wrote: > >> Hi Anibal, >> >> On Mon, 2025-05-26 at 10:30 -0600, Anibal Limon wrote: >> > Yeah, I understand, let me know any further breakage I can fix. >> >> I have patches for oe-core and meta-yocto to fix the issues there. >> meta-virtualization fails, I believe you have fixes for that. meta-arm >> and meta-intel also showed issues: >> >> https://autobuilder.yoctoproject.org/valkyrie/#/builders/75/builds/1599 >> >> https://autobuilder.yoctoproject.org/valkyrie/#/builders/41/builds/1561 >> https://autobuilder.yoctoproject.org/valkyrie/#/builders/89/builds/1574 >> >> I think the missing pieces to get this merged are: >> >> * A note for the migration guide explaining what changed and how to fix >> it >> >> * A tweak to wic to warn about "-" characters in the plugin name. This >> might be able to translate "-" to "_" with a warning to allow some kind >> of slightly easier migration? At the very least we should give users a >> better error with a hint about how to fix it. >> >> Cheers, >> >> Richard >> > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#217313): > https://lists.openembedded.org/g/openembedded-core/message/217313 > Mute This Topic: https://lists.openembedded.org/mt/105108998/8181911 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [ > anibal@limonsoftware.com] > -=-=-=-=-=-=-=-=-=-=-=- > >
On 25 Mar 2024, at 14:39, Anibal Limon via lists.openembedded.org <anibal=limonsoftware.com@lists.openembedded.org> wrote:
> Thanks for reporting, I will adapt the tests.
Without having to rewrite all of the documentation and existing files, why doesn’t wic just normalise the plugin name that it reads to replace all - with _?
This means you can still import the module names, but doesn’t change existing behaviour at all.
Ross
On Thu, May 29, 2025 at 2:06 PM Ross Burton <Ross.Burton@arm.com> wrote: > On 25 Mar 2024, at 14:39, Anibal Limon via lists.openembedded.org <anibal= > limonsoftware.com@lists.openembedded.org> wrote: > > Thanks for reporting, I will adapt the tests. > > Without having to rewrite all of the documentation and existing files, why > doesn’t wic just normalise the plugin name that it reads to replace all - > with _? > > This means you can still import the module names, but doesn’t change > existing behaviour at all. > Hi Ross, So to normalize you mean change python module name from _ to - at runtime?. The plugins already had a name attr with '-', the issue is when trying to import from an external module. Regards!, Anibal > > Ross
On Thu, 2025-05-29 at 17:22 -0600, Anibal Limon wrote: > > > On Thu, May 29, 2025 at 2:06 PM Ross Burton <Ross.Burton@arm.com> > wrote: > > On 25 Mar 2024, at 14:39, Anibal Limon via lists.openembedded.org > > <anibal=limonsoftware.com@lists.openembedded.org> wrote: > > > Thanks for reporting, I will adapt the tests. > > > > Without having to rewrite all of the documentation and existing > > files, why doesn’t wic just normalise the plugin name that it reads > > to replace all - with _? > > > > This means you can still import the module names, but doesn’t > > change existing behaviour at all. > > So to normalize you mean change python module name from _ to - at > runtime?. > The plugins already had a name attr with '-', the issue is when > trying to import from an external module. What Ross is suggesting is that in the code in wic which parses the commandline parameters, we could add a line of code to change "-" in plugin names to "_". We'd need to tweak what gets parsed from the wks files too. This would make the migration easier. We may or may not want to issue a warning at the same time so the user can know to update their wks file or command. Cheers, Richard
On Fri, May 30, 2025 at 12:45 AM Richard Purdie < richard.purdie@linuxfoundation.org> wrote: > On Thu, 2025-05-29 at 17:22 -0600, Anibal Limon wrote: > > > > > > On Thu, May 29, 2025 at 2:06 PM Ross Burton <Ross.Burton@arm.com> > > wrote: > > > On 25 Mar 2024, at 14:39, Anibal Limon via lists.openembedded.org > > > <anibal=limonsoftware.com@lists.openembedded.org> wrote: > > > > Thanks for reporting, I will adapt the tests. > > > > > > Without having to rewrite all of the documentation and existing > > > files, why doesn’t wic just normalise the plugin name that it reads > > > to replace all - with _? > > > > > > This means you can still import the module names, but doesn’t > > > change existing behaviour at all. > > > > So to normalize you mean change python module name from _ to - at > > runtime?. > > The plugins already had a name attr with '-', the issue is when > > trying to import from an external module. > > What Ross is suggesting is that in the code in wic which parses the > commandline parameters, we could add a line of code to change "-" in > plugin names to "_". We'd need to tweak what gets parsed from the wks > files too. > Yeah, I find the plugin manager when plugins are loaded. > > This would make the migration easier. We may or may not want to issue a > warning at the same time so the user can know to update their wks file > or command. > Sure, I think it starts with a warning and then makes the switch at some point or not. Regards!, Anibal > > Cheers, > > Richard >
diff --git a/scripts/lib/wic/plugins/source/bootimg-biosplusefi.py b/scripts/lib/wic/plugins/source/bootimg_biosplusefi.py similarity index 100% rename from scripts/lib/wic/plugins/source/bootimg-biosplusefi.py rename to scripts/lib/wic/plugins/source/bootimg_biosplusefi.py diff --git a/scripts/lib/wic/plugins/source/bootimg-efi.py b/scripts/lib/wic/plugins/source/bootimg_efi.py similarity index 100% rename from scripts/lib/wic/plugins/source/bootimg-efi.py rename to scripts/lib/wic/plugins/source/bootimg_efi.py diff --git a/scripts/lib/wic/plugins/source/bootimg-partition.py b/scripts/lib/wic/plugins/source/bootimg_partition.py similarity index 100% rename from scripts/lib/wic/plugins/source/bootimg-partition.py rename to scripts/lib/wic/plugins/source/bootimg_partition.py diff --git a/scripts/lib/wic/plugins/source/bootimg-pcbios.py b/scripts/lib/wic/plugins/source/bootimg_pcbios.py similarity index 100% rename from scripts/lib/wic/plugins/source/bootimg-pcbios.py rename to scripts/lib/wic/plugins/source/bootimg_pcbios.py diff --git a/scripts/lib/wic/plugins/source/isoimage-isohybrid.py b/scripts/lib/wic/plugins/source/isoimage_isohybrid.py similarity index 100% rename from scripts/lib/wic/plugins/source/isoimage-isohybrid.py rename to scripts/lib/wic/plugins/source/isoimage_isohybrid.py
Python not support importing modules with - so change to _. Signed-off-by: Anibal Limon <anibal@limonsoftware.com> --- .../source/{bootimg-biosplusefi.py => bootimg_biosplusefi.py} | 0 scripts/lib/wic/plugins/source/{bootimg-efi.py => bootimg_efi.py} | 0 .../plugins/source/{bootimg-partition.py => bootimg_partition.py} | 0 .../wic/plugins/source/{bootimg-pcbios.py => bootimg_pcbios.py} | 0 .../source/{isoimage-isohybrid.py => isoimage_isohybrid.py} | 0 5 files changed, 0 insertions(+), 0 deletions(-) rename scripts/lib/wic/plugins/source/{bootimg-biosplusefi.py => bootimg_biosplusefi.py} (100%) rename scripts/lib/wic/plugins/source/{bootimg-efi.py => bootimg_efi.py} (100%) rename scripts/lib/wic/plugins/source/{bootimg-partition.py => bootimg_partition.py} (100%) rename scripts/lib/wic/plugins/source/{bootimg-pcbios.py => bootimg_pcbios.py} (100%) rename scripts/lib/wic/plugins/source/{isoimage-isohybrid.py => isoimage_isohybrid.py} (100%)