Message ID | 20230926101529.3610385-1-Qi.Chen@windriver.com |
---|---|
State | New |
Headers | show |
Series | oe-find-native-sysroot: avoid warning message messing things up | expand |
Hi Chen, I have raised this when it lands https://lists.openembedded.org/g/openembedded-core/message/187378 Tested.by: Jose Quaresma <quaresma.jose@gmail.com> Jose Chen Qi via lists.openembedded.org <Qi.Chen= windriver.com@lists.openembedded.org> escreveu no dia terça, 26/09/2023 à(s) 11:15: > From: Chen Qi <Qi.Chen@windriver.com> > > Add '-q' option to bitbake-getvar to avoid warning messages contaminating > the actual result. > > Signed-off-by: Chen Qi <Qi.Chen@windriver.com> > --- > scripts/oe-find-native-sysroot | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/oe-find-native-sysroot > b/scripts/oe-find-native-sysroot > index 6228efcbee..541318b461 100755 > --- a/scripts/oe-find-native-sysroot > +++ b/scripts/oe-find-native-sysroot > @@ -38,7 +38,7 @@ fi > # Global vars > set_oe_native_sysroot(){ > echo "Getting sysroot..." > - OECORE_NATIVE_SYSROOT=$(bitbake-getvar -r $1 --value > STAGING_DIR_NATIVE) > + OECORE_NATIVE_SYSROOT=$(bitbake-getvar -q -r $1 --value > STAGING_DIR_NATIVE) > } > > if [ "x$OECORE_NATIVE_SYSROOT" = "x" ]; then > -- > 2.40.0 > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#188242): > https://lists.openembedded.org/g/openembedded-core/message/188242 > Mute This Topic: https://lists.openembedded.org/mt/101592501/5052612 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [ > quaresma.jose@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- > >
NAK This is no longer needed since commit 6b7883533 (bitbake-getvar: Make --value imply –quiet) landed in bitbake. //Peter From: openembedded-core@lists.openembedded.org <openembedded-core@lists.openembedded.org> On Behalf Of Jose Quaresma Sent: den 26 september 2023 12:21 To: Qi.Chen@windriver.com Cc: openembedded-core@lists.openembedded.org Subject: Re: [OE-core][PATCH] oe-find-native-sysroot: avoid warning message messing things up Hi Chen, I have raised this when it lands https://lists.openembedded.org/g/openembedded-core/message/187378 Tested.by: Jose Quaresma <quaresma.jose@gmail.com<mailto:quaresma.jose@gmail.com>> Jose Chen Qi via lists.openembedded.org<http://lists.openembedded.org> <Qi.Chen=windriver.com@lists.openembedded.org<mailto:windriver.com@lists.openembedded.org>> escreveu no dia terça, 26/09/2023 à(s) 11:15: From: Chen Qi <Qi.Chen@windriver.com<mailto:Qi.Chen@windriver.com>> Add '-q' option to bitbake-getvar to avoid warning messages contaminating the actual result. Signed-off-by: Chen Qi <Qi.Chen@windriver.com<mailto:Qi.Chen@windriver.com>> --- scripts/oe-find-native-sysroot | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/oe-find-native-sysroot b/scripts/oe-find-native-sysroot index 6228efcbee..541318b461 100755 --- a/scripts/oe-find-native-sysroot +++ b/scripts/oe-find-native-sysroot @@ -38,7 +38,7 @@ fi # Global vars set_oe_native_sysroot(){ echo "Getting sysroot..." - OECORE_NATIVE_SYSROOT=$(bitbake-getvar -r $1 --value STAGING_DIR_NATIVE) + OECORE_NATIVE_SYSROOT=$(bitbake-getvar -q -r $1 --value STAGING_DIR_NATIVE) } if [ "x$OECORE_NATIVE_SYSROOT" = "x" ]; then -- 2.40.0 -- Best regards, José Quaresma
Just noticed your patches. Yes, this patch is not needed. Regards, Qi From: Peter Kjellerstedt <peter.kjellerstedt@axis.com> Sent: Tuesday, September 26, 2023 9:10 PM To: Jose Quaresma <quaresma.jose@gmail.com>; Chen, Qi <Qi.Chen@windriver.com> Cc: openembedded-core@lists.openembedded.org Subject: RE: [OE-core][PATCH] oe-find-native-sysroot: avoid warning message messing things up NAK This is no longer needed since commit 6b7883533 (bitbake-getvar: Make --value imply –quiet) landed in bitbake. //Peter From: openembedded-core@lists.openembedded.org<mailto:openembedded-core@lists.openembedded.org> <openembedded-core@lists.openembedded.org<mailto:openembedded-core@lists.openembedded.org>> On Behalf Of Jose Quaresma Sent: den 26 september 2023 12:21 To: Qi.Chen@windriver.com<mailto:Qi.Chen@windriver.com> Cc: openembedded-core@lists.openembedded.org<mailto:openembedded-core@lists.openembedded.org> Subject: Re: [OE-core][PATCH] oe-find-native-sysroot: avoid warning message messing things up Hi Chen, I have raised this when it lands https://lists.openembedded.org/g/openembedded-core/message/187378<https://urldefense.com/v3/__https:/lists.openembedded.org/g/openembedded-core/message/187378__;!!AjveYdw8EvQ!adHqVF0IzEspqiDUyqlT-QC4Rdy_B_YAK8youCQ60fa96rN8B3AxjRCZmJ2VY3fr0uDPRoNXqypFyOI9RkIgINwfzZE$> Tested.by<https://urldefense.com/v3/__http:/Tested.by__;!!AjveYdw8EvQ!adHqVF0IzEspqiDUyqlT-QC4Rdy_B_YAK8youCQ60fa96rN8B3AxjRCZmJ2VY3fr0uDPRoNXqypFyOI9RkIgVUqchqA$>: Jose Quaresma <quaresma.jose@gmail.com<mailto:quaresma.jose@gmail.com>> Jose Chen Qi via lists.openembedded.org<https://urldefense.com/v3/__http:/lists.openembedded.org__;!!AjveYdw8EvQ!adHqVF0IzEspqiDUyqlT-QC4Rdy_B_YAK8youCQ60fa96rN8B3AxjRCZmJ2VY3fr0uDPRoNXqypFyOI9RkIgL6RxaeA$> <Qi.Chen=windriver.com@lists.openembedded.org<mailto:windriver.com@lists.openembedded.org>> escreveu no dia terça, 26/09/2023 à(s) 11:15: From: Chen Qi <Qi.Chen@windriver.com<mailto:Qi.Chen@windriver.com>> Add '-q' option to bitbake-getvar to avoid warning messages contaminating the actual result. Signed-off-by: Chen Qi <Qi.Chen@windriver.com<mailto:Qi.Chen@windriver.com>> --- scripts/oe-find-native-sysroot | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/oe-find-native-sysroot b/scripts/oe-find-native-sysroot index 6228efcbee..541318b461 100755 --- a/scripts/oe-find-native-sysroot +++ b/scripts/oe-find-native-sysroot @@ -38,7 +38,7 @@ fi # Global vars set_oe_native_sysroot(){ echo "Getting sysroot..." - OECORE_NATIVE_SYSROOT=$(bitbake-getvar -r $1 --value STAGING_DIR_NATIVE) + OECORE_NATIVE_SYSROOT=$(bitbake-getvar -q -r $1 --value STAGING_DIR_NATIVE) } if [ "x$OECORE_NATIVE_SYSROOT" = "x" ]; then -- 2.40.0 -- Best regards, José Quaresma
diff --git a/scripts/oe-find-native-sysroot b/scripts/oe-find-native-sysroot index 6228efcbee..541318b461 100755 --- a/scripts/oe-find-native-sysroot +++ b/scripts/oe-find-native-sysroot @@ -38,7 +38,7 @@ fi # Global vars set_oe_native_sysroot(){ echo "Getting sysroot..." - OECORE_NATIVE_SYSROOT=$(bitbake-getvar -r $1 --value STAGING_DIR_NATIVE) + OECORE_NATIVE_SYSROOT=$(bitbake-getvar -q -r $1 --value STAGING_DIR_NATIVE) } if [ "x$OECORE_NATIVE_SYSROOT" = "x" ]; then