diff mbox series

[meta-oe,1/1] libcamera: Simplify pipeline configuration

Message ID 20230524065534.2977672-1-alexander.stein@ew.tq-group.com
State Under Review
Headers show
Series [meta-oe,1/1] libcamera: Simplify pipeline configuration | expand

Commit Message

Alexander Stein May 24, 2023, 6:55 a.m. UTC
Default to 'auto' which enables all target architecture pipelines (+UVC).
IPAs are also automatically enabled if the corresponding required pipeline
is enabled as well.

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
 .../recipes-multimedia/libcamera/libcamera_0.0.5.bb           | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Kieran Bingham May 24, 2023, 2:17 p.m. UTC | #1
Quoting Alexander Stein (2023-05-24 07:55:34)
> Default to 'auto' which enables all target architecture pipelines (+UVC).
> IPAs are also automatically enabled if the corresponding required pipeline
> is enabled as well.
> 
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>

Yup, This is what I would do!

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

> ---
>  .../recipes-multimedia/libcamera/libcamera_0.0.5.bb           | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/meta-multimedia/recipes-multimedia/libcamera/libcamera_0.0.5.bb b/meta-multimedia/recipes-multimedia/libcamera/libcamera_0.0.5.bb
> index 47da0ec61..6ad376f29 100644
> --- a/meta-multimedia/recipes-multimedia/libcamera/libcamera_0.0.5.bb
> +++ b/meta-multimedia/recipes-multimedia/libcamera/libcamera_0.0.5.bb
> @@ -26,12 +26,10 @@ PACKAGES =+ "${PN}-gst"
>  PACKAGECONFIG ??= ""
>  PACKAGECONFIG[gst] = "-Dgstreamer=enabled,-Dgstreamer=disabled,gstreamer1.0 gstreamer1.0-plugins-base"
>  
> -LIBCAMERA_PIPELINES ??= "uvcvideo,simple,vimc"
> -LIBCAMERA_IPAS ??= "vimc"
> +LIBCAMERA_PIPELINES ??= "auto"
>  
>  EXTRA_OEMESON = " \
>      -Dpipelines=${LIBCAMERA_PIPELINES} \
> -    -Dipas=${LIBCAMERA_IPAS} \
>      -Dv4l2=true \
>      -Dcam=enabled \
>      -Dlc-compliance=disabled \
> -- 
> 2.34.1
> 
>
diff mbox series

Patch

diff --git a/meta-multimedia/recipes-multimedia/libcamera/libcamera_0.0.5.bb b/meta-multimedia/recipes-multimedia/libcamera/libcamera_0.0.5.bb
index 47da0ec61..6ad376f29 100644
--- a/meta-multimedia/recipes-multimedia/libcamera/libcamera_0.0.5.bb
+++ b/meta-multimedia/recipes-multimedia/libcamera/libcamera_0.0.5.bb
@@ -26,12 +26,10 @@  PACKAGES =+ "${PN}-gst"
 PACKAGECONFIG ??= ""
 PACKAGECONFIG[gst] = "-Dgstreamer=enabled,-Dgstreamer=disabled,gstreamer1.0 gstreamer1.0-plugins-base"
 
-LIBCAMERA_PIPELINES ??= "uvcvideo,simple,vimc"
-LIBCAMERA_IPAS ??= "vimc"
+LIBCAMERA_PIPELINES ??= "auto"
 
 EXTRA_OEMESON = " \
     -Dpipelines=${LIBCAMERA_PIPELINES} \
-    -Dipas=${LIBCAMERA_IPAS} \
     -Dv4l2=true \
     -Dcam=enabled \
     -Dlc-compliance=disabled \