diff mbox series

[meta-oe] fftw: Remove hardcoded sysroot into binaries

Message ID 20230514035746.1550853-1-raj.khem@gmail.com
State New
Headers show
Series [meta-oe] fftw: Remove hardcoded sysroot into binaries | expand

Commit Message

Khem Raj May 14, 2023, 3:57 a.m. UTC
FFTW_CC is added to image via version.o and its CC + CFLAGS however CC
in OE containes --syroot compiler option which encodes buildpaths into
binary, therefore remove this option from FFTW_CC in config.h

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 meta-oe/recipes-support/fftw/fftw_3.3.10.bb | 1 +
 1 file changed, 1 insertion(+)

Comments

Jan Vermaete May 22, 2023, 11:12 a.m. UTC | #1
Hi,

Could it be this is causing a failure (see below)

Thanks,

DEBUG: Executing python function autotools_aclocals
DEBUG: SITE files ['endian-little', 'common-linux', 'common-glibc',
'bit-64', 'x86_64-linux', 'common']
DEBUG: Python function autotools_aclocals finished
DEBUG: Executing shell function do_compile
sed: -e expression #1, char 0: no previous regular expression
WARNING: .../build/tmp/work/x86_64-linux/fftw-native/3.3.10-r0/temp/run.do_compile.464684:153
exit 1 from 'sed -i -e 's|||g' config.h'
WARNING: Backtrace (BB generated script):
        #1: do_compile,
.../build/tmp/work/x86_64-linux/fftw-native/3.3.10-r0/temp/run.do_compile.464684,
line 153
        #2: main,
.../build/tmp/work/x86_64-linux/fftw-native/3.3.10-r0/temp/run.do_compile.464684,
line 199

On Sun, May 14, 2023 at 5:57 AM Khem Raj <raj.khem@gmail.com> wrote:
>
> FFTW_CC is added to image via version.o and its CC + CFLAGS however CC
> in OE containes --syroot compiler option which encodes buildpaths into
> binary, therefore remove this option from FFTW_CC in config.h
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>  meta-oe/recipes-support/fftw/fftw_3.3.10.bb | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/meta-oe/recipes-support/fftw/fftw_3.3.10.bb b/meta-oe/recipes-support/fftw/fftw_3.3.10.bb
> index cb45e2b91f..1fead4d029 100644
> --- a/meta-oe/recipes-support/fftw/fftw_3.3.10.bb
> +++ b/meta-oe/recipes-support/fftw/fftw_3.3.10.bb
> @@ -55,6 +55,7 @@ do_configure() {
>  do_compile() {
>      for lib in fftw fftwl fftwf; do
>          cd ${WORKDIR}/build-$lib
> +        sed -i -e 's|${TOOLCHAIN_OPTIONS}||g' config.h
>          autotools_do_compile
>      done
>  }
> --
> 2.40.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#102563): https://lists.openembedded.org/g/openembedded-devel/message/102563
> Mute This Topic: https://lists.openembedded.org/mt/98879626/2167232
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [jan.vermaete@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Khem Raj May 23, 2023, 4:46 a.m. UTC | #2
On Mon, May 22, 2023 at 4:12 AM jan vermaete <jan.vermaete@gmail.com> wrote:
>
> Hi,
>
> Could it be this is causing a failure (see below)
>

Yes, it seems that we need to check for TOOLCHAIN_OPTIONS to be not
empty which is the case when
building the native recipe.

> Thanks,
>
> DEBUG: Executing python function autotools_aclocals
> DEBUG: SITE files ['endian-little', 'common-linux', 'common-glibc',
> 'bit-64', 'x86_64-linux', 'common']
> DEBUG: Python function autotools_aclocals finished
> DEBUG: Executing shell function do_compile
> sed: -e expression #1, char 0: no previous regular expression
> WARNING: .../build/tmp/work/x86_64-linux/fftw-native/3.3.10-r0/temp/run.do_compile.464684:153
> exit 1 from 'sed -i -e 's|||g' config.h'
> WARNING: Backtrace (BB generated script):
>         #1: do_compile,
> .../build/tmp/work/x86_64-linux/fftw-native/3.3.10-r0/temp/run.do_compile.464684,
> line 153
>         #2: main,
> .../build/tmp/work/x86_64-linux/fftw-native/3.3.10-r0/temp/run.do_compile.464684,
> line 199
>
> On Sun, May 14, 2023 at 5:57 AM Khem Raj <raj.khem@gmail.com> wrote:
> >
> > FFTW_CC is added to image via version.o and its CC + CFLAGS however CC
> > in OE containes --syroot compiler option which encodes buildpaths into
> > binary, therefore remove this option from FFTW_CC in config.h
> >
> > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > ---
> >  meta-oe/recipes-support/fftw/fftw_3.3.10.bb | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/meta-oe/recipes-support/fftw/fftw_3.3.10.bb b/meta-oe/recipes-support/fftw/fftw_3.3.10.bb
> > index cb45e2b91f..1fead4d029 100644
> > --- a/meta-oe/recipes-support/fftw/fftw_3.3.10.bb
> > +++ b/meta-oe/recipes-support/fftw/fftw_3.3.10.bb
> > @@ -55,6 +55,7 @@ do_configure() {
> >  do_compile() {
> >      for lib in fftw fftwl fftwf; do
> >          cd ${WORKDIR}/build-$lib
> > +        sed -i -e 's|${TOOLCHAIN_OPTIONS}||g' config.h
> >          autotools_do_compile
> >      done
> >  }
> > --
> > 2.40.1
> >
> >
> > -=-=-=-=-=-=-=-=-=-=-=-
> > Links: You receive all messages sent to this group.
> > View/Reply Online (#102563): https://lists.openembedded.org/g/openembedded-devel/message/102563
> > Mute This Topic: https://lists.openembedded.org/mt/98879626/2167232
> > Group Owner: openembedded-devel+owner@lists.openembedded.org
> > Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [jan.vermaete@gmail.com]
> > -=-=-=-=-=-=-=-=-=-=-=-
> >
>
>
> --
> Jan Vermaete
> “Success is a self-correcting phenomenom.” -- Gary Hamel
diff mbox series

Patch

diff --git a/meta-oe/recipes-support/fftw/fftw_3.3.10.bb b/meta-oe/recipes-support/fftw/fftw_3.3.10.bb
index cb45e2b91f..1fead4d029 100644
--- a/meta-oe/recipes-support/fftw/fftw_3.3.10.bb
+++ b/meta-oe/recipes-support/fftw/fftw_3.3.10.bb
@@ -55,6 +55,7 @@  do_configure() {
 do_compile() {
     for lib in fftw fftwl fftwf; do
         cd ${WORKDIR}/build-$lib
+        sed -i -e 's|${TOOLCHAIN_OPTIONS}||g' config.h
         autotools_do_compile
     done
 }