| Message ID | 20240105142218.542729-1-alassane.yattara@savoirfairelinux.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/3] toaster/test: Bug-fix on TestProjectConfigTab::test_image_recipe_show_rows | expand |
Hi Alassane, On Fri, 2024-01-05 at 15:22 +0100, Alassane Yattara wrote: > Check some rows are visible in table instead of compare table row to > row_to_show, because recipe image table sometime doesn't display full avaiblable > images > > Signed-off-by: Alassane Yattara <alassane.yattara@savoirfairelinux.com> > --- > lib/toaster/tests/functional/test_project_page_tab_config.py | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Thanks, I've merged this series and run more tests. It is definitely improving, in the run of seven there was one failed build (4 tests): https://autobuilder.yoctoproject.org/typhoon/#/builders/161/builds/132/steps/11/logs/stdio FAILED ../bitbake/lib/toaster/tests/browser/test_new_custom_image_page.py::TestNewCustomImagePage::test_new_duplicates_non_image_recipe FAILED ../bitbake/lib/toaster/tests/browser/test_new_custom_image_page.py::TestNewCustomImagePage::test_new_duplicates_other_project_image FAILED ../bitbake/lib/toaster/tests/browser/test_new_custom_image_page.py::TestNewCustomImagePage::test_new_duplicates_project_image FAILED ../bitbake/lib/toaster/tests/browser/test_new_custom_image_page.py::TestNewCustomImagePage::test_new_image and in a separate batch of 5 runs, there was also one failed build: https://autobuilder.yoctoproject.org/typhoon/#/builders/161/builds/124 FAILED ../bitbake/lib/toaster/tests/browser/test_builddashboard_page.py::TestBuildDashboardPage::test_criticals_show_as_errors which is much better than the previous failure rates. Cheers, Richard
diff --git a/lib/toaster/tests/functional/test_project_page_tab_config.py b/lib/toaster/tests/functional/test_project_page_tab_config.py index ee1f5c4b..d027e0bc 100644 --- a/lib/toaster/tests/functional/test_project_page_tab_config.py +++ b/lib/toaster/tests/functional/test_project_page_tab_config.py @@ -254,8 +254,9 @@ class TestProjectConfigTab(SeleniumFunctionalTestCase): # Check that we can show rows == row_to_show show_row_link.select_by_value(str(row_to_show)) self.wait_until_visible('#imagerecipestable tbody tr') + # check at least some rows are visible self.assertTrue( - len(self.find_all('#imagerecipestable tbody tr')) == row_to_show + len(self.find_all('#imagerecipestable tbody tr')) > 0 ) self._navigate_to_project_page()
Check some rows are visible in table instead of compare table row to row_to_show, because recipe image table sometime doesn't display full avaiblable images Signed-off-by: Alassane Yattara <alassane.yattara@savoirfairelinux.com> --- lib/toaster/tests/functional/test_project_page_tab_config.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)