| Message ID | 20251027040535.3340080-1-v-singh1@ti.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Ryan Eatmon |
| Headers | show |
| Series | [v2] meta-ti-bsp : ipc: update ti-librpmsg-dma srcrev & license | expand |
meta-ti / na / 20251027040535.3340080-1-v-singh1
PRC Results: FAIL
=========================================================
check-yocto-patches: PASS
=========================================================
Patches
----------------------------------------
WARN - [PATCH v2] meta-ti-bsp : ipc: update ti-librpmsg-dma srcrev & license
WARN: Missing branches specifier [master/scarthgap/XXXXX]. (META-2)
patch:41
Subject: [PATCH v2] meta-ti-bsp : ipc: update ti-librpmsg-dma srcrev & license
WARN: Commit message does not include file/recipe name: meta-ti-bsp : ipc: update ti-librpmsg-dma srcrev & license. (COMMIT-MESSAGE-2)
patch
WARN: Commit message should not include directory path to recipe: meta-ti-bsp : ipc: update ti-librpmsg-dma srcrev & license.
ipc: (COMMIT-MESSAGE-3)
patch
WARN: Revised patch missing a comment. (REVISION-1)
patch
=========================================================
apply-yocto-patch: FAIL
=========================================================
master
=====================
Summary:
- Patch Series: [PATCH v2] meta-ti-bsp : ipc: update ti-librpmsg-dma srcrev & license
- Submitter: From: vishnu singh <v-singh1@ti.com>
From: Vishnu Singh <v-singh1@ti.com>
- Date: Date: Mon, 27 Oct 2025 09:35:35 +0530
- Num Patches: 1
- Mailing List (public inbox) Commit SHA: e5866cc73c99bf188d4e27659922d80f51eaae7e
Applied to:
- Repository: lcpd-prc-meta-ti
- Base Branch: master
- Commit Author: Ryan Eatmon <reatmon@ti.com>
- Commit Subject: packagegroup-ti-core-initramfs: ensure TI_INITRAMFS_KERNEL_MODULES is set
- Commit SHA: a58677ffedd5733ce7eba266bc1ed981d90af2a0
Patches
----------------------------------------
FAIL - [PATCH v2] meta-ti-bsp : ipc: update ti-librpmsg-dma srcrev & license
error: patch failed: meta-ti-bsp/recipes-ti/ipc/ti-librpmsg-dma_1.0.bb:1
error: meta-ti-bsp/recipes-ti/ipc/ti-librpmsg-dma_1.0.bb: patch does not apply
Applying: meta-ti-bsp : ipc: update ti-librpmsg-dma srcrev & license
Patch failed at 0001 meta-ti-bsp : ipc: update ti-librpmsg-dma srcrev & license
The subject does not state which recipe is being updated. Please change it to: ti-librpmsg-dma: update ti-librpmsg-dma SRCREV & LICENSE Also you did not include the branches in the subject so PRC only checked against master. Likely you will need two patches, one for scarthgap and one for master making the same changes in both. Also, when sending v2 and higher you should always include the version history in the patch after the --- to document what each revision was changing. On 10/26/2025 11:05 PM, vishnu singh wrote: > From: Vishnu Singh <v-singh1@ti.com> > > Update recipe license to TI-TFL, use scarthgap branch > Disable 2dfft and audio offload example build for rpmsg-dma library. > > License-Update: license change to TI-TFL > > Signed-off-by: Vishnu Singh <v-singh1@ti.com> > --- > meta-ti-bsp/recipes-ti/ipc/ti-librpmsg-dma_1.0.bb | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/meta-ti-bsp/recipes-ti/ipc/ti-librpmsg-dma_1.0.bb b/meta-ti-bsp/recipes-ti/ipc/ti-librpmsg-dma_1.0.bb > index b624871d..7600f867 100644 > --- a/meta-ti-bsp/recipes-ti/ipc/ti-librpmsg-dma_1.0.bb > +++ b/meta-ti-bsp/recipes-ti/ipc/ti-librpmsg-dma_1.0.bb > @@ -1,9 +1,9 @@ > SUMMARY = "RPMsg DMA shared library" > -LICENSE = "MIT" > -LIC_FILES_CHKSUM = "file://LICENSE;md5=744e63d2bb8c6151dcdd97f49aa02c53" > +LICENSE = "TI-TFL" > +LIC_FILES_CHKSUM = "file://LICENSE;md5=91dc4ee6d125d0aaba4e5bd2fcc50ed3" > > -SRC_URI = "git://github.com/TexasInstruments/rpmsg-dma.git;protocol=https;branch=main" > -SRCREV = "609fd72f458ba56f80d06810509ef88d010d2c03" > +SRC_URI = "git://github.com/TexasInstruments/rpmsg-dma.git;protocol=https;branch=scarthgap" > +SRCREV = "33d20a5a488844ace45ffb9dbbad9f043c5c897f" > > S = "${WORKDIR}/git" > > @@ -11,6 +11,6 @@ inherit cmake > > DEPENDS = "ti-rpmsg-char" > > -EXTRA_OECMAKE += "-DBUILD_LIB=ON -DBUILD_EXAMPLE=OFF" > +EXTRA_OECMAKE += "-DBUILD_LIB=ON -DBUILD_AUDIO_OFFLOAD_EXAMPLE=OFF -DBUILD_2DFFT_OFFLOAD_EXAMPLE=OFF" > > COMPATIBLE_MACHINE = "^(k3)$"
On Mon, Oct 27, 2025 at 08:03:59AM -0500, Ryan Eatmon wrote: > > The subject does not state which recipe is being updated. Please > change it to: > > ti-librpmsg-dma: update ti-librpmsg-dma SRCREV & LICENSE > > Also you did not include the branches in the subject so PRC only > checked against master. Likely you will need two patches, one for > scarthgap and one for master making the same changes in both. > > Also, when sending v2 and higher you should always include the > version history in the patch after the --- to document what each > revision was changing. Can we also get a little bit more reasoning behind the license change? Re-licensing is very rare and usually is something to stay away from, especially when changing from a more permissive license to a less permissive one. Also, the commit that changes the licensing updates the README file from MIT to BSD-3-Clause, not TI-TFL - so which one is it? https://github.com/TexasInstruments/rpmsg-dma/commit/47beb4c0a98c1fbbac73ef46d69b48b2002c941b https://github.com/TexasInstruments/rpmsg-dma/blob/scarthgap/README.md#-license Please be very specifici when it comes to licensing. Thanks. > On 10/26/2025 11:05 PM, vishnu singh wrote: > >From: Vishnu Singh <v-singh1@ti.com> > > > >Update recipe license to TI-TFL, use scarthgap branch > >Disable 2dfft and audio offload example build for rpmsg-dma library. > > > >License-Update: license change to TI-TFL > > > >Signed-off-by: Vishnu Singh <v-singh1@ti.com> > >--- > > meta-ti-bsp/recipes-ti/ipc/ti-librpmsg-dma_1.0.bb | 10 +++++----- > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > >diff --git a/meta-ti-bsp/recipes-ti/ipc/ti-librpmsg-dma_1.0.bb b/meta-ti-bsp/recipes-ti/ipc/ti-librpmsg-dma_1.0.bb > >index b624871d..7600f867 100644 > >--- a/meta-ti-bsp/recipes-ti/ipc/ti-librpmsg-dma_1.0.bb > >+++ b/meta-ti-bsp/recipes-ti/ipc/ti-librpmsg-dma_1.0.bb > >@@ -1,9 +1,9 @@ > > SUMMARY = "RPMsg DMA shared library" > >-LICENSE = "MIT" > >-LIC_FILES_CHKSUM = "file://LICENSE;md5=744e63d2bb8c6151dcdd97f49aa02c53" > >+LICENSE = "TI-TFL" > >+LIC_FILES_CHKSUM = "file://LICENSE;md5=91dc4ee6d125d0aaba4e5bd2fcc50ed3" > >-SRC_URI = "git://github.com/TexasInstruments/rpmsg-dma.git;protocol=https;branch=main" > >-SRCREV = "609fd72f458ba56f80d06810509ef88d010d2c03" > >+SRC_URI = "git://github.com/TexasInstruments/rpmsg-dma.git;protocol=https;branch=scarthgap" > >+SRCREV = "33d20a5a488844ace45ffb9dbbad9f043c5c897f" > > S = "${WORKDIR}/git" > >@@ -11,6 +11,6 @@ inherit cmake > > DEPENDS = "ti-rpmsg-char" > >-EXTRA_OECMAKE += "-DBUILD_LIB=ON -DBUILD_EXAMPLE=OFF" > >+EXTRA_OECMAKE += "-DBUILD_LIB=ON -DBUILD_AUDIO_OFFLOAD_EXAMPLE=OFF -DBUILD_2DFFT_OFFLOAD_EXAMPLE=OFF" > > COMPATIBLE_MACHINE = "^(k3)$"
diff --git a/meta-ti-bsp/recipes-ti/ipc/ti-librpmsg-dma_1.0.bb b/meta-ti-bsp/recipes-ti/ipc/ti-librpmsg-dma_1.0.bb index b624871d..7600f867 100644 --- a/meta-ti-bsp/recipes-ti/ipc/ti-librpmsg-dma_1.0.bb +++ b/meta-ti-bsp/recipes-ti/ipc/ti-librpmsg-dma_1.0.bb @@ -1,9 +1,9 @@ SUMMARY = "RPMsg DMA shared library" -LICENSE = "MIT" -LIC_FILES_CHKSUM = "file://LICENSE;md5=744e63d2bb8c6151dcdd97f49aa02c53" +LICENSE = "TI-TFL" +LIC_FILES_CHKSUM = "file://LICENSE;md5=91dc4ee6d125d0aaba4e5bd2fcc50ed3" -SRC_URI = "git://github.com/TexasInstruments/rpmsg-dma.git;protocol=https;branch=main" -SRCREV = "609fd72f458ba56f80d06810509ef88d010d2c03" +SRC_URI = "git://github.com/TexasInstruments/rpmsg-dma.git;protocol=https;branch=scarthgap" +SRCREV = "33d20a5a488844ace45ffb9dbbad9f043c5c897f" S = "${WORKDIR}/git" @@ -11,6 +11,6 @@ inherit cmake DEPENDS = "ti-rpmsg-char" -EXTRA_OECMAKE += "-DBUILD_LIB=ON -DBUILD_EXAMPLE=OFF" +EXTRA_OECMAKE += "-DBUILD_LIB=ON -DBUILD_AUDIO_OFFLOAD_EXAMPLE=OFF -DBUILD_2DFFT_OFFLOAD_EXAMPLE=OFF" COMPATIBLE_MACHINE = "^(k3)$"