diff mbox series

[meta-ti,master,v2] packagegroup-ti-core-initramfs: ensure TI_INITRAMFS_KERNEL_MODULES is set

Message ID 20251024155356.19234-1-reatmon@ti.com
State Accepted
Delegated to: Ryan Eatmon
Headers show
Series [meta-ti,master,v2] packagegroup-ti-core-initramfs: ensure TI_INITRAMFS_KERNEL_MODULES is set | expand

Commit Message

Ryan Eatmon Oct. 24, 2025, 3:53 p.m. UTC 
TI_INITRAMFS_KERNEL_MODULES gets set only for TI platfroms and ends up
being undefined otherwise, which breaks parsing in yocto-check-layer
and/or in multi-BSP setups. Ensure the variable is defined in the
packagegroup, if not already set by the machine configuration.

Remove the previous default assignment since we put it in the wrong
location.

Signed-off-by: Denys Dmytriyenko <denys@konsulko.com>
Signed-off-by: Ryan Eatmon <reatmon@ti.com>
---
v2: Remove the setting in ti-soc.inc.

 meta-ti-bsp/conf/machine/include/ti-soc.inc                     | 2 --
 .../recipes-ti/initramfs/packagegroup-ti-core-initramfs.bb      | 2 ++
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

PRC Automation Oct. 24, 2025, 3:55 p.m. UTC | #1 
meta-ti / na / 20251024155356.19234-1-reatmon

PRC Results: FAIL

=========================================================
  check-yocto-patches: PASS
=========================================================
Patches
----------------------------------------
All patches passed



=========================================================
  apply-yocto-patch: PASS
=========================================================
master
=====================
Summary:
- Patch Series: [meta-ti][master][PATCH v2] packagegroup-ti-core-initramfs: ensure TI_INITRAMFS_KERNEL_MODULES is set
- Submitter: From: Ryan Eatmon <reatmon@ti.com>
- Date: Date: Fri, 24 Oct 2025 10:53:56 -0500
- Num Patches: 1
- Mailing List (public inbox) Commit SHA: 01dce1a41f3f821d31c8513e95f25bd7580b6589

Applied to:
- Repository: lcpd-prc-meta-ti
- Base Branch: master-next
- Commit Author: LCPD Automation Script <lcpdbld@list.ti.com>
- Commit Subject: CI/CD Auto-Merger: cicd.master.202510240100
- Commit SHA: 6b9a2b322512ab94e67ef36249b6df2633b29b2d

Patches
----------------------------------------
All patches applied



=========================================================
  check-yocto-repo: FAIL
=========================================================
master
=====================
FAIL
    WARN: You might need a " " as the first character for the :append. (APPEND-2)
        meta-ti-bsp/conf/machine/include/am62axx.inc:15
            TI_INITRAMFS_KERNEL_MODULES:append:bsp-mainline  = "kernel-module-tps6594-i2c"
    
    WARN: You might need a " " as the first character for the :append. (APPEND-2)
        meta-ti-bsp/conf/machine/include/am62axx.inc:16
            TI_INITRAMFS_KERNEL_MODULES:append:bsp-next  = "kernel-module-tps6594-i2c"
    
    
    Code Summary
    ============
    
    APPEND-2
    -------------------------------------------
      :append simply takes the specified string and concatenates it
      directly to the variable.  Most of the time we want there to spaces
      between entries.  This check flags us to check if the missing space
      is actually needed.
diff mbox series

Patch

diff --git a/meta-ti-bsp/conf/machine/include/ti-soc.inc b/meta-ti-bsp/conf/machine/include/ti-soc.inc
index 2e3a1c1b..ca182968 100644
--- a/meta-ti-bsp/conf/machine/include/ti-soc.inc
+++ b/meta-ti-bsp/conf/machine/include/ti-soc.inc
@@ -29,8 +29,6 @@  CLASS_DEVICETREE_PREFIX = "${@ 'ti-devicetree-prefix' if d.getVar('KERNEL_DEVICE
 KERNEL_CLASSES += "${CLASS_DEVICETREE_PREFIX}"
 IMAGE_CLASSES += "${CLASS_DEVICETREE_PREFIX}"
 
-TI_INITRAMFS_KERNEL_MODULES ?= ""
-
 BUILD_CORE_INITRAMFS_IMAGE = "ti-core-initramfs"
 BUILD_CORE_INITRAMFS_IMAGE_FILE = "${BUILD_CORE_INITRAMFS_IMAGE}.cpio.xz"
 
diff --git a/meta-ti-bsp/recipes-ti/initramfs/packagegroup-ti-core-initramfs.bb b/meta-ti-bsp/recipes-ti/initramfs/packagegroup-ti-core-initramfs.bb
index e9cf5e6b..6845f0c9 100644
--- a/meta-ti-bsp/recipes-ti/initramfs/packagegroup-ti-core-initramfs.bb
+++ b/meta-ti-bsp/recipes-ti/initramfs/packagegroup-ti-core-initramfs.bb
@@ -2,6 +2,8 @@  SUMMARY = "Minimal initramfs for boot requirements"
 
 require recipes-core/packagegroups/packagegroup-core-boot.bb
 
+TI_INITRAMFS_KERNEL_MODULES ?= ""
+
 RDEPENDS:${PN} += "\
     ${TI_INITRAMFS_KERNEL_MODULES} \
     initramfs-framework-base \