diff mbox series

[master] packagegroup-ti-core-initramfs: ensure TI_INITRAMFS_KERNEL_MODULES is set

Message ID 20251023181013.25365-1-denis@denix.org
State Superseded
Delegated to: Ryan Eatmon
Headers show
Series [master] packagegroup-ti-core-initramfs: ensure TI_INITRAMFS_KERNEL_MODULES is set | expand

Commit Message

Denys Dmytriyenko Oct. 23, 2025, 6:10 p.m. UTC 
From: Denys Dmytriyenko <denys@konsulko.com>

TI_INITRAMFS_KERNEL_MODULES gets set only for TI platfroms and ends up
being undefined otherwise, which breaks parsing in yocto-check-layer
and/or in multi-BSP setups. Ensure the variable is defined in the
packagegroup, if not already set by the machine configuration.

Signed-off-by: Denys Dmytriyenko <denys@konsulko.com>
---
 .../recipes-ti/initramfs/packagegroup-ti-core-initramfs.bb      | 2 ++
 1 file changed, 2 insertions(+)

Comments

PRC Automation Oct. 23, 2025, 6:15 p.m. UTC | #1 
meta-ti / na / 20251023181013.25365-1-denis

PRC Results: FAIL

=========================================================
  check-yocto-patches: PASS
=========================================================
Patches
----------------------------------------
WARN - [master][PATCH] packagegroup-ti-core-initramfs: ensure TI_INITRAMFS_KERNEL_MODULES is set
    WARN: Commit message does not include file/recipe name: packagegroup-ti-core-initramfs: ensure TI_INITRAMFS_KERNEL_MODULES is set. (COMMIT-MESSAGE-2)
        patch



=========================================================
  apply-yocto-patch: PASS
=========================================================
master
=====================
Summary:
- Patch Series: [master][PATCH] packagegroup-ti-core-initramfs: ensure TI_INITRAMFS_KERNEL_MODULES is set
- Submitter: From: Denys Dmytriyenko <denis@denix.org>
From: Denys Dmytriyenko <denys@konsulko.com>
- Date: Date: Thu, 23 Oct 2025 14:10:13 -0400
- Num Patches: 1
- Mailing List (public inbox) Commit SHA: e5168559f0afa34f5b9a12215cfc418a2b6c77c5

Applied to:
- Repository: lcpd-prc-meta-ti
- Base Branch: master-wip
- Commit Author: Telukula Jeevan Kumar Sahu <j-sahu@ti.com>
- Commit Subject: conf: am335x-evm and am437x-evm: Bump up max_leb_cnt
- Commit SHA: 0473044cc244ce98ccd0300e5c8086433e5e520d

Patches
----------------------------------------
All patches applied



=========================================================
  check-yocto-repo: FAIL
=========================================================
master
=====================
FAIL
    WARN: You might need a " " as the first character for the :append. (APPEND-2)
        meta-ti-bsp/conf/machine/include/am62axx.inc:15
            TI_INITRAMFS_KERNEL_MODULES:append:bsp-mainline  = "kernel-module-tps6594-i2c"
    
    WARN: You might need a " " as the first character for the :append. (APPEND-2)
        meta-ti-bsp/conf/machine/include/am62axx.inc:16
            TI_INITRAMFS_KERNEL_MODULES:append:bsp-next  = "kernel-module-tps6594-i2c"
    
    
    Code Summary
    ============
    
    APPEND-2
    -------------------------------------------
      :append simply takes the specified string and concatenates it
      directly to the variable.  Most of the time we want there to spaces
      between entries.  This check flags us to check if the missing space
      is actually needed.
Denys Dmytriyenko Oct. 23, 2025, 8:16 p.m. UTC | #2 
Hey, Ryan,

Something is wrong with PRC...


On Thu, Oct 23, 2025 at 01:15:25PM -0500, PRC Automation via lists.yoctoproject.org wrote:
> meta-ti / na / 20251023181013.25365-1-denis
> 
> PRC Results: FAIL
> 
> =========================================================
>   check-yocto-patches: PASS
> =========================================================
> Patches
> ----------------------------------------
> WARN - [master][PATCH] packagegroup-ti-core-initramfs: ensure TI_INITRAMFS_KERNEL_MODULES is set
>     WARN: Commit message does not include file/recipe name: packagegroup-ti-core-initramfs: ensure TI_INITRAMFS_KERNEL_MODULES is set. (COMMIT-MESSAGE-2)

Well, packagegroup-ti-core-initramfs is actually the name of the recipe.


> =========================================================
>   check-yocto-repo: FAIL
> =========================================================
> master
> =====================
> FAIL
>     WARN: You might need a " " as the first character for the :append. (APPEND-2)
>         meta-ti-bsp/conf/machine/include/am62axx.inc:15
>             TI_INITRAMFS_KERNEL_MODULES:append:bsp-mainline  = "kernel-module-tps6594-i2c"
>     
>     WARN: You might need a " " as the first character for the :append. (APPEND-2)
>         meta-ti-bsp/conf/machine/include/am62axx.inc:16
>             TI_INITRAMFS_KERNEL_MODULES:append:bsp-next  = "kernel-module-tps6594-i2c"

This is not in my patch, but is a valid concern - need to correct it for 
am62axx.inc, while other machines appending to this variable already use a 
leading space...

>     
>     
>     Code Summary
>     ============
>     
>     APPEND-2
>     -------------------------------------------
>       :append simply takes the specified string and concatenates it
>       directly to the variable.  Most of the time we want there to spaces
>       between entries.  This check flags us to check if the missing space
>       is actually needed.
> 
> 
>
Ryan Eatmon Oct. 24, 2025, 3:34 p.m. UTC | #3 
On 10/23/2025 1:10 PM, Denys Dmytriyenko wrote:
> From: Denys Dmytriyenko <denys@konsulko.com>
> 
> TI_INITRAMFS_KERNEL_MODULES gets set only for TI platfroms and ends up
> being undefined otherwise, which breaks parsing in yocto-check-layer
> and/or in multi-BSP setups. Ensure the variable is defined in the
> packagegroup, if not already set by the machine configuration.
> 
> Signed-off-by: Denys Dmytriyenko <denys@konsulko.com>
> ---
>   .../recipes-ti/initramfs/packagegroup-ti-core-initramfs.bb      | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/meta-ti-bsp/recipes-ti/initramfs/packagegroup-ti-core-initramfs.bb b/meta-ti-bsp/recipes-ti/initramfs/packagegroup-ti-core-initramfs.bb
> index e9cf5e6b..6845f0c9 100644
> --- a/meta-ti-bsp/recipes-ti/initramfs/packagegroup-ti-core-initramfs.bb
> +++ b/meta-ti-bsp/recipes-ti/initramfs/packagegroup-ti-core-initramfs.bb
> @@ -2,6 +2,8 @@ SUMMARY = "Minimal initramfs for boot requirements"
>   
>   require recipes-core/packagegroups/packagegroup-core-boot.bb
>   
> +TI_INITRAMFS_KERNEL_MODULES ?= ""
> +
>   RDEPENDS:${PN} += "\
>       ${TI_INITRAMFS_KERNEL_MODULES} \
>       initramfs-framework-base \

I'm going to send an alternative patch.  We have the default assignment 
in ti-soc.inc, and my patch will remove that as well as it not needed 
there.  I'm going to blend your commit message and mine into a v2. 
Sending shortly.


> 
> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#19156): https://lists.yoctoproject.org/g/meta-ti/message/19156
> Mute This Topic: https://lists.yoctoproject.org/mt/115915657/6551054
> Group Owner: meta-ti+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-ti/unsub [reatmon@ti.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Denys Dmytriyenko Oct. 24, 2025, 3:50 p.m. UTC | #4 
On Fri, Oct 24, 2025 at 10:34:27AM -0500, Ryan Eatmon via lists.yoctoproject.org wrote:
> 
> 
> On 10/23/2025 1:10 PM, Denys Dmytriyenko wrote:
> >From: Denys Dmytriyenko <denys@konsulko.com>
> >
> >TI_INITRAMFS_KERNEL_MODULES gets set only for TI platfroms and ends up
> >being undefined otherwise, which breaks parsing in yocto-check-layer
> >and/or in multi-BSP setups. Ensure the variable is defined in the
> >packagegroup, if not already set by the machine configuration.
> >
> >Signed-off-by: Denys Dmytriyenko <denys@konsulko.com>
> >---
> >  .../recipes-ti/initramfs/packagegroup-ti-core-initramfs.bb      | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> >diff --git a/meta-ti-bsp/recipes-ti/initramfs/packagegroup-ti-core-initramfs.bb b/meta-ti-bsp/recipes-ti/initramfs/packagegroup-ti-core-initramfs.bb
> >index e9cf5e6b..6845f0c9 100644
> >--- a/meta-ti-bsp/recipes-ti/initramfs/packagegroup-ti-core-initramfs.bb
> >+++ b/meta-ti-bsp/recipes-ti/initramfs/packagegroup-ti-core-initramfs.bb
> >@@ -2,6 +2,8 @@ SUMMARY = "Minimal initramfs for boot requirements"
> >  require recipes-core/packagegroups/packagegroup-core-boot.bb
> >+TI_INITRAMFS_KERNEL_MODULES ?= ""
> >+
> >  RDEPENDS:${PN} += "\
> >      ${TI_INITRAMFS_KERNEL_MODULES} \
> >      initramfs-framework-base \
> 
> I'm going to send an alternative patch.  We have the default
> assignment in ti-soc.inc, and my patch will remove that as well as
> it not needed there.  I'm going to blend your commit message and
> mine into a v2. Sending shortly.

Yeah, I thought about the same, but decided to leave it there, as it 
doesn't hurt.
Ryan Eatmon Oct. 24, 2025, 4:22 p.m. UTC | #5 
On 10/23/2025 3:16 PM, Denys Dmytriyenko wrote:
> Hey, Ryan, Something is wrong with PRC. . . On Thu, Oct 23, 2025 at 01: 
>  15: 25PM -0500, PRC Automation via lists. yoctoproject. org wrote: > 
> meta-ti / na / 20251023181013. 25365-1-denis > > PRC Results: FAIL > > 
> =========================================================
> ZjQcmQRYFpfptBannerStart
> This message was sent from outside of Texas Instruments.
> Do not click links or open attachments unless you recognize the source 
> of this email and know the content is safe.
> Report Suspicious
> <https://us-phishalarm-ewt.proofpoint.com/EWT/v1/G3vK!uJdqXRfP1k0bamYkPPNDnBRijNbc-tnZWIKmvuQwEU3-lCPVdNywd9Z3mgF2f24Zn2T7Or4b$>
> ZjQcmQRYFpfptBannerEnd
> 
> Hey, Ryan,
> 
> Something is wrong with PRC...
> 
> 
> On Thu, Oct 23, 2025 at 01:15:25PM -0500, PRC Automation via lists.yoctoproject.org wrote:
>> meta-ti / na / 20251023181013.25365-1-denis
>> 
>> PRC Results: FAIL
>> 
>> =========================================================
>>   check-yocto-patches: PASS
>> =========================================================
>> Patches
>> ----------------------------------------
>> WARN - [master][PATCH] packagegroup-ti-core-initramfs: ensure TI_INITRAMFS_KERNEL_MODULES is set
>>     WARN: Commit message does not include file/recipe name: packagegroup-ti-core-initramfs: ensure TI_INITRAMFS_KERNEL_MODULES is set. (COMMIT-MESSAGE-2)
> 
> Well, packagegroup-ti-core-initramfs is actually the name of the recipe.

Yeah, it's on my list to fix.  Hoping today I can knock off the small 
things like this (and hooking up check-layers) into PRC.

> 
>> =========================================================
>>   check-yocto-repo: FAIL
>> =========================================================
>> master
>> =====================
>> FAIL
>>     WARN: You might need a " " as the first character for the :append. (APPEND-2)
>>         meta-ti-bsp/conf/machine/include/am62axx.inc:15
>>             TI_INITRAMFS_KERNEL_MODULES:append:bsp-mainline  = "kernel-module-tps6594-i2c"
>>     
>>     WARN: You might need a " " as the first character for the :append. (APPEND-2)
>>         meta-ti-bsp/conf/machine/include/am62axx.inc:16
>>             TI_INITRAMFS_KERNEL_MODULES:append:bsp-next  = "kernel-module-tps6594-i2c"
> 
> This is not in my patch, but is a valid concern - need to correct it for
> am62axx.inc, while other machines appending to this variable already use a
> leading space...

Just sent the patch that fixes this.


>>     
>>     
>>     Code Summary
>>     ============
>>     
>>     APPEND-2
>>     -------------------------------------------
>>       :append simply takes the specified string and concatenates it
>>       directly to the variable.  Most of the time we want there to spaces
>>       between entries.  This check flags us to check if the missing space
>>       is actually needed.
>> 
>> 
>> 
>
diff mbox series

Patch

diff --git a/meta-ti-bsp/recipes-ti/initramfs/packagegroup-ti-core-initramfs.bb b/meta-ti-bsp/recipes-ti/initramfs/packagegroup-ti-core-initramfs.bb
index e9cf5e6b..6845f0c9 100644
--- a/meta-ti-bsp/recipes-ti/initramfs/packagegroup-ti-core-initramfs.bb
+++ b/meta-ti-bsp/recipes-ti/initramfs/packagegroup-ti-core-initramfs.bb
@@ -2,6 +2,8 @@  SUMMARY = "Minimal initramfs for boot requirements"
 
 require recipes-core/packagegroups/packagegroup-core-boot.bb
 
+TI_INITRAMFS_KERNEL_MODULES ?= ""
+
 RDEPENDS:${PN} += "\
     ${TI_INITRAMFS_KERNEL_MODULES} \
     initramfs-framework-base \