| Message ID | 20250801044441.1059527-3-b-padhi@ti.com |
|---|---|
| State | New |
| Headers | show |
| Series | Add license for PKA FW | expand |
On 7/31/2025 11:44 PM, Beleswar Padhi wrote: > The PKA-FW license has been added to meta-ti. Point to that license in > the PKA firmware recipe. > > Signed-off-by: Beleswar Padhi <b-padhi@ti.com> > --- > meta-ti-bsp/recipes-bsp/ti-pka-fw/ti-pka-fw_git.bb | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/meta-ti-bsp/recipes-bsp/ti-pka-fw/ti-pka-fw_git.bb b/meta-ti-bsp/recipes-bsp/ti-pka-fw/ti-pka-fw_git.bb > index 49ae0251..bd31726c 100644 > --- a/meta-ti-bsp/recipes-bsp/ti-pka-fw/ti-pka-fw_git.bb > +++ b/meta-ti-bsp/recipes-bsp/ti-pka-fw/ti-pka-fw_git.bb > @@ -1,7 +1,7 @@ > SUMMARY = "PKA prebuilt binary firmware image" > > -LICENSE = "TI-TFL & INSIDE Secure" > -LIC_FILES_CHKSUM = "file://LICENCE.pka_fw;md5=dc20391b287874f0dce069cf87917206" > +LICENSE = "PKA-FW" > +LIC_FILES_CHKSUM = "file://${THISDIR}/../../licenses/PKA-FW;md5=251316268d8e7d1a546e5e6a08af6d9c" > > COMPATIBLE_MACHINE = "k3" > Don't we need BOTH TI_TFL and PKA-FW? Or are you thinking that since the license file contains both that covers it?
On 7/31/2025 11:44 PM, Beleswar Padhi wrote: > The PKA-FW license has been added to meta-ti. Point to that license in > the PKA firmware recipe. > > Signed-off-by: Beleswar Padhi <b-padhi@ti.com> > --- > meta-ti-bsp/recipes-bsp/ti-pka-fw/ti-pka-fw_git.bb | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/meta-ti-bsp/recipes-bsp/ti-pka-fw/ti-pka-fw_git.bb b/meta-ti-bsp/recipes-bsp/ti-pka-fw/ti-pka-fw_git.bb > index 49ae0251..bd31726c 100644 > --- a/meta-ti-bsp/recipes-bsp/ti-pka-fw/ti-pka-fw_git.bb > +++ b/meta-ti-bsp/recipes-bsp/ti-pka-fw/ti-pka-fw_git.bb > @@ -1,7 +1,7 @@ > SUMMARY = "PKA prebuilt binary firmware image" > > -LICENSE = "TI-TFL & INSIDE Secure" > -LIC_FILES_CHKSUM = "file://LICENCE.pka_fw;md5=dc20391b287874f0dce069cf87917206" > +LICENSE = "PKA-FW" > +LIC_FILES_CHKSUM = "file://${THISDIR}/../../licenses/PKA-FW;md5=251316268d8e7d1a546e5e6a08af6d9c" Also, when changing the value in LIC_FILES_CHKSUM it is required that you provide a line in the commit message: License-Update: reason Telling people in a short/brief manner the nature of the change. In this case you could get away with: License-Update: see commit message Is that right, Denys? > COMPATIBLE_MACHINE = "k3" >
On 8/1/2025 6:02 PM, Ryan Eatmon wrote: > > > On 7/31/2025 11:44 PM, Beleswar Padhi wrote: >> The PKA-FW license has been added to meta-ti. Point to that license in >> the PKA firmware recipe. >> >> Signed-off-by: Beleswar Padhi <b-padhi@ti.com> >> --- >> meta-ti-bsp/recipes-bsp/ti-pka-fw/ti-pka-fw_git.bb | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/meta-ti-bsp/recipes-bsp/ti-pka-fw/ti-pka-fw_git.bb >> b/meta-ti-bsp/recipes-bsp/ti-pka-fw/ti-pka-fw_git.bb >> index 49ae0251..bd31726c 100644 >> --- a/meta-ti-bsp/recipes-bsp/ti-pka-fw/ti-pka-fw_git.bb >> +++ b/meta-ti-bsp/recipes-bsp/ti-pka-fw/ti-pka-fw_git.bb >> @@ -1,7 +1,7 @@ >> SUMMARY = "PKA prebuilt binary firmware image" >> -LICENSE = "TI-TFL & INSIDE Secure" >> -LIC_FILES_CHKSUM = >> "file://LICENCE.pka_fw;md5=dc20391b287874f0dce069cf87917206" >> +LICENSE = "PKA-FW" >> +LIC_FILES_CHKSUM = >> "file://${THISDIR}/../../licenses/PKA-FW;md5=251316268d8e7d1a546e5e6a08af6d9c" >> COMPATIBLE_MACHINE = "k3" > > Don't we need BOTH TI_TFL and PKA-FW? Or are you thinking that since > the license file contains both that covers it? > > Yes, the PKA-FW License contains both TFL and Inside secure copyrights. Thanks, Beleswar
On Fri, Aug 01, 2025 at 07:41:17AM -0500, Ryan Eatmon via lists.yoctoproject.org wrote: > > > On 7/31/2025 11:44 PM, Beleswar Padhi wrote: > >The PKA-FW license has been added to meta-ti. Point to that license in > >the PKA firmware recipe. > > > >Signed-off-by: Beleswar Padhi <b-padhi@ti.com> > >--- > > meta-ti-bsp/recipes-bsp/ti-pka-fw/ti-pka-fw_git.bb | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > >diff --git a/meta-ti-bsp/recipes-bsp/ti-pka-fw/ti-pka-fw_git.bb b/meta-ti-bsp/recipes-bsp/ti-pka-fw/ti-pka-fw_git.bb > >index 49ae0251..bd31726c 100644 > >--- a/meta-ti-bsp/recipes-bsp/ti-pka-fw/ti-pka-fw_git.bb > >+++ b/meta-ti-bsp/recipes-bsp/ti-pka-fw/ti-pka-fw_git.bb > >@@ -1,7 +1,7 @@ > > SUMMARY = "PKA prebuilt binary firmware image" > >-LICENSE = "TI-TFL & INSIDE Secure" > >-LIC_FILES_CHKSUM = "file://LICENCE.pka_fw;md5=dc20391b287874f0dce069cf87917206" > >+LICENSE = "PKA-FW" > >+LIC_FILES_CHKSUM = "file://${THISDIR}/../../licenses/PKA-FW;md5=251316268d8e7d1a546e5e6a08af6d9c" > > Also, when changing the value in LIC_FILES_CHKSUM it is required > that you provide a line in the commit message: > > License-Update: reason > > Telling people in a short/brief manner the nature of the change. In > this case you could get away with: > > License-Update: see commit message > > Is that right, Denys? Well, why so radical changes? Isn't it still "TI-TFL & INSIDE-Secure"? We already have TI-TFL license in meta-ti, we just need to add INSIDE-Secure file. And LIC_FILES_CHKSUM doesn't need to change, it should still point to the file in the firmware repository.
On 8/1/2025 8:04 PM, Denys Dmytriyenko wrote: > On Fri, Aug 01, 2025 at 07:41:17AM -0500, Ryan Eatmon via lists.yoctoproject.org wrote: >> >> On 7/31/2025 11:44 PM, Beleswar Padhi wrote: >>> The PKA-FW license has been added to meta-ti. Point to that license in >>> the PKA firmware recipe. >>> >>> Signed-off-by: Beleswar Padhi <b-padhi@ti.com> >>> --- >>> meta-ti-bsp/recipes-bsp/ti-pka-fw/ti-pka-fw_git.bb | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/meta-ti-bsp/recipes-bsp/ti-pka-fw/ti-pka-fw_git.bb b/meta-ti-bsp/recipes-bsp/ti-pka-fw/ti-pka-fw_git.bb >>> index 49ae0251..bd31726c 100644 >>> --- a/meta-ti-bsp/recipes-bsp/ti-pka-fw/ti-pka-fw_git.bb >>> +++ b/meta-ti-bsp/recipes-bsp/ti-pka-fw/ti-pka-fw_git.bb >>> @@ -1,7 +1,7 @@ >>> SUMMARY = "PKA prebuilt binary firmware image" >>> -LICENSE = "TI-TFL & INSIDE Secure" >>> -LIC_FILES_CHKSUM = "file://LICENCE.pka_fw;md5=dc20391b287874f0dce069cf87917206" >>> +LICENSE = "PKA-FW" >>> +LIC_FILES_CHKSUM = "file://${THISDIR}/../../licenses/PKA-FW;md5=251316268d8e7d1a546e5e6a08af6d9c" >> Also, when changing the value in LIC_FILES_CHKSUM it is required >> that you provide a line in the commit message: >> >> License-Update: reason >> >> Telling people in a short/brief manner the nature of the change. In >> this case you could get away with: >> >> License-Update: see commit message >> >> Is that right, Denys? > Well, why so radical changes? > > Isn't it still "TI-TFL & INSIDE-Secure"? > > We already have TI-TFL license in meta-ti, we just need to add INSIDE-Secure > file. I was trying to keep everything same as done in ti-linux-firmware repo. They added a separate License file for PKA: https://git.ti.com/cgit/processor-firmware/ti-linux-firmware/commit/?h=ti-linux-firmware-next&id=a2f39386f89d5ad68a324a9371da3bb8dd20f7de > > And LIC_FILES_CHKSUM doesn't need to change, it should still point to the file > in the firmware repository. Then why add the LICENSE FILE here, if checksum is compared from the one in ti-linux-firmware repo? Thanks, Beleswar
On Fri, Aug 01, 2025 at 08:13:13PM +0530, Beleswar Prasad Padhi wrote: > > On 8/1/2025 8:04 PM, Denys Dmytriyenko wrote: > >On Fri, Aug 01, 2025 at 07:41:17AM -0500, Ryan Eatmon via lists.yoctoproject.org wrote: > >> > >>On 7/31/2025 11:44 PM, Beleswar Padhi wrote: > >>>The PKA-FW license has been added to meta-ti. Point to that license in > >>>the PKA firmware recipe. > >>> > >>>Signed-off-by: Beleswar Padhi <b-padhi@ti.com> > >>>--- > >>> meta-ti-bsp/recipes-bsp/ti-pka-fw/ti-pka-fw_git.bb | 4 ++-- > >>> 1 file changed, 2 insertions(+), 2 deletions(-) > >>> > >>>diff --git a/meta-ti-bsp/recipes-bsp/ti-pka-fw/ti-pka-fw_git.bb b/meta-ti-bsp/recipes-bsp/ti-pka-fw/ti-pka-fw_git.bb > >>>index 49ae0251..bd31726c 100644 > >>>--- a/meta-ti-bsp/recipes-bsp/ti-pka-fw/ti-pka-fw_git.bb > >>>+++ b/meta-ti-bsp/recipes-bsp/ti-pka-fw/ti-pka-fw_git.bb > >>>@@ -1,7 +1,7 @@ > >>> SUMMARY = "PKA prebuilt binary firmware image" > >>>-LICENSE = "TI-TFL & INSIDE Secure" > >>>-LIC_FILES_CHKSUM = "file://LICENCE.pka_fw;md5=dc20391b287874f0dce069cf87917206" > >>>+LICENSE = "PKA-FW" > >>>+LIC_FILES_CHKSUM = "file://${THISDIR}/../../licenses/PKA-FW;md5=251316268d8e7d1a546e5e6a08af6d9c" > >>Also, when changing the value in LIC_FILES_CHKSUM it is required > >>that you provide a line in the commit message: > >> > >>License-Update: reason > >> > >>Telling people in a short/brief manner the nature of the change. In > >>this case you could get away with: > >> > >>License-Update: see commit message > >> > >>Is that right, Denys? > >Well, why so radical changes? > > > >Isn't it still "TI-TFL & INSIDE-Secure"? > > > >We already have TI-TFL license in meta-ti, we just need to add INSIDE-Secure > >file. > > > I was trying to keep everything same as done in ti-linux-firmware > repo. They added a separate License file for PKA: > https://git.ti.com/cgit/processor-firmware/ti-linux-firmware/commit/?h=ti-linux-firmware-next&id=a2f39386f89d5ad68a324a9371da3bb8dd20f7de > > > > >And LIC_FILES_CHKSUM doesn't need to change, it should still point to the file > >in the firmware repository. > > Then why add the LICENSE FILE here, if checksum is compared from the > one in ti-linux-firmware repo? Thanks, Beleswar They serve slightly different purposes. LIC_FILES_CHKSUM should point to any license declaration inside the component - could even be a comment in a source file and as short as "licensed under <blah>"... The point is to catch when such declaration changes upon version update. And LICENSE then lists such <blah> with proper SPDX names and LICENSE_PATH then collects pristine texts for those <blah> - you don't want to checksum pristine texts, as they never change.
diff --git a/meta-ti-bsp/recipes-bsp/ti-pka-fw/ti-pka-fw_git.bb b/meta-ti-bsp/recipes-bsp/ti-pka-fw/ti-pka-fw_git.bb index 49ae0251..bd31726c 100644 --- a/meta-ti-bsp/recipes-bsp/ti-pka-fw/ti-pka-fw_git.bb +++ b/meta-ti-bsp/recipes-bsp/ti-pka-fw/ti-pka-fw_git.bb @@ -1,7 +1,7 @@ SUMMARY = "PKA prebuilt binary firmware image" -LICENSE = "TI-TFL & INSIDE Secure" -LIC_FILES_CHKSUM = "file://LICENCE.pka_fw;md5=dc20391b287874f0dce069cf87917206" +LICENSE = "PKA-FW" +LIC_FILES_CHKSUM = "file://${THISDIR}/../../licenses/PKA-FW;md5=251316268d8e7d1a546e5e6a08af6d9c" COMPATIBLE_MACHINE = "k3"
The PKA-FW license has been added to meta-ti. Point to that license in the PKA firmware recipe. Signed-off-by: Beleswar Padhi <b-padhi@ti.com> --- meta-ti-bsp/recipes-bsp/ti-pka-fw/ti-pka-fw_git.bb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)