| Message ID | 20250723211613.16164-1-reatmon@ti.com |
|---|---|
| State | Accepted |
| Delegated to: | Ryan Eatmon |
| Headers | show |
| Series | [meta-ti,scarthgap,1/3] conf: machine: am64xx: Cleanup assignment whitespace | expand |
Is this change scarthgap specific? I see the change that originally added TI_WKS_BOOTLOADER_APPEND to scarthgap is now being forward-ported to master, thus this fix appears to also be applicable to master? On Wed, Jul 23, 2025 at 04:16:11PM -0500, Ryan Eatmon via lists.yoctoproject.org wrote: > A recent change in bitbake requires that all variable assignments have > whitespace between the variable, the operator and the value. > > FOO = "1" > > Signed-off-by: Ryan Eatmon <reatmon@ti.com> > --- > meta-ti-bsp/conf/machine/include/am64xx.inc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta-ti-bsp/conf/machine/include/am64xx.inc b/meta-ti-bsp/conf/machine/include/am64xx.inc > index 56b56afe..27165547 100644 > --- a/meta-ti-bsp/conf/machine/include/am64xx.inc > +++ b/meta-ti-bsp/conf/machine/include/am64xx.inc > @@ -35,4 +35,4 @@ OPTEEMACHINE = "k3-am64x" > > MACHINE_ESSENTIAL_EXTRA_RRECOMMENDS += "prueth-fw pruhsr-fw prusw-fw" > > -TI_WKS_BOOTLOADER_APPEND="console=ttyS2,115200n8" > +TI_WKS_BOOTLOADER_APPEND = "console=ttyS2,115200n8" > -- > 2.17.1
Nope. I meant to send this patch as a combo patch. For both master and scarthgap. Oops. Good catch. On 7/24/2025 4:52 PM, Denys Dmytriyenko wrote: > Is this change scarthgap specific? I see the change that originally added > TI_WKS_BOOTLOADER_APPEND to scarthgap is now being forward-ported to master, > thus this fix appears to also be applicable to master? > > > On Wed, Jul 23, 2025 at 04:16:11PM -0500, Ryan Eatmon via lists.yoctoproject.org wrote: >> A recent change in bitbake requires that all variable assignments have >> whitespace between the variable, the operator and the value. >> >> FOO = "1" >> >> Signed-off-by: Ryan Eatmon <reatmon@ti.com> >> --- >> meta-ti-bsp/conf/machine/include/am64xx.inc | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/meta-ti-bsp/conf/machine/include/am64xx.inc b/meta-ti-bsp/conf/machine/include/am64xx.inc >> index 56b56afe..27165547 100644 >> --- a/meta-ti-bsp/conf/machine/include/am64xx.inc >> +++ b/meta-ti-bsp/conf/machine/include/am64xx.inc >> @@ -35,4 +35,4 @@ OPTEEMACHINE = "k3-am64x" >> >> MACHINE_ESSENTIAL_EXTRA_RRECOMMENDS += "prueth-fw pruhsr-fw prusw-fw" >> >> -TI_WKS_BOOTLOADER_APPEND="console=ttyS2,115200n8" >> +TI_WKS_BOOTLOADER_APPEND = "console=ttyS2,115200n8" >> -- >> 2.17.1
diff --git a/meta-ti-bsp/conf/machine/include/am64xx.inc b/meta-ti-bsp/conf/machine/include/am64xx.inc index 56b56afe..27165547 100644 --- a/meta-ti-bsp/conf/machine/include/am64xx.inc +++ b/meta-ti-bsp/conf/machine/include/am64xx.inc @@ -35,4 +35,4 @@ OPTEEMACHINE = "k3-am64x" MACHINE_ESSENTIAL_EXTRA_RRECOMMENDS += "prueth-fw pruhsr-fw prusw-fw" -TI_WKS_BOOTLOADER_APPEND="console=ttyS2,115200n8" +TI_WKS_BOOTLOADER_APPEND = "console=ttyS2,115200n8"
A recent change in bitbake requires that all variable assignments have whitespace between the variable, the operator and the value. FOO = "1" Signed-off-by: Ryan Eatmon <reatmon@ti.com> --- meta-ti-bsp/conf/machine/include/am64xx.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)