diff mbox series

[meta-ti,scarthgap/master] meta-ti-bsp: k3r5: Use new tune file for Cortex-R5F

Message ID 20250627202700.582822-1-afd@ti.com
State New
Headers show
Series [meta-ti,scarthgap/master] meta-ti-bsp: k3r5: Use new tune file for Cortex-R5F | expand

Commit Message

Andrew Davis June 27, 2025, 8:27 p.m. UTC
There is now a tune available specifically for Cortex-R5F cores, use that
here. Not sure how much difference this makes as we only build one package
for this (U-Boot R5 SPL) but should be no harm either.

Signed-off-by: Andrew Davis <afd@ti.com>
---
 meta-ti-bsp/conf/machine/include/k3r5.inc | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Denys Dmytriyenko June 27, 2025, 9:03 p.m. UTC | #1
On Fri, Jun 27, 2025 at 03:27:00PM -0500, Andrew Davis via lists.yoctoproject.org wrote:
> There is now a tune available specifically for Cortex-R5F cores, use that
> here. Not sure how much difference this makes as we only build one package
> for this (U-Boot R5 SPL) but should be no harm either.
> 
> Signed-off-by: Andrew Davis <afd@ti.com>
> ---
>  meta-ti-bsp/conf/machine/include/k3r5.inc | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/meta-ti-bsp/conf/machine/include/k3r5.inc b/meta-ti-bsp/conf/machine/include/k3r5.inc
> index fcd54254..ebd8b0aa 100644
> --- a/meta-ti-bsp/conf/machine/include/k3r5.inc
> +++ b/meta-ti-bsp/conf/machine/include/k3r5.inc
> @@ -3,9 +3,9 @@
>  require conf/machine/include/ti-soc.inc
>  SOC_FAMILY:append = ":k3r5"
>  
> -# The closest of existing tunes for Cortex-R5F
> -DEFAULTTUNE = "armv7athf"
> -require conf/machine/include/arm/armv7a/tune-cortexa8.inc
> +# Tune for Cortex-R5F
> +DEFAULTTUNE = "cortexr5hf"
> +require conf/machine/include/arm/armv7r/tune-cortexr5.inc

Last time I tried this, there were some adverse effects, though I don't 
remember specific details - could have been something Thumb-related, size or 
speed.

I still have a patch in one of my old local trees, but I never submited 
it due to the above uncertainty. Ah, I see, back in Kirstone days, 2 years 
ago - see attached...

I would recommend thorough testing with this change. But it might have been 
toolchain-related and is no longer an issue...


>  # R5 runs early bootloader and loads SYSFW
>  # https://git.ti.com/cgit/ti-u-boot/ti-u-boot/tree/doc/board/ti/j721e_evm.rst
> -- 
> 2.39.2
diff mbox series

Patch

diff --git a/meta-ti-bsp/conf/machine/include/k3r5.inc b/meta-ti-bsp/conf/machine/include/k3r5.inc
index fcd54254..ebd8b0aa 100644
--- a/meta-ti-bsp/conf/machine/include/k3r5.inc
+++ b/meta-ti-bsp/conf/machine/include/k3r5.inc
@@ -3,9 +3,9 @@ 
 require conf/machine/include/ti-soc.inc
 SOC_FAMILY:append = ":k3r5"
 
-# The closest of existing tunes for Cortex-R5F
-DEFAULTTUNE = "armv7athf"
-require conf/machine/include/arm/armv7a/tune-cortexa8.inc
+# Tune for Cortex-R5F
+DEFAULTTUNE = "cortexr5hf"
+require conf/machine/include/arm/armv7r/tune-cortexr5.inc
 
 # R5 runs early bootloader and loads SYSFW
 # https://git.ti.com/cgit/ti-u-boot/ti-u-boot/tree/doc/board/ti/j721e_evm.rst