diff mbox series

[meta-ti,master/scarthgap] recipes-bsp: u-boot: Remove do_install from bootsplash image

Message ID 20250417145131.3966302-1-c-shilwant@ti.com
State Superseded
Delegated to: Ryan Eatmon
Headers show
Series [meta-ti,master/scarthgap] recipes-bsp: u-boot: Remove do_install from bootsplash image | expand

Commit Message

Chirag Shilwant April 17, 2025, 2:51 p.m. UTC
* U-Boot reads the bootsplash image file from the /boot (i.e vfat)
partition & displays it during boot-up showcasing early splash screen
support.

* There's no significance of having an additional do_install
as the logo file need not be added in the rootfs/image.

* Fixes 277f04df4c94de44bcea95b46d59cf057f571e45 & 1fed958bfe8a8825996134f62097ac02206f43b2

Signed-off-by: Chirag Shilwant <c-shilwant@ti.com>
---
 meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti.inc | 10 ----------
 1 file changed, 10 deletions(-)

Comments

Denys Dmytriyenko April 17, 2025, 6:07 p.m. UTC | #1
Chirag,

The commit message below looks a bit confusing - can you please rephrase it?


On Thu, Apr 17, 2025 at 08:21:31PM +0530, Chirag Shilwant wrote:
> * U-Boot reads the bootsplash image file from the /boot (i.e vfat)
> partition

Well, vfat boot partition and /boot directory on the rootfs are 2 different 
things.


> & displays it during boot-up showcasing early splash screen
> support.
> 
> * There's no significance of having an additional do_install
> as the logo file need not be added in the rootfs/image.
> 
> * Fixes 277f04df4c94de44bcea95b46d59cf057f571e45 & 1fed958bfe8a8825996134f62097ac02206f43b2
> 
> Signed-off-by: Chirag Shilwant <c-shilwant@ti.com>
> ---
>  meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti.inc | 10 ----------
>  1 file changed, 10 deletions(-)
> 
> diff --git a/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti.inc b/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti.inc
> index 41d4abdd..6fe7ddf1 100644
> --- a/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti.inc
> +++ b/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti.inc
> @@ -353,21 +353,11 @@ uboot_deploy:append () {
>      fi
>  }
>  
> -do_install:append:am62xx() {
> -	install -d ${D}/boot
> -	install -m 0644 ${S}/tools/logos/ti_logo_414x97_32bpp.bmp.gz ${D}/boot
> -}
> -
>  do_deploy:append:am62xx() {
>  	install -d ${DEPLOYDIR}
>  	install -m 0644 ${S}/tools/logos/ti_logo_414x97_32bpp.bmp.gz ${DEPLOYDIR}
>  }
>  
> -do_install:append:am62pxx() {
> -	install -d ${D}/boot
> -	install -m 0644 ${S}/tools/logos/ti_logo_414x97_32bpp.bmp.gz ${D}/boot
> -}
> -
>  do_deploy:append:am62pxx() {
>  	install -d ${DEPLOYDIR}
>  	install -m 0644 ${S}/tools/logos/ti_logo_414x97_32bpp.bmp.gz ${DEPLOYDIR}
> -- 
> 2.34.1
diff mbox series

Patch

diff --git a/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti.inc b/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti.inc
index 41d4abdd..6fe7ddf1 100644
--- a/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti.inc
+++ b/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti.inc
@@ -353,21 +353,11 @@  uboot_deploy:append () {
     fi
 }
 
-do_install:append:am62xx() {
-	install -d ${D}/boot
-	install -m 0644 ${S}/tools/logos/ti_logo_414x97_32bpp.bmp.gz ${D}/boot
-}
-
 do_deploy:append:am62xx() {
 	install -d ${DEPLOYDIR}
 	install -m 0644 ${S}/tools/logos/ti_logo_414x97_32bpp.bmp.gz ${DEPLOYDIR}
 }
 
-do_install:append:am62pxx() {
-	install -d ${D}/boot
-	install -m 0644 ${S}/tools/logos/ti_logo_414x97_32bpp.bmp.gz ${D}/boot
-}
-
 do_deploy:append:am62pxx() {
 	install -d ${DEPLOYDIR}
 	install -m 0644 ${S}/tools/logos/ti_logo_414x97_32bpp.bmp.gz ${DEPLOYDIR}