diff mbox series

[meta-ti,scarthgap,v2] conf: machine: j722s: Add overlay to KERNEL_DEVICETREE_PREFIX

Message ID 20250210080101.75507-1-a-dutta@ti.com
State Rejected
Delegated to: Ryan Eatmon
Headers show
Series [meta-ti,scarthgap,v2] conf: machine: j722s: Add overlay to KERNEL_DEVICETREE_PREFIX | expand

Commit Message

Dutta, Anurag Feb. 10, 2025, 8:01 a.m. UTC
Add the overlay "k3-am625-sk-mcspi-loopback.dtso" to the j722s
configuration so that SPI loopback tests can be carried out
successfully.

Signed-off-by: Anurag Dutta <a-dutta@ti.com>
---

v2: Changelog:
1) Added the correct branch
2) Added the correct overlay with test results

Link to v1: https://lore.kernel.org/all/20250205073251.42414-1-a-dutta@ti.com/

Test_link:https://gist.github.com/anuragdutta731/f93908b31d524ff0c52c3fd314449948

 meta-ti-bsp/conf/machine/j722s-evm.conf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Kumar, Udit Feb. 10, 2025, 10:44 a.m. UTC | #1
On 2/10/2025 1:31 PM, Anurag Dutta wrote:
> Add the overlay "k3-am625-sk-mcspi-loopback.dtso" to the j722s
> configuration so that SPI loopback tests can be carried out
> successfully.
>
> Signed-off-by: Anurag Dutta <a-dutta@ti.com>
> ---
>
> v2: Changelog:
> 1) Added the correct branch
> 2) Added the correct overlay with test results
>
> Link to v1: https://lore.kernel.org/all/20250205073251.42414-1-a-dutta@ti.com/
>
> Test_link:https://gist.github.com/anuragdutta731/f93908b31d524ff0c52c3fd314449948
>
>   meta-ti-bsp/conf/machine/j722s-evm.conf | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta-ti-bsp/conf/machine/j722s-evm.conf b/meta-ti-bsp/conf/machine/j722s-evm.conf
> index 8f42866c..52a6cfbd 100644
> --- a/meta-ti-bsp/conf/machine/j722s-evm.conf
> +++ b/meta-ti-bsp/conf/machine/j722s-evm.conf
> @@ -7,7 +7,7 @@ require conf/machine/include/j722s.inc
>   KERNEL_DEVICETREE_PREFIX = " \
>       ti/k3-j722s \
>       ti/k3-fpdlink \
> -    ti/k3-j7200-evm-mcspi-loopback \
> +    ti/k3-am625-sk-mcspi-loopback \

if v1, yet to be committed to tree then there should be only (+) no 
removal line

if v1, is already in tree then Please include fixes tag


>       ti/k3-v3link \
>   "
>
Ryan Eatmon Feb. 10, 2025, 2:47 p.m. UTC | #2
The first version of the patch was already accepted and promoted last 
week.  So while this patch will apply, I am not going to accept it since 
the commit message does not really document what is being changed.

You should really check the prod branch before you send a v2/v3 patch to 
see if it was accepted and promoted already.

In this case, resend this patch without any v2, and reword all of the 
commit message text to explain what is changing.



On 2/10/2025 2:01 AM, Anurag Dutta wrote:
> Add the overlay "k3-am625-sk-mcspi-loopback.dtso" to the j722s
> configuration so that SPI loopback tests can be carried out
> successfully.
> 
> Signed-off-by: Anurag Dutta <a-dutta@ti.com>
> ---
> 
> v2: Changelog:
> 1) Added the correct branch
> 2) Added the correct overlay with test results
> 
> Link to v1: https://lore.kernel.org/all/20250205073251.42414-1-a-dutta@ti.com/
> 
> Test_link:https://gist.github.com/anuragdutta731/f93908b31d524ff0c52c3fd314449948
> 
>   meta-ti-bsp/conf/machine/j722s-evm.conf | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta-ti-bsp/conf/machine/j722s-evm.conf b/meta-ti-bsp/conf/machine/j722s-evm.conf
> index 8f42866c..52a6cfbd 100644
> --- a/meta-ti-bsp/conf/machine/j722s-evm.conf
> +++ b/meta-ti-bsp/conf/machine/j722s-evm.conf
> @@ -7,7 +7,7 @@ require conf/machine/include/j722s.inc
>   KERNEL_DEVICETREE_PREFIX = " \
>       ti/k3-j722s \
>       ti/k3-fpdlink \
> -    ti/k3-j7200-evm-mcspi-loopback \
> +    ti/k3-am625-sk-mcspi-loopback \
>       ti/k3-v3link \
>   "
>
diff mbox series

Patch

diff --git a/meta-ti-bsp/conf/machine/j722s-evm.conf b/meta-ti-bsp/conf/machine/j722s-evm.conf
index 8f42866c..52a6cfbd 100644
--- a/meta-ti-bsp/conf/machine/j722s-evm.conf
+++ b/meta-ti-bsp/conf/machine/j722s-evm.conf
@@ -7,7 +7,7 @@  require conf/machine/include/j722s.inc
 KERNEL_DEVICETREE_PREFIX = " \
     ti/k3-j722s \
     ti/k3-fpdlink \
-    ti/k3-j7200-evm-mcspi-loopback \
+    ti/k3-am625-sk-mcspi-loopback \
     ti/k3-v3link \
 "