| Message ID | 20241217205945.46805-1-afd@ti.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Ryan Eatmon |
| Headers | show |
| Series | [meta-ti,scarthgap/master] ti-bsp: Disable GC320 support conditionally on BSP version | expand |
Andrew, Thanks for the patches. Ryan and I were discussing them yesterday. Couple points/questions: 1. There's meta-beagle restructuring going on in master right now - the changes are in master-next and should be merged to master shortly. I also just posted a series to backport these changes to scarthgap. That will affect your change below to ti-bsp.inc and will need to be re-spinned. 2. A more generic question... GC320 is a unique peripheral of legacy AM57/J6 platforms and the driver for it hasn't been updated since 5.10 times. It has been disabled globally in the Distro layer for a couple years now. While I do understand your change to move this disablenent from the Distro to BSP, are there any plans to revive GC320 support and not simply remove it altogether? On Tue, Dec 17, 2024 at 02:59:45PM -0600, Andrew Davis via lists.yoctoproject.org wrote: > Like we do with GPU support, GC320 support is conditional on the > kernel we are building and so should be disabled here for kernels > on which it is not functional yet. > > We can then remove these disabling lines as the driver is updated > for each supported kernel, instead of blanket disabling in the > distro layer as done currently. > > Signed-off-by: Andrew Davis <afd@ti.com> > --- > meta-ti-bsp/conf/machine/include/ti-bsp.inc | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/meta-ti-bsp/conf/machine/include/ti-bsp.inc b/meta-ti-bsp/conf/machine/include/ti-bsp.inc > index 814c6ca8..bdc8bef7 100644 > --- a/meta-ti-bsp/conf/machine/include/ti-bsp.inc > +++ b/meta-ti-bsp/conf/machine/include/ti-bsp.inc > @@ -22,6 +22,9 @@ BSP_BOOTLOADER_VERSION:bsp-mainline = "%" > # in mainline, usually present in TI staging or derivative like BB.org > MACHINE_FEATURES:remove:bsp-mainline = "gpu" > > +# GC320 support requires out-of-tree drivers not available in mainline > +MACHINE_FEATURES:remove:bsp-mainline = "gc320" > + > # ========== > # next > # upcoming upstream/mainline kernel, u-boot > @@ -35,6 +38,9 @@ BSP_BOOTLOADER_VERSION:bsp-next = "%" > # in next, usually present in TI staging or derivative like BB.org > MACHINE_FEATURES:remove:bsp-next = "gpu" > > +# GC320 support requires out-of-tree drivers not available in next > +MACHINE_FEATURES:remove:bsp-next = "gc320" > + > # ========== > # ti-6_12 > # TI staging kernel 6.12, u-boot 2024.10 > @@ -48,6 +54,9 @@ BSP_BOOTLOADER_VERSION:bsp-ti-6_12 = "2024.10%" > # in 6.12 yet > MACHINE_FEATURES:remove:bsp-ti-6_12 = "gpu" > > +# GC320 support requires out-of-tree drivers not yet available in 6.12 > +MACHINE_FEATURES:remove:bsp-ti-6_12 = "gc320" > + > # ========== > # ti-6_6 > # TI staging kernel 6.6, u-boot 2024.04 > @@ -65,6 +74,9 @@ BSP_ROGUE_DRIVER_VERSION:bsp-ti-6_6 = "24%" > BSP_ROGUE_UMLIBS_VERSION:bsp-ti-6_6 = "24%" > BSP_MESA_PVR_VERSION:bsp-ti-6_6 = "23%" > > +# GC320 support requires out-of-tree drivers not yet available in 6.6 > +MACHINE_FEATURES:remove:bsp-ti-6_6 = "gc320" > + > # ========== > # ti-6_1 > # TI staging kernel 6.1, u-boot 2023.04 > @@ -82,6 +94,9 @@ BSP_ROGUE_DRIVER_VERSION:bsp-ti-6_1 = "23%" > BSP_ROGUE_UMLIBS_VERSION:bsp-ti-6_1 = "23%" > BSP_MESA_PVR_VERSION:bsp-ti-6_1 = "22%" > > +# GC320 support requires out-of-tree drivers not yet available in 6.1 > +MACHINE_FEATURES:remove:bsp-ti-6_1 = "gc320" > + > # ========== > # bb_org > # BeagleBoard.org kernel 6.1, u-boot 2023.04 > @@ -101,6 +116,9 @@ BSP_ROGUE_DRIVER_VERSION:bsp-bb_org = "23%" > BSP_ROGUE_UMLIBS_VERSION:bsp-bb_org = "23%" > BSP_MESA_PVR_VERSION:bsp-bb_org = "22%" > > +# GC320 support requires out-of-tree drivers not yet available in bb.org > +MACHINE_FEATURES:remove:bsp-bb_org = "gc320" > + > # ========== > # sane fallback defaults > # if specific values are not defined or bsp is set incorrectly > -- > 2.39.2
On 12/18/24 3:19 PM, Denys Dmytriyenko wrote: > Andrew, > > Thanks for the patches. Ryan and I were discussing them yesterday. > > Couple points/questions: > > 1. There's meta-beagle restructuring going on in master right now - the > changes are in master-next and should be merged to master shortly. I also > just posted a series to backport these changes to scarthgap. That will > affect your change below to ti-bsp.inc and will need to be re-spinned. > No worries. The restructure looks good btw, looking forward to having cleaner separation (and the new BeagleY-AI builds :D). I'll re-spin this when meta-beagle lands in master and scarthgap. > 2. A more generic question... GC320 is a unique peripheral of legacy AM57/J6 > platforms and the driver for it hasn't been updated since 5.10 times. It > has been disabled globally in the Distro layer for a couple years now. While > I do understand your change to move this disablenent from the Distro to > BSP, are there any plans to revive GC320 support and not simply remove it > altogether? > The fix to get the GC320 kernel module building again is rather trivial. Just never got around to pushing the fixes. So mostly just wishful thinking that it will get re-enabled here at some point.. Andrew > > On Tue, Dec 17, 2024 at 02:59:45PM -0600, Andrew Davis via lists.yoctoproject.org wrote: >> Like we do with GPU support, GC320 support is conditional on the >> kernel we are building and so should be disabled here for kernels >> on which it is not functional yet. >> >> We can then remove these disabling lines as the driver is updated >> for each supported kernel, instead of blanket disabling in the >> distro layer as done currently. >> >> Signed-off-by: Andrew Davis <afd@ti.com> >> --- >> meta-ti-bsp/conf/machine/include/ti-bsp.inc | 18 ++++++++++++++++++ >> 1 file changed, 18 insertions(+) >> >> diff --git a/meta-ti-bsp/conf/machine/include/ti-bsp.inc b/meta-ti-bsp/conf/machine/include/ti-bsp.inc >> index 814c6ca8..bdc8bef7 100644 >> --- a/meta-ti-bsp/conf/machine/include/ti-bsp.inc >> +++ b/meta-ti-bsp/conf/machine/include/ti-bsp.inc >> @@ -22,6 +22,9 @@ BSP_BOOTLOADER_VERSION:bsp-mainline = "%" >> # in mainline, usually present in TI staging or derivative like BB.org >> MACHINE_FEATURES:remove:bsp-mainline = "gpu" >> >> +# GC320 support requires out-of-tree drivers not available in mainline >> +MACHINE_FEATURES:remove:bsp-mainline = "gc320" >> + >> # ========== >> # next >> # upcoming upstream/mainline kernel, u-boot >> @@ -35,6 +38,9 @@ BSP_BOOTLOADER_VERSION:bsp-next = "%" >> # in next, usually present in TI staging or derivative like BB.org >> MACHINE_FEATURES:remove:bsp-next = "gpu" >> >> +# GC320 support requires out-of-tree drivers not available in next >> +MACHINE_FEATURES:remove:bsp-next = "gc320" >> + >> # ========== >> # ti-6_12 >> # TI staging kernel 6.12, u-boot 2024.10 >> @@ -48,6 +54,9 @@ BSP_BOOTLOADER_VERSION:bsp-ti-6_12 = "2024.10%" >> # in 6.12 yet >> MACHINE_FEATURES:remove:bsp-ti-6_12 = "gpu" >> >> +# GC320 support requires out-of-tree drivers not yet available in 6.12 >> +MACHINE_FEATURES:remove:bsp-ti-6_12 = "gc320" >> + >> # ========== >> # ti-6_6 >> # TI staging kernel 6.6, u-boot 2024.04 >> @@ -65,6 +74,9 @@ BSP_ROGUE_DRIVER_VERSION:bsp-ti-6_6 = "24%" >> BSP_ROGUE_UMLIBS_VERSION:bsp-ti-6_6 = "24%" >> BSP_MESA_PVR_VERSION:bsp-ti-6_6 = "23%" >> >> +# GC320 support requires out-of-tree drivers not yet available in 6.6 >> +MACHINE_FEATURES:remove:bsp-ti-6_6 = "gc320" >> + >> # ========== >> # ti-6_1 >> # TI staging kernel 6.1, u-boot 2023.04 >> @@ -82,6 +94,9 @@ BSP_ROGUE_DRIVER_VERSION:bsp-ti-6_1 = "23%" >> BSP_ROGUE_UMLIBS_VERSION:bsp-ti-6_1 = "23%" >> BSP_MESA_PVR_VERSION:bsp-ti-6_1 = "22%" >> >> +# GC320 support requires out-of-tree drivers not yet available in 6.1 >> +MACHINE_FEATURES:remove:bsp-ti-6_1 = "gc320" >> + >> # ========== >> # bb_org >> # BeagleBoard.org kernel 6.1, u-boot 2023.04 >> @@ -101,6 +116,9 @@ BSP_ROGUE_DRIVER_VERSION:bsp-bb_org = "23%" >> BSP_ROGUE_UMLIBS_VERSION:bsp-bb_org = "23%" >> BSP_MESA_PVR_VERSION:bsp-bb_org = "22%" >> >> +# GC320 support requires out-of-tree drivers not yet available in bb.org >> +MACHINE_FEATURES:remove:bsp-bb_org = "gc320" >> + >> # ========== >> # sane fallback defaults >> # if specific values are not defined or bsp is set incorrectly >> -- >> 2.39.2
On 12/18/2024 6:05 PM, Andrew Davis wrote: > On 12/18/24 3:19 PM, Denys Dmytriyenko wrote: >> Andrew, >> >> Thanks for the patches. Ryan and I were discussing them yesterday. >> >> Couple points/questions: >> >> 1. There's meta-beagle restructuring going on in master right now - the >> changes are in master-next and should be merged to master shortly. I also >> just posted a series to backport these changes to scarthgap. That will >> affect your change below to ti-bsp.inc and will need to be re-spinned. >> > > No worries. The restructure looks good btw, looking forward to having > cleaner separation (and the new BeagleY-AI builds :D). I'll re-spin this > when meta-beagle lands in master and scarthgap. I have pushed all of the needed patches to scarthgap/master. You can re-spin the series if you want. >> 2. A more generic question... GC320 is a unique peripheral of legacy >> AM57/J6 >> platforms and the driver for it hasn't been updated since 5.10 times. It >> has been disabled globally in the Distro layer for a couple years now. >> While >> I do understand your change to move this disablenent from the Distro to >> BSP, are there any plans to revive GC320 support and not simply remove it >> altogether? >> > > The fix to get the GC320 kernel module building again is rather trivial. > Just > never got around to pushing the fixes. So mostly just wishful thinking > that it > will get re-enabled here at some point.. > > Andrew > >> >> On Tue, Dec 17, 2024 at 02:59:45PM -0600, Andrew Davis via >> lists.yoctoproject.org wrote: >>> Like we do with GPU support, GC320 support is conditional on the >>> kernel we are building and so should be disabled here for kernels >>> on which it is not functional yet. >>> >>> We can then remove these disabling lines as the driver is updated >>> for each supported kernel, instead of blanket disabling in the >>> distro layer as done currently. >>> >>> Signed-off-by: Andrew Davis <afd@ti.com> >>> --- >>> meta-ti-bsp/conf/machine/include/ti-bsp.inc | 18 ++++++++++++++++++ >>> 1 file changed, 18 insertions(+) >>> >>> diff --git a/meta-ti-bsp/conf/machine/include/ti-bsp.inc >>> b/meta-ti-bsp/conf/machine/include/ti-bsp.inc >>> index 814c6ca8..bdc8bef7 100644 >>> --- a/meta-ti-bsp/conf/machine/include/ti-bsp.inc >>> +++ b/meta-ti-bsp/conf/machine/include/ti-bsp.inc >>> @@ -22,6 +22,9 @@ BSP_BOOTLOADER_VERSION:bsp-mainline = "%" >>> # in mainline, usually present in TI staging or derivative like BB.org >>> MACHINE_FEATURES:remove:bsp-mainline = "gpu" >>> +# GC320 support requires out-of-tree drivers not available in mainline >>> +MACHINE_FEATURES:remove:bsp-mainline = "gc320" >>> + >>> # ========== >>> # next >>> # upcoming upstream/mainline kernel, u-boot >>> @@ -35,6 +38,9 @@ BSP_BOOTLOADER_VERSION:bsp-next = "%" >>> # in next, usually present in TI staging or derivative like BB.org >>> MACHINE_FEATURES:remove:bsp-next = "gpu" >>> +# GC320 support requires out-of-tree drivers not available in next >>> +MACHINE_FEATURES:remove:bsp-next = "gc320" >>> + >>> # ========== >>> # ti-6_12 >>> # TI staging kernel 6.12, u-boot 2024.10 >>> @@ -48,6 +54,9 @@ BSP_BOOTLOADER_VERSION:bsp-ti-6_12 = "2024.10%" >>> # in 6.12 yet >>> MACHINE_FEATURES:remove:bsp-ti-6_12 = "gpu" >>> +# GC320 support requires out-of-tree drivers not yet available in 6.12 >>> +MACHINE_FEATURES:remove:bsp-ti-6_12 = "gc320" >>> + >>> # ========== >>> # ti-6_6 >>> # TI staging kernel 6.6, u-boot 2024.04 >>> @@ -65,6 +74,9 @@ BSP_ROGUE_DRIVER_VERSION:bsp-ti-6_6 = "24%" >>> BSP_ROGUE_UMLIBS_VERSION:bsp-ti-6_6 = "24%" >>> BSP_MESA_PVR_VERSION:bsp-ti-6_6 = "23%" >>> +# GC320 support requires out-of-tree drivers not yet available in 6.6 >>> +MACHINE_FEATURES:remove:bsp-ti-6_6 = "gc320" >>> + >>> # ========== >>> # ti-6_1 >>> # TI staging kernel 6.1, u-boot 2023.04 >>> @@ -82,6 +94,9 @@ BSP_ROGUE_DRIVER_VERSION:bsp-ti-6_1 = "23%" >>> BSP_ROGUE_UMLIBS_VERSION:bsp-ti-6_1 = "23%" >>> BSP_MESA_PVR_VERSION:bsp-ti-6_1 = "22%" >>> +# GC320 support requires out-of-tree drivers not yet available in 6.1 >>> +MACHINE_FEATURES:remove:bsp-ti-6_1 = "gc320" >>> + >>> # ========== >>> # bb_org >>> # BeagleBoard.org kernel 6.1, u-boot 2023.04 >>> @@ -101,6 +116,9 @@ BSP_ROGUE_DRIVER_VERSION:bsp-bb_org = "23%" >>> BSP_ROGUE_UMLIBS_VERSION:bsp-bb_org = "23%" >>> BSP_MESA_PVR_VERSION:bsp-bb_org = "22%" >>> +# GC320 support requires out-of-tree drivers not yet available in >>> bb.org >>> +MACHINE_FEATURES:remove:bsp-bb_org = "gc320" >>> + >>> # ========== >>> # sane fallback defaults >>> # if specific values are not defined or bsp is set incorrectly >>> -- >>> 2.39.2
diff --git a/meta-ti-bsp/conf/machine/include/ti-bsp.inc b/meta-ti-bsp/conf/machine/include/ti-bsp.inc index 814c6ca8..bdc8bef7 100644 --- a/meta-ti-bsp/conf/machine/include/ti-bsp.inc +++ b/meta-ti-bsp/conf/machine/include/ti-bsp.inc @@ -22,6 +22,9 @@ BSP_BOOTLOADER_VERSION:bsp-mainline = "%" # in mainline, usually present in TI staging or derivative like BB.org MACHINE_FEATURES:remove:bsp-mainline = "gpu" +# GC320 support requires out-of-tree drivers not available in mainline +MACHINE_FEATURES:remove:bsp-mainline = "gc320" + # ========== # next # upcoming upstream/mainline kernel, u-boot @@ -35,6 +38,9 @@ BSP_BOOTLOADER_VERSION:bsp-next = "%" # in next, usually present in TI staging or derivative like BB.org MACHINE_FEATURES:remove:bsp-next = "gpu" +# GC320 support requires out-of-tree drivers not available in next +MACHINE_FEATURES:remove:bsp-next = "gc320" + # ========== # ti-6_12 # TI staging kernel 6.12, u-boot 2024.10 @@ -48,6 +54,9 @@ BSP_BOOTLOADER_VERSION:bsp-ti-6_12 = "2024.10%" # in 6.12 yet MACHINE_FEATURES:remove:bsp-ti-6_12 = "gpu" +# GC320 support requires out-of-tree drivers not yet available in 6.12 +MACHINE_FEATURES:remove:bsp-ti-6_12 = "gc320" + # ========== # ti-6_6 # TI staging kernel 6.6, u-boot 2024.04 @@ -65,6 +74,9 @@ BSP_ROGUE_DRIVER_VERSION:bsp-ti-6_6 = "24%" BSP_ROGUE_UMLIBS_VERSION:bsp-ti-6_6 = "24%" BSP_MESA_PVR_VERSION:bsp-ti-6_6 = "23%" +# GC320 support requires out-of-tree drivers not yet available in 6.6 +MACHINE_FEATURES:remove:bsp-ti-6_6 = "gc320" + # ========== # ti-6_1 # TI staging kernel 6.1, u-boot 2023.04 @@ -82,6 +94,9 @@ BSP_ROGUE_DRIVER_VERSION:bsp-ti-6_1 = "23%" BSP_ROGUE_UMLIBS_VERSION:bsp-ti-6_1 = "23%" BSP_MESA_PVR_VERSION:bsp-ti-6_1 = "22%" +# GC320 support requires out-of-tree drivers not yet available in 6.1 +MACHINE_FEATURES:remove:bsp-ti-6_1 = "gc320" + # ========== # bb_org # BeagleBoard.org kernel 6.1, u-boot 2023.04 @@ -101,6 +116,9 @@ BSP_ROGUE_DRIVER_VERSION:bsp-bb_org = "23%" BSP_ROGUE_UMLIBS_VERSION:bsp-bb_org = "23%" BSP_MESA_PVR_VERSION:bsp-bb_org = "22%" +# GC320 support requires out-of-tree drivers not yet available in bb.org +MACHINE_FEATURES:remove:bsp-bb_org = "gc320" + # ========== # sane fallback defaults # if specific values are not defined or bsp is set incorrectly
Like we do with GPU support, GC320 support is conditional on the kernel we are building and so should be disabled here for kernels on which it is not functional yet. We can then remove these disabling lines as the driver is updated for each supported kernel, instead of blanket disabling in the distro layer as done currently. Signed-off-by: Andrew Davis <afd@ti.com> --- meta-ti-bsp/conf/machine/include/ti-bsp.inc | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+)