| Message ID | 20241206053521.1126544-1-a-shenai@ti.com |
|---|---|
| State | Superseded |
| Delegated to: | Ryan Eatmon |
| Headers | show |
| Series | [meta-ti,master/scarthgap,v2] am62p: PRNG: Remove software PRNG | expand |
Hi, Based on the convention, commit message title should be recipes-security: optee: Remove software PRNG in am62pxx On 06/12/24 11:05, Aashvij Shenai wrote: > With the latest TIFS fix [1], AM62P is able to leverage the hardware-TRNG > instead of having to fallback into the software-PRNG. > > [1] - commit: 98de0a4290ec200cc224d4a5a6f42d2126230e2f ("ti-sysfw: > am65x/am64x/am62x/am62ax/am62px: update to version v10.01.08") > > Repo: https://git.ti.com/git/processor-firmware/ti-linux-firmware.git > Branch: ti-linux-firmware This entire story could just have been, [1]: https://git.ti.com/cgit/processor-firmware/ti-linux-firmware/commit/?h=ti-linux-firmware&id=98de0a4290ec200cc224d4a5a6f42d2126230e2f > > Signed-off-by: Aashvij Shenai <a-shenai@ti.com> > --- > > Changelog: > v1 -> v2: > - Updated commit message to include fix and moved test logs > > Testlogs: https://gist.github.com/AashvijShenai/9ea3e128ab29f703c2b6d988cfd0b82a > > --- > > meta-ti-bsp/recipes-security/optee/optee-os-ti-overrides.inc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta-ti-bsp/recipes-security/optee/optee-os-ti-overrides.inc b/meta-ti-bsp/recipes-security/optee/optee-os-ti-overrides.inc > index 43b8ce1c..f131f1ff 100644 > --- a/meta-ti-bsp/recipes-security/optee/optee-os-ti-overrides.inc > +++ b/meta-ti-bsp/recipes-security/optee/optee-os-ti-overrides.inc > @@ -6,7 +6,7 @@ EXTRA_OEMAKE:remove = "CFG_MAP_EXT_DT_SECURE=y" > EXTRA_OEMAKE:append:k3 = "${@ ' CFG_CONSOLE_UART='+ d.getVar('OPTEE_K3_USART') if d.getVar('OPTEE_K3_USART') else ''}" > > EXTRA_OEMAKE:append:am62xx = " CFG_TEE_CORE_LOG_LEVEL=1" > -EXTRA_OEMAKE:append:am62pxx = " CFG_WITH_SOFTWARE_PRNG=y CFG_TEE_CORE_LOG_LEVEL=1" > +EXTRA_OEMAKE:append:am62pxx = " CFG_TEE_CORE_LOG_LEVEL=1" > EXTRA_OEMAKE:append:am62axx = " CFG_TEE_CORE_LOG_LEVEL=1" > EXTRA_OEMAKE:append:j722s = " CFG_TEE_CORE_LOG_LEVEL=1" >
On 12/6/2024 8:56 AM, Chirag Shilwant wrote: > Hi, > > Based on the convention, commit message title should be > recipes-security: optee: Remove software PRNG in am62pxx We don't usually require the "recipes-security" part. As that makes the message get really long. But the recipe name base should be part of it. For non-recipes we tend to like a portion of the directory that the file being updated is in. For example for a machine conf file: conf: am62xx-evm: do something classes: Update foo.class etc... But we do like to see something a bit more descriptive so that if we search through the logs it is more apparent about what area your change is being made. If you are ever unclear on what to put there, just to git.ti.com, navigate to the file you are changing, then look at the log changes for that file and see the history of changes to that file and try to be consistent. > On 06/12/24 11:05, Aashvij Shenai wrote: >> With the latest TIFS fix [1], AM62P is able to leverage the hardware-TRNG >> instead of having to fallback into the software-PRNG. >> >> [1] - commit: 98de0a4290ec200cc224d4a5a6f42d2126230e2f ("ti-sysfw: >> am65x/am64x/am62x/am62ax/am62px: update to version v10.01.08") >> >> Repo: https://git.ti.com/git/processor-firmware/ti-linux-firmware.git >> Branch: ti-linux-firmware > > > > This entire story could just have been, > > [1]: > https://git.ti.com/cgit/processor-firmware/ti-linux-firmware/commit/?h=ti-linux-firmware&id=98de0a4290ec200cc224d4a5a6f42d2126230e2f > > > >> >> Signed-off-by: Aashvij Shenai <a-shenai@ti.com> >> --- >> >> Changelog: >> v1 -> v2: >> - Updated commit message to include fix and moved test logs >> >> Testlogs: >> https://gist.github.com/AashvijShenai/9ea3e128ab29f703c2b6d988cfd0b82a >> >> --- >> >> meta-ti-bsp/recipes-security/optee/optee-os-ti-overrides.inc | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git >> a/meta-ti-bsp/recipes-security/optee/optee-os-ti-overrides.inc >> b/meta-ti-bsp/recipes-security/optee/optee-os-ti-overrides.inc >> index 43b8ce1c..f131f1ff 100644 >> --- a/meta-ti-bsp/recipes-security/optee/optee-os-ti-overrides.inc >> +++ b/meta-ti-bsp/recipes-security/optee/optee-os-ti-overrides.inc >> @@ -6,7 +6,7 @@ EXTRA_OEMAKE:remove = "CFG_MAP_EXT_DT_SECURE=y" >> EXTRA_OEMAKE:append:k3 = "${@ ' CFG_CONSOLE_UART='+ >> d.getVar('OPTEE_K3_USART') if d.getVar('OPTEE_K3_USART') else ''}" >> EXTRA_OEMAKE:append:am62xx = " CFG_TEE_CORE_LOG_LEVEL=1" >> -EXTRA_OEMAKE:append:am62pxx = " CFG_WITH_SOFTWARE_PRNG=y >> CFG_TEE_CORE_LOG_LEVEL=1" >> +EXTRA_OEMAKE:append:am62pxx = " CFG_TEE_CORE_LOG_LEVEL=1" >> EXTRA_OEMAKE:append:am62axx = " CFG_TEE_CORE_LOG_LEVEL=1" >> EXTRA_OEMAKE:append:j722s = " CFG_TEE_CORE_LOG_LEVEL=1"
Thanks for the reviews, I will update and send a v3 Regards, Aashvij On 06/12/24 20:35, Eatmon, Ryan wrote: > > On 12/6/2024 8:56 AM, Chirag Shilwant wrote: >> Hi, >> >> Based on the convention, commit message title should be >> recipes-security: optee: Remove software PRNG in am62pxx > We don't usually require the "recipes-security" part. As that makes the > message get really long. But the recipe name base should be part of it. > > For non-recipes we tend to like a portion of the directory that the file > being updated is in. For example for a machine conf file: > > conf: am62xx-evm: do something > classes: Update foo.class > > etc... > > But we do like to see something a bit more descriptive so that if we > search through the logs it is more apparent about what area your change > is being made. > > If you are ever unclear on what to put there, just to git.ti.com, > navigate to the file you are changing, then look at the log changes for > that file and see the history of changes to that file and try to be > consistent. > > >> On 06/12/24 11:05, Aashvij Shenai wrote: >>> With the latest TIFS fix [1], AM62P is able to leverage the hardware-TRNG >>> instead of having to fallback into the software-PRNG. >>> >>> [1] - commit: 98de0a4290ec200cc224d4a5a6f42d2126230e2f ("ti-sysfw: >>> am65x/am64x/am62x/am62ax/am62px: update to version v10.01.08") >>> >>> Repo: https://git.ti.com/git/processor-firmware/ti-linux-firmware.git >>> Branch: ti-linux-firmware >> >> >> This entire story could just have been, >> >> [1]: >> https://git.ti.com/cgit/processor-firmware/ti-linux-firmware/commit/?h=ti-linux-firmware&id=98de0a4290ec200cc224d4a5a6f42d2126230e2f >> >> >> >>> Signed-off-by: Aashvij Shenai <a-shenai@ti.com> >>> --- >>> >>> Changelog: >>> v1 -> v2: >>> - Updated commit message to include fix and moved test logs >>> >>> Testlogs: >>> https://gist.github.com/AashvijShenai/9ea3e128ab29f703c2b6d988cfd0b82a >>> >>> --- >>> >>> meta-ti-bsp/recipes-security/optee/optee-os-ti-overrides.inc | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git >>> a/meta-ti-bsp/recipes-security/optee/optee-os-ti-overrides.inc >>> b/meta-ti-bsp/recipes-security/optee/optee-os-ti-overrides.inc >>> index 43b8ce1c..f131f1ff 100644 >>> --- a/meta-ti-bsp/recipes-security/optee/optee-os-ti-overrides.inc >>> +++ b/meta-ti-bsp/recipes-security/optee/optee-os-ti-overrides.inc >>> @@ -6,7 +6,7 @@ EXTRA_OEMAKE:remove = "CFG_MAP_EXT_DT_SECURE=y" >>> EXTRA_OEMAKE:append:k3 = "${@ ' CFG_CONSOLE_UART='+ >>> d.getVar('OPTEE_K3_USART') if d.getVar('OPTEE_K3_USART') else ''}" >>> EXTRA_OEMAKE:append:am62xx = " CFG_TEE_CORE_LOG_LEVEL=1" >>> -EXTRA_OEMAKE:append:am62pxx = " CFG_WITH_SOFTWARE_PRNG=y >>> CFG_TEE_CORE_LOG_LEVEL=1" >>> +EXTRA_OEMAKE:append:am62pxx = " CFG_TEE_CORE_LOG_LEVEL=1" >>> EXTRA_OEMAKE:append:am62axx = " CFG_TEE_CORE_LOG_LEVEL=1" >>> EXTRA_OEMAKE:append:j722s = " CFG_TEE_CORE_LOG_LEVEL=1"
diff --git a/meta-ti-bsp/recipes-security/optee/optee-os-ti-overrides.inc b/meta-ti-bsp/recipes-security/optee/optee-os-ti-overrides.inc index 43b8ce1c..f131f1ff 100644 --- a/meta-ti-bsp/recipes-security/optee/optee-os-ti-overrides.inc +++ b/meta-ti-bsp/recipes-security/optee/optee-os-ti-overrides.inc @@ -6,7 +6,7 @@ EXTRA_OEMAKE:remove = "CFG_MAP_EXT_DT_SECURE=y" EXTRA_OEMAKE:append:k3 = "${@ ' CFG_CONSOLE_UART='+ d.getVar('OPTEE_K3_USART') if d.getVar('OPTEE_K3_USART') else ''}" EXTRA_OEMAKE:append:am62xx = " CFG_TEE_CORE_LOG_LEVEL=1" -EXTRA_OEMAKE:append:am62pxx = " CFG_WITH_SOFTWARE_PRNG=y CFG_TEE_CORE_LOG_LEVEL=1" +EXTRA_OEMAKE:append:am62pxx = " CFG_TEE_CORE_LOG_LEVEL=1" EXTRA_OEMAKE:append:am62axx = " CFG_TEE_CORE_LOG_LEVEL=1" EXTRA_OEMAKE:append:j722s = " CFG_TEE_CORE_LOG_LEVEL=1"
With the latest TIFS fix [1], AM62P is able to leverage the hardware-TRNG instead of having to fallback into the software-PRNG. [1] - commit: 98de0a4290ec200cc224d4a5a6f42d2126230e2f ("ti-sysfw: am65x/am64x/am62x/am62ax/am62px: update to version v10.01.08") Repo: https://git.ti.com/git/processor-firmware/ti-linux-firmware.git Branch: ti-linux-firmware Signed-off-by: Aashvij Shenai <a-shenai@ti.com> --- Changelog: v1 -> v2: - Updated commit message to include fix and moved test logs Testlogs: https://gist.github.com/AashvijShenai/9ea3e128ab29f703c2b6d988cfd0b82a --- meta-ti-bsp/recipes-security/optee/optee-os-ti-overrides.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)