diff mbox series

[master] conf: machine: k3: use ARMv8-A as base arch

Message ID 20241114140801.1964528-1-matthias.schiffer@ew.tq-group.com
State Rejected
Delegated to: Ryan Eatmon
Headers show
Series [master] conf: machine: k3: use ARMv8-A as base arch | expand

Commit Message

Matthias Schiffer Nov. 14, 2024, 2:08 p.m. UTC
All K3 SoCs are Cortex-A53/A72, so arch-armv8a.inc is a more appropriate
common base than the very generic arch-arm64.inc. arch-armv8a.inc defaults
to enable the CRC extension (DEFAULTTUNE = "armv8a-crc") and allows for
easy addition of the ARMv8 crypto extensions by setting the tune to
"armv8a-crc-crypto".

Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
---
 meta-ti-bsp/conf/machine/include/k3.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Matthias Schiffer Dec. 9, 2024, 9:38 a.m. UTC | #1
On Thu, 2024-11-14 at 15:08 +0100, Matthias Schiffer wrote:
> All K3 SoCs are Cortex-A53/A72, so arch-armv8a.inc is a more appropriate
> common base than the very generic arch-arm64.inc. arch-armv8a.inc defaults
> to enable the CRC extension (DEFAULTTUNE = "armv8a-crc") and allows for
> easy addition of the ARMv8 crypto extensions by setting the tune to
> "armv8a-crc-crypto".

Hi, any comments regarding this patch?

Best regards,
Matthias



> 
> Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
> ---
>  meta-ti-bsp/conf/machine/include/k3.inc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta-ti-bsp/conf/machine/include/k3.inc b/meta-ti-bsp/conf/machine/include/k3.inc
> index a296f64f..140564f7 100644
> --- a/meta-ti-bsp/conf/machine/include/k3.inc
> +++ b/meta-ti-bsp/conf/machine/include/k3.inc
> @@ -3,7 +3,7 @@
>  require conf/machine/include/ti-soc.inc
>  SOC_FAMILY:append = ":k3"
>  
> -require conf/machine/include/arm/arch-arm64.inc
> +require conf/machine/include/arm/arch-armv8a.inc
>  
>  require conf/machine/include/ti-bsp.inc
>
Denys Dmytriyenko Dec. 9, 2024, 3:59 p.m. UTC | #2
On Mon, Dec 09, 2024 at 10:38:56AM +0100, Matthias Schiffer via lists.yoctoproject.org wrote:
> On Thu, 2024-11-14 at 15:08 +0100, Matthias Schiffer wrote:
> > All K3 SoCs are Cortex-A53/A72, so arch-armv8a.inc is a more appropriate
> > common base than the very generic arch-arm64.inc. arch-armv8a.inc defaults
> > to enable the CRC extension (DEFAULTTUNE = "armv8a-crc") and allows for
> > easy addition of the ARMv8 crypto extensions by setting the tune to
> > "armv8a-crc-crypto".
> 
> Hi, any comments regarding this patch?

Matthias,

We've discussed this couple of weeks ago and decided to make a slightly 
different change that will also enable your use case as well.

Ryan got busy lately with master breakage, so I should probably send the 
change in for discussion.
Matthias Schiffer Jan. 16, 2025, 2:19 p.m. UTC | #3
On Mon, 2024-12-09 at 10:59 -0500, Denys Dmytriyenko wrote:
> 
> On Mon, Dec 09, 2024 at 10:38:56AM +0100, Matthias Schiffer via lists.yoctoproject.org wrote:
> > On Thu, 2024-11-14 at 15:08 +0100, Matthias Schiffer wrote:
> > > All K3 SoCs are Cortex-A53/A72, so arch-armv8a.inc is a more appropriate
> > > common base than the very generic arch-arm64.inc. arch-armv8a.inc defaults
> > > to enable the CRC extension (DEFAULTTUNE = "armv8a-crc") and allows for
> > > easy addition of the ARMv8 crypto extensions by setting the tune to
> > > "armv8a-crc-crypto".
> > 
> > Hi, any comments regarding this patch?
> 
> Matthias,
> 
> We've discussed this couple of weeks ago and decided to make a slightly 
> different change that will also enable your use case as well.
> 
> Ryan got busy lately with master breakage, so I should probably send the 
> change in for discussion.

Hi Denys,

I haven't seen the mentioned change yet, did you not send it or did I overlook
it?

Best,
Matthias



>
Denys Dmytriyenko Jan. 16, 2025, 9:01 p.m. UTC | #4
On Thu, Jan 16, 2025 at 03:19:29PM +0100, Matthias Schiffer wrote:
> On Mon, 2024-12-09 at 10:59 -0500, Denys Dmytriyenko wrote:
> > 
> > On Mon, Dec 09, 2024 at 10:38:56AM +0100, Matthias Schiffer via lists.yoctoproject.org wrote:
> > > On Thu, 2024-11-14 at 15:08 +0100, Matthias Schiffer wrote:
> > > > All K3 SoCs are Cortex-A53/A72, so arch-armv8a.inc is a more appropriate
> > > > common base than the very generic arch-arm64.inc. arch-armv8a.inc defaults
> > > > to enable the CRC extension (DEFAULTTUNE = "armv8a-crc") and allows for
> > > > easy addition of the ARMv8 crypto extensions by setting the tune to
> > > > "armv8a-crc-crypto".
> > > 
> > > Hi, any comments regarding this patch?
> > 
> > Matthias,
> > 
> > We've discussed this couple of weeks ago and decided to make a slightly 
> > different change that will also enable your use case as well.
> > 
> > Ryan got busy lately with master breakage, so I should probably send the 
> > change in for discussion.
> 
> Hi Denys,
> 
> I haven't seen the mentioned change yet, did you not send it or did I overlook
> it?

Matthias,

Thank you for the reminder - unfortunately it fell through the cracks due to 
the holidays and other engagements and distractions. I'll get to it shortly.
diff mbox series

Patch

diff --git a/meta-ti-bsp/conf/machine/include/k3.inc b/meta-ti-bsp/conf/machine/include/k3.inc
index a296f64f..140564f7 100644
--- a/meta-ti-bsp/conf/machine/include/k3.inc
+++ b/meta-ti-bsp/conf/machine/include/k3.inc
@@ -3,7 +3,7 @@ 
 require conf/machine/include/ti-soc.inc
 SOC_FAMILY:append = ":k3"
 
-require conf/machine/include/arm/arch-arm64.inc
+require conf/machine/include/arm/arch-armv8a.inc
 
 require conf/machine/include/ti-bsp.inc