| Message ID | 20240718182421.13591-1-reatmon@ti.com |
|---|---|
| State | Superseded |
| Delegated to: | Ryan Eatmon |
| Headers | show |
| Series | [meta-ti,master/scarthgap] linux: Manage the kernel patches using the BSP system | expand |
Hi Ryan, On 18/07/24 23:54, Ryan Eatmon via lists.yoctoproject.org wrote: > Applying the patches to all kernels is not going to work. Each kernel > might need different patches to address reproducibility issues. > Signed-off-by: Ryan Eatmon <reatmon@ ti. com> --- > meta-ti-bsp/recipes-kernel/linux/ti-kernel. inc | 12 > ZjQcmQRYFpfptBannerStart > This message was sent from outside of Texas Instruments. > Do not click links or open attachments unless you recognize the source > of this email and know the content is safe. If you wish to report this > message to IT Security, please forward the message as an attachment to > phishing@list.ti.com > ZjQcmQRYFpfptBannerEnd > Applying the patches to all kernels is not going to work. Each kernel > might need different patches to address reproducibility issues. > > Signed-off-by: Ryan Eatmon <reatmon@ti.com> > --- > meta-ti-bsp/recipes-kernel/linux/ti-kernel.inc | 12 ++++++++---- > 1 file changed, 8 insertions(+), 4 deletions(-) > > diff --git a/meta-ti-bsp/recipes-kernel/linux/ti-kernel.inc b/meta-ti-bsp/recipes-kernel/linux/ti-kernel.inc > index f24fbe51..8bb30d40 100644 > --- a/meta-ti-bsp/recipes-kernel/linux/ti-kernel.inc > +++ b/meta-ti-bsp/recipes-kernel/linux/ti-kernel.inc > @@ -13,8 +13,12 @@ EXTRA_DTC_ARGS += "${@get_extra_dtc_args(d)}" > KERNEL_DTBDEST = "${KERNEL_IMAGEDEST}/dtb" > KERNEL_DTBVENDORED = "1" > > -SRC_URI:append = " \ > -file://0001-lib-build_OID_registry-fix-reproducibility-issues.patch \ > -file://0001-vt-conmakehash-improve-reproducibility.patch \ > -file://0001-pnmtologo-use-relocatable-file-name.patch \ > +KERNEL_PATCHES = "" > + > +KERNEL_PATCHES:bsp-ti-6.6 = " \ > + file://0001-lib-build_OID_registry-fix-reproducibility-issues.patch \ > + file://0001-vt-conmakehash-improve-reproducibility.patch \ > + file://0001-pnmtologo-use-relocatable-file-name.patch \ > " The patch title says [master/scarthgap] but I don't see these patches in scarthgap getting applied [1] Additionally the patches itself are missing in scarthgap branch [2] Are they applicable to scarthgap? [1]: https://git.ti.com/cgit/arago-project/meta-ti/tree/meta-ti-bsp/recipes-kernel/linux/ti-kernel.inc?h=scarthgap [2]: https://git.ti.com/cgit/arago-project/meta-ti/tree/meta-ti-bsp/recipes-kernel/linux/files?h=scarthgap > + > +SRC_URI:append = " ${KERNEL_PATCHES} " > -- > 2.17.1 > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#17888): https://urldefense.com/v3/__https://lists.yoctoproject.org/g/meta-ti/message/17888__;!!G3vK!T7Z2BA-Nk4Deu1oupZmJqJKhIHqoFGbruxASymNM3q5ISnIEShmzH_rXiNv1sd9t5IPUFAeq1MVZGvxkGY-um1_ZJzYlEx9Q0w$ > Mute This Topic: https://urldefense.com/v3/__https://lists.yoctoproject.org/mt/107421992/7030289__;!!G3vK!T7Z2BA-Nk4Deu1oupZmJqJKhIHqoFGbruxASymNM3q5ISnIEShmzH_rXiNv1sd9t5IPUFAeq1MVZGvxkGY-um1_ZJzYHEViZow$ > Group Owner: meta-ti+owner@lists.yoctoproject.org > Unsubscribe: https://urldefense.com/v3/__https://lists.yoctoproject.org/g/meta-ti/unsub__;!!G3vK!T7Z2BA-Nk4Deu1oupZmJqJKhIHqoFGbruxASymNM3q5ISnIEShmzH_rXiNv1sd9t5IPUFAeq1MVZGvxkGY-um1_ZJzb2hPAKdA$ [c-shilwant@ti.com] > -=-=-=-=-=-=-=-=-=-=-=- >
On 7/18/2024 11:27 PM, Chirag Shilwant wrote: > Hi Ryan, > On 18/07/24 23:54, Ryan Eatmon via lists.yoctoproject.org wrote: >> Applying the patches to all kernels is not going to work. Each kernel >> might need different patches to address reproducibility issues. >> Signed-off-by: Ryan Eatmon <reatmon@ ti. com> --- >> meta-ti-bsp/recipes-kernel/linux/ti-kernel. inc | 12 >> ZjQcmQRYFpfptBannerStart >> This message was sent from outside of Texas Instruments. >> Do not click links or open attachments unless you recognize the source >> of this email and know the content is safe. If you wish to report this >> message to IT Security, please forward the message as an attachment to >> phishing@list.ti.com >> ZjQcmQRYFpfptBannerEnd >> Applying the patches to all kernels is not going to work. Each kernel >> might need different patches to address reproducibility issues. >> >> Signed-off-by: Ryan Eatmon <reatmon@ti.com> >> --- >> meta-ti-bsp/recipes-kernel/linux/ti-kernel.inc | 12 ++++++++---- >> 1 file changed, 8 insertions(+), 4 deletions(-) >> >> diff --git a/meta-ti-bsp/recipes-kernel/linux/ti-kernel.inc >> b/meta-ti-bsp/recipes-kernel/linux/ti-kernel.inc >> index f24fbe51..8bb30d40 100644 >> --- a/meta-ti-bsp/recipes-kernel/linux/ti-kernel.inc >> +++ b/meta-ti-bsp/recipes-kernel/linux/ti-kernel.inc >> @@ -13,8 +13,12 @@ EXTRA_DTC_ARGS += "${@get_extra_dtc_args(d)}" >> KERNEL_DTBDEST = "${KERNEL_IMAGEDEST}/dtb" >> KERNEL_DTBVENDORED = "1" >> -SRC_URI:append = " \ >> -file://0001-lib-build_OID_registry-fix-reproducibility-issues.patch \ >> -file://0001-vt-conmakehash-improve-reproducibility.patch \ >> -file://0001-pnmtologo-use-relocatable-file-name.patch \ >> +KERNEL_PATCHES = "" >> + >> +KERNEL_PATCHES:bsp-ti-6.6 = " \ >> + >> file://0001-lib-build_OID_registry-fix-reproducibility-issues.patch \ >> + file://0001-vt-conmakehash-improve-reproducibility.patch \ >> + file://0001-pnmtologo-use-relocatable-file-name.patch \ >> " > > > > The patch title says [master/scarthgap] but I don't see these patches in > scarthgap getting applied I'll look into it. I've been a little preoccupied with master this week, but I'll take a look today. [1] > Additionally the patches itself are missing in scarthgap branch [2] > Are they applicable to scarthgap? Yes, they are. > [1]: > https://git.ti.com/cgit/arago-project/meta-ti/tree/meta-ti-bsp/recipes-kernel/linux/ti-kernel.inc?h=scarthgap > > [2]: > https://git.ti.com/cgit/arago-project/meta-ti/tree/meta-ti-bsp/recipes-kernel/linux/files?h=scarthgap > > > >> + >> +SRC_URI:append = " ${KERNEL_PATCHES} " >> -- >> 2.17.1 >> >> >> -=-=-=-=-=-=-=-=-=-=-=- >> Links: You receive all messages sent to this group. >> View/Reply Online (#17888): >> https://urldefense.com/v3/__https://lists.yoctoproject.org/g/meta-ti/message/17888__;!!G3vK!T7Z2BA-Nk4Deu1oupZmJqJKhIHqoFGbruxASymNM3q5ISnIEShmzH_rXiNv1sd9t5IPUFAeq1MVZGvxkGY-um1_ZJzYlEx9Q0w$ >> Mute This Topic: >> https://urldefense.com/v3/__https://lists.yoctoproject.org/mt/107421992/7030289__;!!G3vK!T7Z2BA-Nk4Deu1oupZmJqJKhIHqoFGbruxASymNM3q5ISnIEShmzH_rXiNv1sd9t5IPUFAeq1MVZGvxkGY-um1_ZJzYHEViZow$ >> Group Owner: meta-ti+owner@lists.yoctoproject.org >> Unsubscribe: >> https://urldefense.com/v3/__https://lists.yoctoproject.org/g/meta-ti/unsub__;!!G3vK!T7Z2BA-Nk4Deu1oupZmJqJKhIHqoFGbruxASymNM3q5ISnIEShmzH_rXiNv1sd9t5IPUFAeq1MVZGvxkGY-um1_ZJzb2hPAKdA$ [c-shilwant@ti.com] >> -=-=-=-=-=-=-=-=-=-=-=- >>
On 7/19/2024 8:29 AM, Ryan Eatmon via lists.yoctoproject.org wrote: > > > On 7/18/2024 11:27 PM, Chirag Shilwant wrote: >> Hi Ryan, >> On 18/07/24 23:54, Ryan Eatmon via lists.yoctoproject.org wrote: >>> Applying the patches to all kernels is not going to work. Each kernel >>> might need different patches to address reproducibility issues. >>> Signed-off-by: Ryan Eatmon <reatmon@ ti. com> --- >>> meta-ti-bsp/recipes-kernel/linux/ti-kernel. inc | 12 >>> ZjQcmQRYFpfptBannerStart >>> This message was sent from outside of Texas Instruments. >>> Do not click links or open attachments unless you recognize the >>> source of this email and know the content is safe. If you wish to >>> report this message to IT Security, please forward the message as an >>> attachment to phishing@list.ti.com >>> ZjQcmQRYFpfptBannerEnd >>> Applying the patches to all kernels is not going to work. Each kernel >>> might need different patches to address reproducibility issues. >>> >>> Signed-off-by: Ryan Eatmon <reatmon@ti.com> >>> --- >>> meta-ti-bsp/recipes-kernel/linux/ti-kernel.inc | 12 ++++++++---- >>> 1 file changed, 8 insertions(+), 4 deletions(-) >>> >>> diff --git a/meta-ti-bsp/recipes-kernel/linux/ti-kernel.inc >>> b/meta-ti-bsp/recipes-kernel/linux/ti-kernel.inc >>> index f24fbe51..8bb30d40 100644 >>> --- a/meta-ti-bsp/recipes-kernel/linux/ti-kernel.inc >>> +++ b/meta-ti-bsp/recipes-kernel/linux/ti-kernel.inc >>> @@ -13,8 +13,12 @@ EXTRA_DTC_ARGS += "${@get_extra_dtc_args(d)}" >>> KERNEL_DTBDEST = "${KERNEL_IMAGEDEST}/dtb" >>> KERNEL_DTBVENDORED = "1" >>> -SRC_URI:append = " \ >>> -file://0001-lib-build_OID_registry-fix-reproducibility-issues.patch \ >>> -file://0001-vt-conmakehash-improve-reproducibility.patch \ >>> -file://0001-pnmtologo-use-relocatable-file-name.patch \ >>> +KERNEL_PATCHES = "" >>> + >>> +KERNEL_PATCHES:bsp-ti-6.6 = " \ This is wrong. Should be bsp-ti-6_6. Still not used to the name scheme for this. I'll send a v2. >>> + file://0001-lib-build_OID_registry-fix-reproducibility-issues.patch \ >>> + file://0001-vt-conmakehash-improve-reproducibility.patch \ >>> + file://0001-pnmtologo-use-relocatable-file-name.patch \ >>> " >> >> >> >> The patch title says [master/scarthgap] but I don't see these patches >> in scarthgap getting applied > > I'll look into it. I've been a little preoccupied with master this > week, but I'll take a look today. > > > [1] >> Additionally the patches itself are missing in scarthgap branch [2] >> Are they applicable to scarthgap? > > Yes, they are. > > >> [1]: >> https://git.ti.com/cgit/arago-project/meta-ti/tree/meta-ti-bsp/recipes-kernel/linux/ti-kernel.inc?h=scarthgap >> >> [2]: >> https://git.ti.com/cgit/arago-project/meta-ti/tree/meta-ti-bsp/recipes-kernel/linux/files?h=scarthgap >> >> >> >>> + >>> +SRC_URI:append = " ${KERNEL_PATCHES} " >>> -- >>> 2.17.1 >>> >>> >>> >>> > > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#17890): https://lists.yoctoproject.org/g/meta-ti/message/17890 > Mute This Topic: https://lists.yoctoproject.org/mt/107421992/6551054 > Group Owner: meta-ti+owner@lists.yoctoproject.org > Unsubscribe: https://lists.yoctoproject.org/g/meta-ti/unsub [reatmon@ti.com] > -=-=-=-=-=-=-=-=-=-=-=- >
On Fri, Jul 19, 2024 at 09:18:14AM -0500, Ryan Eatmon via lists.yoctoproject.org wrote: > > > On 7/19/2024 8:29 AM, Ryan Eatmon via lists.yoctoproject.org wrote: > > > > > >On 7/18/2024 11:27 PM, Chirag Shilwant wrote: > >>Hi Ryan, > >>On 18/07/24 23:54, Ryan Eatmon via lists.yoctoproject.org wrote: > >>>Applying the patches to all kernels is not going to work. Each > >>>kernel might need different patches to address reproducibility > >>>issues. Signed-off-by: Ryan Eatmon <reatmon@ ti. com> --- > >>>meta-ti-bsp/recipes-kernel/linux/ti-kernel. inc | 12 > >>>ZjQcmQRYFpfptBannerStart > >>>This message was sent from outside of Texas Instruments. > >>>Do not click links or open attachments unless you recognize > >>>the source of this email and know the content is safe. If you > >>>wish to report this message to IT Security, please forward the > >>>message as an attachment to phishing@list.ti.com > >>>ZjQcmQRYFpfptBannerEnd > >>>Applying the patches to all kernels is not going to work. Each kernel > >>>might need different patches to address reproducibility issues. > >>> > >>>Signed-off-by: Ryan Eatmon <reatmon@ti.com> > >>>--- > >>> meta-ti-bsp/recipes-kernel/linux/ti-kernel.inc | 12 ++++++++---- > >>> 1 file changed, 8 insertions(+), 4 deletions(-) > >>> > >>>diff --git a/meta-ti-bsp/recipes-kernel/linux/ti-kernel.inc > >>>b/meta-ti-bsp/recipes-kernel/linux/ti-kernel.inc > >>>index f24fbe51..8bb30d40 100644 > >>>--- a/meta-ti-bsp/recipes-kernel/linux/ti-kernel.inc > >>>+++ b/meta-ti-bsp/recipes-kernel/linux/ti-kernel.inc > >>>@@ -13,8 +13,12 @@ EXTRA_DTC_ARGS += "${@get_extra_dtc_args(d)}" > >>> KERNEL_DTBDEST = "${KERNEL_IMAGEDEST}/dtb" > >>> KERNEL_DTBVENDORED = "1" > >>>-SRC_URI:append = " \ > >>>-file://0001-lib-build_OID_registry-fix-reproducibility-issues.patch \ > >>>-file://0001-vt-conmakehash-improve-reproducibility.patch \ > >>>-file://0001-pnmtologo-use-relocatable-file-name.patch \ > >>>+KERNEL_PATCHES = "" > >>>+ > >>>+KERNEL_PATCHES:bsp-ti-6.6 = " \ > > This is wrong. Should be bsp-ti-6_6. Still not used to the name > scheme for this. I'll send a v2. Yeah, this is an override, hence the number of special characters is limited - had to replace dot with underscore... > >>>+ file://0001-lib-build_OID_registry-fix-reproducibility-issues.patch \ > >>>+ file://0001-vt-conmakehash-improve-reproducibility.patch \ > >>>+ file://0001-pnmtologo-use-relocatable-file-name.patch \ > >>> " > >> > >> > >> > >>The patch title says [master/scarthgap] but I don't see these > >>patches in scarthgap getting applied > > > >I'll look into it. I've been a little preoccupied with master > >this week, but I'll take a look today. > > > > > > [1] > >>Additionally the patches itself are missing in scarthgap branch [2] > >>Are they applicable to scarthgap? > > > >Yes, they are. > > > > > >>[1]: https://git.ti.com/cgit/arago-project/meta-ti/tree/meta-ti-bsp/recipes-kernel/linux/ti-kernel.inc?h=scarthgap > >> > >>[2]: https://git.ti.com/cgit/arago-project/meta-ti/tree/meta-ti-bsp/recipes-kernel/linux/files?h=scarthgap > >> > >> > >> > >>>+ > >>>+SRC_URI:append = " ${KERNEL_PATCHES} " > >>>-- > >>>2.17.1
diff --git a/meta-ti-bsp/recipes-kernel/linux/ti-kernel.inc b/meta-ti-bsp/recipes-kernel/linux/ti-kernel.inc index f24fbe51..8bb30d40 100644 --- a/meta-ti-bsp/recipes-kernel/linux/ti-kernel.inc +++ b/meta-ti-bsp/recipes-kernel/linux/ti-kernel.inc @@ -13,8 +13,12 @@ EXTRA_DTC_ARGS += "${@get_extra_dtc_args(d)}" KERNEL_DTBDEST = "${KERNEL_IMAGEDEST}/dtb" KERNEL_DTBVENDORED = "1" -SRC_URI:append = " \ -file://0001-lib-build_OID_registry-fix-reproducibility-issues.patch \ -file://0001-vt-conmakehash-improve-reproducibility.patch \ -file://0001-pnmtologo-use-relocatable-file-name.patch \ +KERNEL_PATCHES = "" + +KERNEL_PATCHES:bsp-ti-6.6 = " \ + file://0001-lib-build_OID_registry-fix-reproducibility-issues.patch \ + file://0001-vt-conmakehash-improve-reproducibility.patch \ + file://0001-pnmtologo-use-relocatable-file-name.patch \ " + +SRC_URI:append = " ${KERNEL_PATCHES} "
Applying the patches to all kernels is not going to work. Each kernel might need different patches to address reproducibility issues. Signed-off-by: Ryan Eatmon <reatmon@ti.com> --- meta-ti-bsp/recipes-kernel/linux/ti-kernel.inc | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-)