diff mbox series

[meta-ti,master/scarthgap,3/3] meta-ti-bsp: j742s2: add Rogue GPU driver to machine definition

Message ID 20240717133614.787998-4-a-limaye@ti.com
State Superseded
Delegated to: Ryan Eatmon
Headers show
Series J742S2 support | expand

Commit Message

Aniket Limaye July 17, 2024, 1:36 p.m. UTC
Add ti-img-rogue-driver as the preferred provider and enable the gpu
driver in the image.

Signed-off-by: Aniket Limaye <a-limaye@ti.com>
---
 meta-ti-bsp/conf/machine/include/j742s2.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ryan Eatmon July 17, 2024, 1:41 p.m. UTC | #1
On 7/17/2024 8:36 AM, Aniket Limaye wrote:
> Add ti-img-rogue-driver as the preferred provider and enable the gpu
> driver in the image.
> 
> Signed-off-by: Aniket Limaye <a-limaye@ti.com>
> ---
>   meta-ti-bsp/conf/machine/include/j742s2.inc | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta-ti-bsp/conf/machine/include/j742s2.inc b/meta-ti-bsp/conf/machine/include/j742s2.inc
> index 41f3a73d..60d91f16 100644
> --- a/meta-ti-bsp/conf/machine/include/j742s2.inc
> +++ b/meta-ti-bsp/conf/machine/include/j742s2.inc
> @@ -4,7 +4,7 @@ SOC_FAMILY:append = ":j742s2"
>   MACHINE_FEATURES += "screen gpu"
>   
>   require conf/machine/include/mesa-pvr.inc
> -PREFERRED_PROVIDER_virtual/gpudriver ?= ""
> +PREFERRED_PROVIDER_virtual/gpudriver ?= "ti-img-rogue-driver"

NAK.  With the new BSP support this should be:

PREFERRED_PROVIDER_virtual/gpudriver ?= "${BSP_ROGUE_DRIVER_PROVIDER}"


>   # Default tiboot3.bin on J742S2 is for HS-FS
>   IMAGE_BOOT_FILES += "tiboot3-j742s2-hs-fs-evm.bin"
Aniket Limaye July 18, 2024, 8:12 a.m. UTC | #2
On 7/17/2024 7:11 PM, Ryan Eatmon wrote:
>
>
> On 7/17/2024 8:36 AM, Aniket Limaye wrote:
>> Add ti-img-rogue-driver as the preferred provider and enable the gpu
>> driver in the image.
>>
>> Signed-off-by: Aniket Limaye <a-limaye@ti.com>
>> ---
>>   meta-ti-bsp/conf/machine/include/j742s2.inc | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta-ti-bsp/conf/machine/include/j742s2.inc 
>> b/meta-ti-bsp/conf/machine/include/j742s2.inc
>> index 41f3a73d..60d91f16 100644
>> --- a/meta-ti-bsp/conf/machine/include/j742s2.inc
>> +++ b/meta-ti-bsp/conf/machine/include/j742s2.inc
>> @@ -4,7 +4,7 @@ SOC_FAMILY:append = ":j742s2"
>>   MACHINE_FEATURES += "screen gpu"
>>     require conf/machine/include/mesa-pvr.inc
>> -PREFERRED_PROVIDER_virtual/gpudriver ?= ""
>> +PREFERRED_PROVIDER_virtual/gpudriver ?= "ti-img-rogue-driver"
>
> NAK.  With the new BSP support this should be:
>
> PREFERRED_PROVIDER_virtual/gpudriver ?= "${BSP_ROGUE_DRIVER_PROVIDER}"
>
Right.. sent a v2 with the fix!
https://lists.yoctoproject.org/g/meta-ti/message/17882

Thanks,
Aniket

>
>>   # Default tiboot3.bin on J742S2 is for HS-FS
>>   IMAGE_BOOT_FILES += "tiboot3-j742s2-hs-fs-evm.bin"
>
diff mbox series

Patch

diff --git a/meta-ti-bsp/conf/machine/include/j742s2.inc b/meta-ti-bsp/conf/machine/include/j742s2.inc
index 41f3a73d..60d91f16 100644
--- a/meta-ti-bsp/conf/machine/include/j742s2.inc
+++ b/meta-ti-bsp/conf/machine/include/j742s2.inc
@@ -4,7 +4,7 @@  SOC_FAMILY:append = ":j742s2"
 MACHINE_FEATURES += "screen gpu"
 
 require conf/machine/include/mesa-pvr.inc
-PREFERRED_PROVIDER_virtual/gpudriver ?= ""
+PREFERRED_PROVIDER_virtual/gpudriver ?= "ti-img-rogue-driver"
 
 # Default tiboot3.bin on J742S2 is for HS-FS
 IMAGE_BOOT_FILES += "tiboot3-j742s2-hs-fs-evm.bin"