diff mbox series

[meta-ti,master/scarthgap] ti-img-rogue-driver_23.3.6512818: gcc 14 compat

Message ID 20240621201533.1531567-2-rs@ti.com
State Superseded
Delegated to: Ryan Eatmon
Headers show
Series [meta-ti,master/scarthgap] ti-img-rogue-driver_23.3.6512818: gcc 14 compat | expand

Commit Message

Randolph Sapp June 21, 2024, 8:15 p.m. UTC
From: Randolph Sapp <rs@ti.com>

Bump this recipe to add a change to help with GCC 14 compatibility in
the check-cc script used to check compiler flags before use.

Also ports some of the patches that were added to the kirkstone branch
post creation of what was supposed to be a temporary scarthgap branch.

Signed-off-by: Randolph Sapp <rs@ti.com>
---

Sorry for the delay. Needed to run some tests since there were some other
patches that had not been ported to the intermediary branch.

 .../powervr-drivers/ti-img-rogue-driver_23.3.6512818.bb         | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Max Krummenacher June 21, 2024, 10:41 p.m. UTC | #1
Hello Randolph

Am Freitag, dem 21.06.2024 um 15:15 -0500 schrieb rs@ti.com:
> From: Randolph Sapp <rs@ti.com>
> 
> Bump this recipe to add a change to help with GCC 14 compatibility in
> the check-cc script used to check compiler flags before use.
> 
> Also ports some of the patches that were added to the kirkstone branch
> post creation of what was supposed to be a temporary scarthgap branch.
> 
> Signed-off-by: Randolph Sapp <rs@ti.com>
> ---
> 
> Sorry for the delay. Needed to run some tests since there were some other
> patches that had not been ported to the intermediary branch.
> 
>  .../powervr-drivers/ti-img-rogue-driver_23.3.6512818.bb         | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta-ti-bsp/recipes-bsp/powervr-drivers/ti-img-rogue-driver_23.3.6512818.bb b/meta-ti-bsp/recipes-bsp/powervr-drivers/ti-img-rogue-driver_23.3.6512818.bb
> index 34c22cb2..7fbb0524 100644
> --- a/meta-ti-bsp/recipes-bsp/powervr-drivers/ti-img-rogue-driver_23.3.6512818.bb
> +++ b/meta-ti-bsp/recipes-bsp/powervr-drivers/ti-img-rogue-driver_23.3.6512818.bb
> @@ -19,7 +19,7 @@ SRC_URI = "git://git.ti.com/git/graphics/ti-img-rogue-driver.git;protocol=https;
>  
>  S = "${WORKDIR}/git"
>  
> -SRCREV = "2f409b4dd2540e896b54bff02219d4fc51129b81"
> +SRCREV = "97727f8606ca984527a470252c0bc3ada1bb3f92"

This SHA is not (yet ?) in the repository.
I tried with latest HEAD, i.e. 7b04fd4a24fe. That builds fine in my setup. Thanks for the quick fix.

Max

>  
>  TARGET_PRODUCT:j721e = "j721e_linux"
>  TARGET_PRODUCT:j721s2 = "j721s2_linux"
Randolph Sapp June 21, 2024, 11:41 p.m. UTC | #2
On Fri Jun 21, 2024 at 5:41 PM CDT, Max Krummenacher wrote:
> Hello Randolph
>
> Am Freitag, dem 21.06.2024 um 15:15 -0500 schrieb rs@ti.com:
> > From: Randolph Sapp <rs@ti.com>
> > 
> > Bump this recipe to add a change to help with GCC 14 compatibility in
> > the check-cc script used to check compiler flags before use.
> > 
> > Also ports some of the patches that were added to the kirkstone branch
> > post creation of what was supposed to be a temporary scarthgap branch.
> > 
> > Signed-off-by: Randolph Sapp <rs@ti.com>
> > ---
> > 
> > Sorry for the delay. Needed to run some tests since there were some other
> > patches that had not been ported to the intermediary branch.
> > 
> >  .../powervr-drivers/ti-img-rogue-driver_23.3.6512818.bb         | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/meta-ti-bsp/recipes-bsp/powervr-drivers/ti-img-rogue-driver_23.3.6512818.bb b/meta-ti-bsp/recipes-bsp/powervr-drivers/ti-img-rogue-driver_23.3.6512818.bb
> > index 34c22cb2..7fbb0524 100644
> > --- a/meta-ti-bsp/recipes-bsp/powervr-drivers/ti-img-rogue-driver_23.3.6512818.bb
> > +++ b/meta-ti-bsp/recipes-bsp/powervr-drivers/ti-img-rogue-driver_23.3.6512818.bb
> > @@ -19,7 +19,7 @@ SRC_URI = "git://git.ti.com/git/graphics/ti-img-rogue-driver.git;protocol=https;
> >  
> >  S = "${WORKDIR}/git"
> >  
> > -SRCREV = "2f409b4dd2540e896b54bff02219d4fc51129b81"
> > +SRCREV = "97727f8606ca984527a470252c0bc3ada1bb3f92"
>
> This SHA is not (yet ?) in the repository.
> I tried with latest HEAD, i.e. 7b04fd4a24fe. That builds fine in my setup. Thanks for the quick fix.
>
> Max

Hold on. Just realized the bsp provider logic that's supposed to be selecting
this recipe thinks this is a compatible driver for kernel 6.1. It's not.

This branch was an intermediary branch for kernel 6.6. There were dt changes
made for AM62 that make it incompatible. Have to update the old kirkstone branch
and reset this recipe to point at that.

Thankfully that means I can finally delete the intermediary 6.6-23.3 branch
since that's not officially supported by anyone...

- Randolph

> >  
> >  TARGET_PRODUCT:j721e = "j721e_linux"
> >  TARGET_PRODUCT:j721s2 = "j721s2_linux"
diff mbox series

Patch

diff --git a/meta-ti-bsp/recipes-bsp/powervr-drivers/ti-img-rogue-driver_23.3.6512818.bb b/meta-ti-bsp/recipes-bsp/powervr-drivers/ti-img-rogue-driver_23.3.6512818.bb
index 34c22cb2..7fbb0524 100644
--- a/meta-ti-bsp/recipes-bsp/powervr-drivers/ti-img-rogue-driver_23.3.6512818.bb
+++ b/meta-ti-bsp/recipes-bsp/powervr-drivers/ti-img-rogue-driver_23.3.6512818.bb
@@ -19,7 +19,7 @@  SRC_URI = "git://git.ti.com/git/graphics/ti-img-rogue-driver.git;protocol=https;
 
 S = "${WORKDIR}/git"
 
-SRCREV = "2f409b4dd2540e896b54bff02219d4fc51129b81"
+SRCREV = "97727f8606ca984527a470252c0bc3ada1bb3f92"
 
 TARGET_PRODUCT:j721e = "j721e_linux"
 TARGET_PRODUCT:j721s2 = "j721s2_linux"