| Message ID | 20240603195515.1089534-1-rs@ti.com |
|---|---|
| State | Superseded |
| Delegated to: | Ryan Eatmon |
| Headers | show |
| Series | [meta-ti,master/scarthgap] gitignore: lift some sane defaults from others | expand |
On Mon, Jun 03, 2024 at 02:55:15PM -0500, rs@ti.com wrote: > From: Randolph Sapp <rs@ti.com> > > Lift the common parts of the top level gitignore from oe-core and > meta-openembedded. This masks out temporary python files, intermediate > artifacts, and patches at the root of the project. FWIW, this is a matter of a personal preference, e.g. I don't like when git ignores, essentially hiding patches in the top directory. I do prefer them to be visible with "git status". But I'll leave it to Ryan. > Signed-off-by: Randolph Sapp <rs@ti.com> > --- > .gitignore | 7 +++++++ > 1 file changed, 7 insertions(+) > create mode 100644 .gitignore > > diff --git a/.gitignore b/.gitignore > new file mode 100644 > index 00000000..c01df45e > --- /dev/null > +++ b/.gitignore > @@ -0,0 +1,7 @@ > +*.pyc > +*.pyo > +/*.patch > +*.swp > +*.orig > +*.rej > +*~ > -- > 2.45.1
On 6/4/2024 2:12 PM, Denys Dmytriyenko wrote: > On Mon, Jun 03, 2024 at 02:55:15PM -0500, rs@ti.com wrote: >> From: Randolph Sapp <rs@ti.com> >> >> Lift the common parts of the top level gitignore from oe-core and >> meta-openembedded. This masks out temporary python files, intermediate >> artifacts, and patches at the root of the project. > > FWIW, this is a matter of a personal preference, e.g. I don't like when > git ignores, essentially hiding patches in the top directory. I do prefer > them to be visible with "git status". But I'll leave it to Ryan. Yeah. I was testing it, but I was also thinking the same thing and trying to decide if I wanted to take them. Maybe a reduced set might good. Like leave the patches, but hide the temp files and what not? What are your thoughts on that? Just remove the *.patch from the list below? >> Signed-off-by: Randolph Sapp <rs@ti.com> >> --- >> .gitignore | 7 +++++++ >> 1 file changed, 7 insertions(+) >> create mode 100644 .gitignore >> >> diff --git a/.gitignore b/.gitignore >> new file mode 100644 >> index 00000000..c01df45e >> --- /dev/null >> +++ b/.gitignore >> @@ -0,0 +1,7 @@ >> +*.pyc >> +*.pyo >> +/*.patch >> +*.swp >> +*.orig >> +*.rej >> +*~ >> -- >> 2.45.1
On Tue Jun 4, 2024 at 5:15 PM CDT, Ryan Eatmon wrote: > > > On 6/4/2024 2:12 PM, Denys Dmytriyenko wrote: > > On Mon, Jun 03, 2024 at 02:55:15PM -0500, rs@ti.com wrote: > >> From: Randolph Sapp <rs@ti.com> > >> > >> Lift the common parts of the top level gitignore from oe-core and > >> meta-openembedded. This masks out temporary python files, intermediate > >> artifacts, and patches at the root of the project. > > > > FWIW, this is a matter of a personal preference, e.g. I don't like when > > git ignores, essentially hiding patches in the top directory. I do prefer > > them to be visible with "git status". But I'll leave it to Ryan. > > Yeah. I was testing it, but I was also thinking the same thing and > trying to decide if I wanted to take them. Maybe a reduced set might > good. Like leave the patches, but hide the temp files and what not? > What are your thoughts on that? Just remove the *.patch from the list > below? Up to you guys. I just noticed the different behavior in this layer and wanted to get us more in sync with core. > >> Signed-off-by: Randolph Sapp <rs@ti.com> > >> --- > >> .gitignore | 7 +++++++ > >> 1 file changed, 7 insertions(+) > >> create mode 100644 .gitignore > >> > >> diff --git a/.gitignore b/.gitignore > >> new file mode 100644 > >> index 00000000..c01df45e > >> --- /dev/null > >> +++ b/.gitignore > >> @@ -0,0 +1,7 @@ > >> +*.pyc > >> +*.pyo > >> +/*.patch > >> +*.swp > >> +*.orig > >> +*.rej > >> +*~ > >> -- > >> 2.45.1
On 6/5/2024 11:07 AM, Randolph Sapp wrote: > On Tue Jun 4, 2024 at 5:15 PM CDT, Ryan Eatmon wrote: >> >> >> On 6/4/2024 2:12 PM, Denys Dmytriyenko wrote: >>> On Mon, Jun 03, 2024 at 02:55:15PM -0500, rs@ti.com wrote: >>>> From: Randolph Sapp <rs@ti.com> >>>> >>>> Lift the common parts of the top level gitignore from oe-core and >>>> meta-openembedded. This masks out temporary python files, intermediate >>>> artifacts, and patches at the root of the project. >>> >>> FWIW, this is a matter of a personal preference, e.g. I don't like when >>> git ignores, essentially hiding patches in the top directory. I do prefer >>> them to be visible with "git status". But I'll leave it to Ryan. >> >> Yeah. I was testing it, but I was also thinking the same thing and >> trying to decide if I wanted to take them. Maybe a reduced set might >> good. Like leave the patches, but hide the temp files and what not? >> What are your thoughts on that? Just remove the *.patch from the list >> below? > > Up to you guys. I just noticed the different behavior in this layer and wanted > to get us more in sync with core. I say remove the patches and submit a v2. >>>> Signed-off-by: Randolph Sapp <rs@ti.com> >>>> --- >>>> .gitignore | 7 +++++++ >>>> 1 file changed, 7 insertions(+) >>>> create mode 100644 .gitignore >>>> >>>> diff --git a/.gitignore b/.gitignore >>>> new file mode 100644 >>>> index 00000000..c01df45e >>>> --- /dev/null >>>> +++ b/.gitignore >>>> @@ -0,0 +1,7 @@ >>>> +*.pyc >>>> +*.pyo >>>> +/*.patch >>>> +*.swp >>>> +*.orig >>>> +*.rej >>>> +*~ >>>> -- >>>> 2.45.1 >
diff --git a/.gitignore b/.gitignore new file mode 100644 index 00000000..c01df45e --- /dev/null +++ b/.gitignore @@ -0,0 +1,7 @@ +*.pyc +*.pyo +/*.patch +*.swp +*.orig +*.rej +*~