diff mbox series

[v4] optee-os: Enable OP-TEE TRNG in AM62X and AM62PX

Message ID 20231108-wip-enable-trng-v4-1-69499e0cd53a@ti.com
State Superseded
Delegated to: Ryan Eatmon
Headers show
Series [v4] optee-os: Enable OP-TEE TRNG in AM62X and AM62PX | expand

Commit Message

Kamlesh Gurudasani Nov. 8, 2023, 3:17 p.m. UTC
Enable TRNG in AM62X and AM62PX, as bugs related to TRNG has been fixed now.

TF-A fix:
https://git.trustedfirmware.org/TF-A/trusted-firmware-a.git/commit/?id=d7a7135d32a8c7da004c0c19b75bd4e2813f9759

OP-TEE fix:
https://github.com/OP-TEE/optee_os/commit/e313f4765fd0478bb66985827441411793433773

Signed-off-by: Kamlesh Gurudasani <kamlesh@ti.com>
---
Changes in V4:
-rebase on kirkstone-wip

Changes in V3:
-updated commit title and message

Changes in V2:
-updated commit message
-included changes for AM62p
---
 meta-ti-bsp/recipes-security/optee/optee-os-ti-overrides.inc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)


---
base-commit: 578823721ebf23485e7cfaaebc6146145996faa2
change-id: 20231108-wip-enable-trng-e93bf6831e47

Best regards,

Comments

Bajjuri, Praneeth Nov. 13, 2023, 11:59 p.m. UTC | #1
On 11/8/2023 9:17 AM, Kamlesh Gurudasani wrote:
> Enable TRNG in AM62X and AM62PX, as bugs related to TRNG has been fixed now.
> 
> TF-A fix:
> https://git.trustedfirmware.org/TF-A/trusted-firmware-a.git/commit/?id=d7a7135d32a8c7da004c0c19b75bd4e2813f9759
> 
> OP-TEE fix:
> https://github.com/OP-TEE/optee_os/commit/e313f4765fd0478bb66985827441411793433773

Kamlesh,

AM62Px boot failed (data abort) with this change.

Can you verify and submit along with what else is missing.

Error snip:
E/TC:0 0 Core data-abort at address 0x9b510010
E/TC:0 0  esr 0x96000210  ttbr0 0x9e8a0000   ttbr1 0x00000000   cidr 0x0
E/TC:0 0  cpu #0          cpsr 0x800003c4
E/TC:0 0  x0  000000009b510010 x1  0000000000000001
E/TC:0 0  x2  000000009b510000 x3  0000000000000000
E/TC:0 0  x4  000000009e874000 x5  0000000000ffffff
E/TC:0 0  x6  0000000000000002 x7  000000000000fd20
E/TC:0 0  x8  000000009e890f80 x9  000000009e881000
E/TC:0 0  x10 000000000000000a x11 0000000000000002
E/TC:0 0  x12 0000000000000042 x13 0000000000000000
E/TC:0 0  x14 0000000000000000 x15 0000000000000000
E/TC:0 0  x16 000000009e83b8cc x17 0000000000000000
E/TC:0 0  x18 0000000000000000 x19 000000009e8a83d0
E/TC:0 0  x20 000000009e8a83d8 x21 0000000000000007
E/TC:0 0  x22 000000009e880000 x23 000000009e880fa8
E/TC:0 0  x24 0000000100000000 x25 0000000000000000
E/TC:0 0  x26 0000000000000000 x27 0000000000000000
E/TC:0 0  x28 0000000000000000 x29 000000009e8a8350
E/TC:0 0  x30 000000009e816fbc elr 000000009e816fdc
E/TC:0 0  sp_el0 000000009e8a8350
E/TC:0 0



> 
> Signed-off-by: Kamlesh Gurudasani <kamlesh@ti.com>
> ---
> Changes in V4:
> -rebase on kirkstone-wip
> 
> Changes in V3:
> -updated commit title and message
> 
> Changes in V2:
> -updated commit message
> -included changes for AM62p
> ---
>   meta-ti-bsp/recipes-security/optee/optee-os-ti-overrides.inc | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta-ti-bsp/recipes-security/optee/optee-os-ti-overrides.inc b/meta-ti-bsp/recipes-security/optee/optee-os-ti-overrides.inc
> index b1846cad..a3dd7239 100644
> --- a/meta-ti-bsp/recipes-security/optee/optee-os-ti-overrides.inc
> +++ b/meta-ti-bsp/recipes-security/optee/optee-os-ti-overrides.inc
> @@ -3,8 +3,8 @@ inherit ti-secdev
>   
>   EXTRA_OEMAKE:append:k3 = "${@ ' CFG_CONSOLE_UART='+ d.getVar('OPTEE_K3_USART') if d.getVar('OPTEE_K3_USART') else ''}"
>   
> -EXTRA_OEMAKE:append:am62xx = " CFG_WITH_SOFTWARE_PRNG=y CFG_TEE_CORE_LOG_LEVEL=1"
> -EXTRA_OEMAKE:append:am62pxx = " CFG_WITH_SOFTWARE_PRNG=y CFG_TEE_CORE_LOG_LEVEL=1"
> +EXTRA_OEMAKE:append:am62xx = " CFG_TEE_CORE_LOG_LEVEL=1"
> +EXTRA_OEMAKE:append:am62pxx = " CFG_TEE_CORE_LOG_LEVEL=1"
>   EXTRA_OEMAKE:append:am62axx = " CFG_TEE_CORE_LOG_LEVEL=1"
>   
>   do_compile:append:k3() {
> 
> ---
> base-commit: 578823721ebf23485e7cfaaebc6146145996faa2
> change-id: 20231108-wip-enable-trng-e93bf6831e47
> 
> Best regards,
Raghavendra, Vignesh Nov. 14, 2023, 4:43 a.m. UTC | #2
On 11/14/2023 5:29 AM, Bajjuri, Praneeth wrote:
> 
> 
> On 11/8/2023 9:17 AM, Kamlesh Gurudasani wrote:
>> Enable TRNG in AM62X and AM62PX, as bugs related to TRNG has been
>> fixed now.
>>
>> TF-A fix:
>> https://git.trustedfirmware.org/TF-A/trusted-firmware-a.git/commit/?id=d7a7135d32a8c7da004c0c19b75bd4e2813f9759
>>
>> OP-TEE fix:
>> https://github.com/OP-TEE/optee_os/commit/e313f4765fd0478bb66985827441411793433773
> 
> Kamlesh,
> 
> AM62Px boot failed (data abort) with this change.
> 
> Can you verify and submit along with what else is missing.
> 
> Error snip:
> E/TC:0 0 Core data-abort at address 0x9b510010
> E/TC:0 0  esr 0x96000210  ttbr0 0x9e8a0000   ttbr1 0x00000000   cidr 0x0
> E/TC:0 0  cpu #0          cpsr 0x800003c4
> E/TC:0 0  x0  000000009b510010 x1  0000000000000001
> E/TC:0 0  x2  000000009b510000 x3  0000000000000000
> E/TC:0 0  x4  000000009e874000 x5  0000000000ffffff
> E/TC:0 0  x6  0000000000000002 x7  000000000000fd20
> E/TC:0 0  x8  000000009e890f80 x9  000000009e881000
> E/TC:0 0  x10 000000000000000a x11 0000000000000002
> E/TC:0 0  x12 0000000000000042 x13 0000000000000000
> E/TC:0 0  x14 0000000000000000 x15 0000000000000000
> E/TC:0 0  x16 000000009e83b8cc x17 0000000000000000
> E/TC:0 0  x18 0000000000000000 x19 000000009e8a83d0
> E/TC:0 0  x20 000000009e8a83d8 x21 0000000000000007
> E/TC:0 0  x22 000000009e880000 x23 000000009e880fa8
> E/TC:0 0  x24 0000000100000000 x25 0000000000000000
> E/TC:0 0  x26 0000000000000000 x27 0000000000000000
> E/TC:0 0  x28 0000000000000000 x29 000000009e8a8350
> E/TC:0 0  x30 000000009e816fbc elr 000000009e816fdc
> E/TC:0 0  sp_el0 000000009e8a8350
> E/TC:0 0

I suggest lets keep CFG_WITH_SOFTWARE_PRNG=y for am62px and debug this
post 9.2

Regards
Vignesh
diff mbox series

Patch

diff --git a/meta-ti-bsp/recipes-security/optee/optee-os-ti-overrides.inc b/meta-ti-bsp/recipes-security/optee/optee-os-ti-overrides.inc
index b1846cad..a3dd7239 100644
--- a/meta-ti-bsp/recipes-security/optee/optee-os-ti-overrides.inc
+++ b/meta-ti-bsp/recipes-security/optee/optee-os-ti-overrides.inc
@@ -3,8 +3,8 @@  inherit ti-secdev
 
 EXTRA_OEMAKE:append:k3 = "${@ ' CFG_CONSOLE_UART='+ d.getVar('OPTEE_K3_USART') if d.getVar('OPTEE_K3_USART') else ''}"
 
-EXTRA_OEMAKE:append:am62xx = " CFG_WITH_SOFTWARE_PRNG=y CFG_TEE_CORE_LOG_LEVEL=1"
-EXTRA_OEMAKE:append:am62pxx = " CFG_WITH_SOFTWARE_PRNG=y CFG_TEE_CORE_LOG_LEVEL=1"
+EXTRA_OEMAKE:append:am62xx = " CFG_TEE_CORE_LOG_LEVEL=1"
+EXTRA_OEMAKE:append:am62pxx = " CFG_TEE_CORE_LOG_LEVEL=1"
 EXTRA_OEMAKE:append:am62axx = " CFG_TEE_CORE_LOG_LEVEL=1"
 
 do_compile:append:k3() {