| Message ID | 20231004-atf-bump-lpm-v1-1-66ebc652e365@ti.com |
|---|---|
| State | Accepted |
| Delegated to: | Ryan Eatmon |
| Headers | show |
| Series | trusted-firmware-a: Update to sha fixing deep sleep on AM62x | expand |
On 10/4/2023 10:49 AM, Kamlesh Gurudasani wrote: > Update to commit d7a7135d32a8c7da004c0c19b75bd4e2813f9759, > which fixes deep sleep bug on AM62x Thanks for the patch, But is this commit sanity tested across all K3 platforms? > > https://git.trustedfirmware.org/TF-A/trusted-firmware-a.git/commit/?id=d7a7135d32a8c7da004c0c19b75bd4e2813f9759 > > Signed-off-by: Kamlesh Gurudasani <kamlesh@ti.com> > --- > meta-ti-bsp/recipes-bsp/trusted-firmware-a/trusted-firmware-a-ti.inc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta-ti-bsp/recipes-bsp/trusted-firmware-a/trusted-firmware-a-ti.inc b/meta-ti-bsp/recipes-bsp/trusted-firmware-a/trusted-firmware-a-ti.inc > index 64bfec67..b2787005 100644 > --- a/meta-ti-bsp/recipes-bsp/trusted-firmware-a/trusted-firmware-a-ti.inc > +++ b/meta-ti-bsp/recipes-bsp/trusted-firmware-a/trusted-firmware-a-ti.inc > @@ -1,5 +1,5 @@ > PV:k3 = "2.9+git${SRCPV}" > -SRCREV_tfa:k3 = "d3e71ead6ea5bc3555ac90a446efec84ef6c6122" > +SRCREV_tfa:k3 = "d7a7135d32a8c7da004c0c19b75bd4e2813f9759" > SRC_URI:k3 = "git://git.trustedfirmware.org/TF-A/trusted-firmware-a.git;protocol=https;name=tfa;branch=master" > COMPATIBLE_MACHINE:k3 = "k3" > TFA_BUILD_TARGET:k3 = "all" > > --- > base-commit: 771e12cfb7a9ffedb40395632bc123cd4ce5fb9a > change-id: 20231004-atf-bump-lpm-cf9d26d6f4ce > > Best regards,
"Bajjuri, Praneeth" <praneeth@ti.com> writes: > On 10/4/2023 10:49 AM, Kamlesh Gurudasani wrote: >> Update to commit d7a7135d32a8c7da004c0c19b75bd4e2813f9759, >> which fixes deep sleep bug on AM62x > > Thanks for the patch, But is this commit sanity tested across all K3 > platforms? Yes, Manorit has sanity tested this on all K3 devices http://lcpdresults.itg.ti.com/launcher/results/16114 Regards, Kamlesh
On 10/4/2023 11:00 AM, Kamlesh Gurudasani wrote: > "Bajjuri, Praneeth" <praneeth@ti.com> writes: > >> On 10/4/2023 10:49 AM, Kamlesh Gurudasani wrote: >>> Update to commit d7a7135d32a8c7da004c0c19b75bd4e2813f9759, >>> which fixes deep sleep bug on AM62x >> >> Thanks for the patch, But is this commit sanity tested across all K3 >> platforms? > Yes, Manorit has sanity tested this on all K3 devices > > http://lcpdresults.itg.ti.com/launcher/results/16114 For future reference, no internal links for mainline lists please:) Looking at the log, doesnt look like some platforms are booting . (AM62 LP, AM65,AM62 GP) Can you clarify if the failures seen are regression related to ATF update. > > Regards, > Kamlesh
"Bajjuri, Praneeth" <praneeth@ti.com> writes: > On 10/4/2023 11:00 AM, Kamlesh Gurudasani wrote: >> "Bajjuri, Praneeth" <praneeth@ti.com> writes: >> >>> On 10/4/2023 10:49 AM, Kamlesh Gurudasani wrote: >>>> Update to commit d7a7135d32a8c7da004c0c19b75bd4e2813f9759, >>>> which fixes deep sleep bug on AM62x >>> >>> Thanks for the patch, But is this commit sanity tested across all K3 >>> platforms? >> Yes, Manorit has sanity tested this on all K3 devices >> >> http://lcpdresults.itg.ti.com/launcher/results/16114 > > For future reference, no internal links for mainline lists please:) > > Looking at the log, doesnt look like some platforms are booting . (AM62 > LP, AM65,AM62 GP) > > Can you clarify if the failures seen are regression related to ATF update. AM62X LP-SE is passing, FS is failing because of some infrastructure reasons TF-A is same for SE/FS/GP, so should not be an issue. Same for AM62x. AM65 is not tested at all. So nothing related to ATF update. > > >> >> Regards, >> Kamlesh
On Oct 04, 2023 at 21:19:50 +0530, Kamlesh Gurudasani wrote: > Update to commit d7a7135d32a8c7da004c0c19b75bd4e2813f9759, > which fixes deep sleep bug on AM62x > > https://git.trustedfirmware.org/TF-A/trusted-firmware-a.git/commit/?id=d7a7135d32a8c7da004c0c19b75bd4e2813f9759 > > Signed-off-by: Kamlesh Gurudasani <kamlesh@ti.com> > --- > meta-ti-bsp/recipes-bsp/trusted-firmware-a/trusted-firmware-a-ti.inc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta-ti-bsp/recipes-bsp/trusted-firmware-a/trusted-firmware-a-ti.inc b/meta-ti-bsp/recipes-bsp/trusted-firmware-a/trusted-firmware-a-ti.inc > index 64bfec67..b2787005 100644 > --- a/meta-ti-bsp/recipes-bsp/trusted-firmware-a/trusted-firmware-a-ti.inc > +++ b/meta-ti-bsp/recipes-bsp/trusted-firmware-a/trusted-firmware-a-ti.inc > @@ -1,5 +1,5 @@ > PV:k3 = "2.9+git${SRCPV}" > -SRCREV_tfa:k3 = "d3e71ead6ea5bc3555ac90a446efec84ef6c6122" > +SRCREV_tfa:k3 = "d7a7135d32a8c7da004c0c19b75bd4e2813f9759" checked-out to this ATF commit sha locally and tested on my AM62x-SK HSFS and GP samples: https://gist.github.com/DhruvaG2000/6f3e950417ce418c1bf083661c1a6fca NOTE: Local changes to enable suspend support: 8<------------------------------------------------------------------------------ diff --git a/plat/ti/k3/common/plat_common.mk b/plat/ti/k3/common/plat_common.mk index fb633a832713..d234b7f3d690 100644 --- a/plat/ti/k3/common/plat_common.mk +++ b/plat/ti/k3/common/plat_common.mk @@ -45,7 +45,7 @@ K3_USART_BAUD := 115200 $(eval $(call add_define,K3_USART_BAUD)) # Enable system suspend modes -K3_PM_SYSTEM_SUSPEND := 0 +K3_PM_SYSTEM_SUSPEND := 1 $(eval $(call add_define,K3_PM_SYSTEM_SUSPEND)) # Libraries ------------------------------------------------------------------------------>8 > SRC_URI:k3 = "git://git.trustedfirmware.org/TF-A/trusted-firmware-a.git;protocol=https;name=tfa;branch=master" > COMPATIBLE_MACHINE:k3 = "k3" > TFA_BUILD_TARGET:k3 = "all" > > --- > base-commit: 771e12cfb7a9ffedb40395632bc123cd4ce5fb9a > change-id: 20231004-atf-bump-lpm-cf9d26d6f4ce > Tested-by: Dhruva Gole <d-gole@ti.com>
"Gurudasani, Kamlesh via lists.yoctoproject.org" <kamlesh=ti.com@lists.yoctoproject.org> writes: ... >>> Yes, Manorit has sanity tested this on all K3 devices >>> >>> http://lcpdresults.itg.ti.com/launcher/results/16114 >> >> For future reference, no internal links for mainline lists please:) >> >> Looking at the log, doesnt look like some platforms are booting . (AM62 >> LP, AM65,AM62 GP) >> >> Can you clarify if the failures seen are regression related to ATF update. > AM62X LP-SE is passing, FS is failing because of some infrastructure > reasons > > TF-A is same for SE/FS/GP, so should not be an issue. > > Same for AM62x. > > AM65 is not tested at all. Sanity tested on GP AM65x succesfully. https://gist.github.com/ti-kamlesh/b28a001aa3d868df83b0f6180eddf168 Regards, Kamlesh
diff --git a/meta-ti-bsp/recipes-bsp/trusted-firmware-a/trusted-firmware-a-ti.inc b/meta-ti-bsp/recipes-bsp/trusted-firmware-a/trusted-firmware-a-ti.inc index 64bfec67..b2787005 100644 --- a/meta-ti-bsp/recipes-bsp/trusted-firmware-a/trusted-firmware-a-ti.inc +++ b/meta-ti-bsp/recipes-bsp/trusted-firmware-a/trusted-firmware-a-ti.inc @@ -1,5 +1,5 @@ PV:k3 = "2.9+git${SRCPV}" -SRCREV_tfa:k3 = "d3e71ead6ea5bc3555ac90a446efec84ef6c6122" +SRCREV_tfa:k3 = "d7a7135d32a8c7da004c0c19b75bd4e2813f9759" SRC_URI:k3 = "git://git.trustedfirmware.org/TF-A/trusted-firmware-a.git;protocol=https;name=tfa;branch=master" COMPATIBLE_MACHINE:k3 = "k3" TFA_BUILD_TARGET:k3 = "all"
Update to commit d7a7135d32a8c7da004c0c19b75bd4e2813f9759, which fixes deep sleep bug on AM62x https://git.trustedfirmware.org/TF-A/trusted-firmware-a.git/commit/?id=d7a7135d32a8c7da004c0c19b75bd4e2813f9759 Signed-off-by: Kamlesh Gurudasani <kamlesh@ti.com> --- meta-ti-bsp/recipes-bsp/trusted-firmware-a/trusted-firmware-a-ti.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- base-commit: 771e12cfb7a9ffedb40395632bc123cd4ce5fb9a change-id: 20231004-atf-bump-lpm-cf9d26d6f4ce Best regards,