| Message ID | 20230921124848.3663826-3-anandb@ti.com |
|---|---|
| State | Rejected |
| Delegated to: | Ryan Eatmon |
| Headers | show |
| Series | SGX driver enablement | expand |
On 9/21/23 7:48 AM, Anand Balagopalakrishnan via lists.yoctoproject.org wrote: > mesa-pvr should be dependent on user mode libraries and not the kernel mode > driver. While true, this patch doesn't do this. Currently the mesa-pvr is not dependent on either the user nor kernel mode driver. And you didn't add the user mode dependency here. > Remove auto configurations in mesa-pvr when gpudriver is set to sgx > kernel mode driver. > Why? You will need this later. Andrew > Signed-off-by: Anand Balagopalakrishnan <anandb@ti.com> > --- > meta-ti-bsp/recipes-graphics/mesa/mesa-pvr_22.3.5.bb | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/meta-ti-bsp/recipes-graphics/mesa/mesa-pvr_22.3.5.bb b/meta-ti-bsp/recipes-graphics/mesa/mesa-pvr_22.3.5.bb > index 0de3cb94..d8c438ff 100644 > --- a/meta-ti-bsp/recipes-graphics/mesa/mesa-pvr_22.3.5.bb > +++ b/meta-ti-bsp/recipes-graphics/mesa/mesa-pvr_22.3.5.bb > @@ -25,12 +25,10 @@ SRCREV = "54fd9d7dea098b6f11c2a244b0c6763dc8c5690c" > > PACKAGECONFIG:append = " \ > ${@bb.utils.contains('PREFERRED_PROVIDER_virtual/gpudriver', 'ti-img-rogue-driver', 'pvr', '', d)} \ > - ${@bb.utils.contains('PREFERRED_PROVIDER_virtual/gpudriver', 'ti-sgx-ddk-km', 'sgx', '', d)} \ > " > > PVR_DISPLAY_CONTROLLER_ALIAS ??= "tidss" > PACKAGECONFIG[pvr] = "-Dgallium-pvr-alias=${PVR_DISPLAY_CONTROLLER_ALIAS}," > -PACKAGECONFIG[sgx] = "-Dgallium-sgx-alias=${PVR_DISPLAY_CONTROLLER_ALIAS}," > > PACKAGECONFIG:remove = "video-codecs" > PACKAGECONFIG[video-codecs] = "" > @@ -42,7 +40,6 @@ PACKAGECONFIG[xvmc] = "" > PACKAGE_ARCH = "${MACHINE_ARCH}" > > GALLIUMDRIVERS:append = "${@bb.utils.contains('PACKAGECONFIG', 'pvr', ',pvr', '', d)}" > -GALLIUMDRIVERS:append = "${@bb.utils.contains('PACKAGECONFIG', 'sgx', ',sgx', '', d)}" > > VULKAN_DRIVERS:append = "${@bb.utils.contains('PACKAGECONFIG', 'pvr', ',pvr', '', d)}" > > > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#17002): https://lists.yoctoproject.org/g/meta-ti/message/17002 > Mute This Topic: https://lists.yoctoproject.org/mt/101499136/3619733 > Group Owner: meta-ti+owner@lists.yoctoproject.org > Unsubscribe: https://lists.yoctoproject.org/g/meta-ti/unsub [afd@ti.com] > -=-=-=-=-=-=-=-=-=-=-=- >
diff --git a/meta-ti-bsp/recipes-graphics/mesa/mesa-pvr_22.3.5.bb b/meta-ti-bsp/recipes-graphics/mesa/mesa-pvr_22.3.5.bb index 0de3cb94..d8c438ff 100644 --- a/meta-ti-bsp/recipes-graphics/mesa/mesa-pvr_22.3.5.bb +++ b/meta-ti-bsp/recipes-graphics/mesa/mesa-pvr_22.3.5.bb @@ -25,12 +25,10 @@ SRCREV = "54fd9d7dea098b6f11c2a244b0c6763dc8c5690c" PACKAGECONFIG:append = " \ ${@bb.utils.contains('PREFERRED_PROVIDER_virtual/gpudriver', 'ti-img-rogue-driver', 'pvr', '', d)} \ - ${@bb.utils.contains('PREFERRED_PROVIDER_virtual/gpudriver', 'ti-sgx-ddk-km', 'sgx', '', d)} \ " PVR_DISPLAY_CONTROLLER_ALIAS ??= "tidss" PACKAGECONFIG[pvr] = "-Dgallium-pvr-alias=${PVR_DISPLAY_CONTROLLER_ALIAS}," -PACKAGECONFIG[sgx] = "-Dgallium-sgx-alias=${PVR_DISPLAY_CONTROLLER_ALIAS}," PACKAGECONFIG:remove = "video-codecs" PACKAGECONFIG[video-codecs] = "" @@ -42,7 +40,6 @@ PACKAGECONFIG[xvmc] = "" PACKAGE_ARCH = "${MACHINE_ARCH}" GALLIUMDRIVERS:append = "${@bb.utils.contains('PACKAGECONFIG', 'pvr', ',pvr', '', d)}" -GALLIUMDRIVERS:append = "${@bb.utils.contains('PACKAGECONFIG', 'sgx', ',sgx', '', d)}" VULKAN_DRIVERS:append = "${@bb.utils.contains('PACKAGECONFIG', 'pvr', ',pvr', '', d)}"
mesa-pvr should be dependent on user mode libraries and not the kernel mode driver. Remove auto configurations in mesa-pvr when gpudriver is set to sgx kernel mode driver. Signed-off-by: Anand Balagopalakrishnan <anandb@ti.com> --- meta-ti-bsp/recipes-graphics/mesa/mesa-pvr_22.3.5.bb | 3 --- 1 file changed, 3 deletions(-)