diff mbox series

[meta-ti,master/kirkstone,1/2] conf: machine: Add am62xx-sip-evm configuration

Message ID 20230908130234.2227726-1-c-shilwant@ti.com
State Superseded
Delegated to: Ryan Eatmon
Headers show
Series [meta-ti,master/kirkstone,1/2] conf: machine: Add am62xx-sip-evm configuration | expand

Commit Message

Chirag Shilwant Sept. 8, 2023, 1:02 p.m. UTC 
- Add A53 and R5 machine configurations for am62xx-sip-evm.

Signed-off-by: Chirag Shilwant <c-shilwant@ti.com>
---
 meta-ti-bsp/conf/machine/am62xx-sip-evm-k3r5.conf | 11 +++++++++++
 meta-ti-bsp/conf/machine/am62xx-sip-evm.conf      | 13 +++++++++++++
 2 files changed, 24 insertions(+)
 create mode 100644 meta-ti-bsp/conf/machine/am62xx-sip-evm-k3r5.conf
 create mode 100644 meta-ti-bsp/conf/machine/am62xx-sip-evm.conf

Comments

Bajjuri, Praneeth Sept. 8, 2023, 2:15 p.m. UTC | #1 
On 9/8/2023 8:02 AM, Chirag Shilwant wrote:
> - Add A53 and R5 machine configurations for am62xx-sip-evm.

Can you keep the name consistent with the convention
https://git.ti.com/cgit/ti-u-boot/ti-u-boot/commit/?h=ti-u-boot-2023.04&id=600ab30716936aa7f91dd11a9b1b8f8a184122e0

s/am62xx-sip-evm/am62xxsip-evm

> 
> Signed-off-by: Chirag Shilwant <c-shilwant@ti.com>
> ---
>   meta-ti-bsp/conf/machine/am62xx-sip-evm-k3r5.conf | 11 +++++++++++
>   meta-ti-bsp/conf/machine/am62xx-sip-evm.conf      | 13 +++++++++++++
>   2 files changed, 24 insertions(+)
>   create mode 100644 meta-ti-bsp/conf/machine/am62xx-sip-evm-k3r5.conf
>   create mode 100644 meta-ti-bsp/conf/machine/am62xx-sip-evm.conf
> 
> diff --git a/meta-ti-bsp/conf/machine/am62xx-sip-evm-k3r5.conf b/meta-ti-bsp/conf/machine/am62xx-sip-evm-k3r5.conf
> new file mode 100644
> index 00000000..472da1cc
> --- /dev/null
> +++ b/meta-ti-bsp/conf/machine/am62xx-sip-evm-k3r5.conf
> @@ -0,0 +1,11 @@
> +#@TYPE: Machine
> +#@NAME: AM62XX SIP EVM (R5F)
> +#@DESCRIPTION: Machine configuration for the TI AM62xx SIP EVM (R5F core)
> +
> +require conf/machine/include/k3r5.inc
> +
> +SYSFW_SOC = "am62x"
> +SYSFW_CONFIG = "evm"
> +SYSFW_SUFFIX = "hs-fs"
> +
> +UBOOT_MACHINE = "am62x_evm_r5_defconfig"

This is am62x config. Please converge config name from second patch and use
am62xsip_sk_r5.config	


> diff --git a/meta-ti-bsp/conf/machine/am62xx-sip-evm.conf b/meta-ti-bsp/conf/machine/am62xx-sip-evm.conf
> new file mode 100644
> index 00000000..dc4f3b77
> --- /dev/null
> +++ b/meta-ti-bsp/conf/machine/am62xx-sip-evm.conf
> @@ -0,0 +1,13 @@
> +#@TYPE: Machine
> +#@NAME: AM62XX SIP EVM
> +#@DESCRIPTION: Machine configuration for the TI AM62XX SIP EVM
> +
> +require conf/machine/include/am62xx.inc
> +
> +KERNEL_DEVICETREE_PREFIX = "ti/k3-am625"
> +
> +KERNEL_DEVICETREE = " \
> +    ti/k3-am625-sk.dtb \
> +"
> +
> +UBOOT_MACHINE = "am62x_evm_a53_defconfig"

same comment here . This is not the correct config for am62xxsip
Ryan Eatmon Sept. 8, 2023, 2:25 p.m. UTC | #2 
On 9/8/2023 9:15 AM, Bajjuri, Praneeth wrote:
> 
> 
> On 9/8/2023 8:02 AM, Chirag Shilwant wrote:
>> - Add A53 and R5 machine configurations for am62xx-sip-evm.
> 
> Can you keep the name consistent with the convention
> https://git.ti.com/cgit/ti-u-boot/ti-u-boot/commit/?h=ti-u-boot-2023.04&id=600ab30716936aa7f91dd11a9b1b8f8a184122e0
> 
> s/am62xx-sip-evm/am62xxsip-evm

But about the am62xx-lp-evm?  Why is that different than the sip 
variation?  (I really do not know, so please enlighten me.)

>>
>> Signed-off-by: Chirag Shilwant <c-shilwant@ti.com>
>> ---
>>   meta-ti-bsp/conf/machine/am62xx-sip-evm-k3r5.conf | 11 +++++++++++
>>   meta-ti-bsp/conf/machine/am62xx-sip-evm.conf      | 13 +++++++++++++
>>   2 files changed, 24 insertions(+)
>>   create mode 100644 meta-ti-bsp/conf/machine/am62xx-sip-evm-k3r5.conf
>>   create mode 100644 meta-ti-bsp/conf/machine/am62xx-sip-evm.conf
>>
>> diff --git a/meta-ti-bsp/conf/machine/am62xx-sip-evm-k3r5.conf 
>> b/meta-ti-bsp/conf/machine/am62xx-sip-evm-k3r5.conf
>> new file mode 100644
>> index 00000000..472da1cc
>> --- /dev/null
>> +++ b/meta-ti-bsp/conf/machine/am62xx-sip-evm-k3r5.conf
>> @@ -0,0 +1,11 @@
>> +#@TYPE: Machine
>> +#@NAME: AM62XX SIP EVM (R5F)
>> +#@DESCRIPTION: Machine configuration for the TI AM62xx SIP EVM (R5F 
>> core)
>> +
>> +require conf/machine/include/k3r5.inc
>> +
>> +SYSFW_SOC = "am62x"
>> +SYSFW_CONFIG = "evm"
>> +SYSFW_SUFFIX = "hs-fs"
>> +
>> +UBOOT_MACHINE = "am62x_evm_r5_defconfig"
> 
> This is am62x config. Please converge config name from second patch and use
> am62xsip_sk_r5.config
> 
> 
>> diff --git a/meta-ti-bsp/conf/machine/am62xx-sip-evm.conf 
>> b/meta-ti-bsp/conf/machine/am62xx-sip-evm.conf
>> new file mode 100644
>> index 00000000..dc4f3b77
>> --- /dev/null
>> +++ b/meta-ti-bsp/conf/machine/am62xx-sip-evm.conf
>> @@ -0,0 +1,13 @@
>> +#@TYPE: Machine
>> +#@NAME: AM62XX SIP EVM
>> +#@DESCRIPTION: Machine configuration for the TI AM62XX SIP EVM
>> +
>> +require conf/machine/include/am62xx.inc
>> +
>> +KERNEL_DEVICETREE_PREFIX = "ti/k3-am625"
>> +
>> +KERNEL_DEVICETREE = " \
>> +    ti/k3-am625-sk.dtb \
>> +"
>> +
>> +UBOOT_MACHINE = "am62x_evm_a53_defconfig"
> 
> same comment here . This is not the correct config for am62xxsip
> 
>
Bajjuri, Praneeth Sept. 8, 2023, 2:41 p.m. UTC | #3 
On 9/8/2023 9:25 AM, Ryan Eatmon wrote:
> 
> 
> On 9/8/2023 9:15 AM, Bajjuri, Praneeth wrote:
>>
>>
>> On 9/8/2023 8:02 AM, Chirag Shilwant wrote:
>>> - Add A53 and R5 machine configurations for am62xx-sip-evm.
>>
>> Can you keep the name consistent with the convention
>> https://git.ti.com/cgit/ti-u-boot/ti-u-boot/commit/?h=ti-u-boot-2023.04&id=600ab30716936aa7f91dd11a9b1b8f8a184122e0
>>
>> s/am62xx-sip-evm/am62xxsip-evm
> 
> But about the am62xx-lp-evm?  Why is that different than the sip 
> variation?  (I really do not know, so please enlighten me.)

am62xxsip-evm >> is am62xx with LPDDR4 integrated with silicon (System 
in Package) and LPDDR4 is 512MB on this new board/sip variant

am62xx-evm >> is am62xx Soc with 2GB DDR4 on board.

am62xx-lp-evm >> is am62xx AMC package Soc with LPDDR4 on board.


> 
>>>
>>> Signed-off-by: Chirag Shilwant <c-shilwant@ti.com>
>>> ---
>>>   meta-ti-bsp/conf/machine/am62xx-sip-evm-k3r5.conf | 11 +++++++++++
>>>   meta-ti-bsp/conf/machine/am62xx-sip-evm.conf      | 13 +++++++++++++
>>>   2 files changed, 24 insertions(+)
>>>   create mode 100644 meta-ti-bsp/conf/machine/am62xx-sip-evm-k3r5.conf
>>>   create mode 100644 meta-ti-bsp/conf/machine/am62xx-sip-evm.conf
>>>
>>> diff --git a/meta-ti-bsp/conf/machine/am62xx-sip-evm-k3r5.conf 
>>> b/meta-ti-bsp/conf/machine/am62xx-sip-evm-k3r5.conf
>>> new file mode 100644
>>> index 00000000..472da1cc
>>> --- /dev/null
>>> +++ b/meta-ti-bsp/conf/machine/am62xx-sip-evm-k3r5.conf
>>> @@ -0,0 +1,11 @@
>>> +#@TYPE: Machine
>>> +#@NAME: AM62XX SIP EVM (R5F)
>>> +#@DESCRIPTION: Machine configuration for the TI AM62xx SIP EVM (R5F 
>>> core)
>>> +
>>> +require conf/machine/include/k3r5.inc
>>> +
>>> +SYSFW_SOC = "am62x"
>>> +SYSFW_CONFIG = "evm"
>>> +SYSFW_SUFFIX = "hs-fs"
>>> +
>>> +UBOOT_MACHINE = "am62x_evm_r5_defconfig"
>>
>> This is am62x config. Please converge config name from second patch 
>> and use
>> am62xsip_sk_r5.config
>>
>>
>>> diff --git a/meta-ti-bsp/conf/machine/am62xx-sip-evm.conf 
>>> b/meta-ti-bsp/conf/machine/am62xx-sip-evm.conf
>>> new file mode 100644
>>> index 00000000..dc4f3b77
>>> --- /dev/null
>>> +++ b/meta-ti-bsp/conf/machine/am62xx-sip-evm.conf
>>> @@ -0,0 +1,13 @@
>>> +#@TYPE: Machine
>>> +#@NAME: AM62XX SIP EVM
>>> +#@DESCRIPTION: Machine configuration for the TI AM62XX SIP EVM
>>> +
>>> +require conf/machine/include/am62xx.inc
>>> +
>>> +KERNEL_DEVICETREE_PREFIX = "ti/k3-am625"
>>> +
>>> +KERNEL_DEVICETREE = " \
>>> +    ti/k3-am625-sk.dtb \
>>> +"
>>> +
>>> +UBOOT_MACHINE = "am62x_evm_a53_defconfig"
>>
>> same comment here . This is not the correct config for am62xxsip
>>
>>
>
Ryan Eatmon Sept. 8, 2023, 3:38 p.m. UTC | #4 
On 9/8/2023 9:41 AM, Bajjuri, Praneeth wrote:
> 
> 
> On 9/8/2023 9:25 AM, Ryan Eatmon wrote:
>>
>>
>> On 9/8/2023 9:15 AM, Bajjuri, Praneeth wrote:
>>>
>>>
>>> On 9/8/2023 8:02 AM, Chirag Shilwant wrote:
>>>> - Add A53 and R5 machine configurations for am62xx-sip-evm.
>>>
>>> Can you keep the name consistent with the convention
>>> https://git.ti.com/cgit/ti-u-boot/ti-u-boot/commit/?h=ti-u-boot-2023.04&id=600ab30716936aa7f91dd11a9b1b8f8a184122e0
>>>
>>> s/am62xx-sip-evm/am62xxsip-evm
>>
>> But about the am62xx-lp-evm?  Why is that different than the sip 
>> variation?  (I really do not know, so please enlighten me.)
> 
> am62xxsip-evm >> is am62xx with LPDDR4 integrated with silicon (System 
> in Package) and LPDDR4 is 512MB on this new board/sip variant
> 
> am62xx-evm >> is am62xx Soc with 2GB DDR4 on board.
> 
> am62xx-lp-evm >> is am62xx AMC package Soc with LPDDR4 on board.

Thanks.  Then I agree.  It needs to be called am62xxsip-evm.

> 
>>
>>>>
>>>> Signed-off-by: Chirag Shilwant <c-shilwant@ti.com>
>>>> ---
>>>>   meta-ti-bsp/conf/machine/am62xx-sip-evm-k3r5.conf | 11 +++++++++++
>>>>   meta-ti-bsp/conf/machine/am62xx-sip-evm.conf      | 13 +++++++++++++
>>>>   2 files changed, 24 insertions(+)
>>>>   create mode 100644 meta-ti-bsp/conf/machine/am62xx-sip-evm-k3r5.conf
>>>>   create mode 100644 meta-ti-bsp/conf/machine/am62xx-sip-evm.conf
>>>>
>>>> diff --git a/meta-ti-bsp/conf/machine/am62xx-sip-evm-k3r5.conf 
>>>> b/meta-ti-bsp/conf/machine/am62xx-sip-evm-k3r5.conf
>>>> new file mode 100644
>>>> index 00000000..472da1cc
>>>> --- /dev/null
>>>> +++ b/meta-ti-bsp/conf/machine/am62xx-sip-evm-k3r5.conf
>>>> @@ -0,0 +1,11 @@
>>>> +#@TYPE: Machine
>>>> +#@NAME: AM62XX SIP EVM (R5F)
>>>> +#@DESCRIPTION: Machine configuration for the TI AM62xx SIP EVM (R5F 
>>>> core)
>>>> +
>>>> +require conf/machine/include/k3r5.inc
>>>> +
>>>> +SYSFW_SOC = "am62x"
>>>> +SYSFW_CONFIG = "evm"
>>>> +SYSFW_SUFFIX = "hs-fs"
>>>> +
>>>> +UBOOT_MACHINE = "am62x_evm_r5_defconfig"
>>>
>>> This is am62x config. Please converge config name from second patch 
>>> and use
>>> am62xsip_sk_r5.config
>>>
>>>
>>>> diff --git a/meta-ti-bsp/conf/machine/am62xx-sip-evm.conf 
>>>> b/meta-ti-bsp/conf/machine/am62xx-sip-evm.conf
>>>> new file mode 100644
>>>> index 00000000..dc4f3b77
>>>> --- /dev/null
>>>> +++ b/meta-ti-bsp/conf/machine/am62xx-sip-evm.conf
>>>> @@ -0,0 +1,13 @@
>>>> +#@TYPE: Machine
>>>> +#@NAME: AM62XX SIP EVM
>>>> +#@DESCRIPTION: Machine configuration for the TI AM62XX SIP EVM
>>>> +
>>>> +require conf/machine/include/am62xx.inc
>>>> +
>>>> +KERNEL_DEVICETREE_PREFIX = "ti/k3-am625"
>>>> +
>>>> +KERNEL_DEVICETREE = " \
>>>> +    ti/k3-am625-sk.dtb \
>>>> +"
>>>> +
>>>> +UBOOT_MACHINE = "am62x_evm_a53_defconfig"
>>>
>>> same comment here . This is not the correct config for am62xxsip
>>>
>>>
>>
diff mbox series

Patch

diff --git a/meta-ti-bsp/conf/machine/am62xx-sip-evm-k3r5.conf b/meta-ti-bsp/conf/machine/am62xx-sip-evm-k3r5.conf
new file mode 100644
index 00000000..472da1cc
--- /dev/null
+++ b/meta-ti-bsp/conf/machine/am62xx-sip-evm-k3r5.conf
@@ -0,0 +1,11 @@ 
+#@TYPE: Machine
+#@NAME: AM62XX SIP EVM (R5F)
+#@DESCRIPTION: Machine configuration for the TI AM62xx SIP EVM (R5F core)
+
+require conf/machine/include/k3r5.inc
+
+SYSFW_SOC = "am62x"
+SYSFW_CONFIG = "evm"
+SYSFW_SUFFIX = "hs-fs"
+
+UBOOT_MACHINE = "am62x_evm_r5_defconfig"
diff --git a/meta-ti-bsp/conf/machine/am62xx-sip-evm.conf b/meta-ti-bsp/conf/machine/am62xx-sip-evm.conf
new file mode 100644
index 00000000..dc4f3b77
--- /dev/null
+++ b/meta-ti-bsp/conf/machine/am62xx-sip-evm.conf
@@ -0,0 +1,13 @@ 
+#@TYPE: Machine
+#@NAME: AM62XX SIP EVM
+#@DESCRIPTION: Machine configuration for the TI AM62XX SIP EVM
+
+require conf/machine/include/am62xx.inc
+
+KERNEL_DEVICETREE_PREFIX = "ti/k3-am625"
+
+KERNEL_DEVICETREE = " \
+    ti/k3-am625-sk.dtb \
+"
+
+UBOOT_MACHINE = "am62x_evm_a53_defconfig"