| Message ID | 20230609142901.2958733-2-devarsht@ti.com |
|---|---|
| State | Superseded |
| Delegated to: | Ryan Eatmon |
| Headers | show |
| Series | Early splash screen on AM62x | expand |
On 6/9/23 9:29 AM, Devarsh Thakkar wrote: > Early splash screen support for AM62x has been enabled in u-boot > and it requires ti.gz bitmap file to be present in boot partition > as per the default environment settings done in u-boot [1]. > > Copy ti.gz [2] to boot partition to enable out of box early display on > AM62x when it is flashed with the wic image compiled using TI's > bsp. > > [1] https://git.ti.com/cgit/ti-u-boot/ti-u-boot/tree/board/ti/am62x/am62x.env?h=09.00.00.001#n34 > [2] https://git.ti.com/cgit/ti-u-boot/ti-u-boot/tree/tools/logos/ti.gz?h=ti-u-boot-2023.04 > > Signed-off-by: Devarsh Thakkar <devarsht@ti.com> > --- > .../recipes-bsp/u-boot/u-boot-ti-staging_2023.04.bb | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti-staging_2023.04.bb b/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti-staging_2023.04.bb > index 4bbb6433..5067e3c8 100644 > --- a/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti-staging_2023.04.bb > +++ b/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti-staging_2023.04.bb > @@ -8,3 +8,12 @@ BRANCH = "ti-u-boot-2023.04" > > SRCREV = "d8e6f9178f6c80abff4ed2e9094001357bda40d4" > > +do_install:append:am62xx() { > + install -d ${D}/boot > + install -m 0644 ${S}/tools/logos/ti.gz ${D}/boot Could you copy this over as ti_logo.gz or similar so we have some idea of the contents. Andrew > +} > + > +do_deploy:append:am62xx() { > + install -d ${DEPLOYDIR} > + install -m 0644 ${S}/tools/logos/ti.gz ${DEPLOYDIR} > +}
Hi Andrew, Thanks for the quick review. On 09/06/23 20:05, Andrew Davis wrote: > On 6/9/23 9:29 AM, Devarsh Thakkar wrote: >> Early splash screen support for AM62x has been enabled in u-boot >> and it requires ti.gz bitmap file to be present in boot partition >> as per the default environment settings done in u-boot [1]. >> >> Copy ti.gz [2] to boot partition to enable out of box early display on >> AM62x when it is flashed with the wic image compiled using TI's >> bsp. >> >> [1] >> https://git.ti.com/cgit/ti-u-boot/ti-u-boot/tree/board/ti/am62x/am62x.env?h=09.00.00.001#n34 >> [2] >> https://git.ti.com/cgit/ti-u-boot/ti-u-boot/tree/tools/logos/ti.gz?h=ti-u-boot-2023.04 >> >> Signed-off-by: Devarsh Thakkar <devarsht@ti.com> >> --- >> .../recipes-bsp/u-boot/u-boot-ti-staging_2023.04.bb | 9 +++++++++ >> 1 file changed, 9 insertions(+) >> >> diff --git a/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti-staging_2023.04.bb >> b/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti-staging_2023.04.bb >> index 4bbb6433..5067e3c8 100644 >> --- a/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti-staging_2023.04.bb >> +++ b/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti-staging_2023.04.bb >> @@ -8,3 +8,12 @@ BRANCH = "ti-u-boot-2023.04" >> SRCREV = "d8e6f9178f6c80abff4ed2e9094001357bda40d4" >> +do_install:append:am62xx() { >> + install -d ${D}/boot >> + install -m 0644 ${S}/tools/logos/ti.gz ${D}/boot > > Could you copy this over as ti_logo.gz or similar so we have some idea of the > contents. > I agree with you regarding naming convention, but unfortunately I think this file is already present in upstream as ti.gz [1] so we thought to stick with it and rather not change it in ti-u-boot. [1] https://github.com/u-boot/u-boot/blob/master/tools/logos/ti.gz Regards Devarsh > Andrew > >> +} >> + >> +do_deploy:append:am62xx() { >> + install -d ${DEPLOYDIR} >> + install -m 0644 ${S}/tools/logos/ti.gz ${DEPLOYDIR} >> +}
On 6/9/23 9:40 AM, Devarsh Thakkar wrote: > Hi Andrew, > > Thanks for the quick review. > > On 09/06/23 20:05, Andrew Davis wrote: >> On 6/9/23 9:29 AM, Devarsh Thakkar wrote: >>> Early splash screen support for AM62x has been enabled in u-boot >>> and it requires ti.gz bitmap file to be present in boot partition >>> as per the default environment settings done in u-boot [1]. >>> >>> Copy ti.gz [2] to boot partition to enable out of box early display on >>> AM62x when it is flashed with the wic image compiled using TI's >>> bsp. >>> >>> [1] >>> https://git.ti.com/cgit/ti-u-boot/ti-u-boot/tree/board/ti/am62x/am62x.env?h=09.00.00.001#n34 >>> [2] >>> https://git.ti.com/cgit/ti-u-boot/ti-u-boot/tree/tools/logos/ti.gz?h=ti-u-boot-2023.04 >>> >>> Signed-off-by: Devarsh Thakkar <devarsht@ti.com> >>> --- >>> .../recipes-bsp/u-boot/u-boot-ti-staging_2023.04.bb | 9 +++++++++ >>> 1 file changed, 9 insertions(+) >>> >>> diff --git a/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti-staging_2023.04.bb >>> b/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti-staging_2023.04.bb >>> index 4bbb6433..5067e3c8 100644 >>> --- a/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti-staging_2023.04.bb >>> +++ b/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti-staging_2023.04.bb >>> @@ -8,3 +8,12 @@ BRANCH = "ti-u-boot-2023.04" >>> SRCREV = "d8e6f9178f6c80abff4ed2e9094001357bda40d4" >>> +do_install:append:am62xx() { >>> + install -d ${D}/boot >>> + install -m 0644 ${S}/tools/logos/ti.gz ${D}/boot >> >> Could you copy this over as ti_logo.gz or similar so we have some idea of the >> contents. >> > > I agree with you regarding naming convention, but unfortunately I think this > file is already present in upstream as ti.gz [1] so we thought to stick with > it and rather not change it in ti-u-boot. > In u-boot it is in a folder called "logos", you are moving it into the generic "boot" partition. Could you put it in /boot/logo/ti.gz instead? > [1] https://github.com/u-boot/u-boot/blob/master/tools/logos/ti.gz > > Regards > Devarsh > >> Andrew >> >>> +} >>> + >>> +do_deploy:append:am62xx() { >>> + install -d ${DEPLOYDIR} >>> + install -m 0644 ${S}/tools/logos/ti.gz ${DEPLOYDIR} >>> +}
Hi Andrew, Thanks for the suggestions. On 09/06/23 20:18, Andrew Davis wrote: > On 6/9/23 9:40 AM, Devarsh Thakkar wrote: >> Hi Andrew, >> >> Thanks for the quick review. >> >> On 09/06/23 20:05, Andrew Davis wrote: >>> On 6/9/23 9:29 AM, Devarsh Thakkar wrote: >>>> Early splash screen support for AM62x has been enabled in u-boot >>>> and it requires ti.gz bitmap file to be present in boot partition >>>> as per the default environment settings done in u-boot [1]. >>>> >>>> Copy ti.gz [2] to boot partition to enable out of box early display on >>>> AM62x when it is flashed with the wic image compiled using TI's >>>> bsp. >>>> >>>> [1] >>>> https://git.ti.com/cgit/ti-u-boot/ti-u-boot/tree/board/ti/am62x/am62x.env?h=09.00.00.001#n34 >>>> [2] >>>> https://git.ti.com/cgit/ti-u-boot/ti-u-boot/tree/tools/logos/ti.gz?h=ti-u-boot-2023.04 >>>> >>>> Signed-off-by: Devarsh Thakkar <devarsht@ti.com> >>>> --- >>>> .../recipes-bsp/u-boot/u-boot-ti-staging_2023.04.bb | 9 +++++++++ >>>> 1 file changed, 9 insertions(+) >>>> >>>> diff --git a/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti-staging_2023.04.bb >>>> b/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti-staging_2023.04.bb >>>> index 4bbb6433..5067e3c8 100644 >>>> --- a/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti-staging_2023.04.bb >>>> +++ b/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti-staging_2023.04.bb >>>> @@ -8,3 +8,12 @@ BRANCH = "ti-u-boot-2023.04" >>>> SRCREV = "d8e6f9178f6c80abff4ed2e9094001357bda40d4" >>>> +do_install:append:am62xx() { >>>> + install -d ${D}/boot >>>> + install -m 0644 ${S}/tools/logos/ti.gz ${D}/boot >>> >>> Could you copy this over as ti_logo.gz or similar so we have some idea of the >>> contents. >>> >> >> I agree with you regarding naming convention, but unfortunately I think this >> file is already present in upstream as ti.gz [1] so we thought to stick with >> it and rather not change it in ti-u-boot. >> > > In u-boot it is in a folder called "logos", you are moving it into the > generic "boot" partition. Could you put it in /boot/logo/ti.gz instead? > Yeah, that also makes sense to me to have a logos directory if there is a possibility of having multiple logos with different resolutions so that user can choose based upon the connector being used. But this as well will require a change in u-boot's am62x.env file's splashfile variable, moreover I had to make a change in oe-core to allow installation of directories in boot partition for the same [1]. Meanwhile I discussed with team here (Vignesh and Nikhil) and we agreed to both rename the logo and have it in logos directory but we thought to do the latter as a separate patch when [1] is available in kirkstone, until then we thought it is better to just rename it as ti_logo_414x97.gz in boot partition [1] https://lists.openembedded.org/g/openembedded-core/topic/patch_v2_wic_bootimg_add/99501427?p=,,,20,0,0,0::recentpostdate/sticky,,,20,2,0,99501427,previd%3D1686655986349989245,nextid%3D1686587607620747491&previd=1686655986349989245&nextid=1686587607620747491 So is it ok to go ahead with ti_logo_414x97.gz in boot partition for now and take logos directory change as a separate patch in future when [1] is available ? Regards Devarsh >> [1] https://github.com/u-boot/u-boot/blob/master/tools/logos/ti.gz >> >> Regards >> Devarsh >> >>> Andrew >>> >>>> +} >>>> + >>>> +do_deploy:append:am62xx() { >>>> + install -d ${DEPLOYDIR} >>>> + install -m 0644 ${S}/tools/logos/ti.gz ${DEPLOYDIR} >>>> +}
On 6/13/23 6:50 AM, Devarsh Thakkar wrote: > Hi Andrew, > > Thanks for the suggestions. > > On 09/06/23 20:18, Andrew Davis wrote: >> On 6/9/23 9:40 AM, Devarsh Thakkar wrote: >>> Hi Andrew, >>> >>> Thanks for the quick review. >>> >>> On 09/06/23 20:05, Andrew Davis wrote: >>>> On 6/9/23 9:29 AM, Devarsh Thakkar wrote: >>>>> Early splash screen support for AM62x has been enabled in u-boot >>>>> and it requires ti.gz bitmap file to be present in boot partition >>>>> as per the default environment settings done in u-boot [1]. >>>>> >>>>> Copy ti.gz [2] to boot partition to enable out of box early display on >>>>> AM62x when it is flashed with the wic image compiled using TI's >>>>> bsp. >>>>> >>>>> [1] >>>>> https://git.ti.com/cgit/ti-u-boot/ti-u-boot/tree/board/ti/am62x/am62x.env?h=09.00.00.001#n34 >>>>> [2] >>>>> https://git.ti.com/cgit/ti-u-boot/ti-u-boot/tree/tools/logos/ti.gz?h=ti-u-boot-2023.04 >>>>> >>>>> Signed-off-by: Devarsh Thakkar <devarsht@ti.com> >>>>> --- >>>>> .../recipes-bsp/u-boot/u-boot-ti-staging_2023.04.bb | 9 +++++++++ >>>>> 1 file changed, 9 insertions(+) >>>>> >>>>> diff --git a/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti-staging_2023.04.bb >>>>> b/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti-staging_2023.04.bb >>>>> index 4bbb6433..5067e3c8 100644 >>>>> --- a/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti-staging_2023.04.bb >>>>> +++ b/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti-staging_2023.04.bb >>>>> @@ -8,3 +8,12 @@ BRANCH = "ti-u-boot-2023.04" >>>>> SRCREV = "d8e6f9178f6c80abff4ed2e9094001357bda40d4" >>>>> +do_install:append:am62xx() { >>>>> + install -d ${D}/boot >>>>> + install -m 0644 ${S}/tools/logos/ti.gz ${D}/boot >>>> >>>> Could you copy this over as ti_logo.gz or similar so we have some idea of the >>>> contents. >>>> >>> >>> I agree with you regarding naming convention, but unfortunately I think this >>> file is already present in upstream as ti.gz [1] so we thought to stick with >>> it and rather not change it in ti-u-boot. >>> >> >> In u-boot it is in a folder called "logos", you are moving it into the >> generic "boot" partition. Could you put it in /boot/logo/ti.gz instead? >> > > Yeah, that also makes sense to me to have a logos directory if there is a > possibility of having multiple logos with different resolutions so that user > can choose based upon the connector being used. > > But this as well will require a change in u-boot's am62x.env file's splashfile > variable, moreover I had to make a change in oe-core to allow installation of > directories in boot partition for the same [1]. > > > Meanwhile I discussed with team here (Vignesh and Nikhil) and we agreed to > both rename the logo and have it in logos directory but we thought to do the > latter as a separate patch when [1] is available in kirkstone, until then we > thought it is better to just rename it as ti_logo_414x97.gz in boot partition > > [1] > https://lists.openembedded.org/g/openembedded-core/topic/patch_v2_wic_bootimg_add/99501427?p=,,,20,0,0,0::recentpostdate/sticky,,,20,2,0,99501427,previd%3D1686655986349989245,nextid%3D1686587607620747491&previd=1686655986349989245&nextid=1686587607620747491 > > So is it ok to go ahead with ti_logo_414x97.gz in boot partition for now > and take logos directory change as a separate patch in future when [1] is > available ? > Sounds good to me. Andrew > Regards > Devarsh > >>> [1] https://github.com/u-boot/u-boot/blob/master/tools/logos/ti.gz >>> >>> Regards >>> Devarsh >>> >>>> Andrew >>>> >>>>> +} >>>>> + >>>>> +do_deploy:append:am62xx() { >>>>> + install -d ${DEPLOYDIR} >>>>> + install -m 0644 ${S}/tools/logos/ti.gz ${DEPLOYDIR} >>>>> +}
diff --git a/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti-staging_2023.04.bb b/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti-staging_2023.04.bb index 4bbb6433..5067e3c8 100644 --- a/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti-staging_2023.04.bb +++ b/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti-staging_2023.04.bb @@ -8,3 +8,12 @@ BRANCH = "ti-u-boot-2023.04" SRCREV = "d8e6f9178f6c80abff4ed2e9094001357bda40d4" +do_install:append:am62xx() { + install -d ${D}/boot + install -m 0644 ${S}/tools/logos/ti.gz ${D}/boot +} + +do_deploy:append:am62xx() { + install -d ${DEPLOYDIR} + install -m 0644 ${S}/tools/logos/ti.gz ${DEPLOYDIR} +}
Early splash screen support for AM62x has been enabled in u-boot and it requires ti.gz bitmap file to be present in boot partition as per the default environment settings done in u-boot [1]. Copy ti.gz [2] to boot partition to enable out of box early display on AM62x when it is flashed with the wic image compiled using TI's bsp. [1] https://git.ti.com/cgit/ti-u-boot/ti-u-boot/tree/board/ti/am62x/am62x.env?h=09.00.00.001#n34 [2] https://git.ti.com/cgit/ti-u-boot/ti-u-boot/tree/tools/logos/ti.gz?h=ti-u-boot-2023.04 Signed-off-by: Devarsh Thakkar <devarsht@ti.com> --- .../recipes-bsp/u-boot/u-boot-ti-staging_2023.04.bb | 9 +++++++++ 1 file changed, 9 insertions(+)