| Message ID | 20230328025621.15198-1-kai.kang@windriver.com |
|---|---|
| State | Superseded |
| Delegated to: | Ryan Eatmon |
| Headers | show |
| Series | mesa/mesa-gl: remove version from bbappend file name | expand |
NAK 1. https://patchwork.yoctoproject.org/project/ti/patch/20230327170809.2115712-1-theodore_roth@trimble.com/ On Tue, Mar 28, 2023 at 10:56:21AM +0800, Kai Kang wrote: > From: Kai Kang <kai.kang@windriver.com> > > Remove version from mesa/mesa-gl bbappend file names that no need to > rename them when mesa update. > > Issue: LINUXEXEC-26101 2. Unknown tag > (LOCAL REV: NOT UPSTREAM) - Send to meta-ti on 20230328 3. Seems inappropriate here > Signed-off-by: Kai Kang <kai.kang@windriver.com> > --- > .../mesa/{mesa-gl_22.%.bbappend => mesa-gl_%.bbappend} | 0 > .../recipes-graphics/mesa/{mesa_22.%.bbappend => mesa_%.bbappend} | 0 > 2 files changed, 0 insertions(+), 0 deletions(-) > rename meta-ti-bsp/recipes-graphics/mesa/{mesa-gl_22.%.bbappend => mesa-gl_%.bbappend} (100%) > rename meta-ti-bsp/recipes-graphics/mesa/{mesa_22.%.bbappend => mesa_%.bbappend} (100%) 4. PowerVR changes are definitely not version agnostic! > diff --git a/meta-ti-bsp/recipes-graphics/mesa/mesa-gl_22.%.bbappend b/meta-ti-bsp/recipes-graphics/mesa/mesa-gl_%.bbappend > similarity index 100% > rename from meta-ti-bsp/recipes-graphics/mesa/mesa-gl_22.%.bbappend > rename to meta-ti-bsp/recipes-graphics/mesa/mesa-gl_%.bbappend > diff --git a/meta-ti-bsp/recipes-graphics/mesa/mesa_22.%.bbappend b/meta-ti-bsp/recipes-graphics/mesa/mesa_%.bbappend > similarity index 100% > rename from meta-ti-bsp/recipes-graphics/mesa/mesa_22.%.bbappend > rename to meta-ti-bsp/recipes-graphics/mesa/mesa_%.bbappend > -- > 2.17.1
On 3/28/23 23:45, Denys Dmytriyenko wrote: > NAK > > 1. https://patchwork.yoctoproject.org/project/ti/patch/20230327170809.2115712-1-theodore_roth@trimble.com/ > > > On Tue, Mar 28, 2023 at 10:56:21AM +0800, Kai Kang wrote: >> From: Kai Kang <kai.kang@windriver.com> >> >> Remove version from mesa/mesa-gl bbappend file names that no need to >> rename them when mesa update. >> >> Issue: LINUXEXEC-26101 > 2. Unknown tag > > >> (LOCAL REV: NOT UPSTREAM) - Send to meta-ti on 20230328 > 3. Seems inappropriate here Sorry for the noise that I forgot to clean 2 & 3. > > >> Signed-off-by: Kai Kang <kai.kang@windriver.com> >> --- >> .../mesa/{mesa-gl_22.%.bbappend => mesa-gl_%.bbappend} | 0 >> .../recipes-graphics/mesa/{mesa_22.%.bbappend => mesa_%.bbappend} | 0 >> 2 files changed, 0 insertions(+), 0 deletions(-) >> rename meta-ti-bsp/recipes-graphics/mesa/{mesa-gl_22.%.bbappend => mesa-gl_%.bbappend} (100%) >> rename meta-ti-bsp/recipes-graphics/mesa/{mesa_22.%.bbappend => mesa_%.bbappend} (100%) > 4. PowerVR changes are definitely not version agnostic! OK. Regards, Kai > > >> diff --git a/meta-ti-bsp/recipes-graphics/mesa/mesa-gl_22.%.bbappend b/meta-ti-bsp/recipes-graphics/mesa/mesa-gl_%.bbappend >> similarity index 100% >> rename from meta-ti-bsp/recipes-graphics/mesa/mesa-gl_22.%.bbappend >> rename to meta-ti-bsp/recipes-graphics/mesa/mesa-gl_%.bbappend >> diff --git a/meta-ti-bsp/recipes-graphics/mesa/mesa_22.%.bbappend b/meta-ti-bsp/recipes-graphics/mesa/mesa_%.bbappend >> similarity index 100% >> rename from meta-ti-bsp/recipes-graphics/mesa/mesa_22.%.bbappend >> rename to meta-ti-bsp/recipes-graphics/mesa/mesa_%.bbappend >> -- >> 2.17.1 >> >> -=-=-=-=-=-=-=-=-=-=-=- >> Links: You receive all messages sent to this group. >> View/Reply Online (#16249): https://lists.yoctoproject.org/g/meta-ti/message/16249 >> Mute This Topic: https://lists.yoctoproject.org/mt/97898091/3616933 >> Group Owner: meta-ti+owner@lists.yoctoproject.org >> Unsubscribe: https://lists.yoctoproject.org/g/meta-ti/leave/12166737/3616933/1349768870/xyzzy [kai.kang@eng.windriver.com] >> -=-=-=-=-=-=-=-=-=-=-=- >>
On 3/27/23 21:56, Kai Kang wrote: > From: Kai Kang <kai.kang@windriver.com> > > Remove version from mesa/mesa-gl bbappend file names that no need to > rename them when mesa update. > > Issue: LINUXEXEC-26101 > > (LOCAL REV: NOT UPSTREAM) - Send to meta-ti on 20230328 > > Signed-off-by: Kai Kang <kai.kang@windriver.com> > --- > .../mesa/{mesa-gl_22.%.bbappend => mesa-gl_%.bbappend} | 0 > .../recipes-graphics/mesa/{mesa_22.%.bbappend => mesa_%.bbappend} | 0 > 2 files changed, 0 insertions(+), 0 deletions(-) > rename meta-ti-bsp/recipes-graphics/mesa/{mesa-gl_22.%.bbappend => mesa-gl_%.bbappend} (100%) > rename meta-ti-bsp/recipes-graphics/mesa/{mesa_22.%.bbappend => mesa_%.bbappend} (100%) > > diff --git a/meta-ti-bsp/recipes-graphics/mesa/mesa-gl_22.%.bbappend b/meta-ti-bsp/recipes-graphics/mesa/mesa-gl_%.bbappend > similarity index 100% > rename from meta-ti-bsp/recipes-graphics/mesa/mesa-gl_22.%.bbappend > rename to meta-ti-bsp/recipes-graphics/mesa/mesa-gl_%.bbappend > diff --git a/meta-ti-bsp/recipes-graphics/mesa/mesa_22.%.bbappend b/meta-ti-bsp/recipes-graphics/mesa/mesa_%.bbappend > similarity index 100% > rename from meta-ti-bsp/recipes-graphics/mesa/mesa_22.%.bbappend > rename to meta-ti-bsp/recipes-graphics/mesa/mesa_%.bbappend > > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#16247): https://lists.yoctoproject.org/g/meta-ti/message/16247 > Mute This Topic: https://lists.yoctoproject.org/mt/97898091/7094281 > Group Owner: meta-ti+owner@lists.yoctoproject.org > Unsubscribe: https://lists.yoctoproject.org/g/meta-ti/unsub [rs@ti.com] > -=-=-=-=-=-=-=-=-=-=-=- > Yeah, alright. Here's why we didn't do that *yet*: There's currently a handful of patches sitting outside of mesa for rogue devices. Some of them are fundamental (introducing the gallium-frontend shim), others are less important but are still relevant to features we are requested to have for the rogue devices. The upstream-ability of these patches was only recently called into question so I'm trying my best to sort them out and get them upstream as soon as possible, if possible, but considering some of their *unique* approaches to improving performance that will take a little time to get it sorted out. In the meantime we want to use those patches in yocto, and considering the way we receive them (tagged to a particular release), we need to update them and keep them clean rolling forward while we close the gap. If you look at the source line in the include file you'll see our solution to this was to basically glob all 22.% releases and point them all at a branch in a public tree I want to use as an intermediary. This was done to prevent other build issues with tools expecting particular features (like a specific extension of dma buffer feedback). Using this scheme, in the event of a major version drift it should default to software rendering. It's a little scuffed, but this was the safest way I could think to add out of tree graphics without introducing stalls for any other component development. Moving forward I will attempt to track and update this recipe faster. The only reason I wrote up this response instead of just forward porting the mesa patches and posting my own version of this patch changing the glob to 23.% is that moving forward I want to keep the graphics bbappends only applicable to major versions (while they exist). These will help keep backwards compatibility open for community multi-distro efforts (and better compatibility with tagged yocto releases, as they tend to park mesa after a little while). Hopefully this is a little clearer now. Thanks for your interest! Regards, Randolph Sapp
diff --git a/meta-ti-bsp/recipes-graphics/mesa/mesa-gl_22.%.bbappend b/meta-ti-bsp/recipes-graphics/mesa/mesa-gl_%.bbappend similarity index 100% rename from meta-ti-bsp/recipes-graphics/mesa/mesa-gl_22.%.bbappend rename to meta-ti-bsp/recipes-graphics/mesa/mesa-gl_%.bbappend diff --git a/meta-ti-bsp/recipes-graphics/mesa/mesa_22.%.bbappend b/meta-ti-bsp/recipes-graphics/mesa/mesa_%.bbappend similarity index 100% rename from meta-ti-bsp/recipes-graphics/mesa/mesa_22.%.bbappend rename to meta-ti-bsp/recipes-graphics/mesa/mesa_%.bbappend