| Message ID | 20230208183608.2589-1-sinthu.raja@ti.com |
|---|---|
| State | Superseded |
| Delegated to: | Ryan Eatmon |
| Headers | show |
| Series | [meta-ti,dunfell] conf: machine: j721s2: Add DTB and DTBO load address for FIT image | expand |
On 2/8/23 12:36 PM, Sinthu Raja M via lists.yoctoproject.org wrote: > From: Sinthu Raja <sinthu.raja@ti.com> > > Now the J721S2 defconfig is merged for both GP and HS-FS devices, the > HS-FS devices use FIT image to load the kernel and DTB. However, the > DTB/DTBOs are added to the FIT image, but the load address is not added > in the image section of each DTB/DTBOs. This load address is calculated > based on the LOADADDRESS macros in kernel-fitmage class. > > Therefore add the DTB/DTBOs load address and offset macros in J721S2 conf. > This conf is common to both GP and HS-FS devices > > Signed-off-by: Sinthu Raja <sinthu.raja@ti.com> > --- > > Hi All, > This patch resolves the overlay loading issue using name_overlay. This > is not yet tested and will test tomorrow. > > conf/machine/j721s2-evm.conf | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/conf/machine/j721s2-evm.conf b/conf/machine/j721s2-evm.conf > index f1127ed5..2db6c087 100644 > --- a/conf/machine/j721s2-evm.conf > +++ b/conf/machine/j721s2-evm.conf Why are we putting these in the -evm level configs? I know we "usually" only build FIT images for the HS platforms, but FIT is valid and works for all device types. So for all platforms with these defines, we should moved them up into the common machine/include/machine.inc files. Or even better, since these look to be all the same across K3, bubble it up into k3.inc, then you won't need to add this same patch for each new platform. Andrew > @@ -40,6 +40,9 @@ KERNEL_DEVICETREE = " \ > " > > UBOOT_MACHINE = "j721s2_evm_a72_defconfig" > +UBOOT_DTB_LOADADDRESS = "0x83000000" > +UBOOT_DTBO_LOADADDRESS = "0x83080000" > +UBOOT_DTBO_OFFSET = "0x00010000" > > do_image_wic[mcdepends] = "mc::k3r5:ti-sci-fw:do_deploy" > do_image_tar[mcdepends] = "mc::k3r5:ti-sci-fw:do_deploy" > > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#15754): https://lists.yoctoproject.org/g/meta-ti/message/15754 > Mute This Topic: https://lists.yoctoproject.org/mt/96836839/3619733 > Group Owner: meta-ti+owner@lists.yoctoproject.org > Unsubscribe: https://lists.yoctoproject.org/g/meta-ti/unsub [afd@ti.com] > -=-=-=-=-=-=-=-=-=-=-=- >
diff --git a/conf/machine/j721s2-evm.conf b/conf/machine/j721s2-evm.conf index f1127ed5..2db6c087 100644 --- a/conf/machine/j721s2-evm.conf +++ b/conf/machine/j721s2-evm.conf @@ -40,6 +40,9 @@ KERNEL_DEVICETREE = " \ " UBOOT_MACHINE = "j721s2_evm_a72_defconfig" +UBOOT_DTB_LOADADDRESS = "0x83000000" +UBOOT_DTBO_LOADADDRESS = "0x83080000" +UBOOT_DTBO_OFFSET = "0x00010000" do_image_wic[mcdepends] = "mc::k3r5:ti-sci-fw:do_deploy" do_image_tar[mcdepends] = "mc::k3r5:ti-sci-fw:do_deploy"