Message ID | 20230127180217.1760815-1-rs@ti.com |
---|---|
State | Rejected |
Delegated to: | Ryan Eatmon |
Headers | show |
Series | meta-ti-extras: ti-unpack: Drop update_data call | expand |
This change was already made on the master branch back in November to address this issue. Are you seeing this on other branches? I do not believe that this patch needs to be applied to dunfell or kirkstone unless you are seeing an issue. On 1/27/2023 12:02, Randolph Sapp wrote: > Bitbake made it's data store dynamic many releases ago and finally > removed the update_data command altogether in commit > 584989ed2b5af4e8799571dece0cf94f995ef14e. This drops our references as > well. > > Signed-off-by: Randolph Sapp <rs@ti.com> > --- > meta-ti-extras/recipes-ti/includes/ti-unpack.inc | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/meta-ti-extras/recipes-ti/includes/ti-unpack.inc b/meta-ti-extras/recipes-ti/includes/ti-unpack.inc > index 46bfb957..13068843 100644 > --- a/meta-ti-extras/recipes-ti/includes/ti-unpack.inc > +++ b/meta-ti-extras/recipes-ti/includes/ti-unpack.inc > @@ -24,7 +24,6 @@ python ti_bin_do_unpack() { > bb.fatal("TI installer requires 32bit glibc libraries for proper operation\nrun 'yum install glibc.i686' on Fedora or 'apt-get install libc6:i386' on Ubuntu/Debian") > > localdata = bb.data.createCopy(d) > - bb.data.update_data(localdata) > > binfile = localdata.getVar('BINFILE') > binfile = bb.data.expand(binfile, localdata)
On Fri, Jan 27 2023 at 12:12:55 PM -0600, Ryan Eatmon <reatmon@ti.com> wrote: > This change was already made on the master branch back in November to > address this issue. Are you seeing this on other branches? I do not > believe that this patch needs to be applied to dunfell or kirkstone > unless you are seeing an issue. I saw this issue under kirkstone with the latest version of my GPU patch for meta-ti and meta-arago.
On 1/27/2023 15:44, Sapp, Randolph wrote: > On Fri, Jan 27 2023 at 12:12:55 PM -0600, Ryan Eatmon <reatmon@ti.com> > wrote: >> This change was already made on the master branch back in November to >> address this issue. Are you seeing this on other branches? I do not >> believe that this patch needs to be applied to dunfell or kirkstone >> unless you are seeing an issue. > > I saw this issue under kirkstone with the latest version of my GPU patch > for meta-ti and meta-arago. They must have back ported it.
On Fri, Jan 27 2023 at 03:48:58 PM -0600, Ryan Eatmon <reatmon@ti.com> wrote: > On 1/27/2023 15:44, Sapp, Randolph wrote: >> On Fri, Jan 27 2023 at 12:12:55 PM -0600, Ryan Eatmon >> <reatmon@ti.com> wrote: >>> This change was already made on the master branch back in November >>> to address this issue. Are you seeing this on other branches? I >>> do not believe that this patch needs to be applied to dunfell or >>> kirkstone unless you are seeing an issue. >> >> I saw this issue under kirkstone with the latest version of my GPU >> patch for meta-ti and meta-arago. > > They must have back ported it. Whoops, I was tracking bitbake main. Kirkstone doesn't appear to have that commit yet. Still, there should be no reason to call update_data as it is a deprecated function and a NOOP. Entirely up to you whether you want to take this, I don't care.
diff --git a/meta-ti-extras/recipes-ti/includes/ti-unpack.inc b/meta-ti-extras/recipes-ti/includes/ti-unpack.inc index 46bfb957..13068843 100644 --- a/meta-ti-extras/recipes-ti/includes/ti-unpack.inc +++ b/meta-ti-extras/recipes-ti/includes/ti-unpack.inc @@ -24,7 +24,6 @@ python ti_bin_do_unpack() { bb.fatal("TI installer requires 32bit glibc libraries for proper operation\nrun 'yum install glibc.i686' on Fedora or 'apt-get install libc6:i386' on Ubuntu/Debian") localdata = bb.data.createCopy(d) - bb.data.update_data(localdata) binfile = localdata.getVar('BINFILE') binfile = bb.data.expand(binfile, localdata)
Bitbake made it's data store dynamic many releases ago and finally removed the update_data command altogether in commit 584989ed2b5af4e8799571dece0cf94f995ef14e. This drops our references as well. Signed-off-by: Randolph Sapp <rs@ti.com> --- meta-ti-extras/recipes-ti/includes/ti-unpack.inc | 1 - 1 file changed, 1 deletion(-)