diff mbox series

[[meta-ti,master/dunfell] ] conf: machine: j721s2: Add AM68 SK specific dtb and dtbo to KERNEL_DEVICETREE

Message ID 20221228112906.5301-1-sinthu.raja@ti.com
State Superseded
Delegated to: Ryan Eatmon
Headers show
Series [[meta-ti,master/dunfell] ] conf: machine: j721s2: Add AM68 SK specific dtb and dtbo to KERNEL_DEVICETREE | expand

Commit Message

Sinthu Raja M Dec. 28, 2022, 11:29 a.m. UTC 
From: Sinthu Raja <sinthu.raja@ti.com>

AM68 Starter Kit is a low cost, small form factor board designed for
TI's AM68/J721S2 SoC[1] which is optimized to provide best in class performance
for industrial applications. Add DTB entry for the same.

AM68 SK features camera support with MIPI(OV5640) and RPi(IMX219) connectors.
Add DTBO for the same. Also, add DTBO entry for the DDR memory carveout.

[1]:http://www.ti.com/lit/zip/spruj28

Signed-off-by: Sinthu Raja <sinthu.raja@ti.com>
---
 conf/machine/j721s2-evm.conf | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Sinthu Raja M Jan. 4, 2023, 10:37 a.m. UTC | #1 
Hi Ryan,

On Wed, Dec 28, 2022 at 4:59 PM Sinthu Raja
<sinthu.raja@mistralsolutions.com> wrote:
>
> From: Sinthu Raja <sinthu.raja@ti.com>
>
> AM68 Starter Kit is a low cost, small form factor board designed for
> TI's AM68/J721S2 SoC[1] which is optimized to provide best in class performance
> for industrial applications. Add DTB entry for the same.
>
> AM68 SK features camera support with MIPI(OV5640) and RPi(IMX219) connectors.
> Add DTBO for the same. Also, add DTBO entry for the DDR memory carveout.
>
> [1]:http://www.ti.com/lit/zip/spruj28
>
Any comments on this patch? If not what is the next step to getting it
to merge? The corresponding kernel patches got merged.
Commit IDs:
1d32ced7a84e35463361e839157dd67063af9b89
3693f8e9adff20b11c4fa4c3f968747a83bf6175
a89f682b592bc958f276ef83f09d756b019a47c6
93a0e90a955bd9dded8732037c39818e97b679d2

> Signed-off-by: Sinthu Raja <sinthu.raja@ti.com>
> ---
>  conf/machine/j721s2-evm.conf | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/conf/machine/j721s2-evm.conf b/conf/machine/j721s2-evm.conf
> index 6377c459..abdd9e03 100644
> --- a/conf/machine/j721s2-evm.conf
> +++ b/conf/machine/j721s2-evm.conf
> @@ -13,6 +13,10 @@ OPTEEMACHINE = "k3-j784s4"
>  OPTEE_K3_USART = "0x8"
>
>  KERNEL_DEVICETREE = " \
> +    ti/k3-am68-sk-base-board.dtb \
> +    ti/k3-am68-sk-bb-csi2-ov5640.dtb \
> +    ti/k3-am68-sk-rpi-cam-imx219.dtbo \
> +    ti/k3-am68-sk-som-ddr_mem_carveout.dtbo \
>      ti/k3-j721s2-common-proc-board.dtb \
>      ti/k3-j721s2-gesi-exp-board.dtbo \
>  "
> --
> 2.36.1
>
Ryan Eatmon Jan. 9, 2023, 4:19 p.m. UTC | #2 
On 12/28/2022 5:29, Sinthu Raja wrote:
> From: Sinthu Raja <sinthu.raja@ti.com>
> 
> AM68 Starter Kit is a low cost, small form factor board designed for
> TI's AM68/J721S2 SoC[1] which is optimized to provide best in class performance
> for industrial applications. Add DTB entry for the same.
> 
> AM68 SK features camera support with MIPI(OV5640) and RPi(IMX219) connectors.
> Add DTBO for the same. Also, add DTBO entry for the DDR memory carveout.
> 
> [1]:http://www.ti.com/lit/zip/spruj28
> 
> Signed-off-by: Sinthu Raja <sinthu.raja@ti.com>
> ---
>   conf/machine/j721s2-evm.conf | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/conf/machine/j721s2-evm.conf b/conf/machine/j721s2-evm.conf
> index 6377c459..abdd9e03 100644
> --- a/conf/machine/j721s2-evm.conf
> +++ b/conf/machine/j721s2-evm.conf
> @@ -13,6 +13,10 @@ OPTEEMACHINE = "k3-j784s4"
>   OPTEE_K3_USART = "0x8"
>   
>   KERNEL_DEVICETREE = " \
> +    ti/k3-am68-sk-base-board.dtb \
> +    ti/k3-am68-sk-bb-csi2-ov5640.dtb \
> +    ti/k3-am68-sk-rpi-cam-imx219.dtbo \

This file is not what made it into the kernel.  The file in the kernel is:

ti/k3-am68-sk-bb-rpi-cam-imx219.dts
               ^^

Fix this and resubmit the patch please.


> +    ti/k3-am68-sk-som-ddr_mem_carveout.dtbo \
>       ti/k3-j721s2-common-proc-board.dtb \
>       ti/k3-j721s2-gesi-exp-board.dtbo \
>   "
Denys Dmytriyenko Jan. 9, 2023, 5:01 p.m. UTC | #3 
On Mon, Jan 09, 2023 at 10:19:53AM -0600, Ryan Eatmon via lists.yoctoproject.org wrote:
> On 12/28/2022 5:29, Sinthu Raja wrote:
> >From: Sinthu Raja <sinthu.raja@ti.com>
> >
> >AM68 Starter Kit is a low cost, small form factor board designed for
> >TI's AM68/J721S2 SoC[1] which is optimized to provide best in class performance
> >for industrial applications. Add DTB entry for the same.
> >
> >AM68 SK features camera support with MIPI(OV5640) and RPi(IMX219) connectors.
> >Add DTBO for the same. Also, add DTBO entry for the DDR memory carveout.
> >
> >[1]:http://www.ti.com/lit/zip/spruj28
> >
> >Signed-off-by: Sinthu Raja <sinthu.raja@ti.com>
> >---
> >  conf/machine/j721s2-evm.conf | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> >diff --git a/conf/machine/j721s2-evm.conf b/conf/machine/j721s2-evm.conf
> >index 6377c459..abdd9e03 100644
> >--- a/conf/machine/j721s2-evm.conf
> >+++ b/conf/machine/j721s2-evm.conf
> >@@ -13,6 +13,10 @@ OPTEEMACHINE = "k3-j784s4"
> >  OPTEE_K3_USART = "0x8"
> >  KERNEL_DEVICETREE = " \
> >+    ti/k3-am68-sk-base-board.dtb \
> >+    ti/k3-am68-sk-bb-csi2-ov5640.dtb \
> >+    ti/k3-am68-sk-rpi-cam-imx219.dtbo \
> 
> This file is not what made it into the kernel.  The file in the kernel is:
> 
> ti/k3-am68-sk-bb-rpi-cam-imx219.dts
>               ^^
> 
> Fix this and resubmit the patch please.

Please also avoid nested brackets in the Subject, otherwise you get this issue 
in the git history:
https://git.yoctoproject.org/meta-ti/commit/?h=dunfell-wip&id=8e63da858658b7b6ac51803f943c1023248d178f


> >+    ti/k3-am68-sk-som-ddr_mem_carveout.dtbo \
> >      ti/k3-j721s2-common-proc-board.dtb \
> >      ti/k3-j721s2-gesi-exp-board.dtbo \
> >  "
Ryan Eatmon Jan. 9, 2023, 5:19 p.m. UTC | #4 
On 1/9/2023 11:01, Denys Dmytriyenko wrote:
> On Mon, Jan 09, 2023 at 10:19:53AM -0600, Ryan Eatmon via lists.yoctoproject.org wrote:
>> On 12/28/2022 5:29, Sinthu Raja wrote:
>>> From: Sinthu Raja <sinthu.raja@ti.com>
>>>
>>> AM68 Starter Kit is a low cost, small form factor board designed for
>>> TI's AM68/J721S2 SoC[1] which is optimized to provide best in class performance
>>> for industrial applications. Add DTB entry for the same.
>>>
>>> AM68 SK features camera support with MIPI(OV5640) and RPi(IMX219) connectors.
>>> Add DTBO for the same. Also, add DTBO entry for the DDR memory carveout.
>>>
>>> [1]:http://www.ti.com/lit/zip/spruj28
>>>
>>> Signed-off-by: Sinthu Raja <sinthu.raja@ti.com>
>>> ---
>>>   conf/machine/j721s2-evm.conf | 4 ++++
>>>   1 file changed, 4 insertions(+)
>>>
>>> diff --git a/conf/machine/j721s2-evm.conf b/conf/machine/j721s2-evm.conf
>>> index 6377c459..abdd9e03 100644
>>> --- a/conf/machine/j721s2-evm.conf
>>> +++ b/conf/machine/j721s2-evm.conf
>>> @@ -13,6 +13,10 @@ OPTEEMACHINE = "k3-j784s4"
>>>   OPTEE_K3_USART = "0x8"
>>>   KERNEL_DEVICETREE = " \
>>> +    ti/k3-am68-sk-base-board.dtb \
>>> +    ti/k3-am68-sk-bb-csi2-ov5640.dtb \
>>> +    ti/k3-am68-sk-rpi-cam-imx219.dtbo \
>>
>> This file is not what made it into the kernel.  The file in the kernel is:
>>
>> ti/k3-am68-sk-bb-rpi-cam-imx219.dts
>>                ^^
>>
>> Fix this and resubmit the patch please.
> 
> Please also avoid nested brackets in the Subject, otherwise you get this issue
> in the git history:
> https://git.yoctoproject.org/meta-ti/commit/?h=dunfell-wip&id=8e63da858658b7b6ac51803f943c1023248d178f
> 

Yes.  I forgot to mention that.  Thank you.


>>> +    ti/k3-am68-sk-som-ddr_mem_carveout.dtbo \
>>>       ti/k3-j721s2-common-proc-board.dtb \
>>>       ti/k3-j721s2-gesi-exp-board.dtbo \
>>>   "
diff mbox series

Patch

diff --git a/conf/machine/j721s2-evm.conf b/conf/machine/j721s2-evm.conf
index 6377c459..abdd9e03 100644
--- a/conf/machine/j721s2-evm.conf
+++ b/conf/machine/j721s2-evm.conf
@@ -13,6 +13,10 @@  OPTEEMACHINE = "k3-j784s4"
 OPTEE_K3_USART = "0x8"
 
 KERNEL_DEVICETREE = " \
+    ti/k3-am68-sk-base-board.dtb \
+    ti/k3-am68-sk-bb-csi2-ov5640.dtb \
+    ti/k3-am68-sk-rpi-cam-imx219.dtbo \
+    ti/k3-am68-sk-som-ddr_mem_carveout.dtbo \
     ti/k3-j721s2-common-proc-board.dtb \
     ti/k3-j721s2-gesi-exp-board.dtbo \
 "