| Message ID | 20221202145817.28581-1-reatmon@ti.com |
|---|---|
| State | Rejected |
| Delegated to: | Ryan Eatmon |
| Headers | show |
| Series | [meta-ti,master] u-boot: Add lzop dependency | expand |
On Fri, Dec 02, 2022 at 08:58:17AM -0600, Ryan Eatmon via lists.yoctoproject.org wrote: > It turns out we do need lzop for building dra7 and am57 in u-boot, > so add the dependency back in and add a layer dependency on > meta-oe(openembedded-layer). Oh, no, please don't do that! This is a heavy dependency and meta-ti BSP has stayed away from it since the beginning of times. It would be better to figure out why lzop is used for those platforms and change that, as LZOP is pretty much deprecated these days... > Signed-off-by: Ryan Eatmon <reatmon@ti.com> > --- > meta-ti-bsp/conf/layer.conf | 1 + > meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti.inc | 2 +- > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/meta-ti-bsp/conf/layer.conf b/meta-ti-bsp/conf/layer.conf > index 39e7f9eb..8bafa854 100644 > --- a/meta-ti-bsp/conf/layer.conf > +++ b/meta-ti-bsp/conf/layer.conf > @@ -15,6 +15,7 @@ LICENSE_PATH += "${LAYERDIR}/licenses" > > LAYERDEPENDS_meta-ti-bsp = " \ > core \ > + openembedded-layer \ > meta-arm \ > " > > diff --git a/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti.inc b/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti.inc > index d87dcbe1..5127e137 100644 > --- a/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti.inc > +++ b/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti.inc > @@ -23,7 +23,7 @@ SRC_URI = "${UBOOT_GIT_URI};protocol=${UBOOT_GIT_PROTOCOL};branch=${BRANCH}" > PV:append = "+git${SRCPV}" > > # u-boot needs devtree compiler to parse dts files > -DEPENDS += "dtc-native bc-native flex-native bison-native python3-setuptools-native" > +DEPENDS += "dtc-native bc-native lzop-native flex-native bison-native python3-setuptools-native" > > DM_FIRMWARE = "ipc_echo_testb_mcu1_0_release_strip.xer5f" > > -- > 2.17.1
On 12/2/2022 10:10, Denys Dmytriyenko wrote: > On Fri, Dec 02, 2022 at 08:58:17AM -0600, Ryan Eatmon via lists.yoctoproject.org wrote: >> It turns out we do need lzop for building dra7 and am57 in u-boot, >> so add the dependency back in and add a layer dependency on >> meta-oe(openembedded-layer). > > Oh, no, please don't do that! This is a heavy dependency and meta-ti BSP has > stayed away from it since the beginning of times. > > It would be better to figure out why lzop is used for those platforms and > change that, as LZOP is pretty much deprecated these days... Ok. I'll back this one out. And look for an alternative solution. > >> Signed-off-by: Ryan Eatmon <reatmon@ti.com> >> --- >> meta-ti-bsp/conf/layer.conf | 1 + >> meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti.inc | 2 +- >> 2 files changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/meta-ti-bsp/conf/layer.conf b/meta-ti-bsp/conf/layer.conf >> index 39e7f9eb..8bafa854 100644 >> --- a/meta-ti-bsp/conf/layer.conf >> +++ b/meta-ti-bsp/conf/layer.conf >> @@ -15,6 +15,7 @@ LICENSE_PATH += "${LAYERDIR}/licenses" >> >> LAYERDEPENDS_meta-ti-bsp = " \ >> core \ >> + openembedded-layer \ >> meta-arm \ >> " >> >> diff --git a/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti.inc b/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti.inc >> index d87dcbe1..5127e137 100644 >> --- a/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti.inc >> +++ b/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti.inc >> @@ -23,7 +23,7 @@ SRC_URI = "${UBOOT_GIT_URI};protocol=${UBOOT_GIT_PROTOCOL};branch=${BRANCH}" >> PV:append = "+git${SRCPV}" >> >> # u-boot needs devtree compiler to parse dts files >> -DEPENDS += "dtc-native bc-native flex-native bison-native python3-setuptools-native" >> +DEPENDS += "dtc-native bc-native lzop-native flex-native bison-native python3-setuptools-native" >> >> DM_FIRMWARE = "ipc_echo_testb_mcu1_0_release_strip.xer5f" >> >> -- >> 2.17.1
On 12/2/2022 10:42, Ryan Eatmon via lists.yoctoproject.org wrote: > > > On 12/2/2022 10:10, Denys Dmytriyenko wrote: >> On Fri, Dec 02, 2022 at 08:58:17AM -0600, Ryan Eatmon via >> lists.yoctoproject.org wrote: >>> It turns out we do need lzop for building dra7 and am57 in u-boot, >>> so add the dependency back in and add a layer dependency on >>> meta-oe(openembedded-layer). >> >> Oh, no, please don't do that! This is a heavy dependency and meta-ti >> BSP has >> stayed away from it since the beginning of times. >> >> It would be better to figure out why lzop is used for those platforms and >> change that, as LZOP is pretty much deprecated these days... > > Ok. I'll back this one out. And look for an alternative solution. Ok. Adding lzop to HOSTTOOLS in our build script and adding lzop to our build environment fixes this issue. >> >>> Signed-off-by: Ryan Eatmon <reatmon@ti.com> >>> --- >>> meta-ti-bsp/conf/layer.conf | 1 + >>> meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti.inc | 2 +- >>> 2 files changed, 2 insertions(+), 1 deletion(-) >>> >>> diff --git a/meta-ti-bsp/conf/layer.conf b/meta-ti-bsp/conf/layer.conf >>> index 39e7f9eb..8bafa854 100644 >>> --- a/meta-ti-bsp/conf/layer.conf >>> +++ b/meta-ti-bsp/conf/layer.conf >>> @@ -15,6 +15,7 @@ LICENSE_PATH += "${LAYERDIR}/licenses" >>> LAYERDEPENDS_meta-ti-bsp = " \ >>> core \ >>> + openembedded-layer \ >>> meta-arm \ >>> " >>> diff --git a/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti.inc >>> b/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti.inc >>> index d87dcbe1..5127e137 100644 >>> --- a/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti.inc >>> +++ b/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti.inc >>> @@ -23,7 +23,7 @@ SRC_URI = >>> "${UBOOT_GIT_URI};protocol=${UBOOT_GIT_PROTOCOL};branch=${BRANCH}" >>> PV:append = "+git${SRCPV}" >>> # u-boot needs devtree compiler to parse dts files >>> -DEPENDS += "dtc-native bc-native flex-native bison-native >>> python3-setuptools-native" >>> +DEPENDS += "dtc-native bc-native lzop-native flex-native >>> bison-native python3-setuptools-native" >>> DM_FIRMWARE = "ipc_echo_testb_mcu1_0_release_strip.xer5f" >>> -- >>> 2.17.1 > > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#15389): https://lists.yoctoproject.org/g/meta-ti/message/15389 > Mute This Topic: https://lists.yoctoproject.org/mt/95407408/6551054 > Group Owner: meta-ti+owner@lists.yoctoproject.org > Unsubscribe: https://lists.yoctoproject.org/g/meta-ti/unsub [reatmon@ti.com] > -=-=-=-=-=-=-=-=-=-=-=- >
diff --git a/meta-ti-bsp/conf/layer.conf b/meta-ti-bsp/conf/layer.conf index 39e7f9eb..8bafa854 100644 --- a/meta-ti-bsp/conf/layer.conf +++ b/meta-ti-bsp/conf/layer.conf @@ -15,6 +15,7 @@ LICENSE_PATH += "${LAYERDIR}/licenses" LAYERDEPENDS_meta-ti-bsp = " \ core \ + openembedded-layer \ meta-arm \ " diff --git a/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti.inc b/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti.inc index d87dcbe1..5127e137 100644 --- a/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti.inc +++ b/meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti.inc @@ -23,7 +23,7 @@ SRC_URI = "${UBOOT_GIT_URI};protocol=${UBOOT_GIT_PROTOCOL};branch=${BRANCH}" PV:append = "+git${SRCPV}" # u-boot needs devtree compiler to parse dts files -DEPENDS += "dtc-native bc-native flex-native bison-native python3-setuptools-native" +DEPENDS += "dtc-native bc-native lzop-native flex-native bison-native python3-setuptools-native" DM_FIRMWARE = "ipc_echo_testb_mcu1_0_release_strip.xer5f"
It turns out we do need lzop for building dra7 and am57 in u-boot, so add the dependency back in and add a layer dependency on meta-oe(openembedded-layer). Signed-off-by: Ryan Eatmon <reatmon@ti.com> --- meta-ti-bsp/conf/layer.conf | 1 + meta-ti-bsp/recipes-bsp/u-boot/u-boot-ti.inc | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-)