| Message ID | 20221025224919.17617-1-praneeth@ti.com |
|---|---|
| State | Rejected |
| Delegated to: | Ryan Eatmon |
| Headers | show |
| Series | [dunfell] cnm-wave-fw: update firmware name to wave521c_k3_codec_fw.bin | expand |
On 10/25/2022 17:49, Praneeth Bajjuri wrote: > update firmware name to wave521c_k3_codec_fw.bin to align with > linux-firmware main branch. the following patch is part of > ti-linux-firmware thru mainline sync. > > commit 48407ffd ("cnm: update chips&media wave521c firmware.") > > Signed-off-by: Praneeth Bajjuri <praneeth@ti.com> > --- > recipes-bsp/cnm-wave-fw/cnm-wave-fw_git.bb | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/recipes-bsp/cnm-wave-fw/cnm-wave-fw_git.bb b/recipes-bsp/cnm-wave-fw/cnm-wave-fw_git.bb > index b5ad3e31..75b8ce21 100644 > --- a/recipes-bsp/cnm-wave-fw/cnm-wave-fw_git.bb > +++ b/recipes-bsp/cnm-wave-fw/cnm-wave-fw_git.bb > @@ -21,9 +21,9 @@ S = "${WORKDIR}/git" > TARGET_WAVE521C = "wave521c_codec_fw.bin" > > SOURCE_WAVE521C = "wave521c_codec_fw.bin" > -SOURCE_WAVE521C_j721s2-evm = "wave521c_j721s2_codec_fw.bin" > -SOURCE_WAVE521C_j721s2-hs-evm = "wave521c_j721s2_codec_fw.bin" > -SOURCE_WAVE521C_j784s4-evm = "wave521c_j721s2_codec_fw.bin" > +SOURCE_WAVE521C_j721s2-evm = "wave521c_k3_codec_fw.bin" > +SOURCE_WAVE521C_j721s2-hs-evm = "wave521c_k3_codec_fw.bin" > +SOURCE_WAVE521C_j784s4-evm = "wave521c_k3_codec_fw.bin" I'm going to say No to this patch. The only reason I set the file up the way I did was because of the name of the orig file: wave521c_j721s2_codec_fw.bin If all of the platforms will now use the same file, then I would rather eliminate the machine overrides and just change the default setting for SOURCE_WAVE521C to be the "correct" value. I'll put out an alternative patch here in a few minutes. > ALTERNATIVE_LINK_NAME[wave521c_codec_fw.bin] = "${base_libdir}/firmware/${TARGET_WAVE521C}" > ALTERNATIVE_TARGET[wave521c_codec_fw.bin] = "${base_libdir}/firmware/cnm/${TARGET_WAVE521C}"
On 10/25/2022 6:02 PM, Ryan Eatmon wrote: > > > On 10/25/2022 17:49, Praneeth Bajjuri wrote: >> update firmware name to wave521c_k3_codec_fw.bin to align with >> linux-firmware main branch. the following patch is part of >> ti-linux-firmware thru mainline sync. >> >> commit 48407ffd ("cnm: update chips&media wave521c firmware.") >> >> Signed-off-by: Praneeth Bajjuri <praneeth@ti.com> >> --- >> recipes-bsp/cnm-wave-fw/cnm-wave-fw_git.bb | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/recipes-bsp/cnm-wave-fw/cnm-wave-fw_git.bb >> b/recipes-bsp/cnm-wave-fw/cnm-wave-fw_git.bb >> index b5ad3e31..75b8ce21 100644 >> --- a/recipes-bsp/cnm-wave-fw/cnm-wave-fw_git.bb >> +++ b/recipes-bsp/cnm-wave-fw/cnm-wave-fw_git.bb >> @@ -21,9 +21,9 @@ S = "${WORKDIR}/git" >> TARGET_WAVE521C = "wave521c_codec_fw.bin" >> SOURCE_WAVE521C = "wave521c_codec_fw.bin" >> -SOURCE_WAVE521C_j721s2-evm = "wave521c_j721s2_codec_fw.bin" >> -SOURCE_WAVE521C_j721s2-hs-evm = "wave521c_j721s2_codec_fw.bin" >> -SOURCE_WAVE521C_j784s4-evm = "wave521c_j721s2_codec_fw.bin" >> +SOURCE_WAVE521C_j721s2-evm = "wave521c_k3_codec_fw.bin" >> +SOURCE_WAVE521C_j721s2-hs-evm = "wave521c_k3_codec_fw.bin" >> +SOURCE_WAVE521C_j784s4-evm = "wave521c_k3_codec_fw.bin" > > > I'm going to say No to this patch. The only reason I set the file up > the way I did was because of the name of the orig file: > wave521c_j721s2_codec_fw.bin > > If all of the platforms will now use the same file, then I would rather > eliminate the machine overrides and just change the default setting for > SOURCE_WAVE521C to be the "correct" value. > > I'll put out an alternative patch here in a few minutes. Thanks for quick review. Sounds good to me. > > > >> ALTERNATIVE_LINK_NAME[wave521c_codec_fw.bin] = >> "${base_libdir}/firmware/${TARGET_WAVE521C}" >> ALTERNATIVE_TARGET[wave521c_codec_fw.bin] = >> "${base_libdir}/firmware/cnm/${TARGET_WAVE521C}" >
diff --git a/recipes-bsp/cnm-wave-fw/cnm-wave-fw_git.bb b/recipes-bsp/cnm-wave-fw/cnm-wave-fw_git.bb index b5ad3e31..75b8ce21 100644 --- a/recipes-bsp/cnm-wave-fw/cnm-wave-fw_git.bb +++ b/recipes-bsp/cnm-wave-fw/cnm-wave-fw_git.bb @@ -21,9 +21,9 @@ S = "${WORKDIR}/git" TARGET_WAVE521C = "wave521c_codec_fw.bin" SOURCE_WAVE521C = "wave521c_codec_fw.bin" -SOURCE_WAVE521C_j721s2-evm = "wave521c_j721s2_codec_fw.bin" -SOURCE_WAVE521C_j721s2-hs-evm = "wave521c_j721s2_codec_fw.bin" -SOURCE_WAVE521C_j784s4-evm = "wave521c_j721s2_codec_fw.bin" +SOURCE_WAVE521C_j721s2-evm = "wave521c_k3_codec_fw.bin" +SOURCE_WAVE521C_j721s2-hs-evm = "wave521c_k3_codec_fw.bin" +SOURCE_WAVE521C_j784s4-evm = "wave521c_k3_codec_fw.bin" ALTERNATIVE_LINK_NAME[wave521c_codec_fw.bin] = "${base_libdir}/firmware/${TARGET_WAVE521C}" ALTERNATIVE_TARGET[wave521c_codec_fw.bin] = "${base_libdir}/firmware/cnm/${TARGET_WAVE521C}"
update firmware name to wave521c_k3_codec_fw.bin to align with linux-firmware main branch. the following patch is part of ti-linux-firmware thru mainline sync. commit 48407ffd ("cnm: update chips&media wave521c firmware.") Signed-off-by: Praneeth Bajjuri <praneeth@ti.com> --- recipes-bsp/cnm-wave-fw/cnm-wave-fw_git.bb | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)