| Message ID | 20220512134657.31238-1-a-m1@ti.com |
|---|---|
| State | Rejected |
| Delegated to: | Ryan Eatmon |
| Headers | show |
| Series | [meta-ti,dunfell] ti-sci-fw: Add DM firmware to deploy directory for am62xx-evm | expand |
On 12/05/22 19:16, Aparna M wrote: > Add DM firmware ipc_echo_testb_mcu1_0_release_strip.xer5f to deploy > directory for am62xx-evm. This is required for building tispl.bin. > > Signed-off-by: Aparna M <a-m1@ti.com> > --- > recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb b/recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb > index 099473b4..bb88633a 100644 > --- a/recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb > +++ b/recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb > @@ -186,6 +186,7 @@ do_deploy_am62xx-evm-k3r5() { > ln -sf ${UBOOT_IMAGE} ${DEPLOYDIR}/${UBOOT_SYMLINK} > ln -sf ${UBOOT_IMAGE} ${DEPLOYDIR}/${UBOOT_BINARY} > install -m 644 ${SYSFW_TISCI} ${DEPLOYDIR}/ > + install -m 644 ${S}/ti-dm/am62xx/ipc_echo_testb_mcu1_0_release_strip.xer5f ${DEPLOYDIR}/ What is SYSFW_TISCI being used for AM62 ? Any existing macros can't be used ? Also is it changing indentation w.r.t previous line ? > } > > addtask deploy before do_build after do_compile
On 19:27-20220512, Devarsh Thakkar via lists.yoctoproject.org wrote: > > On 12/05/22 19:16, Aparna M wrote: > > Add DM firmware ipc_echo_testb_mcu1_0_release_strip.xer5f to deploy > > directory for am62xx-evm. This is required for building tispl.bin. > > > > Signed-off-by: Aparna M <a-m1@ti.com> > > --- > > recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb b/recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb > > index 099473b4..bb88633a 100644 > > --- a/recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb > > +++ b/recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb > > @@ -186,6 +186,7 @@ do_deploy_am62xx-evm-k3r5() { > > ln -sf ${UBOOT_IMAGE} ${DEPLOYDIR}/${UBOOT_SYMLINK} > > ln -sf ${UBOOT_IMAGE} ${DEPLOYDIR}/${UBOOT_BINARY} > > install -m 644 ${SYSFW_TISCI} ${DEPLOYDIR}/ > > + install -m 644 ${S}/ti-dm/am62xx/ipc_echo_testb_mcu1_0_release_strip.xer5f ${DEPLOYDIR}/ > > What is SYSFW_TISCI being used for AM62 ? Any existing macros can't be used > ? > > Also is it changing indentation w.r.t previous line ? This is the DM firmware. yes, it is already packaged as of tispl build, so what is missing here?
On 5/12/2022 8:46, Aparna M wrote: > Add DM firmware ipc_echo_testb_mcu1_0_release_strip.xer5f to deploy > directory for am62xx-evm. This is required for building tispl.bin. > > Signed-off-by: Aparna M <a-m1@ti.com> > --- > recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb b/recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb > index 099473b4..bb88633a 100644 > --- a/recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb > +++ b/recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb > @@ -186,6 +186,7 @@ do_deploy_am62xx-evm-k3r5() { > ln -sf ${UBOOT_IMAGE} ${DEPLOYDIR}/${UBOOT_SYMLINK} > ln -sf ${UBOOT_IMAGE} ${DEPLOYDIR}/${UBOOT_BINARY} > install -m 644 ${SYSFW_TISCI} ${DEPLOYDIR}/ > + install -m 644 ${S}/ti-dm/am62xx/ipc_echo_testb_mcu1_0_release_strip.xer5f ${DEPLOYDIR}/ > } > > addtask deploy before do_build after do_compile NACK. I think this is in the wrong recipe. This file is referenced for all of the other platforms in: recipes-ti/ti-rtos-bin/ti-rtos-firmware.bb I think it would make more sense to put this change in that recipe for consistency.
On 12/05/22 19:35, Nishanth Menon wrote: > On 19:27-20220512, Devarsh Thakkar via lists.yoctoproject.org wrote: >> On 12/05/22 19:16, Aparna M wrote: >>> Add DM firmware ipc_echo_testb_mcu1_0_release_strip.xer5f to deploy >>> directory for am62xx-evm. This is required for building tispl.bin. >>> >>> Signed-off-by: Aparna M <a-m1@ti.com> >>> --- >>> recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb b/recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb >>> index 099473b4..bb88633a 100644 >>> --- a/recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb >>> +++ b/recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb >>> @@ -186,6 +186,7 @@ do_deploy_am62xx-evm-k3r5() { >>> ln -sf ${UBOOT_IMAGE} ${DEPLOYDIR}/${UBOOT_SYMLINK} >>> ln -sf ${UBOOT_IMAGE} ${DEPLOYDIR}/${UBOOT_BINARY} >>> install -m 644 ${SYSFW_TISCI} ${DEPLOYDIR}/ >>> + install -m 644 ${S}/ti-dm/am62xx/ipc_echo_testb_mcu1_0_release_strip.xer5f ${DEPLOYDIR}/ >> What is SYSFW_TISCI being used for AM62 ? Any existing macros can't be used >> ? >> >> Also is it changing indentation w.r.t previous line ? > > This is the DM firmware. yes, it is already packaged as of tispl build, so > what is missing here? The DM firmware is required in the SDK for toplevel makefile build of u-boot for am62xx. The flow is to add it to deploy and then to prebuilt-images folder of SDK. Sent a new patch for the same as per Ryan's suggestion to use ti-rtos-firmware recipe for this - https://lists.yoctoproject.org/g/meta-ti/topic/dunfell_patch/91076133 -- Aparna
On 12/05/22 19:35, Nishanth Menon wrote: > On 19:27-20220512, Devarsh Thakkar via lists.yoctoproject.org wrote: >> On 12/05/22 19:16, Aparna M wrote: >>> Add DM firmware ipc_echo_testb_mcu1_0_release_strip.xer5f to deploy >>> directory for am62xx-evm. This is required for building tispl.bin. >>> >>> Signed-off-by: Aparna M <a-m1@ti.com> >>> --- >>> recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb b/recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb >>> index 099473b4..bb88633a 100644 >>> --- a/recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb >>> +++ b/recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb >>> @@ -186,6 +186,7 @@ do_deploy_am62xx-evm-k3r5() { >>> ln -sf ${UBOOT_IMAGE} ${DEPLOYDIR}/${UBOOT_SYMLINK} >>> ln -sf ${UBOOT_IMAGE} ${DEPLOYDIR}/${UBOOT_BINARY} >>> install -m 644 ${SYSFW_TISCI} ${DEPLOYDIR}/ >>> + install -m 644 ${S}/ti-dm/am62xx/ipc_echo_testb_mcu1_0_release_strip.xer5f ${DEPLOYDIR}/ >> What is SYSFW_TISCI being used for AM62 ? Any existing macros can't be used >> ? >> >> Also is it changing indentation w.r.t previous line ? > > This is the DM firmware. yes, it is already packaged as of tispl build, so > what is missing here? The DM firmware is required in the SDK for toplevel makefile build of u-boot for am62xx. The flow is to add it to deploy and then to prebuilt-images folder of SDK. Sent a new patch for the same as per Ryan's suggestion to use ti-rtos-firmware recipe for this - https://lists.yoctoproject.org/g/meta-ti/topic/dunfell_patch/91076133 -- Aparna
diff --git a/recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb b/recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb index 099473b4..bb88633a 100644 --- a/recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb +++ b/recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb @@ -186,6 +186,7 @@ do_deploy_am62xx-evm-k3r5() { ln -sf ${UBOOT_IMAGE} ${DEPLOYDIR}/${UBOOT_SYMLINK} ln -sf ${UBOOT_IMAGE} ${DEPLOYDIR}/${UBOOT_BINARY} install -m 644 ${SYSFW_TISCI} ${DEPLOYDIR}/ + install -m 644 ${S}/ti-dm/am62xx/ipc_echo_testb_mcu1_0_release_strip.xer5f ${DEPLOYDIR}/ } addtask deploy before do_build after do_compile
Add DM firmware ipc_echo_testb_mcu1_0_release_strip.xer5f to deploy directory for am62xx-evm. This is required for building tispl.bin. Signed-off-by: Aparna M <a-m1@ti.com> --- recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb | 1 + 1 file changed, 1 insertion(+)