diff mbox series

[dunfell,1/2] ti-k3-secdev: include ti-paths.inc

Message ID 1667427383-18305-2-git-send-email-denis@denix.org
State Accepted
Delegated to: Ryan Eatmon
Headers show
Series Fix K3 HS builds when external SECDEV is not provided | expand

Commit Message

Denys Dmytriyenko Nov. 2, 2022, 10:16 p.m. UTC
From: Denys Dmytriyenko <denys@konsulko.com>

Include ti-paths.inc so TI_K3_SECDEV_INSTALL_DIR_RECIPE gets defined and
artifacts are installed in the correct location.

Cc: Andrew Davis <afd@ti.com>
Signed-off-by: Denys Dmytriyenko <denys@konsulko.com>
---
 recipes-ti/secdev/ti-k3-secdev_git.bb | 2 ++
 1 file changed, 2 insertions(+)

Comments

Andrew Davis Nov. 3, 2022, 1:40 a.m. UTC | #1
On 11/2/22 5:16 PM, Denys Dmytriyenko wrote:
> From: Denys Dmytriyenko <denys@konsulko.com>
> 
> Include ti-paths.inc so TI_K3_SECDEV_INSTALL_DIR_RECIPE gets defined and
> artifacts are installed in the correct location.
> 
> Cc: Andrew Davis <afd@ti.com>
> Signed-off-by: Denys Dmytriyenko <denys@konsulko.com>
> ---
>   recipes-ti/secdev/ti-k3-secdev_git.bb | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/recipes-ti/secdev/ti-k3-secdev_git.bb b/recipes-ti/secdev/ti-k3-secdev_git.bb
> index 28dbe9e..7196be9 100644
> --- a/recipes-ti/secdev/ti-k3-secdev_git.bb
> +++ b/recipes-ti/secdev/ti-k3-secdev_git.bb
> @@ -4,6 +4,8 @@ SECTION = "devel"
>   LICENSE = "BSD-3-Clause"
>   LIC_FILES_CHKSUM = "file://manifest/k3-secdev-0.2-manifest.html;md5=f632a78870cc64550078d7b3cbac0892"
>   
> +require recipes-ti/includes/ti-paths.inc
> +

Seems like a rather big missing piece, how was this even working at all before?

I'm feeling there should be a better way to use the contents of -native packages
without putting all their content into some hard-coded directory. I wrote all
this in a hurry and just copied what the TI compilers were doing, might be
good to revisit this whole patch for kirkstone/master..

Acked-by: Andrew Davis <afd@ti.com>

>   # Native host tool only
>   COMPATIBLE_MACHINE = "null"
>   COMPATIBLE_MACHINE_class-native = "(.*)"
diff mbox series

Patch

diff --git a/recipes-ti/secdev/ti-k3-secdev_git.bb b/recipes-ti/secdev/ti-k3-secdev_git.bb
index 28dbe9e..7196be9 100644
--- a/recipes-ti/secdev/ti-k3-secdev_git.bb
+++ b/recipes-ti/secdev/ti-k3-secdev_git.bb
@@ -4,6 +4,8 @@  SECTION = "devel"
 LICENSE = "BSD-3-Clause"
 LIC_FILES_CHKSUM = "file://manifest/k3-secdev-0.2-manifest.html;md5=f632a78870cc64550078d7b3cbac0892"
 
+require recipes-ti/includes/ti-paths.inc
+
 # Native host tool only
 COMPATIBLE_MACHINE = "null"
 COMPATIBLE_MACHINE_class-native = "(.*)"