diff mbox series

bluealsa: upgrade 4.0.0+git -> 4.3.0

Message ID 88b75d895a22439a271d83df9e66c7dc2a1e75e6.1724391421.git.joerg.sommer@navimatix.de
State Accepted
Headers show
Series bluealsa: upgrade 4.0.0+git -> 4.3.0 | expand

Commit Message

Jörg Sommer Aug. 23, 2024, 5:37 a.m. UTC
From: Jörg Sommer <joerg.sommer@navimatix.de>

The change in the license file was the update of the year in the copyright
line.

glib-2.0-native and python3-packaging-native (with python3native) is
required to have gdbus-codegen at build time.

Signed-off-by: Jörg Sommer <joerg.sommer@navimatix.de>
---
 .../{bluealsa_git.bb => bluealsa_4.3.0.bb}    | 36 ++++++++++++-------
 1 file changed, 24 insertions(+), 12 deletions(-)
 rename meta-multimedia/recipes-multimedia/bluealsa/{bluealsa_git.bb => bluealsa_4.3.0.bb} (67%)

Comments

Khem Raj Aug. 24, 2024, 5:38 a.m. UTC | #1
This resulted in
ERROR: bluealsa-4.3.0-r0 do_package: QA Issue: bluealsa:
Files/directories were installed but not shipped in any package:
  /usr/share
  /usr/share/dbus-1
  /usr/share/dbus-1/system.d
  /usr/share/dbus-1/system.d/bluealsa.conf
Please set FILES such that these items are packaged. Alternatively if
they are unneeded, avoid installing them

I have appended a patchlet to the original patch please check it in
master-next and see if all is ok.


On Thu, Aug 22, 2024 at 10:37 PM Jörg Sommer via
lists.openembedded.org
<joerg.sommer=navimatix.de@lists.openembedded.org> wrote:
>
> From: Jörg Sommer <joerg.sommer@navimatix.de>
>
> The change in the license file was the update of the year in the copyright
> line.
>
> glib-2.0-native and python3-packaging-native (with python3native) is
> required to have gdbus-codegen at build time.
>
> Signed-off-by: Jörg Sommer <joerg.sommer@navimatix.de>
> ---
>  .../{bluealsa_git.bb => bluealsa_4.3.0.bb}    | 36 ++++++++++++-------
>  1 file changed, 24 insertions(+), 12 deletions(-)
>  rename meta-multimedia/recipes-multimedia/bluealsa/{bluealsa_git.bb => bluealsa_4.3.0.bb} (67%)
>
> diff --git a/meta-multimedia/recipes-multimedia/bluealsa/bluealsa_git.bb b/meta-multimedia/recipes-multimedia/bluealsa/bluealsa_4.3.0.bb
> similarity index 67%
> rename from meta-multimedia/recipes-multimedia/bluealsa/bluealsa_git.bb
> rename to meta-multimedia/recipes-multimedia/bluealsa/bluealsa_4.3.0.bb
> index 5007c88ff..ba43b4378 100644
> --- a/meta-multimedia/recipes-multimedia/bluealsa/bluealsa_git.bb
> +++ b/meta-multimedia/recipes-multimedia/bluealsa/bluealsa_4.3.0.bb
> @@ -1,22 +1,30 @@
>  SUMMARY = "Bluetooth Audio ALSA Backend"
> +DESCRIPTION = "\
> +    BlueALSA is a replacement for BlueZ >= 5, with which one can achieve the \
> +    same Bluetooth audio profile support as with PulseAudio, but with fewer \
> +    dependencies and at a lower level in the software stack. It is designed \
> +    specifically for use on small, low-powered, dedicated audio or audio/visual \
> +    systems where the high-level audio management features of PulseAudio or \
> +    PipeWire are not required. \
> +"
>  HOMEPAGE = "https://github.com/Arkq/bluez-alsa"
> +BUGTRACKER = "https://github.com/arkq/bluez-alsa/issues"
>  SECTION = "libs"
>
>  LICENSE = "MIT"
> -LIC_FILES_CHKSUM = "file://LICENSE;md5=8449a4f133a93f6254b496d4fb476e83"
> +LIC_FILES_CHKSUM = "file://LICENSE;md5=143bc4e73f39cc5e89d6e096ac0315ba"
> +
> +DEPENDS += "alsa-lib bluez5 dbus glib-2.0-native python3-packaging-native sbc"
>
>  SRC_URI = "git://github.com/Arkq/bluez-alsa.git;protocol=https;branch=master"
>
> -SRCREV = "dd05a1baa261b94da9ba977b5e3392c8b4dc7a5e"
> -PV = "4.0.0+git"
> +SRCREV = "959573c2cccef5cf074f5b2fa7941abbd699c5f4"
>
> -S  = "${WORKDIR}/git"
> -
> -DEPENDS += "alsa-lib bluez5 dbus glib-2.0 sbc"
> +S = "${WORKDIR}/git"
>
>  PACKAGECONFIG ??= "aplay cli hcitop ${@bb.utils.filter('DISTRO_FEATURES', 'systemd', d)}"
> -PACKAGECONFIG[a2dpconf]  = "--enable-a2dpconf,--disable-a2dpconf"
> -PACKAGECONFIG[aac]  = "--enable-aac,--disable-aac,fdk-aac"
> +PACKAGECONFIG[a2dpconf] = "--enable-a2dpconf,--disable-a2dpconf"
> +PACKAGECONFIG[aac] = "--enable-aac,--disable-aac,fdk-aac"
>  PACKAGECONFIG[aplay] = "--enable-aplay,--disable-aplay"
>  PACKAGECONFIG[cli] = "--enable-cli,--disable-cli"
>  PACKAGECONFIG[coverage] = "--with-coverage,--without-coverage,lcov-native"
> @@ -25,8 +33,10 @@ PACKAGECONFIG[debug-time] = "--enable-debug-time,--disable-debug-time"
>  PACKAGECONFIG[faststream] = "--enable-faststream,--disable-faststream"
>  PACKAGECONFIG[hcitop] = "--enable-hcitop,--disable-hcitop,libbsd ncurses"
>  PACKAGECONFIG[libunwind] = "--with-libunwind,--without-libunwind,libunwind"
> +PACKAGECONFIG[midi] = "--enable-midi,--disable-midi"
>  PACKAGECONFIG[mp3lame] = "--enable-mp3lame,--disable-mp3lame,lame"
>  PACKAGECONFIG[mpg123] = "--enable-mpg123,--disable-mpg123,mpg123,mpg123"
> +PACKAGECONFIG[msbc] = "--enable-msbc,--disable-msbc,spandsp"
>  PACKAGECONFIG[ofono] = "--enable-ofono,--disable-ofono,ofono"
>  PACKAGECONFIG[payloadcheck] = "--enable-payloadcheck,--disable-payloadcheck"
>  PACKAGECONFIG[rfcomm] = "--enable-rfcomm,--disable-rfcomm"
> @@ -35,9 +45,10 @@ PACKAGECONFIG[systemd] = "--enable-systemd --with-systemdsystemunitdir=${systemd
>  PACKAGECONFIG[test] = "--enable-test,--disable-test,libcheck libsndfile1"
>  PACKAGECONFIG[upower] = "--enable-upower,--disable-upower,,upower"
>
> -inherit autotools pkgconfig systemd
> +inherit autotools pkgconfig python3native systemd
>
> -EXTRA_OECONF = " \
> +# These proprietary codecs are not available in Yocto
> +EXTRA_OECONF = "\
>      --disable-aptx \
>      --disable-lc3plus \
>      --disable-ldac \
> @@ -45,11 +56,12 @@ EXTRA_OECONF = " \
>  "
>
>  PACKAGE_BEFORE_PN = "${PN}-aplay"
> -RRECOMMENDS:${PN} = "${PN}-aplay"
>
> -FILES:${PN}-aplay = "${bindir}/bluealsa-aplay"
> +FILES:${PN}-aplay += "${bindir}/bluealsa-aplay"
>  FILES:${PN} += "${libdir}/alsa-lib/*"
>
> +RRECOMMENDS:${PN} = "${PN}-aplay"
> +
>  SYSTEMD_PACKAGES += "${PN}-aplay"
>  SYSTEMD_SERVICE:${PN} = "bluealsa.service"
>  SYSTEMD_SERVICE:${PN}-aplay = "bluealsa-aplay.service"
> --
> 2.34.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#111909): https://lists.openembedded.org/g/openembedded-devel/message/111909
> Mute This Topic: https://lists.openembedded.org/mt/108051676/1997914
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Jörg Sommer Aug. 24, 2024, 9:07 a.m. UTC | #2
Khem Raj schrieb am Fr 23. Aug, 22:38 (GMT):
> This resulted in
> ERROR: bluealsa-4.3.0-r0 do_package: QA Issue: bluealsa:
> Files/directories were installed but not shipped in any package:
>   /usr/share
>   /usr/share/dbus-1
>   /usr/share/dbus-1/system.d
>   /usr/share/dbus-1/system.d/bluealsa.conf
> Please set FILES such that these items are packaged. Alternatively if
> they are unneeded, avoid installing them
> 
> I have appended a patchlet to the original patch please check it in
> master-next and see if all is ok.

Yes, it looks fine. Thanks for it!
diff mbox series

Patch

diff --git a/meta-multimedia/recipes-multimedia/bluealsa/bluealsa_git.bb b/meta-multimedia/recipes-multimedia/bluealsa/bluealsa_4.3.0.bb
similarity index 67%
rename from meta-multimedia/recipes-multimedia/bluealsa/bluealsa_git.bb
rename to meta-multimedia/recipes-multimedia/bluealsa/bluealsa_4.3.0.bb
index 5007c88ff..ba43b4378 100644
--- a/meta-multimedia/recipes-multimedia/bluealsa/bluealsa_git.bb
+++ b/meta-multimedia/recipes-multimedia/bluealsa/bluealsa_4.3.0.bb
@@ -1,22 +1,30 @@ 
 SUMMARY = "Bluetooth Audio ALSA Backend"
+DESCRIPTION = "\
+    BlueALSA is a replacement for BlueZ >= 5, with which one can achieve the \
+    same Bluetooth audio profile support as with PulseAudio, but with fewer \
+    dependencies and at a lower level in the software stack. It is designed \
+    specifically for use on small, low-powered, dedicated audio or audio/visual \
+    systems where the high-level audio management features of PulseAudio or \
+    PipeWire are not required. \
+"
 HOMEPAGE = "https://github.com/Arkq/bluez-alsa"
+BUGTRACKER = "https://github.com/arkq/bluez-alsa/issues"
 SECTION = "libs"
 
 LICENSE = "MIT"
-LIC_FILES_CHKSUM = "file://LICENSE;md5=8449a4f133a93f6254b496d4fb476e83"
+LIC_FILES_CHKSUM = "file://LICENSE;md5=143bc4e73f39cc5e89d6e096ac0315ba"
+
+DEPENDS += "alsa-lib bluez5 dbus glib-2.0-native python3-packaging-native sbc"
 
 SRC_URI = "git://github.com/Arkq/bluez-alsa.git;protocol=https;branch=master"
 
-SRCREV = "dd05a1baa261b94da9ba977b5e3392c8b4dc7a5e"
-PV = "4.0.0+git"
+SRCREV = "959573c2cccef5cf074f5b2fa7941abbd699c5f4"
 
-S  = "${WORKDIR}/git"
-
-DEPENDS += "alsa-lib bluez5 dbus glib-2.0 sbc"
+S = "${WORKDIR}/git"
 
 PACKAGECONFIG ??= "aplay cli hcitop ${@bb.utils.filter('DISTRO_FEATURES', 'systemd', d)}"
-PACKAGECONFIG[a2dpconf]  = "--enable-a2dpconf,--disable-a2dpconf"
-PACKAGECONFIG[aac]  = "--enable-aac,--disable-aac,fdk-aac"
+PACKAGECONFIG[a2dpconf] = "--enable-a2dpconf,--disable-a2dpconf"
+PACKAGECONFIG[aac] = "--enable-aac,--disable-aac,fdk-aac"
 PACKAGECONFIG[aplay] = "--enable-aplay,--disable-aplay"
 PACKAGECONFIG[cli] = "--enable-cli,--disable-cli"
 PACKAGECONFIG[coverage] = "--with-coverage,--without-coverage,lcov-native"
@@ -25,8 +33,10 @@  PACKAGECONFIG[debug-time] = "--enable-debug-time,--disable-debug-time"
 PACKAGECONFIG[faststream] = "--enable-faststream,--disable-faststream"
 PACKAGECONFIG[hcitop] = "--enable-hcitop,--disable-hcitop,libbsd ncurses"
 PACKAGECONFIG[libunwind] = "--with-libunwind,--without-libunwind,libunwind"
+PACKAGECONFIG[midi] = "--enable-midi,--disable-midi"
 PACKAGECONFIG[mp3lame] = "--enable-mp3lame,--disable-mp3lame,lame"
 PACKAGECONFIG[mpg123] = "--enable-mpg123,--disable-mpg123,mpg123,mpg123"
+PACKAGECONFIG[msbc] = "--enable-msbc,--disable-msbc,spandsp"
 PACKAGECONFIG[ofono] = "--enable-ofono,--disable-ofono,ofono"
 PACKAGECONFIG[payloadcheck] = "--enable-payloadcheck,--disable-payloadcheck"
 PACKAGECONFIG[rfcomm] = "--enable-rfcomm,--disable-rfcomm"
@@ -35,9 +45,10 @@  PACKAGECONFIG[systemd] = "--enable-systemd --with-systemdsystemunitdir=${systemd
 PACKAGECONFIG[test] = "--enable-test,--disable-test,libcheck libsndfile1"
 PACKAGECONFIG[upower] = "--enable-upower,--disable-upower,,upower"
 
-inherit autotools pkgconfig systemd
+inherit autotools pkgconfig python3native systemd
 
-EXTRA_OECONF = " \
+# These proprietary codecs are not available in Yocto
+EXTRA_OECONF = "\
     --disable-aptx \
     --disable-lc3plus \
     --disable-ldac \
@@ -45,11 +56,12 @@  EXTRA_OECONF = " \
 "
 
 PACKAGE_BEFORE_PN = "${PN}-aplay"
-RRECOMMENDS:${PN} = "${PN}-aplay"
 
-FILES:${PN}-aplay = "${bindir}/bluealsa-aplay"
+FILES:${PN}-aplay += "${bindir}/bluealsa-aplay"
 FILES:${PN} += "${libdir}/alsa-lib/*"
 
+RRECOMMENDS:${PN} = "${PN}-aplay"
+
 SYSTEMD_PACKAGES += "${PN}-aplay"
 SYSTEMD_SERVICE:${PN} = "bluealsa.service"
 SYSTEMD_SERVICE:${PN}-aplay = "bluealsa-aplay.service"