diff mbox series

[meta-python,wrynose] python3-socketio: Fix CVE-2026-48804

Message ID 20261120115751.2246881-1-asparmar@cisco.com
State New
Headers show
Series [meta-python,wrynose] python3-socketio: Fix CVE-2026-48804 | expand

Commit Message

From: Ashishkumar Parmar <asparmar@cisco.com>

This patch applies the upstream fix referenced in [2], using the commit
shown in [1].

[1] https://github.com/miguelgrinberg/python-socketio/commit/4bec3ef87bcfd6ab5b94cd3ac09d873283a6960e
[2] https://nvd.nist.gov/vuln/detail/CVE-2026-48804

Signed-off-by: Ashishkumar Parmar <asparmar@cisco.com>
---
 .../python3-socketio/CVE-2026-48804.patch     | 117 ++++++++++++++++++
 .../python/python3-socketio_5.16.3.bb         |   2 +
 2 files changed, 119 insertions(+)
 create mode 100644 meta-python/recipes-devtools/python/python3-socketio/CVE-2026-48804.patch
diff mbox series

Patch

diff --git a/meta-python/recipes-devtools/python/python3-socketio/CVE-2026-48804.patch b/meta-python/recipes-devtools/python/python3-socketio/CVE-2026-48804.patch
new file mode 100644
index 0000000000..8ac7a49c7d
--- /dev/null
+++ b/meta-python/recipes-devtools/python/python3-socketio/CVE-2026-48804.patch
@@ -0,0 +1,117 @@ 
+From f568afc1b85c0bd5001910cb4957a52d7116ab2f Mon Sep 17 00:00:00 2001
+From: Miguel Grinberg <miguel.grinberg@gmail.com>
+Date: Fri, 7 Aug 2026 00:02:23 +0100
+Subject: [PATCH] Delete incomplete binary packet when client disconnects
+
+CVE: CVE-2026-48804
+Upstream-Status: Backport [https://github.com/miguelgrinberg/python-socketio/commit/4bec3ef87bcfd6ab5b94cd3ac09d873283a6960e]
+
+Signed-off-by: Ashishkumar Parmar <asparmar@cisco.com>
+---
+ src/socketio/async_server.py |  2 ++
+ src/socketio/server.py       |  2 ++
+ tests/async/test_server.py   | 19 ++++++++++++++++++-
+ tests/common/test_server.py  | 17 ++++++++++++++++-
+ 4 files changed, 38 insertions(+), 2 deletions(-)
+
+diff --git a/src/socketio/async_server.py b/src/socketio/async_server.py
+index 7e9c872..bcffb35 100644
+--- a/src/socketio/async_server.py
++++ b/src/socketio/async_server.py
+@@ -590,6 +590,8 @@ class AsyncServer(base_server.BaseServer):
+         if not self.manager.is_connected(sid, namespace):  # pragma: no cover
+             return
+         self.manager.pre_disconnect(sid, namespace=namespace)
++        if eio_sid in self._binary_packet:
++            del self._binary_packet[eio_sid]
+         await self._trigger_event('disconnect', namespace, sid,
+                                   reason or self.reason.CLIENT_DISCONNECT)
+         await self.manager.disconnect(sid, namespace, ignore_queue=True)
+diff --git a/src/socketio/server.py b/src/socketio/server.py
+index 143d27e..6af30f3 100644
+--- a/src/socketio/server.py
++++ b/src/socketio/server.py
+@@ -571,6 +571,8 @@ class Server(base_server.BaseServer):
+         if not self.manager.is_connected(sid, namespace):  # pragma: no cover
+             return
+         self.manager.pre_disconnect(sid, namespace=namespace)
++        if eio_sid in self._binary_packet:
++            del self._binary_packet[eio_sid]
+         self._trigger_event('disconnect', namespace, sid,
+                             reason or self.reason.CLIENT_DISCONNECT)
+         self.manager.disconnect(sid, namespace, ignore_queue=True)
+diff --git a/tests/async/test_server.py b/tests/async/test_server.py
+index c3c0903..97c804a 100644
+--- a/tests/async/test_server.py
++++ b/tests/async/test_server.py
+@@ -937,7 +937,7 @@ class TestAsyncServer:
+         await s.disconnect('1', namespace='/foo')
+         assert calls == s.eio.send.await_count
+ 
+-    async def test_disconnect_with_partial_binary_packet(self, eio):
++    async def test_server_disconnect_with_partial_binary_packet(self, eio):
+         eio.return_value.send = mock.AsyncMock()
+         eio.return_value.disconnect = mock.AsyncMock()
+         s = async_server.AsyncServer()
+@@ -955,6 +955,23 @@ class TestAsyncServer:
+         s.eio.send.assert_any_await('123', '1')
+         assert '123' not in s._binary_packet
+ 
++    async def test_client_disconnect_with_partial_binary_packet(self, eio):
++        eio.return_value.send = mock.AsyncMock()
++        eio.return_value.disconnect = mock.AsyncMock()
++        s = async_server.AsyncServer()
++        await s._handle_eio_connect('123', 'environ')
++        await s._handle_eio_message('123', '0')
++        await s._handle_eio_message(
++            '123',
++            '52-["my message","a",'
++            '{"_placeholder":true,"num":1},'
++            '{"_placeholder":true,"num":0}]',
++        )
++        await s._handle_eio_message('123', b'foo')
++        assert s._binary_packet['123'] is not None
++        await s._handle_disconnect('123', '/')
++        assert '123' not in s._binary_packet
++
+     async def test_namespace_handler(self, eio):
+         eio.return_value.send = mock.AsyncMock()
+         result = {}
+diff --git a/tests/common/test_server.py b/tests/common/test_server.py
+index d8d80dc..251d661 100644
+--- a/tests/common/test_server.py
++++ b/tests/common/test_server.py
+@@ -862,7 +862,7 @@ class TestServer:
+         s.disconnect('123', namespace='/foo')
+         assert calls == s.eio.send.call_count
+ 
+-    def test_disconnect_with_partial_binary_packet(self, eio):
++    def test_disconnect_server_with_partial_binary_packet(self, eio):
+         s = server.Server()
+         s._handle_eio_connect('123', 'environ')
+         s._handle_eio_message('123', '0')
+@@ -878,6 +878,21 @@ class TestServer:
+         s.eio.send.assert_any_call('123', '1')
+         assert '123' not in s._binary_packet
+ 
++    def test_disconnect_client_with_partial_binary_packet(self, eio):
++        s = server.Server()
++        s._handle_eio_connect('123', 'environ')
++        s._handle_eio_message('123', '0')
++        s._handle_eio_message(
++            '123',
++            '52-["my message","a",'
++            '{"_placeholder":true,"num":1},'
++            '{"_placeholder":true,"num":0}]',
++        )
++        s._handle_eio_message('123', b'foo')
++        assert s._binary_packet['123'] is not None
++        s._handle_disconnect('123', '/')
++        assert '123' not in s._binary_packet
++
+     def test_namespace_handler(self, eio):
+         result = {}
+ 
+-- 
+2.35.6
+
diff --git a/meta-python/recipes-devtools/python/python3-socketio_5.16.3.bb b/meta-python/recipes-devtools/python/python3-socketio_5.16.3.bb
index be352876a8..be58a2172c 100644
--- a/meta-python/recipes-devtools/python/python3-socketio_5.16.3.bb
+++ b/meta-python/recipes-devtools/python/python3-socketio_5.16.3.bb
@@ -9,6 +9,8 @@  inherit pypi python_setuptools_build_meta
 
 PYPI_PACKAGE = "python_socketio"
 
+SRC_URI += "file://CVE-2026-48804.patch"
+
 SRC_URI[sha256sum] = "89b136f677ae65607a84cecda9b4d6c5377b40a97582c504c25df89af16d520e"
 
 PACKAGECONFIG ?= "asyncio_client client"