diff mbox series

[meta-networking,6/8] ssmtp: Drop gcc-15 incompatible-pointer-types patch

Message ID 20261118040831.2284885-6-khem.raj@oss.qualcomm.com
State New
Headers show
Series [meta-oe,1/8] geany-plugins: Remove unused patch | expand

Commit Message

Khem Raj Nov. 18, 2026, 4:08 a.m. UTC
ssmtp 2.66 already casts the handler passed to signal(), so it builds
without this patch.

AI-Generated: Uses Claude Code
Signed-off-by: Khem Raj <khem.raj@oss.qualcomm.com>
---
 ...ible-pointer-types-error-with-gcc-15.patch | 46 -------------------
 .../recipes-support/ssmtp/ssmtp_2.66.bb       |  1 -
 2 files changed, 47 deletions(-)
 delete mode 100644 meta-networking/recipes-support/ssmtp/ssmtp/0001-Fix-incompatible-pointer-types-error-with-gcc-15.patch
diff mbox series

Patch

diff --git a/meta-networking/recipes-support/ssmtp/ssmtp/0001-Fix-incompatible-pointer-types-error-with-gcc-15.patch b/meta-networking/recipes-support/ssmtp/ssmtp/0001-Fix-incompatible-pointer-types-error-with-gcc-15.patch
deleted file mode 100644
index cde2ec4681..0000000000
--- a/meta-networking/recipes-support/ssmtp/ssmtp/0001-Fix-incompatible-pointer-types-error-with-gcc-15.patch
+++ /dev/null
@@ -1,46 +0,0 @@ 
-From 7d3db0f63b9fa4a0deca486eccbe60c3cfa00750 Mon Sep 17 00:00:00 2001
-From: "mark.yang" <mark.yang@lge.com>
-Date: Wed, 16 Apr 2025 18:28:24 +0900
-Subject: [PATCH] Fix incompatible-pointer-types error with gcc 15
-
-../ssmtp-2.64/ssmtp.c:1454:31: error: passing argument 2 of 'signal' from incompatible pointer type [-Wincompatible-pointer-types]
- 1454 |         (void)signal(SIGALRM, (void(*)())handler);      /* Catch SIGALRM */
-      |                               ^~~~~~~~~~~~~~~~~~
-      |                               |
-      |                               void (*)(void)
-In file included from TOPDIR/tmp/work/core2-64-oe-linux/ssmtp/2.64/recipe-sysroot/usr/include/sys/param.h:28,
-                 from ../ssmtp-2.64/ssmtp.c:18:
-TOPDIR/tmp/work/core2-64-oe-linux/ssmtp/2.64/recipe-sysroot/usr/include/signal.h:88:57: note: expected '__sighandler_t' {aka 'void (*)(int)'} but argument is of type 'void (*)(void)'
-   88 | extern __sighandler_t signal (int __sig, __sighandler_t __handler)
-      |                                          ~~~~~~~~~~~~~~~^~~~~~~~~
-../ssmtp-2.64/ssmtp.c:1393:6: note: 'handler' declared here
- 1393 | void handler(void)
-      |      ^~~~~~~
-
-Note: as of ssmtp 2.66, the call site already reads
-"(void)signal(SIGALRM, (sighandler_t)handler);", so once handler()'s
-signature below is changed to take an int argument it matches
-sighandler_t (void (*)(int)) exactly and the incompatible-pointer-types
-warning/error is gone. Only the handler() signature hunk from the
-original patch is still needed; the call-site hunk has been dropped
-since it no longer applies and is unnecessary.
-
-Upstream-Status: Pending
-Signed-off-by: mark.yang <mark.yang@lge.com>
----
- ssmtp.c | 2 +-
- 1 file changed, 1 insertion(+), 1 deletion(-)
-
-diff --git a/ssmtp.c b/ssmtp.c
-index 4dedaf8..a938d14 100644
---- a/ssmtp.c
-+++ b/ssmtp.c
-@@ -1390,7 +1390,7 @@ handler() -- A "normal" non-portable version of an alarm handler
- 			like a socket. So we longjump instead, which is erronious on
- 			a small number of machines and ill-defined in the language
- */
--void handler(void)
-+void handler(__attribute__((unused)) int sig)
- {
- 	extern jmp_buf TimeoutJmpBuf;
-
diff --git a/meta-networking/recipes-support/ssmtp/ssmtp_2.66.bb b/meta-networking/recipes-support/ssmtp/ssmtp_2.66.bb
index 67c335b7a0..714b8ce635 100644
--- a/meta-networking/recipes-support/ssmtp/ssmtp_2.66.bb
+++ b/meta-networking/recipes-support/ssmtp/ssmtp_2.66.bb
@@ -7,7 +7,6 @@  SRC_URI = "${DEBIAN_MIRROR}/main/s/${BPN}/${BPN}_${PV}.orig.tar.gz \
            file://build-ouside_srcdir.patch \
            file://use-DESTDIR.patch \
            file://0001-include-libgen.h-for-basename.patch \
-           file://0001-Fix-incompatible-pointer-types-error-with-gcc-15.patch \
            "

 SRC_URI[md5sum] = "f9894703fcc559f63cffacfea08f9b75"