diff mbox series

[meta-gnome,01/30] libxklavier: Fix link with lld

Message ID 20261116060209.2916444-1-khem.raj@oss.qualcomm.com
State New
Headers show
Series [meta-gnome,01/30] libxklavier: Fix link with lld | expand

Commit Message

Khem Raj Nov. 16, 2026, 6:01 a.m. UTC
libxklavier.public exports xkl_engine_VOID__FLAGS_INT_BOOLEAN, which
marshal.list never generates. GNU ld ignores the unknown symbol, lld
fails on it. Drop it from the export list.

AI-Generated: Uses Claude Code
Signed-off-by: Khem Raj <khem.raj@oss.qualcomm.com>
---
 ...existent-symbol-from-the-export-list.patch | 31 +++++++++++++++++++
 .../libxklavier/libxklavier_5.4.bb            |  1 +
 2 files changed, 32 insertions(+)
 create mode 100644 meta-gnome/recipes-gnome/libxklavier/libxklavier/0001-Drop-nonexistent-symbol-from-the-export-list.patch
diff mbox series

Patch

diff --git a/meta-gnome/recipes-gnome/libxklavier/libxklavier/0001-Drop-nonexistent-symbol-from-the-export-list.patch b/meta-gnome/recipes-gnome/libxklavier/libxklavier/0001-Drop-nonexistent-symbol-from-the-export-list.patch
new file mode 100644
index 0000000000..c42883213e
--- /dev/null
+++ b/meta-gnome/recipes-gnome/libxklavier/libxklavier/0001-Drop-nonexistent-symbol-from-the-export-list.patch
@@ -0,0 +1,31 @@ 
+From 3d64d9c69a92e4f05957e79010ca0be04bd59779 Mon Sep 17 00:00:00 2001
+From: Khem Raj <khem.raj@oss.qualcomm.com>
+Date: Sun, 15 Nov 2026 17:09:44 -0800
+Subject: [PATCH] Drop nonexistent symbol from the export list
+
+libxklavier.public exports xkl_engine_VOID__FLAGS_INT_BOOLEAN, but
+marshal.list has no VOID:FLAGS,INT,BOOLEAN entry, so the marshaller is
+never generated. GNU ld ignores the unknown symbol, but lld fails:
+
+  error: version script assignment of 'global' to symbol
+  'xkl_engine_VOID__FLAGS_INT_BOOLEAN' failed: symbol not defined
+
+Upstream-Status: Inactive-Upstream [lastrelease: 2013]
+
+Signed-off-by: Khem Raj <khem.raj@oss.qualcomm.com>
+---
+ libxklavier/libxklavier.public | 1 -
+ 1 file changed, 1 deletion(-)
+
+diff --git a/libxklavier/libxklavier.public b/libxklavier/libxklavier.public
+index 11f27d5..2789e6b 100644
+--- a/libxklavier/libxklavier.public
++++ b/libxklavier/libxklavier.public
+@@ -83,7 +83,6 @@ xkl_engine_start_listen
+ xkl_engine_state_change_get_type
+ xkl_engine_stop_listen
+ xkl_engine_ungrab_key
+-xkl_engine_VOID__FLAGS_INT_BOOLEAN
+ xkl_engine_VOID__ENUM_INT_BOOLEAN
+ xkl_get_country_name
+ xkl_get_language_name
diff --git a/meta-gnome/recipes-gnome/libxklavier/libxklavier_5.4.bb b/meta-gnome/recipes-gnome/libxklavier/libxklavier_5.4.bb
index f52c210ed4..d3ca8c4f1b 100644
--- a/meta-gnome/recipes-gnome/libxklavier/libxklavier_5.4.bb
+++ b/meta-gnome/recipes-gnome/libxklavier/libxklavier_5.4.bb
@@ -14,6 +14,7 @@  SRC_URI = " \
     http://pkgs.fedoraproject.org/repo/pkgs/${BPN}/${BPN}-${PV}.tar.bz2/13af74dcb6011ecedf1e3ed122bd31fa/${BPN}-${PV}.tar.bz2 \
     file://fix-do_installe-failure.patch \
     file://0001-xklavier_config_xkb.c-Fix-keyboard-layout-settings-f.patch \
+    file://0001-Drop-nonexistent-symbol-from-the-export-list.patch \
 "
 SRC_URI[md5sum] = "13af74dcb6011ecedf1e3ed122bd31fa"
 SRC_URI[sha256sum] = "17a34194df5cbcd3b7bfd0f561d95d1f723aa1c87fca56bc2c209514460a9320"