diff mbox series

[meta-oe,77/96] pidgin: Fix build with libgnt 2.15

Message ID 20261115074918.2932593-77-khem.raj@oss.qualcomm.com
State New
Headers show
Series [meta-oe,01/96] crow: upgrade 1.3.4 -> 1.3.5 | expand

Commit Message

Khem Raj Nov. 15, 2026, 7:48 a.m. UTC
libgnt 2.15.0 deprecated gnt_util_parse_xhtml_to_textview(), which finch
uses, and pidgin builds with -DGNT_DISABLE_DEPRECATED. Stop disabling
the deprecated libgnt API.

AI-Generated: Uses Claude Code
Signed-off-by: Khem Raj <khem.raj@oss.qualcomm.com>
---
 ...Do-not-disable-deprecated-libgnt-API.patch | 24 +++++++++++++++++++
 .../recipes-support/pidgin/pidgin_2.14.14.bb  |  1 +
 2 files changed, 25 insertions(+)
 create mode 100644 meta-oe/recipes-support/pidgin/pidgin/0001-configure-Do-not-disable-deprecated-libgnt-API.patch
diff mbox series

Patch

diff --git a/meta-oe/recipes-support/pidgin/pidgin/0001-configure-Do-not-disable-deprecated-libgnt-API.patch b/meta-oe/recipes-support/pidgin/pidgin/0001-configure-Do-not-disable-deprecated-libgnt-API.patch
new file mode 100644
index 0000000000..1bd7c9c6da
--- /dev/null
+++ b/meta-oe/recipes-support/pidgin/pidgin/0001-configure-Do-not-disable-deprecated-libgnt-API.patch
@@ -0,0 +1,24 @@ 
+From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
+From: Khem Raj <khem.raj@oss.qualcomm.com>
+Date: Thu, 12 Nov 2026 00:00:00 -0800
+Subject: [PATCH] configure: Do not disable deprecated libgnt API
+
+libgnt 2.15.0 deprecated gnt_util_parse_xhtml_to_textview(), which finch
+still uses, so building with -DGNT_DISABLE_DEPRECATED fails with:
+
+  finch/gntnotify.c:96:9: error: call to undeclared function 'gnt_util_parse_xhtml_to_textview'
+
+Upstream-Status: Pending
+Signed-off-by: Khem Raj <khem.raj@oss.qualcomm.com>
+---
+--- a/configure.ac
++++ b/configure.ac
+@@ -1262,7 +1262,7 @@
+ 
+ AC_ARG_ENABLE(fortify, [AC_HELP_STRING([--disable-fortify], [compile without FORTIFY_SOURCE support])], , enable_fortify=yes)
+ 
+-DEBUG_CFLAGS="$DEBUG_CFLAGS -DPURPLE_DISABLE_DEPRECATED -DPIDGIN_DISABLE_DEPRECATED -DFINCH_DISABLE_DEPRECATED -DGNT_DISABLE_DEPRECATED"
++DEBUG_CFLAGS="$DEBUG_CFLAGS -DPURPLE_DISABLE_DEPRECATED -DPIDGIN_DISABLE_DEPRECATED -DFINCH_DISABLE_DEPRECATED"
+ if test "x$GCC" = "xyes"; then
+ 	dnl We enable -Wall later.
+ 	dnl If it's set after the warning CFLAGS in the compiler invocation, it counteracts the -Wno... flags.
diff --git a/meta-oe/recipes-support/pidgin/pidgin_2.14.14.bb b/meta-oe/recipes-support/pidgin/pidgin_2.14.14.bb
index 397ca3e4d0..7ed75c7ed3 100644
--- a/meta-oe/recipes-support/pidgin/pidgin_2.14.14.bb
+++ b/meta-oe/recipes-support/pidgin/pidgin_2.14.14.bb
@@ -10,6 +10,7 @@  inherit autotools gettext pkgconfig gconf perlnative python3native
 SRC_URI = "\
     ${SOURCEFORGE_MIRROR}/pidgin/pidgin-${PV}.tar.bz2 \
     file://sanitize-configure.ac.patch \
+    file://0001-configure-Do-not-disable-deprecated-libgnt-API.patch \
 "
 
 SRC_URI[sha256sum] = "0ffc9994def10260f98a55cd132deefa8dc4a9835451cc0e982747bd458e2356"