diff mbox series

[meta-networking,02/13] dante: Fix build with lld

Message ID 20261114193733.1743149-2-khem.raj@oss.qualcomm.com
State New
Headers show
Series [meta-oe,01/13] frame: Fix build with lld without x11 | expand

Commit Message

Khem Raj Nov. 14, 2026, 7:37 p.m. UTC 
getipnodebyname() and freehostent() are only interposed when the
platform has getipnodebyname(), which glibc and musl do not, but they
are always exported, so lld fails with:

  error: version script assignment of 'global' to symbol 'freehostent' failed: symbol not defined

Only export them when configure finds getipnodebyname().

Do not export rresvport where it does not exist

AI-Generated: Uses Claude Code
Signed-off-by: Khem Raj <khem.raj@oss.qualcomm.com>
---
 ...rposed-functions-that-exist-on-the-p.patch | 44 +++++++++++++++++++
 .../recipes-protocols/dante/dante_1.4.4.bb    |  3 +-
 2 files changed, 46 insertions(+), 1 deletion(-)
 create mode 100644 meta-networking/recipes-protocols/dante/dante/0001-Only-export-interposed-functions-that-exist-on-the-p.patch
diff mbox series

Patch

diff --git a/meta-networking/recipes-protocols/dante/dante/0001-Only-export-interposed-functions-that-exist-on-the-p.patch b/meta-networking/recipes-protocols/dante/dante/0001-Only-export-interposed-functions-that-exist-on-the-p.patch
new file mode 100644
index 0000000000..ea7c3e03ff
--- /dev/null
+++ b/meta-networking/recipes-protocols/dante/dante/0001-Only-export-interposed-functions-that-exist-on-the-p.patch
@@ -0,0 +1,44 @@ 
+From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
+From: Khem Raj <khem.raj@oss.qualcomm.com>
+Date: Mon, 9 Nov 2026 08:37:30 -0800
+Subject: [PATCH] Only export interposed functions that exist on the platform
+
+dlib only interposes getipnodebyname() and freehostent() when the
+platform has getipnodebyname() (Solaris), and rresvport() when it is
+available (not on Android or musl), but they are always listed in the
+exported symbols, so linkers that check the version script, like lld,
+fail with:
+
+  error: version script assignment of 'global' to symbol 'freehostent' failed: symbol not defined
+  error: version script assignment of 'global' to symbol 'rresvport' failed: symbol not defined
+
+Leave them out of the symbol list when configure did not find them.
+
+Upstream-Status: Pending
+Signed-off-by: Khem Raj <khem.raj@oss.qualcomm.com>
+---
+ mapfile.m4 | 10 +++++++++-
+ 1 file changed, 9 insertions(+), 1 deletion(-)
+
+diff --git a/mapfile.m4 b/mapfile.m4
+index 644a94b..dc964f8 100644
+--- a/mapfile.m4
++++ b/mapfile.m4
+@@ -12,8 +12,16 @@ PLDDIRS="dlib/" #preloading (standard, non-Rfoo functions)
+ if test x"$sol64" = xt; then
+    PLDDIRS="$PLDDIRS dlib64/"
+ fi
++#only export interposed functions that exist on this platform
++PLDEXCLUDE="-e ^$" #skip blank lines
++if test x"$ac_cv_func_getipnodebyname" != xyes; then
++    PLDEXCLUDE="$PLDEXCLUDE -e ^freehostent$ -e ^getipnodebyname$"
++fi
++if test x"$ac_cv_func_rresvport" != xyes; then
++    PLDEXCLUDE="$PLDEXCLUDE -e ^rresvport$"
++fi
+ for symdir in $PLDDIRS; do
+-    cat include/symbols_preload.txt >> $symdir/$MAPFILE
++    grep -v $PLDEXCLUDE include/symbols_preload.txt >> $symdir/$MAPFILE
+
+     #platform dependent symbols
+     case $host in
diff --git a/meta-networking/recipes-protocols/dante/dante_1.4.4.bb b/meta-networking/recipes-protocols/dante/dante_1.4.4.bb
index 6a1eed3edb..e15f7c4d41 100644
--- a/meta-networking/recipes-protocols/dante/dante_1.4.4.bb
+++ b/meta-networking/recipes-protocols/dante/dante_1.4.4.bb
@@ -12,7 +12,8 @@  LICENSE = "BSD-3-Clause"
 LIC_FILES_CHKSUM = "file://LICENSE;md5=b3a8e7dc09bb720460f28c9d3796afa5"

 SRC_URI = "https://www.inet.no/dante/files/dante-${PV}.tar.gz \
-          "
+           file://0001-Only-export-interposed-functions-that-exist-on-the-p.patch \
+           "
 SRC_URI[sha256sum] = "1973c7732f1f9f0a4c0ccf2c1ce462c7c25060b25643ea90f9b98f53a813faec"

 # without --without-gssapi, config.log will contain reference to /usr/lib