[meta-gnome,26/29] gthumb: Include stdbool.h for bool

Message ID	20261023065350.3228996-26-khem.raj@oss.qualcomm.com
State	New
Headers	show Received: from mail-pg1-f182.google.com (mail-pg1-f182.google.com [209.85.215.182]) by mx.groups.io with SMTP id smtpd.msgproc01-g2.1664.1792738465070215854 for <openembedded-devel@lists.openembedded.org>; Thu, 22 Oct 2026 23:54:25 -0700 ip: 209.85.215.182, mailfrom: raj.khem@gmail.com) From: Khem Raj <raj.khem@gmail.com> To: openembedded-devel@lists.openembedded.org Cc: Khem Raj <khem.raj@oss.qualcomm.com> Subject: [meta-gnome][PATCH 26/29] gthumb: Include stdbool.h for bool Date: Thu, 22 Oct 2026 23:53:47 -0700 Message-ID: <20261023065350.3228996-26-khem.raj@oss.qualcomm.com> In-Reply-To: <20261023065350.3228996-1-khem.raj@oss.qualcomm.com> References: <20261023065350.3228996-1-khem.raj@oss.qualcomm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8"
Series	[meta-oe,01/29] castxml: upgrade 0.7.0 -> 0.8.0 \| expand [meta-oe,01/29] castxml: upgrade 0.7.0 -> 0.8.0 [meta-networking,02/29] ntp: Use time_t for the stime() argument [meta-networking,03/29] rdma-core: upgrade 64.0 -> 65.0 [meta-networking,04/29] rdma-core: Link libmana with libatomic when needed [meta-oe,05/29] poco: Fix libatomic detection with optimized builds [meta-oe,06/29] fio: Link with libatomic when 64-bit atomics need it [meta-networking,07/29] pgpool2: Define SIZEOF_LONG and SIZEOF_LONG_LONG [meta-networking,08/29] ngtcp2: Fix example server build on 32-bit targets [meta-oe,09/29] bit7z: Avoid 64-bit atomics in BufferQueue [meta-oe,10/29] android-tools: Mark incompatible with riscv32 [meta-oe,11/29] libtorrent: Fix libatomic detection with optimized builds [meta-oe,12/29] rtorrent: Fix libatomic detection with optimized builds [meta-webserver,13/29] hiawatha: Link with libatomic when 64-bit atomics need it [meta-multimedia,14/29] x265: Link with libatomic when 64-bit atomics need it [meta-initramfs,15/29] klibc: Mark incompatible with riscv32 [meta-oe,16/29] mozjs-140: Backport libc fix to declare getrandom on all musl targets [meta-oe,17/29] floret: Link with libatomic when 64-bit atomics need it [meta-python,18/29] python3-ruff: Upgrade 0.16.8 -> 0.17.1 [meta-python,19/29] python3-ruff: Fix build on targets without 64-bit atomics [meta-oe,20/29] nushell: Upgrade 0.116.0 -> 0.116.1 [meta-oe,21/29] nushell: Fix build for riscv32 musl [meta-oe,22/29] librice: Fix build on targets without 64-bit atomics [meta-gnome,23/29] ibus: Use native pkg-config for build tools [meta-oe,24/29] sd: Fix build for riscv32 [meta-gnome,25/29] gnome-shell: Mark incompatible with riscv32 [meta-gnome,26/29] gthumb: Include stdbool.h for bool [meta-networking,27/29] samba: Fix riscv32 waf cross answers [meta-networking,28/29] waf-samba: Reconfigure when the cross-answers file changes [meta-gnome,29/29] gnome-commander: Fix build on targets without 64-bit atomics

Message ID

20261023065350.3228996-26-khem.raj@oss.qualcomm.com

State

New

Headers

From: Khem Raj <raj.khem@gmail.com>
To: openembedded-devel@lists.openembedded.org
Cc: Khem Raj <khem.raj@oss.qualcomm.com>
Subject: [meta-gnome][PATCH 26/29] gthumb: Include stdbool.h for bool
Date: Thu, 22 Oct 2026 23:53:47 -0700
Message-ID: <20261023065350.3228996-26-khem.raj@oss.qualcomm.com>
In-Reply-To: <20261023065350.3228996-1-khem.raj@oss.qualcomm.com>
References: <20261023065350.3228996-1-khem.raj@oss.qualcomm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="utf-8"

Series

[meta-oe,01/29] castxml: upgrade 0.7.0 -> 0.8.0 | expand

Commit Message

Khem Raj Oct. 23, 2026, 6:53 a.m. UTC

src/lib/util.h uses bool without including stdbool.h, which fails to
build where no other header pulls it in, e.g. with clang on riscv32
musl:

  src/lib/util.h:68:1: error: unknown type name 'bool'

Add a patch that includes it.

AI-Generated: Uses Claude Code
Signed-off-by: Khem Raj <khem.raj@oss.qualcomm.com>
---
 ...01-util.h-Include-stdbool.h-for-bool.patch | 29 +++++++++++++++++++
 meta-gnome/recipes-gnome/gthumb/gthumb_4.0.bb |  1 +
 2 files changed, 30 insertions(+)
 create mode 100644 meta-gnome/recipes-gnome/gthumb/gthumb/0001-util.h-Include-stdbool.h-for-bool.patch

diff --git a/meta-gnome/recipes-gnome/gthumb/gthumb/0001-util.h-Include-stdbool.h-for-bool.patch b/meta-gnome/recipes-gnome/gthumb/gthumb/0001-util.h-Include-stdbool.h-for-bool.patch
new file mode 100644
index 0000000000..8b5c9d8474
--- /dev/null
+++ b/meta-gnome/recipes-gnome/gthumb/gthumb/0001-util.h-Include-stdbool.h-for-bool.patch
@@ -0,0 +1,29 @@ 
+From: Khem Raj <khem.raj@oss.qualcomm.com>
+Date: Thu, 22 Oct 2026 19:00:00 -0700
+Subject: [PATCH] util.h: Include stdbool.h for bool
+
+util.h declares _g_parse_exif_date() returning bool, but relies on
+another header to include stdbool.h. Before C23, bool is not a keyword,
+so where none of them does, e.g. with clang and musl on riscv32, the
+build fails:
+
+  src/lib/util.h:68:1: error: unknown type name 'bool'
+
+Include stdbool.h directly.
+
+Upstream-Status: Submitted [https://gitlab.gnome.org/GNOME/gthumb/-/merge_requests/64]
+Signed-off-by: Khem Raj <khem.raj@oss.qualcomm.com>
+---
+ src/lib/util.h | 1 +
+ 1 file changed, 1 insertion(+)
+
+--- a/src/lib/util.h
++++ b/src/lib/util.h
+@@ -2,6 +2,7 @@
+ #define LIB_UTIL_H
+
+ #include <math.h>
++#include <stdbool.h>
+ #include <glib.h>
+ #include <glib/gi18n-lib.h>
+ #include <gio/gio.h>
diff --git a/meta-gnome/recipes-gnome/gthumb/gthumb_4.0.bb b/meta-gnome/recipes-gnome/gthumb/gthumb_4.0.bb
index f534d5f1f4..c3340551aa 100644
--- a/meta-gnome/recipes-gnome/gthumb/gthumb_4.0.bb
+++ b/meta-gnome/recipes-gnome/gthumb/gthumb_4.0.bb
@@ -33,6 +33,7 @@  inherit gnomebase gsettings gtk-icon-cache mime-xdg vala features_check

 REQUIRED_DISTRO_FEATURES = "opengl"

+SRC_URI += "file://0001-util.h-Include-stdbool.h-for-bool.patch"
 SRC_URI[archive.sha256sum] = "a24aaa72b5637f49097dedc9c141a33615da770d029315f3285ebf2156cf7b61"

 FILES:${PN} += "${datadir}/metainfo"

[meta-gnome,26/29] gthumb: Include stdbool.h for bool

Commit Message

Patch